46226 2010-09-21 16:00:31 -0700 -[WebView _scheduleCompositingLayerSync] should wake the run loop 2010-09-22 01:37:15 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Mac OS X 10.6 RESOLVED FIXED P2 Normal --- 0 pknight webkit-unassigned commit-queue pknight oldest_to_newest 282602 0 pknight 2010-09-21 16:00:31 -0700 This is in Radar as <rdar://problem/8460238>. -[WebView _scheduleCompositingLayerSync] should ensure that the runloop is woken up if the RLO is already scheduled. Otherwise, layers might not get synced for a while until some other event wakes the run loop, causing rendering delays. 282631 1 68304 pknight 2010-09-21 16:34:46 -0700 Created attachment 68304 suggested patch 282636 2 68304 simon.fraser 2010-09-21 16:38:32 -0700 Comment on attachment 68304 suggested patch View in context: https://bugs.webkit.org/attachment.cgi?id=68304&action=review > WebKit/mac/WebView/WebView.mm:5874 > + // Make sure we wake up the loop or the observer could be delayed until some other source fires Period at the end of the sentence please. 282638 3 68306 pknight 2010-09-21 16:42:33 -0700 Created attachment 68306 Address feedback from Simon Fraser, add a period at the end of a comment. 282834 4 68306 commit-queue 2010-09-22 01:37:10 -0700 Comment on attachment 68306 Address feedback from Simon Fraser, add a period at the end of a comment. Clearing flags on attachment: 68306 Committed r68028: <http://trac.webkit.org/changeset/68028> 282835 5 commit-queue 2010-09-22 01:37:15 -0700 All reviewed patches have been landed. Closing bug. 68304 2010-09-21 16:34:46 -0700 2010-09-21 16:42:33 -0700 suggested patch 46226.txt text/plain 1613 pknight SW5kZXg6IFdlYktpdC9tYWMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9tYWMvQ2hh bmdlTG9nCShyZXZpc2lvbiA2Nzk4OSkKKysrIFdlYktpdC9tYWMvQ2hhbmdlTG9nCSh3b3JraW5n IGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTAtMDktMjEgIFBhdWwgS25pZ2h0ICA8cGtuaWdo dEBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgLVtXZWJWaWV3IF9zY2hlZHVsZUNvbXBvc2l0aW5nTGF5ZXJTeW5jXSBzaG91bGQgd2Fr ZSB0aGUgcnVuIGxvb3AKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTQ2MjI2CisKKyAgICAgICAgQ2FsbCBDRlJ1bkxvb3BXYWtlVXAgdG8gbWFrZSBzdXJl IHRoZSBydW4gbG9vcCBpcyBub3Qgc2xlZXBpbmcsIHdoaWNoIGNvdWxkIGRlbGF5IGxheWVyIHBh aW50aW5nLgorCisgICAgICAgICogV2ViVmlldy9XZWJWaWV3Lm1tOgorICAgICAgICAoLVtXZWJW aWV3IF9zY2hlZHVsZUNvbXBvc2l0aW5nTGF5ZXJTeW5jXSk6CisKIDIwMTAtMDktMjEgIEFuZHkg RXN0ZXMgIDxhZXN0ZXNAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEFk bGVyLgpJbmRleDogV2ViS2l0L21hYy9XZWJWaWV3L1dlYlZpZXcubW0KPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g V2ViS2l0L21hYy9XZWJWaWV3L1dlYlZpZXcubW0JKHJldmlzaW9uIDY3OTg5KQorKysgV2ViS2l0 L21hYy9XZWJWaWV3L1dlYlZpZXcubW0JKHdvcmtpbmcgY29weSkKQEAgLTU4NjksNiArNTg2OSwx MSBAQAogCiAtICh2b2lkKV9zY2hlZHVsZUNvbXBvc2l0aW5nTGF5ZXJTeW5jCiB7CisgICAgQ0ZS dW5Mb29wUmVmIGN1cnJlbnRSdW5Mb29wID0gQ0ZSdW5Mb29wR2V0Q3VycmVudCgpOworCisgICAg Ly8gTWFrZSBzdXJlIHdlIHdha2UgdXAgdGhlIGxvb3Agb3IgdGhlIG9ic2VydmVyIGNvdWxkIGJl IGRlbGF5ZWQgdW50aWwgc29tZSBvdGhlciBzb3VyY2UgZmlyZXMKKyAgICBDRlJ1bkxvb3BXYWtl VXAoY3VycmVudFJ1bkxvb3ApOworCiAgICAgaWYgKF9wcml2YXRlLT5sYXllclN5bmNSdW5Mb29w T2JzZXJ2ZXIpCiAgICAgICAgIHJldHVybjsKIApAQCAtNTg4NCw3ICs1ODg5LDcgQEAKICAgICAg ICAga0NGUnVuTG9vcEJlZm9yZVdhaXRpbmcgfCBrQ0ZSdW5Mb29wRXhpdCwgdHJ1ZSAvKiByZXBl YXRzICovLAogICAgICAgICBydW5Mb29wT3JkZXIsIGxheWVyU3luY1J1bkxvb3BPYnNlcnZlckNh bGxCYWNrLCAmY29udGV4dCk7CiAKLSAgICBDRlJ1bkxvb3BBZGRPYnNlcnZlcihDRlJ1bkxvb3BH ZXRDdXJyZW50KCksIF9wcml2YXRlLT5sYXllclN5bmNSdW5Mb29wT2JzZXJ2ZXIsIGtDRlJ1bkxv b3BDb21tb25Nb2Rlcyk7CisgICAgQ0ZSdW5Mb29wQWRkT2JzZXJ2ZXIoY3VycmVudFJ1bkxvb3As IF9wcml2YXRlLT5sYXllclN5bmNSdW5Mb29wT2JzZXJ2ZXIsIGtDRlJ1bkxvb3BDb21tb25Nb2Rl cyk7CiB9CiAKICNlbmRpZgo= 68306 2010-09-21 16:42:33 -0700 2010-09-22 01:37:10 -0700 Address feedback from Simon Fraser, add a period at the end of a comment. 46226.txt text/plain 1614 pknight SW5kZXg6IFdlYktpdC9tYWMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9tYWMvQ2hh bmdlTG9nCShyZXZpc2lvbiA2Nzk5MCkKKysrIFdlYktpdC9tYWMvQ2hhbmdlTG9nCSh3b3JraW5n IGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTAtMDktMjEgIFBhdWwgS25pZ2h0ICA8cGtuaWdo dEBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgLVtXZWJWaWV3IF9zY2hlZHVsZUNvbXBvc2l0aW5nTGF5ZXJTeW5jXSBzaG91bGQgd2Fr ZSB0aGUgcnVuIGxvb3AKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTQ2MjI2CisKKyAgICAgICAgQ2FsbCBDRlJ1bkxvb3BXYWtlVXAgdG8gbWFrZSBzdXJl IHRoZSBydW4gbG9vcCBpcyBub3Qgc2xlZXBpbmcsIHdoaWNoIGNvdWxkIGRlbGF5IGxheWVyIHBh aW50aW5nLgorCisgICAgICAgICogV2ViVmlldy9XZWJWaWV3Lm1tOgorICAgICAgICAoLVtXZWJW aWV3IF9zY2hlZHVsZUNvbXBvc2l0aW5nTGF5ZXJTeW5jXSk6CisKIDIwMTAtMDktMjEgIEFuZHkg RXN0ZXMgIDxhZXN0ZXNAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEFk bGVyLgpJbmRleDogV2ViS2l0L21hYy9XZWJWaWV3L1dlYlZpZXcubW0KPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g V2ViS2l0L21hYy9XZWJWaWV3L1dlYlZpZXcubW0JKHJldmlzaW9uIDY3OTkwKQorKysgV2ViS2l0 L21hYy9XZWJWaWV3L1dlYlZpZXcubW0JKHdvcmtpbmcgY29weSkKQEAgLTU4NjksNiArNTg2OSwx MSBAQAogCiAtICh2b2lkKV9zY2hlZHVsZUNvbXBvc2l0aW5nTGF5ZXJTeW5jCiB7CisgICAgQ0ZS dW5Mb29wUmVmIGN1cnJlbnRSdW5Mb29wID0gQ0ZSdW5Mb29wR2V0Q3VycmVudCgpOworCisgICAg Ly8gTWFrZSBzdXJlIHdlIHdha2UgdXAgdGhlIGxvb3Agb3IgdGhlIG9ic2VydmVyIGNvdWxkIGJl IGRlbGF5ZWQgdW50aWwgc29tZSBvdGhlciBzb3VyY2UgZmlyZXMuCisgICAgQ0ZSdW5Mb29wV2Fr ZVVwKGN1cnJlbnRSdW5Mb29wKTsKKwogICAgIGlmIChfcHJpdmF0ZS0+bGF5ZXJTeW5jUnVuTG9v cE9ic2VydmVyKQogICAgICAgICByZXR1cm47CiAKQEAgLTU4ODQsNyArNTg4OSw3IEBACiAgICAg ICAgIGtDRlJ1bkxvb3BCZWZvcmVXYWl0aW5nIHwga0NGUnVuTG9vcEV4aXQsIHRydWUgLyogcmVw ZWF0cyAqLywKICAgICAgICAgcnVuTG9vcE9yZGVyLCBsYXllclN5bmNSdW5Mb29wT2JzZXJ2ZXJD YWxsQmFjaywgJmNvbnRleHQpOwogCi0gICAgQ0ZSdW5Mb29wQWRkT2JzZXJ2ZXIoQ0ZSdW5Mb29w R2V0Q3VycmVudCgpLCBfcHJpdmF0ZS0+bGF5ZXJTeW5jUnVuTG9vcE9ic2VydmVyLCBrQ0ZSdW5M b29wQ29tbW9uTW9kZXMpOworICAgIENGUnVuTG9vcEFkZE9ic2VydmVyKGN1cnJlbnRSdW5Mb29w LCBfcHJpdmF0ZS0+bGF5ZXJTeW5jUnVuTG9vcE9ic2VydmVyLCBrQ0ZSdW5Mb29wQ29tbW9uTW9k ZXMpOwogfQogCiAjZW5kaWYK