46212 2010-09-21 13:07:40 -0700 [gtk] Use the smart pointers to handle cairo_path_t 2010-09-22 01:44:41 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 1 alex webkit-unassigned abarth eric webkit.review.bot oldest_to_newest 282501 0 alex 2010-09-21 13:07:40 -0700 Now we can use OwnPtr to handle cairo_path_t variables, we can replace all the uses in the code. 282505 1 68281 alex 2010-09-21 13:09:35 -0700 Created attachment 68281 Patch 282666 2 68281 mrobinson 2010-09-21 17:10:17 -0700 Comment on attachment 68281 Patch Looks good! 282832 3 alex 2010-09-22 01:31:59 -0700 patch landed http://trac.webkit.org/changeset/68027 282836 4 webkit.review.bot 2010-09-22 01:44:41 -0700 http://trac.webkit.org/changeset/68027 might have broken GTK Linux 32-bit Release 68281 2010-09-21 13:09:35 -0700 2010-09-21 17:10:16 -0700 Patch bug-46212-20100921220932.patch text/plain 5157 alex ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NTNhNDUzM2NmN2JkZDNjZjIyYjM5MjJkYWVkYTliZjY4MDNlYjVkOC4uNDIxODZkYjYwZmFlNjA4 YmI0YTM1ODgyN2Y1YzI0YzA0MjM2MmYxMiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMyBAQAorMjAxMC0wOS0yMSAgQWxl amFuZHJvIEcuIENhc3RybyAgPGFsZXhAaWdhbGlhLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbZ3RrXSBVc2UgdGhlIHNtYXJ0IHBvaW50ZXJz IHRvIGhhbmRsZSBjYWlyb19wYXRoX3QKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTQ2MjEyCisKKyAgICAgICAgTW9kaWZpZWQgdGhlIGNvZGUgdG8gdXNl IHNtYXJ0IHBvaW50ZXJzIHdpdGggY2Fpcm9fcGF0aF90CisgICAgICAgIHZhcmlhYmxlcy4KKwor ICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2NhaXJvL0dyYXBoaWNzQ29udGV4dENhaXJvLmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OmFwcGVuZFBhdGhUb0NhaXJvQ29udGV4dCk6CisgICAgICAg IChXZWJDb3JlOjpHcmFwaGljc0NvbnRleHQ6OmNsaXApOgorICAgICAgICAoV2ViQ29yZTo6R3Jh cGhpY3NDb250ZXh0OjpkcmF3VGlsZWRTaGFkb3cpOgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBo aWNzL2NhaXJvL1BhdGhDYWlyby5jcHA6CisgICAgICAgIChXZWJDb3JlOjpQYXRoOjpQYXRoKToK KyAgICAgICAgKFdlYkNvcmU6OlBhdGg6Om9wZXJhdG9yPSk6CisgICAgICAgIChXZWJDb3JlOjpQ YXRoOjphcHBseSk6CisgICAgICAgIChXZWJDb3JlOjpQYXRoOjpkZWJ1Z1N0cmluZyk6CisKIDIw MTAtMDktMjEgIERhbmllbCBDaGVuZyAgPGRjaGVuZ0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAg UmV2aWV3ZWQgYnkgVG9ueSBDaGFuZy4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3MvY2Fpcm8vR3JhcGhpY3NDb250ZXh0Q2Fpcm8uY3BwIGIvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy9jYWlyby9HcmFwaGljc0NvbnRleHRDYWlyby5jcHAKaW5kZXggNWRlN2UxZjBkNGEy MWYxNTMyMGJjZTg2OWMzYWNkYWFhOGUyOWVlMS4uZjEyZTA5ODFkMzM2NDQ5NjAwMmM3NGYxYzc3 OWVhMmMzMGNhZjM4ZiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jYWly by9HcmFwaGljc0NvbnRleHRDYWlyby5jcHAKKysrIGIvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj cy9jYWlyby9HcmFwaGljc0NvbnRleHRDYWlyby5jcHAKQEAgLTE1MCw5ICsxNTAsOCBAQCBzdGF0 aWMgaW5saW5lIHZvaWQgY29weUNvbnRleHRQcm9wZXJ0aWVzKGNhaXJvX3QqIHNyY0NyLCBjYWly b190KiBkc3RDcikKIAogc3RhdGljIHZvaWQgYXBwZW5kUGF0aFRvQ2Fpcm9Db250ZXh0KGNhaXJv X3QqIHRvLCBjYWlyb190KiBmcm9tKQogewotICAgIGNhaXJvX3BhdGhfdCogY2Fpcm9QYXRoID0g Y2Fpcm9fY29weV9wYXRoKGZyb20pOwotICAgIGNhaXJvX2FwcGVuZF9wYXRoKHRvLCBjYWlyb1Bh dGgpOwotICAgIGNhaXJvX3BhdGhfZGVzdHJveShjYWlyb1BhdGgpOworICAgIE93blB0cjxjYWly b19wYXRoX3Q+IGNhaXJvUGF0aChjYWlyb19jb3B5X3BhdGgoZnJvbSkpOworICAgIGNhaXJvX2Fw cGVuZF9wYXRoKHRvLCBjYWlyb1BhdGguZ2V0KCkpOwogfQogCiAvLyBXZSBhcHBseSB0aGUgcGVu ZGluZyBwYXRoIGJ1aWx0IHZpYSBhZGRQYXRoIHRvIHRoZSBDYWlybyBjb250ZXh0CkBAIC0xMTgy LDkgKzExODEsOCBAQCB2b2lkIEdyYXBoaWNzQ29udGV4dDo6Y2xpcChjb25zdCBQYXRoJiBwYXRo KQogICAgICAgICByZXR1cm47CiAKICAgICBjYWlyb190KiBjciA9IG1fZGF0YS0+Y3I7Ci0gICAg Y2Fpcm9fcGF0aF90KiBwID0gY2Fpcm9fY29weV9wYXRoKHBhdGgucGxhdGZvcm1QYXRoKCktPmNv bnRleHQoKSk7Ci0gICAgY2Fpcm9fYXBwZW5kX3BhdGgoY3IsIHApOwotICAgIGNhaXJvX3BhdGhf ZGVzdHJveShwKTsKKyAgICBPd25QdHI8Y2Fpcm9fcGF0aF90PiBwKGNhaXJvX2NvcHlfcGF0aChw YXRoLnBsYXRmb3JtUGF0aCgpLT5jb250ZXh0KCkpKTsKKyAgICBjYWlyb19hcHBlbmRfcGF0aChj ciwgcC5nZXQoKSk7CiAgICAgY2Fpcm9fZmlsbF9ydWxlX3Qgc2F2ZWRGaWxsUnVsZSA9IGNhaXJv X2dldF9maWxsX3J1bGUoY3IpOwogICAgIGNhaXJvX3NldF9maWxsX3J1bGUoY3IsIENBSVJPX0ZJ TExfUlVMRV9XSU5ESU5HKTsKICAgICBjYWlyb19jbGlwKGNyKTsKQEAgLTEzNDEsOSArMTMzOSw4 IEBAIHZvaWQgR3JhcGhpY3NDb250ZXh0OjpkcmF3VGlsZWRTaGFkb3coY29uc3QgSW50UmVjdCYg cmVjdCwgY29uc3QgRmxvYXRTaXplJiB0b3BMCiAgICAgICAgIGNvcHlDb250ZXh0UHJvcGVydGll cyhjciwgc2hhZG93Q29udGV4dCk7CiAgICAgICAgIGNhaXJvX3RyYW5zbGF0ZShzaGFkb3dDb250 ZXh0LCAtcmVjdC54KCkgKyBibHVyUmFkaXVzLCAtcmVjdC55KCkgKyBibHVyUmFkaXVzKTsKICAg ICAgICAgY2Fpcm9fbmV3X3BhdGgoc2hhZG93Q29udGV4dCk7Ci0gICAgICAgIGNhaXJvX3BhdGhf dCogcGF0aCA9IGNhaXJvX2NvcHlfcGF0aChjcik7Ci0gICAgICAgIGNhaXJvX2FwcGVuZF9wYXRo KHNoYWRvd0NvbnRleHQsIHBhdGgpOwotICAgICAgICBjYWlyb19wYXRoX2Rlc3Ryb3kocGF0aCk7 CisgICAgICAgIE93blB0cjxjYWlyb19wYXRoX3Q+IHBhdGgoY2Fpcm9fY29weV9wYXRoKGNyKSk7 CisgICAgICAgIGNhaXJvX2FwcGVuZF9wYXRoKHNoYWRvd0NvbnRleHQsIHBhdGguZ2V0KCkpOwog CiAgICAgICAgIHNldFBsYXRmb3JtRmlsbCh0aGlzLCBzaGFkb3dDb250ZXh0LCBtX2NvbW1vbik7 CiAKZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2Fpcm8vUGF0aENhaXJv LmNwcCBiL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2Fpcm8vUGF0aENhaXJvLmNwcAppbmRl eCAwNWM2OTUyNGUyMGExMTc3NDliN2E0OTRmZjYwMTU4ZGNkODdjYjI4Li4wNmRkMzEzOGEwY2Mx Zjg2OTNkMjgwMDAwYzgwZTlhNGJkNmJlMTdhIDEwMDY0NAotLS0gYS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL2NhaXJvL1BhdGhDYWlyby5jcHAKKysrIGIvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy9jYWlyby9QYXRoQ2Fpcm8uY3BwCkBAIC01Miw5ICs1Miw4IEBAIFBhdGg6OlBhdGgoY29u c3QgUGF0aCYgb3RoZXIpCiAgICAgOiBtX3BhdGgobmV3IENhaXJvUGF0aCgpKQogewogICAgIGNh aXJvX3QqIGNyID0gcGxhdGZvcm1QYXRoKCktPmNvbnRleHQoKTsKLSAgICBjYWlyb19wYXRoX3Qq IHAgPSBjYWlyb19jb3B5X3BhdGgob3RoZXIucGxhdGZvcm1QYXRoKCktPmNvbnRleHQoKSk7Ci0g ICAgY2Fpcm9fYXBwZW5kX3BhdGgoY3IsIHApOwotICAgIGNhaXJvX3BhdGhfZGVzdHJveShwKTsK KyAgICBPd25QdHI8Y2Fpcm9fcGF0aF90PiBwKGNhaXJvX2NvcHlfcGF0aChvdGhlci5wbGF0Zm9y bVBhdGgoKS0+Y29udGV4dCgpKSk7CisgICAgY2Fpcm9fYXBwZW5kX3BhdGgoY3IsIHAuZ2V0KCkp OwogfQogCiBQYXRoJiBQYXRoOjpvcGVyYXRvcj0oY29uc3QgUGF0aCYgb3RoZXIpCkBAIC02NCw5 ICs2Myw4IEBAIFBhdGgmIFBhdGg6Om9wZXJhdG9yPShjb25zdCBQYXRoJiBvdGhlcikKIAogICAg IGNsZWFyKCk7CiAgICAgY2Fpcm9fdCogY3IgPSBwbGF0Zm9ybVBhdGgoKS0+Y29udGV4dCgpOwot ICAgIGNhaXJvX3BhdGhfdCogcCA9IGNhaXJvX2NvcHlfcGF0aChvdGhlci5wbGF0Zm9ybVBhdGgo KS0+Y29udGV4dCgpKTsKLSAgICBjYWlyb19hcHBlbmRfcGF0aChjciwgcCk7Ci0gICAgY2Fpcm9f cGF0aF9kZXN0cm95KHApOworICAgIE93blB0cjxjYWlyb19wYXRoX3Q+IHAoY2Fpcm9fY29weV9w YXRoKG90aGVyLnBsYXRmb3JtUGF0aCgpLT5jb250ZXh0KCkpKTsKKyAgICBjYWlyb19hcHBlbmRf cGF0aChjciwgcC5nZXQoKSk7CiAgICAgcmV0dXJuICp0aGlzOwogfQogCkBAIC0yOTcsNyArMjk1 LDcgQEAgYm9vbCBQYXRoOjpzdHJva2VDb250YWlucyhTdHJva2VTdHlsZUFwcGxpZXIqIGFwcGxp ZXIsIGNvbnN0IEZsb2F0UG9pbnQmIHBvaW50KQogdm9pZCBQYXRoOjphcHBseSh2b2lkKiBpbmZv LCBQYXRoQXBwbGllckZ1bmN0aW9uIGZ1bmN0aW9uKSBjb25zdAogewogICAgIGNhaXJvX3QqIGNy ID0gcGxhdGZvcm1QYXRoKCktPmNvbnRleHQoKTsKLSAgICBjYWlyb19wYXRoX3QqIHBhdGggPSBj YWlyb19jb3B5X3BhdGgoY3IpOworICAgIE93blB0cjxjYWlyb19wYXRoX3Q+IHBhdGgoY2Fpcm9f Y29weV9wYXRoKGNyKSk7CiAgICAgY2Fpcm9fcGF0aF9kYXRhX3QqIGRhdGE7CiAgICAgUGF0aEVs ZW1lbnQgcGVsZW1lbnQ7CiAgICAgRmxvYXRQb2ludCBwb2ludHNbM107CkBAIC0zMjksNyArMzI3 LDYgQEAgdm9pZCBQYXRoOjphcHBseSh2b2lkKiBpbmZvLCBQYXRoQXBwbGllckZ1bmN0aW9uIGZ1 bmN0aW9uKSBjb25zdAogICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgIH0KICAgICB9Ci0gICAg Y2Fpcm9fcGF0aF9kZXN0cm95KHBhdGgpOwogfQogCiB2b2lkIFBhdGg6OnRyYW5zZm9ybShjb25z dCBBZmZpbmVUcmFuc2Zvcm0mIHRyYW5zKQpAQCAtMzQ2LDcgKzM0Myw3IEBAIFN0cmluZyBQYXRo OjpkZWJ1Z1N0cmluZygpIGNvbnN0CiAgICAgICAgIHJldHVybiBTdHJpbmcoKTsKIAogICAgIFN0 cmluZyBwYXRoU3RyaW5nOwotICAgIGNhaXJvX3BhdGhfdCogcGF0aCA9IGNhaXJvX2NvcHlfcGF0 aChwbGF0Zm9ybVBhdGgoKS0+Y29udGV4dCgpKTsKKyAgICBPd25QdHI8Y2Fpcm9fcGF0aF90PiBw YXRoKGNhaXJvX2NvcHlfcGF0aChwbGF0Zm9ybVBhdGgoKS0+Y29udGV4dCgpKSk7CiAgICAgY2Fp cm9fcGF0aF9kYXRhX3QqIGRhdGE7CiAKICAgICBmb3IgKGludCBpID0gMDsgaSA8IHBhdGgtPm51 bV9kYXRhOyBpICs9IHBhdGgtPmRhdGFbaV0uaGVhZGVyLmxlbmd0aCkgewpAQCAtMzczLDcgKzM3 MCw2IEBAIFN0cmluZyBQYXRoOjpkZWJ1Z1N0cmluZygpIGNvbnN0CiAgICAgICAgIH0KICAgICB9 CiAKLSAgICBjYWlyb19wYXRoX2Rlc3Ryb3kocGF0aCk7CiAgICAgcmV0dXJuIHBhdGhTdHJpbmcu c2ltcGxpZnlXaGl0ZVNwYWNlKCk7CiB9CiAK