46206 2010-09-21 11:48:13 -0700 [WINCE] Remove usage of MemoryManager 2010-09-23 07:22:54 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Other Other RESOLVED FIXED P2 Normal --- 1 paroga paroga aroben commit-queue oldest_to_newest 282459 0 paroga 2010-09-21 11:48:13 -0700 see patch 282464 1 68269 paroga 2010-09-21 11:52:55 -0700 Created attachment 68269 Patch 282581 2 68269 cfleizach 2010-09-21 15:08:22 -0700 Comment on attachment 68269 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=68269&action=review > WebCore/ChangeLog:9 > + can you explain why someone thought it provided value before, and what is the benefit of changing > WebCore/platform/graphics/wince/PlatformPathWinCE.cpp:-237 > - MemoryAllocationCanFail canFail; why does this need to be removed. is this part of the MemoryManager change? 282589 3 paroga 2010-09-21 15:29:38 -0700 (In reply to comment #2) > (From update of attachment 68269 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=68269&action=review > > > WebCore/ChangeLog:9 > > + > > can you explain why someone thought it provided value before, and what is the benefit of changing No, sorry, the initial bug 27550 does not say anything. :( > > > WebCore/platform/graphics/wince/PlatformPathWinCE.cpp:-237 > > - MemoryAllocationCanFail canFail; > > why does this need to be removed. is this part of the MemoryManager change? MemoryAllocationCanFail is part of the MemoryManager. (see http://trac.webkit.org/browser/trunk/JavaScriptCore/wtf/wince/MemoryManager.h?rev=46268#L60) 283611 4 68269 aroben 2010-09-23 06:56:24 -0700 Comment on attachment 68269 Patch I think Patrick answered Chris's questions satisfactorily. Chris, if you feel otherwise please let me know! 283619 5 68269 commit-queue 2010-09-23 07:22:49 -0700 Comment on attachment 68269 Patch Clearing flags on attachment: 68269 Committed r68135: <http://trac.webkit.org/changeset/68135> 283620 6 commit-queue 2010-09-23 07:22:54 -0700 All reviewed patches have been landed. Closing bug. 68269 2010-09-21 11:52:55 -0700 2010-09-23 07:22:49 -0700 Patch bug-46206.patch text/plain 2055 paroga ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZGFmMmNkMy4uNWVhMWZlOCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxMC0wOS0yMSAgUGF0cmljayBHYW5z dGVyZXIgIDxwYXJvZ2FAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBbV0lOQ0VdIFJlbW92ZSB1c2FnZSBvZiBNZW1vcnlNYW5hZ2Vy CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NjIwNgor CisgICAgICAgIE1lbW9yeU1hbmFnZXIgZG9lcyBub3QgcHJvdmlkZSBhbnkgZXh0cmEgdmFsdWUs IHNvIHJlbW92ZSBpdC4KKworICAgICAgICAqIHBhZ2Uvd2luY2UvRnJhbWVXaW5DRS5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjppbWFnZUZyb21TZWxlY3Rpb24pOgorICAgICAgICAqIHBsYXRmb3Jt L2dyYXBoaWNzL3dpbmNlL1BsYXRmb3JtUGF0aFdpbkNFLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OmRyYXdQb2x5Z29ucyk6CisKIDIwMTAtMDktMjEgIEFiaGlzaGVrIEFyeWEgIDxpbmZlcm5vQGNo cm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXZlIEh5YXR0LgpkaWZmIC0tZ2l0 IGEvV2ViQ29yZS9wYWdlL3dpbmNlL0ZyYW1lV2luQ0UuY3BwIGIvV2ViQ29yZS9wYWdlL3dpbmNl L0ZyYW1lV2luQ0UuY3BwCmluZGV4IGRmZWE4NjQuLjllYjQ4N2IgMTAwNjQ0Ci0tLSBhL1dlYkNv cmUvcGFnZS93aW5jZS9GcmFtZVdpbkNFLmNwcAorKysgYi9XZWJDb3JlL3BhZ2Uvd2luY2UvRnJh bWVXaW5DRS5jcHAKQEAgLTEyOSwxMSArMTI5LDExIEBAIEhCSVRNQVAgaW1hZ2VGcm9tU2VsZWN0 aW9uKEZyYW1lKiBmcmFtZSwgYm9vbCBmb3JjZUJsYWNrVGV4dCkKICAgICB9CiAKICAgICBPd25Q dHI8SERDPiBibXBEQyhDcmVhdGVDb21wYXRpYmxlREMoZ19zY3JlZW5EQykpOwotICAgIEhCSVRN QVAgaEJtcCA9IE1lbW9yeU1hbmFnZXI6OmNyZWF0ZUNvbXBhdGlibGVCaXRtYXAoZ19zY3JlZW5E QywgdywgaCk7CisgICAgSEJJVE1BUCBoQm1wID0gQ3JlYXRlQ29tcGF0aWJsZUJpdG1hcChnX3Nj cmVlbkRDLCB3LCBoKTsKICAgICBpZiAoIWhCbXApCiAgICAgICAgIHJldHVybiAwOwogCi0gICAg SEJJVE1BUCBoYm1wT2xkID0gKEhCSVRNQVApU2VsZWN0T2JqZWN0KGJtcERDLmdldCgpLCBoQm1w KTsKKyAgICBIR0RJT0JKIGhibXBPbGQgPSBTZWxlY3RPYmplY3QoYm1wREMuZ2V0KCksIGhCbXAp OwogCiAgICAgewogICAgICAgICBHcmFwaGljc0NvbnRleHQgZ2MoYm1wREMuZ2V0KCkpOwpkaWZm IC0tZ2l0IGEvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy93aW5jZS9QbGF0Zm9ybVBhdGhXaW5D RS5jcHAgYi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3dpbmNlL1BsYXRmb3JtUGF0aFdpbkNF LmNwcAppbmRleCA0MDcyYTE4Li44MGUwMWE5IDEwMDY0NAotLS0gYS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL3dpbmNlL1BsYXRmb3JtUGF0aFdpbkNFLmNwcAorKysgYi9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL3dpbmNlL1BsYXRmb3JtUGF0aFdpbkNFLmNwcApAQCAtMjM0LDcgKzIzNCw2 IEBAIHN0YXRpYyB2b2lkIGFkZEFyY1BvaW50cyhQYXRoUG9seWdvbiYgcG9seSwgY29uc3QgUGxh dGZvcm1QYXRoRWxlbWVudDo6QXJjVG8mIGRhCiAKIHN0YXRpYyB2b2lkIGRyYXdQb2x5Z29ucyhI REMgZGMsIGNvbnN0IFZlY3RvcjxQYXRoUG9seWdvbj4mIHBvbHlnb25zLCBib29sIGZpbGwsIGNv bnN0IEFmZmluZVRyYW5zZm9ybSogdHJhbnNmb3JtYXRpb24pCiB7Ci0gICAgTWVtb3J5QWxsb2Nh dGlvbkNhbkZhaWwgY2FuRmFpbDsKICAgICBmb3IgKFZlY3RvcjxQYXRoUG9seWdvbj46OmNvbnN0 X2l0ZXJhdG9yIGkgPSBwb2x5Z29ucy5iZWdpbigpOyBpICE9IHBvbHlnb25zLmVuZCgpOyArK2kp IHsKICAgICAgICAgaW50IG5wb2ludHMgPSBpLT5zaXplKCk7CiAgICAgICAgIGlmICghbnBvaW50 cykK