46201 2010-09-21 10:38:12 -0700 Need to stop autocorrection panel timer after editing. 2010-09-22 17:44:32 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Mac OS X 10.6 RESOLVED FIXED InRadar P2 Normal --- 0 jiapu.mail webkit-unassigned commit-queue jiapu.mail mitz oldest_to_newest 282416 0 jiapu.mail 2010-09-21 10:38:12 -0700 <rdar://problem/8441042> A reproducible case is typing "doesn'". After typing the apostrophe, the string is corrected into "doesn'does'". This exposes in fact two bugs. 1. After typing "doesn", the correction panel timer is started. If the apostrophe is typed before the time fires, by the time the timer fires, we end up checking spelling on "doesn'" instead of "doesn". The solution is to stop timer whenever the selection changes. 2. If the spelling checking is done for the purpose of bringing up correction bubble, we should suppress any suggestion correction whose range does not end at the last character. In this case, the correction range ends at letter "n" which is the second to the last.This is generally a good policy since it is confusing if we alter other text at the same time we show the correction bubble. 282431 1 jiapu.mail 2010-09-21 10:56:21 -0700 (In reply to comment #0) > <rdar://problem/8441042> > > A reproducible case is typing "doesn'". After typing the apostrophe, the string is corrected into "doesn'does'". This exposes in fact two bugs. > > 1. After typing "doesn", the correction panel timer is started. If the apostrophe is typed before the time fires, by the time the timer fires, we end up checking spelling on "doesn'" instead of "doesn". The solution is to stop timer whenever the selection changes. > > 2. If the spelling checking is done for the purpose of bringing up correction bubble, we should suppress any suggestion correction whose range does not end at the last character. In this case, the correction range ends at letter "n" which is the second to the last.This is generally a good policy since it is confusing if we alter other text at the same time we show the correction bubble. I should point out that fixing bug 1 would prevent bug 2 from manifest. But we should fix them both. 283004 2 68385 jiapu.mail 2010-09-22 10:02:06 -0700 Created attachment 68385 Proposed patch (v1) 283083 3 68385 mitz 2010-09-22 11:23:18 -0700 Comment on attachment 68385 Proposed patch (v1) View in context: https://bugs.webkit.org/attachment.cgi?id=68385&action=review > WebCore/editing/Editor.h:315 > void startCorrectionPanelTimer(); > + void stopCorrectionPanelTimer(); I don’t think these two methods need to be public. r+ but please upload a new patch making these methods private if possible. If not, set the “cq” flag to ? and I will set to + and the patch will be committed as-is. 283249 4 68441 jiapu.mail 2010-09-22 14:17:07 -0700 Created attachment 68441 Proposed patch (v2) Revised per comment #3. startCorrectionPanelTimer() is used by TypingCommand, so need to stay public. I have made stopCorrectionPanelTimer() private. 283394 5 68441 commit-queue 2010-09-22 17:44:27 -0700 Comment on attachment 68441 Proposed patch (v2) Clearing flags on attachment: 68441 Committed r68103: <http://trac.webkit.org/changeset/68103> 283395 6 commit-queue 2010-09-22 17:44:32 -0700 All reviewed patches have been landed. Closing bug. 68385 2010-09-22 10:02:06 -0700 2010-09-22 14:17:07 -0700 Proposed patch (v1) webkit_bug46201.patch text/plain 3236 jiapu.mail SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2ODA0NykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjEgQEAKKzIwMTAtMDktMjIgIEppYSBQdSAgPGpwdUBhcHBsZS5jb20+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTmVlZCB0byBzdG9w IGF1dG9jb3JyZWN0aW9uIHBhbmVsIHRpbWVyIHdoZW4gc2VsZWN0aW9uIGNoYW5nZXMuCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NjIwMQorICAgICAg ICA8cmRhcjovL3Byb2JsZW0vODQ0MTA0Mj4KKworICAgICAgICAqIGVkaXRpbmcvRWRpdG9yLmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OkVkaXRvcjo6YXBwbGllZEVkaXRpbmcpOiBTdG9wIGNvcnJl Y3Rpb24gdGltZXIgYWZ0ZXIgZWRpdGluZy4KKyAgICAgICAgKFdlYkNvcmU6OkVkaXRvcjo6bWFy a0FsbE1pc3NwZWxsaW5nc0FuZEJhZEdyYW1tYXJJblJhbmdlcyk6IFdoZW4gdGV4dCBjaGVja2lu ZyBpcyBkb25lIGZvcgorICAgICAgICAgIHNob3dpbmcgYXV0b2NvcnJlY3Rpb24gcGFuZWwsIHdl IHN1cHByZXNzIGFsbCBjb3JyZWN0aW9ucyB0aGF0IGFyZSBub3QgYXQgdGhlIGVuZCBvZgorICAg ICAgICAgIHRleHQgY2hlY2tpbmcgcmFuZ2UuIFNvIHRoYXQgd2UgZG9uJ3QgcmVwbGFjZSBvdGhl ciB3b3JkcyB3aGlsZSBzaG93aW5nIGNvcnJlY3Rpb24gcGFuZWwKKyAgICAgICAgICBmb3IgdGhl IGxhc3Qgd29yZC4KKyAgICAgICAgKFdlYkNvcmU6OkVkaXRvcjo6c3RvcENvcnJlY3Rpb25QYW5l bFRpbWVyKTogU3RvcCBjb3JyZWN0aW9uIHRpbWVyLgorCisgICAgICAgICogZWRpdGluZy9FZGl0 b3IuaDogQWRkZWQgc3RvcENvcnJlY3Rpb25QYW5lbFRpbWVyKCkgbWV0aG9kLgorCiAyMDEwLTA5 LTIyICBLZW5uZXRoIFJ1c3NlbGwgIDxrYnJAZ29vZ2xlLmNvbT4KIAogICAgICAgICBSZXZpZXdl ZCBieSBKYW1lcyBSb2JpbnNvbi4KSW5kZXg6IFdlYkNvcmUvZWRpdGluZy9FZGl0b3IuY3BwCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFdlYkNvcmUvZWRpdGluZy9FZGl0b3IuY3BwCShyZXZpc2lvbiA2ODA0NykK KysrIFdlYkNvcmUvZWRpdGluZy9FZGl0b3IuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMDI3LDcg KzEwMjcsOCBAQCB2b2lkIEVkaXRvcjo6YXBwbGllZEVkaXRpbmcoUGFzc1JlZlB0cjxFCiAgICAg ICAgIGlmIChjbGllbnQoKSkKICAgICAgICAgICAgIGNsaWVudCgpLT5yZWdpc3RlckNvbW1hbmRG b3JVbmRvKG1fbGFzdEVkaXRDb21tYW5kKTsKICAgICB9Ci0gICAgcmVzcG9uZFRvQ2hhbmdlZENv bnRlbnRzKG5ld1NlbGVjdGlvbik7ICAgIAorICAgIHJlc3BvbmRUb0NoYW5nZWRDb250ZW50cyhu ZXdTZWxlY3Rpb24pOworICAgIHN0b3BDb3JyZWN0aW9uUGFuZWxUaW1lcigpOwogfQogCiB2b2lk IEVkaXRvcjo6dW5hcHBsaWVkRWRpdGluZyhQYXNzUmVmUHRyPEVkaXRDb21tYW5kPiBjbWQpCkBA IC0yNjc1LDYgKzI2NzYsMTAgQEAgdm9pZCBFZGl0b3I6Om1hcmtBbGxNaXNzcGVsbGluZ3NBbmRC YWRHcgogICAgICAgICAgICAgICAgICAgICB8fCByZXN1bHQtPnR5cGUgPT0gVGV4dENoZWNraW5n VHlwZUNvcnJlY3Rpb24pKSB7CiAgICAgICAgICAgICAvLyBJbiB0aGlzIGNhc2UgdGhlIHJlc3Vs dCByYW5nZSBqdXN0IGhhcyB0byB0b3VjaCB0aGUgc3BlbGxpbmcgcmFuZ2UsIHNvIHdlIGNhbiBo YW5kbGUgcmVwbGFjaW5nIG5vbi13b3JkIHRleHQgc3VjaCBhcyBwdW5jdHVhdGlvbi4KICAgICAg ICAgICAgIEFTU0VSVChyZXN1bHRMZW5ndGggPiAwICYmIHJlc3VsdExvY2F0aW9uID49IDApOwor CisgICAgICAgICAgICBpZiAoc2hvdWxkU2hvd0NvcnJlY3Rpb25QYW5lbCAmJiByZXN1bHRMb2Nh dGlvbiArIHJlc3VsdExlbmd0aCA8IHNwZWxsaW5nUmFuZ2VFbmRPZmZzZXQpCisgICAgICAgICAg ICAgICAgY29udGludWU7CisKICAgICAgICAgICAgIGludCByZXBsYWNlbWVudExlbmd0aCA9IHJl c3VsdC0+cmVwbGFjZW1lbnQubGVuZ3RoKCk7CiAgICAgICAgICAgICBib29sIGRvUmVwbGFjZW1l bnQgPSAocmVwbGFjZW1lbnRMZW5ndGggPiAwKTsKICAgICAgICAgICAgIFJlZlB0cjxSYW5nZT4g cmFuZ2VUb1JlcGxhY2UgPSBUZXh0SXRlcmF0b3I6OnN1YnJhbmdlKHBhcmFncmFwaFJhbmdlLmdl dCgpLCByZXN1bHRMb2NhdGlvbiwgcmVzdWx0TGVuZ3RoKTsKQEAgLTI4NDQsNiArMjg0OSwxMyBA QCB2b2lkIEVkaXRvcjo6c3RhcnRDb3JyZWN0aW9uUGFuZWxUaW1lcigpCiAjZW5kaWYKIH0KIAor dm9pZCBFZGl0b3I6OnN0b3BDb3JyZWN0aW9uUGFuZWxUaW1lcigpCit7CisjaWYgUExBVEZPUk0o TUFDKSAmJiAhZGVmaW5lZChCVUlMRElOR19PTl9USUdFUikgJiYgIWRlZmluZWQoQlVJTERJTkdf T05fTEVPUEFSRCkgJiYgIWRlZmluZWQoQlVJTERJTkdfT05fU05PV19MRU9QQVJEKQorICAgIG1f Y29ycmVjdGlvblBhbmVsVGltZXIuc3RvcCgpOworI2VuZGlmCit9CisKIHZvaWQgRWRpdG9yOjpo YW5kbGVDYW5jZWxPcGVyYXRpb24oKQogewogI2lmIFBMQVRGT1JNKE1BQykgJiYgIWRlZmluZWQo QlVJTERJTkdfT05fVElHRVIpICYmICFkZWZpbmVkKEJVSUxESU5HX09OX0xFT1BBUkQpICYmICFk ZWZpbmVkKEJVSUxESU5HX09OX1NOT1dfTEVPUEFSRCkKSW5kZXg6IFdlYkNvcmUvZWRpdGluZy9F ZGl0b3IuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2VkaXRpbmcvRWRpdG9yLmgJKHJldmlzaW9u IDY4MDQ3KQorKysgV2ViQ29yZS9lZGl0aW5nL0VkaXRvci5oCSh3b3JraW5nIGNvcHkpCkBAIC0z MTIsNiArMzEyLDcgQEAgcHVibGljOgogCiAgICAgdm9pZCBoYW5kbGVDYW5jZWxPcGVyYXRpb24o KTsKICAgICB2b2lkIHN0YXJ0Q29ycmVjdGlvblBhbmVsVGltZXIoKTsKKyAgICB2b2lkIHN0b3BD b3JyZWN0aW9uUGFuZWxUaW1lcigpOwogICAgIHZvaWQgaGFuZGxlUmVqZWN0ZWRDb3JyZWN0aW9u KCk7CiAgICAgYm9vbCBpc1Nob3dpbmdDb3JyZWN0aW9uUGFuZWwoKTsKIAo= 68441 2010-09-22 14:17:07 -0700 2010-09-22 17:44:27 -0700 Proposed patch (v2) webkit_bug46201.patch text/plain 3369 jiapu.mail SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2ODA0NykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjEgQEAKKzIwMTAtMDktMjIgIEppYSBQdSAgPGpwdUBhcHBsZS5jb20+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTmVlZCB0byBzdG9w IGF1dG9jb3JyZWN0aW9uIHBhbmVsIHRpbWVyIHdoZW4gc2VsZWN0aW9uIGNoYW5nZXMuCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NjIwMQorICAgICAg ICA8cmRhcjovL3Byb2JsZW0vODQ0MTA0Mj4KKworICAgICAgICAqIGVkaXRpbmcvRWRpdG9yLmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OkVkaXRvcjo6YXBwbGllZEVkaXRpbmcpOiBTdG9wIGNvcnJl Y3Rpb24gdGltZXIgYWZ0ZXIgZWRpdGluZy4KKyAgICAgICAgKFdlYkNvcmU6OkVkaXRvcjo6bWFy a0FsbE1pc3NwZWxsaW5nc0FuZEJhZEdyYW1tYXJJblJhbmdlcyk6IFdoZW4gdGV4dCBjaGVja2lu ZyBpcyBkb25lIGZvcgorICAgICAgICAgIHNob3dpbmcgYXV0b2NvcnJlY3Rpb24gcGFuZWwsIHdl IHN1cHByZXNzIGFsbCBjb3JyZWN0aW9ucyB0aGF0IGFyZSBub3QgYXQgdGhlIGVuZCBvZgorICAg ICAgICAgIHRleHQgY2hlY2tpbmcgcmFuZ2UuIFNvIHRoYXQgd2UgZG9uJ3QgcmVwbGFjZSBvdGhl ciB3b3JkcyB3aGlsZSBzaG93aW5nIGNvcnJlY3Rpb24gcGFuZWwKKyAgICAgICAgICBmb3IgdGhl IGxhc3Qgd29yZC4KKyAgICAgICAgKFdlYkNvcmU6OkVkaXRvcjo6c3RvcENvcnJlY3Rpb25QYW5l bFRpbWVyKTogU3RvcCBjb3JyZWN0aW9uIHRpbWVyLgorCisgICAgICAgICogZWRpdGluZy9FZGl0 b3IuaDogQWRkZWQgc3RvcENvcnJlY3Rpb25QYW5lbFRpbWVyKCkgbWV0aG9kLgorCiAyMDEwLTA5 LTIyICBLZW5uZXRoIFJ1c3NlbGwgIDxrYnJAZ29vZ2xlLmNvbT4KIAogICAgICAgICBSZXZpZXdl ZCBieSBKYW1lcyBSb2JpbnNvbi4KSW5kZXg6IFdlYkNvcmUvZWRpdGluZy9FZGl0b3IuY3BwCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFdlYkNvcmUvZWRpdGluZy9FZGl0b3IuY3BwCShyZXZpc2lvbiA2ODA0NykK KysrIFdlYkNvcmUvZWRpdGluZy9FZGl0b3IuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMDI3LDcg KzEwMjcsOCBAQCB2b2lkIEVkaXRvcjo6YXBwbGllZEVkaXRpbmcoUGFzc1JlZlB0cjxFCiAgICAg ICAgIGlmIChjbGllbnQoKSkKICAgICAgICAgICAgIGNsaWVudCgpLT5yZWdpc3RlckNvbW1hbmRG b3JVbmRvKG1fbGFzdEVkaXRDb21tYW5kKTsKICAgICB9Ci0gICAgcmVzcG9uZFRvQ2hhbmdlZENv bnRlbnRzKG5ld1NlbGVjdGlvbik7ICAgIAorICAgIHJlc3BvbmRUb0NoYW5nZWRDb250ZW50cyhu ZXdTZWxlY3Rpb24pOworICAgIHN0b3BDb3JyZWN0aW9uUGFuZWxUaW1lcigpOwogfQogCiB2b2lk IEVkaXRvcjo6dW5hcHBsaWVkRWRpdGluZyhQYXNzUmVmUHRyPEVkaXRDb21tYW5kPiBjbWQpCkBA IC0yNjc1LDYgKzI2NzYsMTAgQEAgdm9pZCBFZGl0b3I6Om1hcmtBbGxNaXNzcGVsbGluZ3NBbmRC YWRHcgogICAgICAgICAgICAgICAgICAgICB8fCByZXN1bHQtPnR5cGUgPT0gVGV4dENoZWNraW5n VHlwZUNvcnJlY3Rpb24pKSB7CiAgICAgICAgICAgICAvLyBJbiB0aGlzIGNhc2UgdGhlIHJlc3Vs dCByYW5nZSBqdXN0IGhhcyB0byB0b3VjaCB0aGUgc3BlbGxpbmcgcmFuZ2UsIHNvIHdlIGNhbiBo YW5kbGUgcmVwbGFjaW5nIG5vbi13b3JkIHRleHQgc3VjaCBhcyBwdW5jdHVhdGlvbi4KICAgICAg ICAgICAgIEFTU0VSVChyZXN1bHRMZW5ndGggPiAwICYmIHJlc3VsdExvY2F0aW9uID49IDApOwor CisgICAgICAgICAgICBpZiAoc2hvdWxkU2hvd0NvcnJlY3Rpb25QYW5lbCAmJiByZXN1bHRMb2Nh dGlvbiArIHJlc3VsdExlbmd0aCA8IHNwZWxsaW5nUmFuZ2VFbmRPZmZzZXQpCisgICAgICAgICAg ICAgICAgY29udGludWU7CisKICAgICAgICAgICAgIGludCByZXBsYWNlbWVudExlbmd0aCA9IHJl c3VsdC0+cmVwbGFjZW1lbnQubGVuZ3RoKCk7CiAgICAgICAgICAgICBib29sIGRvUmVwbGFjZW1l bnQgPSAocmVwbGFjZW1lbnRMZW5ndGggPiAwKTsKICAgICAgICAgICAgIFJlZlB0cjxSYW5nZT4g cmFuZ2VUb1JlcGxhY2UgPSBUZXh0SXRlcmF0b3I6OnN1YnJhbmdlKHBhcmFncmFwaFJhbmdlLmdl dCgpLCByZXN1bHRMb2NhdGlvbiwgcmVzdWx0TGVuZ3RoKTsKQEAgLTI4NDQsNiArMjg0OSwxMyBA QCB2b2lkIEVkaXRvcjo6c3RhcnRDb3JyZWN0aW9uUGFuZWxUaW1lcigpCiAjZW5kaWYKIH0KIAor dm9pZCBFZGl0b3I6OnN0b3BDb3JyZWN0aW9uUGFuZWxUaW1lcigpCit7CisjaWYgUExBVEZPUk0o TUFDKSAmJiAhZGVmaW5lZChCVUlMRElOR19PTl9USUdFUikgJiYgIWRlZmluZWQoQlVJTERJTkdf T05fTEVPUEFSRCkgJiYgIWRlZmluZWQoQlVJTERJTkdfT05fU05PV19MRU9QQVJEKQorICAgIG1f Y29ycmVjdGlvblBhbmVsVGltZXIuc3RvcCgpOworI2VuZGlmCit9CisKIHZvaWQgRWRpdG9yOjpo YW5kbGVDYW5jZWxPcGVyYXRpb24oKQogewogI2lmIFBMQVRGT1JNKE1BQykgJiYgIWRlZmluZWQo QlVJTERJTkdfT05fVElHRVIpICYmICFkZWZpbmVkKEJVSUxESU5HX09OX0xFT1BBUkQpICYmICFk ZWZpbmVkKEJVSUxESU5HX09OX1NOT1dfTEVPUEFSRCkKSW5kZXg6IFdlYkNvcmUvZWRpdGluZy9F ZGl0b3IuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2VkaXRpbmcvRWRpdG9yLmgJKHJldmlzaW9u IDY4MDQ3KQorKysgV2ViQ29yZS9lZGl0aW5nL0VkaXRvci5oCSh3b3JraW5nIGNvcHkpCkBAIC00 MDIsNiArNDAyLDcgQEAgcHJpdmF0ZToKICAgICB2b2lkIGNoYW5nZVNlbGVjdGlvbkFmdGVyQ29t bWFuZChjb25zdCBWaXNpYmxlU2VsZWN0aW9uJiBuZXdTZWxlY3Rpb24sIGJvb2wgY2xvc2VUeXBp bmcsIGJvb2wgY2xlYXJUeXBpbmdTdHlsZSk7CiAgICAgdm9pZCBjb3JyZWN0aW9uUGFuZWxUaW1l ckZpcmVkKFRpbWVyPEVkaXRvcj4qKTsKICAgICBOb2RlKiBmaW5kRXZlbnRUYXJnZXRGcm9tU2Vs ZWN0aW9uKCkgY29uc3Q7CisgICAgdm9pZCBzdG9wQ29ycmVjdGlvblBhbmVsVGltZXIoKTsKIH07 CiAKIGlubGluZSB2b2lkIEVkaXRvcjo6c2V0U3RhcnROZXdLaWxsUmluZ1NlcXVlbmNlKGJvb2wg ZmxhZykK