46193 2010-09-21 09:42:54 -0700 [chromium] Composited layers get double transformed when scrolling 2010-09-21 10:51:48 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 vangelis vangelis jamesr kbr nduca oldest_to_newest 282360 0 vangelis 2010-09-21 09:42:54 -0700 There's a new scroll layer now maintained by the common RenderLayerCompositor which applies the scrolling transform. The additional transform added by the LayerRendererChromium should now be removed. 282389 1 68255 vangelis 2010-09-21 10:13:39 -0700 Created attachment 68255 proposed patch updateLayersRecursive is (incorrectly) also called by LayerRendererChromium::prepareToDrawLayers() but the invocation in drawLayers() is the one that really matters. I'll clean up the prepareToDrawLayers() in a separate CL. 282419 2 68255 kbr 2010-09-21 10:44:28 -0700 Comment on attachment 68255 proposed patch Looks fine to me. 282428 3 vangelis 2010-09-21 10:51:48 -0700 Committed r67966: <http://trac.webkit.org/changeset/67966> 68255 2010-09-21 10:13:39 -0700 2010-09-21 10:44:28 -0700 proposed patch doubleTransform_46193.txt text/plain 1920 vangelis SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2Nzk2MikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTQgQEAKKzIwMTAtMDktMjEgIFZhbmdlbGlzIEtva2tldmlzICA8dmFuZ2VsaXNA Y2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFtjaHJvbWl1bV0gRml4aW5nIGRvdWJsZSB0cmFuc2xhdGlvbiBvZiBjb21wb3NpdGVk IGxheWVycyB3aGVuIHNjcm9sbGluZy4KKyAgICAgICAgVGhlIHNjcm9sbGluZyB0cmFuc2Zvcm0g aXMgbm93IGFwcGxpZWQgYnkgYSBzZXBhcmF0ZSBsYXllciBtYWludGFpbmVkIGluCisgICAgICAg IHRoZSBSZW5kZXJMYXllckNvbXBvc2l0b3IuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGlj cy9jaHJvbWl1bS9MYXllclJlbmRlcmVyQ2hyb21pdW0uY3BwOgorICAgICAgICAoV2ViQ29yZTo6 TGF5ZXJSZW5kZXJlckNocm9taXVtOjpkcmF3TGF5ZXJzKToKKwogMjAxMC0wOS0yMSAgRGF2aWQg SHlhdHQgIDxoeWF0dEBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFuIEJlcm5z dGVpbi4KSW5kZXg6IFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vTGF5ZXJSZW5k ZXJlckNocm9taXVtLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L2Nocm9taXVtL0xheWVyUmVuZGVyZXJDaHJvbWl1bS5jcHAJKHJldmlzaW9uIDY3OTEyKQorKysg V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9MYXllclJlbmRlcmVyQ2hyb21pdW0u Y3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zMDYsMTYgKzMwNiwxMyBAQCB2b2lkIExheWVyUmVuZGVy ZXJDaHJvbWl1bTo6ZHJhd0xheWVycyhjCiAgICAgLy8gU2V0IHRoZSByb290VmlzaWJsZVJlY3Qg LS0tIHVzZWQgYnkgc3Vic2VxdWVudCBkcmF3TGF5ZXJzIGNhbGxzCiAgICAgbV9yb290VmlzaWJs ZVJlY3QgPSB2aXNpYmxlUmVjdDsKIAotICAgIC8vIFRyYW5zbGF0ZSBhbGwgdGhlIGNvbXBvc2l0 ZWQgbGF5ZXJzIGJ5IHRoZSBzY3JvbGwgcG9zaXRpb24uCi0gICAgVHJhbnNmb3JtYXRpb25NYXRy aXggbWF0cml4OwotICAgIG1hdHJpeC50cmFuc2xhdGUzZCgtbV9zY3JvbGxQb3NpdGlvbi54KCks IC1tX3Njcm9sbFBvc2l0aW9uLnkoKSwgMCk7Ci0KICAgICAvLyBUcmF2ZXJzZSB0aGUgbGF5ZXIg dHJlZSBhbmQgdXBkYXRlIHRoZSBsYXllciB0cmFuc2Zvcm1zLgogICAgIGZsb2F0IG9wYWNpdHkg PSAxOwogICAgIGNvbnN0IFZlY3RvcjxSZWZQdHI8TGF5ZXJDaHJvbWl1bT4gPiYgc3VibGF5ZXJz ID0gbV9yb290TGF5ZXItPmdldFN1YmxheWVycygpOwogICAgIHNpemVfdCBpOworICAgIFRyYW5z Zm9ybWF0aW9uTWF0cml4IGlkZW50aXR5TWF0cml4OwogICAgIGZvciAoaSA9IDA7IGkgPCBzdWJs YXllcnMuc2l6ZSgpOyBpKyspCi0gICAgICAgIHVwZGF0ZUxheWVyc1JlY3Vyc2l2ZShzdWJsYXll cnNbaV0uZ2V0KCksIG1hdHJpeCwgb3BhY2l0eSk7CisgICAgICAgIHVwZGF0ZUxheWVyc1JlY3Vy c2l2ZShzdWJsYXllcnNbaV0uZ2V0KCksIGlkZW50aXR5TWF0cml4LCBvcGFjaXR5KTsKIAogICAg IC8vIEVuYWJsZSBzY2lzc29yaW5nIHRvIGF2b2lkIHJlbmRlcmluZyBjb21wb3NpdGVkIGxheWVy cyBvdmVyIHRoZSBzY3JvbGxiYXJzLgogICAgIEdMQyhtX2NvbnRleHQsIG1fY29udGV4dC0+ZW5h YmxlKEdyYXBoaWNzQ29udGV4dDNEOjpTQ0lTU09SX1RFU1QpKTsK