46192 2010-09-21 09:39:56 -0700 Add link to bug to review page 2010-09-25 15:52:41 -0700 1 1 1 Unclassified WebKit WebKit Website 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 darin webkit-unassigned abarth ap cfleizach commit-queue darin eric oldest_to_newest 282358 0 darin 2010-09-21 09:39:56 -0700 I’d really like to have a link to the bug on the review page! 282458 1 abarth 2010-09-21 11:46:36 -0700 There are three (small) problems that need to be solved to make that happen: 1) Adding the link at a time when we know the bug_id. We know the bug_id in the context of this function: http://trac.webkit.org/browser/trunk/BugsSite/code-review.js#L225 2) Deciding where to display the link. I think putting it on the toolbar makes sense, but the toolbar is getting a bit crowded. Maybe we should move the help text elsewhere? 3) The CSS for hyperlinks in PrettyPatch is overbroad, which means it would apply to the bug link too. We probably need to tighten down the CSS for hyperlinks so the bug link isn't the wrong font/size. 282460 2 68267 abarth 2010-09-21 11:48:38 -0700 Created attachment 68267 dev extension Here's the extension I use to develop the tool. Basically, it substitutes the existing code-review.js on the live site with the one in the extension. That way you can hack on the script and see the effects on the live site at the same time. 282479 3 darin 2010-09-21 12:32:58 -0700 (In reply to comment #1) > 1) Adding the link at a time when we know the bug_id. We know the bug_id in the context of this function: > http://trac.webkit.org/browser/trunk/BugsSite/code-review.js#L225 Now that I know about this it won’t be too hard. > 2) Deciding where to display the link. I think putting it on the toolbar makes sense, but the toolbar is getting a bit crowded. Maybe we should move the help text elsewhere? > > 3) The CSS for hyperlinks in PrettyPatch is overbroad, which means it would apply to the bug link too. We probably need to tighten down the CSS for hyperlinks so the bug link isn't the wrong font/size. When doing the work myself, I used the web inspector to insert the link and it looked fine. For both (2) and (3) above, it was OK the way I had it. I figured others might later want to refine further, but I think just putting the bug before the instructions is fine. And the style for links looked OK to me. Assuming it’s a Chromium extension, I’ll have to make it work in Safari, but thanks very much for showing me that extension. 282676 4 abarth 2010-09-21 17:20:41 -0700 > Assuming it’s a Chromium extension, I’ll have to make it work in Safari, but thanks very much for showing me that extension. Yeah, it's a Chrome extension, but should give you the general idea. 283226 5 abarth 2010-09-22 13:49:12 -0700 *** Bug 46282 has been marked as a duplicate of this bug. *** 283486 6 68495 abarth 2010-09-22 20:39:51 -0700 Created attachment 68495 Patch 283487 7 68495 eric 2010-09-22 20:41:06 -0700 Comment on attachment 68495 Patch OK. 283488 8 abarth 2010-09-22 20:42:21 -0700 Committed r68118: <http://trac.webkit.org/changeset/68118> 285058 9 ap 2010-09-25 15:52:41 -0700 *** Bug 46498 has been marked as a duplicate of this bug. *** 68267 2010-09-21 11:48:38 -0700 2010-09-21 11:48:38 -0700 dev extension wkreview.zip application/zip 5541 abarth UEsDBBQAAAAIAAm9ND0MwQ0bKBIAAIc/AAAXABwAd2tyZXZpZXcvY29kZS1yZXZpZXcuanNVVAkA A1FTmExeWJhMdXgLAAEE9QEAAAQUAAAAzTtrc9pItt/9KzpsahBlEPbcb3bsKQw4Ua0DXsDJpDxe l0CN0VpIjCTseHbz3+85/VJ362HP3pqqW5UE6D59Xn36vLrT75NhsntJw4dNTpxhh/x8dHxEBoG/ JRd+mm9cMogiwqYzktKMpk80cA/6ffhDZjQIszwNl/s8TGLixwHZZ5SEMcmSfbqibGQZxn76QtZJ us265DnMNyRJ2WeyzxHLNgnCdbjyEUeX+CklO5puwzynAdmlyVMYwJd84+fwDwU8UZQ8h/EDWSVx EOKijC3a0vxE8HXsWqxlJFlLnlZJAMD7LAdxch94Raz+MnnCKamJOMnDFe0isnwTZiQCZIhDpxkH FkNAcRX54ZamUkE/lxkBgppGJCMgZ7AH5v4CXogQMUhW+y2Nc6ZnRAaL+rATCUymZOvnNA39KCtU zraKrdQEkJItPnlzMp9eLr4OZmMC369n0y/eaDwiF9/I4Pr6CgYnQ7CeyYh4izkZTieLmXdxs5jO 5qQ1mMOSFpscTL4hvvGv17PxfE6mM+J9vr7yABFgng0mC2887yKuq5uRN/nYJYCDTKYLcuV99hYA tph2gZuxXIbIipVkekk+j2fDT/BzcOFdeYtvjOqlt5gguUugNyDXg9nCG95cDWbk+mZ2PZ2PCUiF mEbefHg18D6PRy7wAHTJ+Mt4siDzT4OrK11O5NsW82IMTA4uAATIIDaQFTDOxsMFSlR8G4LigL+r Lplfj4cefhn/OgZ5BrNvXUQNaOfjf9wAEEwyvgafBx9BPOcVxcCuDG9m48/IM6hifnMxX3iLm8WY fJxOR6huxDYfz754w/H8lFxN50xnN/NxF4gsBow8YAGFwTR8v7iZe0x13mQxns1urhfedNIhn6Zf QTMM23AAq0dMzdMJkxm2Zzr7hnhRH2wXuuTrpzGMz1CtTGsD1MUctDdcIBYNEqiCPheasGQy/njl fRxPhmOcnSKir9583IF98+YI4HHKXwfMuqY3THw0E+CNf9Xst8t2lXiXZDD64iHzAhhMYe4Js2Hq G34qtO8eHDjrfbzCY+F0yL8PCJE/SUBz9GExHeS5v9rgufNGAoiQHE4//0bQCe3TmPTD4Mz5LTjs 9F36na4cOMRB8uxGCfeLbkb9dLXp3B7fsXU/CIyvNsSh3zsWqlMOcIB/4R80O3Cl2x24z4T4wN4T HHWSxNGL9AytGX0K6TO5RpQt9Cs5/Z67sDhcE8lJnuzIuzPCf3UOTHoI966aZXeLWJ2+zxRzljJS /Y6N4clPia90dR8G5KxOiYqgAW8iFBhjkOM+Agwc4RGbUJsUBpdJegWzTrzfLmkqNSm2pI0L2+SQ 8NlTqVG1HrHjcm1nxVINs8bB4WGnjASiwBikYMArP4qW/upRYoM54qAcIWMePj4YIp2Sw8Ow2H+5 3HnvtP+GjBdshJ1OxzIMTQ3h+qWwTQgxLtOWLl6Z7w0EqVRf+N7BpR2XTdgHQwfwg2AY+VnmtDdJ 3pZsdbnEEn3FupRuAXXF0grudmhnyT4bJlu0jwz04KDSJFZU6krMgai3d6dqeJdkLKrCMK7gE8+b MKLEkXMu6gZY/OknYg25Gz8TLFo8tDuFSBoNa/2p3EvBnLvbZ5uC7gMFGG0nlcW9d+SKKhuDkym4 uBaYqhTyF0r+RrmFMHKuUZILcDSPDft6v0QAoNQkvUGdORVjtSbTypZF97aCb2NtmfkwhvQ5F6xI FrqEQasj38SsvwaH6HD4Mno8VyZuiRQFw98ueMzUaQd+7vdAst6qbJkQLi69Xz+PT8gCc83f9xRi FXzBQw0RA1bsIvqdLOnKx1T/GZL1yGdZNUPFhckKZIxlgm4kcwnx4iynftC1wEkGtUAEpQLgAXML UhpjgstXCVxv2EX5sQ4j1FPbXafJHzRWVuhScLTOPl6nlP5BxbA6cXb0JKRJZV3SztM9lT6IgyrH JqCGPJIiUK11gq/+EIRPZIUrz1piunX+AVdCXeMTRluM9yAknLXQt2vMhUG7AyNtWNSXq851pDz2 ZjAPSXwOpiLGk8fW+fTvH/p81J7FEsJPg9b5iH8p4PqAW/wrFVBj24a0AtQ6YVBrwJ5lEXyOkufY aa/9DPXbEEGkkThtKS5s7hrqm8xpiAna+QhpFDi6z2ABTwWoYss1tbd1LyHzDcJXiqDJAcxzWMTi TsETkgQrpRh7/l3i8tp0n0KV/h4q5rRQKYre5PakYb3dfOTGW+67ZW01S9UYM3VGzGeLdS7y6vBR pHSio8K5+tMAB0jngGMyVFBlVP5uR+PA0bnsyMGCnnAIMpMBu4pCyJ4sO/mzBm5uJxwicJAv1pZm RbRuSPVUDhDR+CHfWNlesQ2wQoLehncuHzzVwNDU7mN/Sy1INa4Ds9ySp7wWuDajL9B3w1qhTwkf WHDEQjOcgVvFxp0Bw2PPGWm7GAgIVCBtSVYGNMHN7dEdOQPAXrtQD4s+C6hudHmw0UIzDDw+Yemk H0FU+koh18UeE9RHwb+wIYNVESefJzq+KEkeiWhEtSC6bFsMvQpSpMQ0Aim2OU9puIXotmZIgGVW b6VJBKHPT8FTY/dIgpt7of1ys/0yg8N7rMLXjwPlJFGfGAXB2Bk7ws4rHCrXpPR7OU/t3hmUOgrU DJG6uWi+cwfeONbyWPInHZoSx0hykUvrNOCGH1XlYgHNVmm4y41zIReB85Fj7dNa1OfkWGLWsB3C rmZiFXr1PEmg3EqJtPJ57uf7TPqoNsufdqxKh8SBoNPVkYGFEDJfwcZHYAlpsn9gzbZt0XZrxS3W 2GvtWuSRvmRuu8K/QGTGPEj5FanUmujAi50DffNwiNX74KhC4Pu3WHrnKp/Ezb3WIcH2MxoMDD2A qP7/6dyek7vDjnP7zxP4OHF6v2Cz432/ox/pd2x5YXF4MsJ4b7in3/dJTu+3fvpIU6TEltwe39X5 Oz7/8129i+MQ/3NncFKgCGPupurZEiWSrR6skZQelGUd6cPScUFkU9hBp1XeVW7V7d0byDo2XTws 5D//MQi/44R1b2AQ46WnXKGdaI3DH+Kz1wtP0bmN6Ar8KjrYUNUIvDGdovPcgXWDvYexggJP/IBN ePjjk4xiT9utkN6MLYK/fyVhzO3VzcGp1hXPhXhtfjraJ9L3FDNqv2FSfdfmNZMBCO2XBqMzC0D6 z0qvZlaNWUXBmPHO3GXkPzgZjegqtxpN7+WwyOXyMI+gKGFGNaPg/SGYoe65H+LNN7ddRQk9SJj/ Y0/39E+Tk6d8xXD0fkck/do+BIt24LMqyODRqxLa9POm9+VCEQ4pXReN8B6KYasRrAnlqlhi4VXQ 1fUFEsBeU9GwdAK8ZIoy3RevAepeRv0z0vrAaZx/SHaICJJd+UV8/lIaOSyN9IqRvsDXqohVohRs q3RYZQ3tD9nOV8Uf12rrnKQnLHQZPEPwAiIAje7jFUSaLgHb6vfX0IkUUKiNZzHtvyF8pvaiNp+p MDC9pOPraeDFAf0OJeb7htlOQyW5pmDun8IMArnW/2TNuXbRlHZXD+EvYXCG8pqtbRD4J9EPp0Fo FLtYrZkhdbl/4N3rfmFVBIIn+FqmIna+L/YPRL8+YGi0qCiYyzbJ8z0g1Fnj+GtZqO2V8s1mwGKX 3OUf96ql1JBzWrWL3AWBhG5BKplFaVGnqBbLawrC3PnWrZZAPH3ANN25hASd7HcBuxRZaxtFKveN uNIyO20dO/oalkVxV2gS6uhJNG7GlqYPVKWd3eYsTpPih/b91cpST6U1exL8MyWy3ZNwzf7rtDjf Dd4ET3+4TjFvEuc/Y1nxxX65jGiLZOnqrLXJ81120u8/0+UjhAs9aiCebJfk6IL7fGlvydb2K7cD MLIUOowfzlpxgo0CTv688QCvUv85GoXrtXZ7wSs2abjsUqTUIAiWUVOPAJFcQvKAmBtOgJ2iltta m+OSCdulsug6lWSETRUX/Xhj4gcvZQ406UWib/gzKYvE4y6TAGSHypltMW/QgPNoCTNoNfcaEXLH w4k8pDB7zUdKvUcGnWS5DrpfRmG2sduPGs0tzTL/AeNLKfSougxNg8UYE2ZDo13rfJQADdpjewt5 KKtpwTfx3/AlSP0HAtyxCZ73ZbxdEAC4oOMKAlXt0TdoU7oMfBaiWnFhzG5sqanj5zDOqeqv6TMR vhhZJt9hThxDRM11zRGzE/gng5S2vjhgbxJTuAWjqYenyY+iodpgfVKWyEC2dT7lkCr6nAiaRZNb 63drjAiPpzfhsIEt2w96LlZcDpsdjOwGarwIznMR0GRrQwQdrfXc3DA2uiS8GSyo8rBQe6fFm+I3 u7e0xPnlaOEuWH+XDw5qLn0kKNZOQ+PCYpFcUBCAcjbq3ah1lVK6CsZjj719yDoKt1LmV/gtpWuI sXzDQLURGL/TZgcRFGBuJN9lY2HyWFpTUppdV7JLlv/L/pcaSQqt++RHjqxOWVGmdShNYVy8vecs 1N9ImRZbovZX2aG4o+HXj1aL3rhja2rUF/ro6If0fcU9nbmB5Qs7IxfHa59pLEnp8ZxNUbQi4+mA Gi7t22utRT228rxjkezU4uL6ryAsb7LRCJId6Yn3M24YxzT9RNFb93+ufBUCGCagtSqfpSXjKGbp tr2+sVknGGvyYdmjt0zZgGMoUqDu98mEPUrkzzJ7xwSqi4xs0duzNvqRKxqIfG+KxwmsDOGUDslx p1Mnut0x/n8lPusrcPAzEF7dBNoYRJe0vOZIq1iFim7vGo59ox57ph5RlsfhxodiIqBwhCdY5cTg x8TQIHeOGLQNeI2AuxIgP6IYzdXBfKQveI2SVTlX/f0ATWk7Iw8Je3m2pJApLWmOzwGe/ReWPT0l 4McySvHBar6hGSUStcRFn5i0SoXstwu+BOR3Y+BywlJo4Hwx/nUxmI0H7aoNLpZK6XCNoaaOviHG ybM6Ss14rg08JTOuyk7Eezv22qH6PUssql5ZeovOL4vxpRcq6tGBliSogpNNdYkW14mMCQwbj9gV Tcr3cjH22yD7pU7V2X0tlRAcvY1/2SivfbXCOtj8FYYSVct7at9ivC62OklhfI+5/z3vDeGNpQ92 YO4flE27EQDNGYxRUcqWkh2CinFhnzVktNwI+Zzw/vObMpzGezn1IKjBet6WHQrVCcMWjG0T9JfJ c1zFXElW3EEzOVSZVhFSbY3xU4jE4XNE1/4+0o4XIQdGSa+xRbF0quSLveswmLNdiVLukilAVy8w IjPGglWFl8PLfLhQegEqSQnIasEVff6qqiCPD58ayDPw8jO9MnUO2EC8/IbT3BjTBPa7/1LRUk6J XIR62wgYCHs6dg8MyZYBAL+TkC4wqb0Mqzd3jlAta3rKJWUoU1ZqNF4AWbzYyS82YuaUqci01Ij6 TxQUaPqXsoKt+crgMo9DyM20dyuYO8TGDXHGQbQb4srA1NjV4v0CTCSI8VZDvQ1W+gcVtbW2aLHw UC1UEbe8mjvTagQ9haCiX1y02NzKRrFUAr855ErCzgjHfki0NwqyFysCpFpZ3EpWXYBFLGOxw7zA wR2qWX9q/USrALWahPZb00CYX0B3+cYi5MT0mQzS1H/h0zwZF6yf8+dgpOKaMHvdjPTGZklcsxA1 X7ZUbC/5hT2QEa/VtL1jr2rUg5WT0nyeWDsr3+XLDS24ZM/RZCksGIIx2D/4eOX0lBXEXie8+thL vWNQnsN+hM53RaslsvAP1d1Rg01HUYh6ZltCr9d52/kQb+9KR8Ri3DopQnHqt/2ypDgeCqpTfaBs OhXnCtsYetuUuLwz+nqGZK9s6yFNNl2rm4lgOpEXiztqWFpZm95DfNPzdlHGFf/VQ3Gku4E3vNTW cl7l+8xnWRob5uN3q6lT+YhW71fpDlwhZC2sBsqyGtcNu/Y/Y+gLhWsB8Bong79L2MW54P5LR1c+ XtVHs4SxU6HHe3yTdV+uw0glAD8RQgpDizZT70xt1iOzFtoPXSpWKAcme2bGAt0+OXwlpuLIWUfU tDHMYqymPmm0Kd2iDB3IQXxq91sMhA2Hh8NVAkg2i5drevNHhyxeYdkUgeAXfEYSqpSJP1Sw/lMb 93CGbguNiEsu5ol4j7W4OAE9CIeaFTFJgctnDkWzGZVmbl4F+BtfRcgmAn9uUvdGQjfUdwJcHK+6 A9/0fqIrSb71dQXqy74nfN2Rl72xLCVLDt6owCt9PGNBv3z87+mXd0twke2X21ArVX908Pv/AlBL AwQUAAAACABSXR09yrSg4bAAAAAKAQAAFgAcAHdrcmV2aWV3L21hbmlmZXN0Lmpzb25VVAkAAxuq ekyr/ZhMdXgLAAEE9QEAAAQUAAAAPY7NDoIwEITvfYqmR0OKXrl48S0MMaWsULE/2S5gQnh3WxAv m+zMfjO7MM6FUxZExcU8IEwGZlFkdQKMxrtsXOR511qIGk2gn36DCd4+WHDE4UPgMsCfHvkRJXdO e5dceux0TOw9yZwv20wHVpHuYTNETxRiVZbN2EU5QzMYkh67UhEp3ecyqTtzPYm6OHAc3UNRfqn1 erRbFSkk8b947dkBISgEmdZ6s9Y0a7Yy9gVQSwMEFAAAAAgA62MfPcyd61O3AAAA/QAAABMAHAB3 a3Jldmlldy9wcmVwYXJlLmpzVVQJAAOJWH1MaXOYTHV4CwABBPUBAAAEFAAAAFWOwQ6CMAyG7zxF 44WRCLsretKbz2AyugJDtpFuUxPju4sQD57aP/3S/9MekyUXK6X1+T4vFxMiOWKRN9R6ptErnW+h TQ6j8U4U8MoATAuCvniVeKysitgLeUWvqWS6G3pUQ5DFygKs5MTLPFGr0hhFsV9u+ifwYBNJ5HVA NlOEwHjYYM/eUknPWSnM7Tspm6HDDq2lwd6Ms83NkVE9Tt03+LGX/xKbYy3Xj8d8aXxn7y1ETjSn D1BLAQIeAxQAAAAIAAm9ND0MwQ0bKBIAAIc/AAAXABgAAAAAAAEAAACkgQAAAAB3a3Jldmlldy9j b2RlLXJldmlldy5qc1VUBQADUVOYTHV4CwABBPUBAAAEFAAAAFBLAQIeAxQAAAAIAFJdHT3KtKDh sAAAAAoBAAAWABgAAAAAAAEAAACkgXkSAAB3a3Jldmlldy9tYW5pZmVzdC5qc29uVVQFAAMbqnpM dXgLAAEE9QEAAAQUAAAAUEsBAh4DFAAAAAgA62MfPcyd61O3AAAA/QAAABMAGAAAAAAAAQAAAKSB eRMAAHdrcmV2aWV3L3ByZXBhcmUuanNVVAUAA4lYfUx1eAsAAQT1AQAABBQAAABQSwUGAAAAAAMA AwASAQAAfRQAAAAA 68495 2010-09-22 20:39:51 -0700 2010-09-22 20:41:06 -0700 Patch bug-46192-20100922203949.patch text/plain 4096 abarth SW5kZXg6IEJ1Z3NTaXRlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBCdWdzU2l0ZS9DaGFuZ2VM b2cJKHJldmlzaW9uIDY4MTE3KQorKysgQnVnc1NpdGUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkp CkBAIC0xLDMgKzEsMjAgQEAKKzIwMTAtMDktMjIgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0 Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBB ZGQgbGluayB0byBidWcgdG8gcmV2aWV3IHBhZ2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTQ2MTkyCisKKyAgICAgICAgVG8gbWFrZSByb29tIGZvciB0 aGUgbGluaywgSSBtb3ZlZCB0aGUgaGVscCB0ZXh0IHRvIHRoZSB0b3Agb2YgdGhlIHBhZ2UKKyAg ICAgICAgYW5kIHR3ZWFrZWQgdGhlIGxhbmd1YWdlIHRvIGhlbHAgZm9sa3MgZGlzY292ZXIgdGhh dCB5b3UgY2FuIHNlbGVjdAorICAgICAgICBjb250ZXh0IHVzaW5nIHRoZSBsaW5lIG51bWJlcnMu CisKKyAgICAgICAgQWxzbywgbW92ZSBtb3JlIHRleHQgdG8gc2Fucy1zZXJpZiBzaW5jZSB0aGF0 IGZpdHMgaW4gYmV0dGVyIHdpdGggdGhlCisgICAgICAgIHByZXR0eS1wYXRjaCBmb250cy4KKwor ICAgICAgICAqIFByZXR0eVBhdGNoL1ByZXR0eVBhdGNoLnJiOgorICAgICAgICAqIGNvZGUtcmV2 aWV3LmpzOgorCiAyMDEwLTA5LTIxICBBZGFtIEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CiAK ICAgICAgICAgVW5yZXZpZXdlZC4KSW5kZXg6IEJ1Z3NTaXRlL2NvZGUtcmV2aWV3LmpzCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIEJ1Z3NTaXRlL2NvZGUtcmV2aWV3LmpzCShyZXZpc2lvbiA2ODExNikKKysrIEJ1 Z3NTaXRlL2NvZGUtcmV2aWV3LmpzCSh3b3JraW5nIGNvcHkpCkBAIC0xNjEsNyArMTYxLDcgQEAK ICAgICBkZXNjcmlwdG9yID0gY29tbWVudHMubGVuZ3RoICsgJyBjb21tZW50JzsKICAgICBpZiAo Y29tbWVudHMubGVuZ3RoID4gMSkKICAgICAgIGRlc2NyaXB0b3IgKz0gJ3MnOwotICAgICQoJyN0 b29sYmFyIC5jb21tZW50U3RhdHVzJykudGV4dCgnVGhpcyBwYXRjaCBoYXMgJyArIGRlc2NyaXB0 b3IgKyAnLiAgU2Nyb2xsIHRocm91Z2ggdGhlbSB3aXRoIHRoZSAibiIgYW5kICJwIiBrZXlzLicp OworICAgICQoJy5tZXNzYWdlIC5jb21tZW50U3RhdHVzJykudGV4dCgnVGhpcyBwYXRjaCBoYXMg JyArIGRlc2NyaXB0b3IgKyAnLiAgU2Nyb2xsIHRocm91Z2ggdGhlbSB3aXRoIHRoZSAibiIgYW5k ICJwIiBrZXlzLicpOwogICB9CiAKICAgZnVuY3Rpb24gc2NhbkZvckNvbW1lbnRzKGF1dGhvciwg dGV4dCkgewpAQCAtMjQwLDYgKzI0MCw3IEBACiAgICAgICB2YXIgZGV0YWlscyA9ICQoZGF0YSk7 CiAgICAgICBhZGRGbGFnc0ZvckF0dGFjaG1lbnQoZGV0YWlscyk7CiAgICAgICAkKCcjdG9vbGJh ciAuYWN0aW9ucycpLmFwcGVuZCgkKCc8aWZyYW1lIGNsYXNzPSJzdGF0dXNCdWJibGUiIHNyYz0i aHR0cHM6Ly93ZWJraXQtY29tbWl0LXF1ZXVlLmFwcHNwb3QuY29tL3N0YXR1cy1idWJibGUvJyAr IGF0dGFjaG1lbnRfaWQgKyAnIiBzY3JvbGxpbmc9Im5vIj48L2lmcmFtZT4nKSk7CisgICAgICAk KCcjdG9vbGJhciAuYnVnTGluaycpLmh0bWwoJzxhIGhyZWY9Ii9zaG93X2J1Zy5jZ2k/aWQ9JyAr IGJ1Z19pZCArICciIHRhcmdldD0iX2JsYW5rIj5CdWcgJyArIGJ1Z19pZCArICc8L2E+Jyk7CiAg ICAgfSk7CiAgIH0KIApAQCAtMjU0LDcgKzI1NSw4IEBACiAgICQoZG9jdW1lbnQpLnJlYWR5KGZ1 bmN0aW9uKCkgewogICAgIGNyYXdsRGlmZigpOwogICAgIGZldGNoSGlzdG9yeSgpOwotICAgICQo ZG9jdW1lbnQuYm9keSkucHJlcGVuZCgnPGRpdiBpZD0idG9vbGJhciI+PGRpdiBjbGFzcz0iYWN0 aW9ucyI+PGJ1dHRvbiBpZD0icHJldmlld19jb21tZW50cyI+UHJldmlldzwvYnV0dG9uPjxidXR0 b24gaWQ9InBvc3RfY29tbWVudHMiPlB1Ymxpc2g8L2J1dHRvbj48L2Rpdj48ZGl2IGNsYXNzPSJt ZXNzYWdlIj4gPHNwYW4gY2xhc3M9ImNvbW1lbnRTdGF0dXMiPjwvc3Bhbj4gPHNwYW4gY2xhc3M9 ImhlbHAiPkRvdWJsZS1jbGljayBhIGxpbmUgb3IgY2xpY2sgb3IgZHJhZyBvbiBsaW5lIG51bWJl cnMgdG8gYWRkIGEgY29tbWVudC48L3NwYW4+PC9kaXY+PC9kaXY+Jyk7CisgICAgJChkb2N1bWVu dC5ib2R5KS5wcmVwZW5kKCc8ZGl2IGlkPSJtZXNzYWdlIj48ZGl2IGNsYXNzPSJoZWxwIj5Eb3Vi bGUtY2xpY2sgYSBsaW5lIG9yIHNlbGVjdCBsaW5lIG51bWJlcnMgdG8gYWRkIGEgY29tbWVudC48 L2Rpdj48ZGl2IGNsYXNzPSJjb21tZW50U3RhdHVzIj48L2Rpdj48L2Rpdj4nKTsKKyAgICAkKGRv Y3VtZW50LmJvZHkpLnByZXBlbmQoJzxkaXYgaWQ9InRvb2xiYXIiPjxkaXYgY2xhc3M9ImFjdGlv bnMiPjxidXR0b24gaWQ9InByZXZpZXdfY29tbWVudHMiPlByZXZpZXc8L2J1dHRvbj48YnV0dG9u IGlkPSJwb3N0X2NvbW1lbnRzIj5QdWJsaXNoPC9idXR0b24+PC9kaXY+PGRpdiBjbGFzcz0ibGlu a3MiPjxzcGFuIGNsYXNzPSJidWdMaW5rIj48L3NwYW4+PC9kaXY+Jyk7CiAgICAgJChkb2N1bWVu dC5ib2R5KS5wcmVwZW5kKCc8ZGl2IGlkPSJjb21tZW50X2Zvcm0iIGNsYXNzPSJpbmFjdGl2ZSI+ PGRpdiBjbGFzcz0id2ludGVyIj48L2Rpdj48ZGl2IGNsYXNzPSJsaWdodGJveCI+PGlmcmFtZSBp ZD0icmV2aWV3Zm9ybSIgc3JjPSJhdHRhY2htZW50LmNnaT9pZD0nICsgYXR0YWNobWVudF9pZCAr ICcmYWN0aW9uPXJldmlld2Zvcm0iPjwvaWZyYW1lPjwvZGl2PjwvZGl2PicpOwogICAgICQoZG9j dW1lbnQuYm9keSkuYXBwZW5kKCc8ZGl2IGNsYXNzPSJvdmVyYWxsQ29tbWVudHMiPjxkaXYgY2xh c3M9ImRlc2NyaXB0aW9uIj5PdmVyYWxsIGNvbW1lbnRzOjwvZGl2Pjx0ZXh0YXJlYT48L3RleHRh cmVhPjwvZGl2PicpOwogICB9KTsKSW5kZXg6IEJ1Z3NTaXRlL1ByZXR0eVBhdGNoL1ByZXR0eVBh dGNoLnJiCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIEJ1Z3NTaXRlL1ByZXR0eVBhdGNoL1ByZXR0eVBhdGNoLnJi CShyZXZpc2lvbiA2ODExNikKKysrIEJ1Z3NTaXRlL1ByZXR0eVBhdGNoL1ByZXR0eVBhdGNoLnJi CSh3b3JraW5nIGNvcHkpCkBAIC0yMTMsMjAgKzIxMywxNyBAQCBib2R5IHsKICAgcmlnaHQ6IDA7 CiAgIGJvcmRlci10b3A6IDFweCBzb2xpZCAjZGRkOwogICBiYWNrZ3JvdW5kLWNvbG9yOiAjZWVl OworICBmb250LWZhbWlseTogc2Fucy1zZXJpZjsKIH0KIAogI3Rvb2xiYXIgLmFjdGlvbnMgewog ICBmbG9hdDogbGVmdDsKIH0KIAotI3Rvb2xiYXIgLm1lc3NhZ2UgeworI3Rvb2xiYXIgLmxpbmtz IHsKICAgZmxvYXQ6IHJpZ2h0OwogfQogCi0jdG9vbGJhciAuY29tbWVudFN0YXR1cyB7Ci0gIGZv bnQtc3R5bGU6aXRhbGljCi19Ci0KIC53aW50ZXIgewogICBwb3NpdGlvbjogZml4ZWQ7CiAgIHot aW5kZXg6IDU7CkBAIC0yNzEsNiArMjY4LDE1IEBAIGJvZHkgewogIGZvbnQtc3R5bGU6IGl0YWxp YzsKIH0KIAorLm1lc3NhZ2UgeworICBmb250LXNpemU6IHNtYWxsOworICBmb250LWZhbWlseTog c2Fucy1zZXJpZjsKK30KKworLmNvbW1lbnRTdGF0dXMgeworICBmb250LXN0eWxlOiBpdGFsaWM7 Cit9CisKIC5kZXNjcmlwdGlvbiB7CiAgIGZvbnQtc3R5bGU6IGl0YWxpYzsKIH0KQEAgLTMwNiw3 ICszMTIsNyBAQCBib2R5IHsKIH0KIDwvc3R5bGU+CiA8c2NyaXB0IHNyYz0iaHR0cHM6Ly9hamF4 Lmdvb2dsZWFwaXMuY29tL2FqYXgvbGlicy9qcXVlcnkvMS40LjIvanF1ZXJ5Lm1pbi5qcyI+PC9z Y3JpcHQ+IAotPHNjcmlwdCBzcmM9ImNvZGUtcmV2aWV3LmpzP3ZlcnNpb249MTEiPjwvc2NyaXB0 PiAKKzxzY3JpcHQgc3JjPSJjb2RlLXJldmlldy5qcz92ZXJzaW9uPTEyIj48L3NjcmlwdD4gCiBF T0YKIAogICAgIGRlZiBzZWxmLnJldmlzaW9uT3JEZXNjcmlwdGlvbihzdHJpbmcpCg==