<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>46188</bug_id>
          
          <creation_ts>2010-09-21 08:52:53 -0700</creation_ts>
          <short_desc>Make the cross-platform setPrinting method match the Mac-specific WebKit method.</short_desc>
          <delta_ts>2010-09-21 08:58:37 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Printing</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>PC</rep_platform>
          <op_sys>OS X 10.5</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Dave Hyatt">hyatt</reporter>
          <assigned_to name="Dave Hyatt">hyatt</assigned_to>
          
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>282330</commentid>
    <comment_count>0</comment_count>
    <who name="Dave Hyatt">hyatt</who>
    <bug_when>2010-09-21 08:52:53 -0700</bug_when>
    <thetext>OS X does not use Frame::setPrinting, since it still has its own WebKit method.  The cross-platform method was copied from it, and I noticed while mucking around in the printing code that it contains an error.  Subframes are not supposed to receive the page size or lay out to the page size.  The Mac method just passes 0 for all the numbers to child frames, so I will change the cross-platform method to match.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>282331</commentid>
    <comment_count>1</comment_count>
      <attachid>68244</attachid>
    <who name="Dave Hyatt">hyatt</who>
    <bug_when>2010-09-21 08:54:38 -0700</bug_when>
    <thetext>Created attachment 68244
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>282337</commentid>
    <comment_count>2</comment_count>
    <who name="Dave Hyatt">hyatt</who>
    <bug_when>2010-09-21 08:58:37 -0700</bug_when>
    <thetext>Fixed in r67956.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>68244</attachid>
            <date>2010-09-21 08:54:38 -0700</date>
            <delta_ts>2010-09-21 08:57:30 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>patch.txt</filename>
            <type>text/plain</type>
            <size>1463</size>
            <attacher name="Dave Hyatt">hyatt</attacher>
            
              <data encoding="base64">SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n
CShyZXZpc2lvbiA2Nzk1NCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA
IC0xLDMgKzEsMTMgQEAKKzIwMTAtMDktMjEgIERhdmlkIEh5YXR0ICA8aHlhdHRAYXBwbGUuY29t
PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGh0dHBz
Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NjE4OCwgbWFrZSB0aGUgY3Jvc3Mt
cGxhdGZvcm0gc2V0UHJpbnRpbmcgbWV0aG9kIG1hdGNoIHRoZSBNYWMgdmVyc2lvbiBvZiB0aGUg
bWV0aG9kLgorICAgICAgICBTcGVjaWZpY2FsbHkgZG9uJ3QgcGFzcyB0aGUgcGFnZSBzaXplIGRv
d24gdG8gc3ViZnJhbWVzIG9mIHRoZSBvbmUgeW91J3JlIHByaW50aW5nLgorCisgICAgICAgICog
cGFnZS9GcmFtZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpGcmFtZTo6c2V0UHJpbnRpbmcpOgor
CiAyMDEwLTA5LTIxICBQYXRyaWNrIEdhbnN0ZXJlciAgPHBhcm9nYUB3ZWJraXQub3JnPgogCiAg
ICAgICAgIFJldmlld2VkIGJ5IEFkYW0gUm9iZW4uCkluZGV4OiBXZWJDb3JlL3BhZ2UvRnJhbWUu
Y3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcGFnZS9GcmFtZS5jcHAJKHJldmlzaW9uIDY3OTMw
KQorKysgV2ViQ29yZS9wYWdlL0ZyYW1lLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNDk5LDggKzQ5
OSw5IEBAIHZvaWQgRnJhbWU6OnNldFByaW50aW5nKGJvb2wgcHJpbnRpbmcsIGMKICAgICBtX2Rv
Yy0+c3R5bGVTZWxlY3RvckNoYW5nZWQoUmVjYWxjU3R5bGVJbW1lZGlhdGVseSk7CiAgICAgdmll
dygpLT5mb3JjZUxheW91dEZvclBhZ2luYXRpb24ocGFnZVNpemUsIG1heGltdW1TaHJpbmtSYXRp
bywgc2hvdWxkQWRqdXN0Vmlld1NpemUpOwogCisgICAgLy8gU3ViZnJhbWVzIG9mIHRoZSBvbmUg
d2UncmUgcHJpbnRpbmcgZG9uJ3QgbGF5IG91dCB0byB0aGUgcGFnZSBzaXplLgogICAgIGZvciAo
RnJhbWUqIGNoaWxkID0gdHJlZSgpLT5maXJzdENoaWxkKCk7IGNoaWxkOyBjaGlsZCA9IGNoaWxk
LT50cmVlKCktPm5leHRTaWJsaW5nKCkpCi0gICAgICAgIGNoaWxkLT5zZXRQcmludGluZyhwcmlu
dGluZywgcGFnZVNpemUsIG1heGltdW1TaHJpbmtSYXRpbywgc2hvdWxkQWRqdXN0Vmlld1NpemUp
OworICAgICAgICBjaGlsZC0+c2V0UHJpbnRpbmcocHJpbnRpbmcsIEludFNpemUoKSwgMCwgc2hv
dWxkQWRqdXN0Vmlld1NpemUpOwogfQogCiB2b2lkIEZyYW1lOjppbmplY3RVc2VyU2NyaXB0cyhV
c2VyU2NyaXB0SW5qZWN0aW9uVGltZSBpbmplY3Rpb25UaW1lKQo=
</data>
<flag name="review"
          id="57734"
          type_id="1"
          status="+"
          setter="sullivan"
    />
          </attachment>
      

    </bug>

</bugzilla>