46185 2010-09-21 07:21:24 -0700 [WIN] Add internetHandle to WebCoreSynchronousLoader. 2010-09-22 00:37:35 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) PC Windows XP RESOLVED FIXED P2 Normal --- 43712 1 paroga paroga aroben commit-queue oldest_to_newest 282292 0 paroga 2010-09-21 07:21:24 -0700 see patch 282294 1 68237 paroga 2010-09-21 07:23:25 -0700 Created attachment 68237 Patch 282308 2 68237 aroben 2010-09-21 07:54:48 -0700 Comment on attachment 68237 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=68237&action=review > WebCore/platform/network/win/ResourceHandleWin.cpp:87 > +static HINTERNET asynchronousInternetHandle(const String& userAgent) > +{ > + static HINTERNET internetHandle = 0; > + > + if (!internetHandle) > + internetHandle = createInternetHandle(userAgent, true); > + > + return internetHandle; > +} You can do this more simply: static HINTERNET internetHandle = createInternetHandle(userAgent, true); return internetHandle; > WebCore/platform/network/win/ResourceHandleWin.cpp:188 > , m_response(response) > , m_data(data) > { > + m_internetHandle = createInternetHandle(userAgent, false); > +} Why not put this in the initializer list? 282340 3 68245 paroga 2010-09-21 09:03:00 -0700 Created attachment 68245 Patch 282809 4 68245 commit-queue 2010-09-22 00:37:30 -0700 Comment on attachment 68245 Patch Clearing flags on attachment: 68245 Committed r68020: <http://trac.webkit.org/changeset/68020> 282810 5 commit-queue 2010-09-22 00:37:35 -0700 All reviewed patches have been landed. Closing bug. 68237 2010-09-21 07:23:25 -0700 2010-09-21 09:03:00 -0700 Patch bug-46185.patch text/plain 3541 paroga SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nDQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09DQotLS0gV2ViQ29yZS9DaGFuZ2VM b2cJKHJldmlzaW9uIDY3OTQ5KQorKysgV2ViQ29yZS9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkK QEAgLTEsMyArMSwyMCBAQAorMjAxMC0wOS0yMSAgUGF0cmljayBHYW5zdGVyZXIgIDxwYXJvZ2FA d2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBbV0lOXSBBZGQgaW50ZXJuZXRIYW5kbGUgdG8gV2ViQ29yZVN5bmNocm9ub3VzTG9hZGVy LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDYxODUK KworICAgICAgICBGb3IgbG9hZGluZyBjb250ZW50IHZpYSBuZXR3b3JrIHRoZSBXZWJDb3JlU3lu Y2hyb25vdXNMb2FkZXIgbmVlZHMgaXRzIG93biAoc3luY2hyb25vdXMpIGludGVybmV0SGFuZGxl LgorICAgICAgICBUaGlzIGFsc28gYWRkcyBhc3luY2hyb25vdXNJbnRlcm5ldEhhbmRsZSgpIHRv IGNyZWF0ZSBhIHN0YXRpYyBhc3luY2hyb25vdXMgaW50ZXJuZXRIYW5kbGUuCisKKyAgICAgICAg KiBwbGF0Zm9ybS9uZXR3b3JrL3dpbi9SZXNvdXJjZUhhbmRsZVdpbi5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpjcmVhdGVJbnRlcm5ldEhhbmRsZSk6CisgICAgICAgIChXZWJDb3JlOjphc3luY2hy b25vdXNJbnRlcm5ldEhhbmRsZSk6CisgICAgICAgIChXZWJDb3JlOjpXZWJDb3JlU3luY2hyb25v dXNMb2FkZXI6OmludGVybmV0SGFuZGxlKToKKyAgICAgICAgKFdlYkNvcmU6OldlYkNvcmVTeW5j aHJvbm91c0xvYWRlcjo6V2ViQ29yZVN5bmNocm9ub3VzTG9hZGVyKTogQ3JlYXRlIHN5bmNocm9u b3VzIGludGVybmV0SGFuZGxlLgorICAgICAgICAoV2ViQ29yZTo6V2ViQ29yZVN5bmNocm9ub3Vz TG9hZGVyOjp+V2ViQ29yZVN5bmNocm9ub3VzTG9hZGVyKTogRGVsZXRlIHN5bmNocm9ub3VzIGlu dGVybmV0SGFuZGxlLgorCiAyMDEwLTA5LTIxICBTdGV2ZSBCbG9jayAgPHN0ZXZlYmxvY2tAZ29v Z2xlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBKZXJlbXkgT3Jsb3cuCkluZGV4OiBXZWJD b3JlL3BsYXRmb3JtL25ldHdvcmsvd2luL1Jlc291cmNlSGFuZGxlV2luLmNwcA0KPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQ0KLS0tIFdlYkNvcmUvcGxhdGZvcm0vbmV0d29yay93aW4vUmVzb3VyY2VIYW5kbGVXaW4uY3Bw CShyZXZpc2lvbiA2Nzk0MykKKysrIFdlYkNvcmUvcGxhdGZvcm0vbmV0d29yay93aW4vUmVzb3Vy Y2VIYW5kbGVXaW4uY3BwCSh3b3JraW5nIGNvcHkpCkBAIC02NSw2ICs2NSwyNyBAQCBzdGF0aWMg Y29uc3QgUmVzb3VyY2VIYW5kbGVFdmVudEhhbmRsZXIgCiAgICAgJlJlc291cmNlSGFuZGxlOjpv blJlcXVlc3RDb21wbGV0ZQogfTsKIAorc3RhdGljIGlubGluZSBISU5URVJORVQgY3JlYXRlSW50 ZXJuZXRIYW5kbGUoY29uc3QgU3RyaW5nJiB1c2VyQWdlbnQsIGJvb2wgYXN5bmNocm9ub3VzKQor eworICAgIFN0cmluZyB1c2VyQWdlbnRTdHJpbmcgPSB1c2VyQWdlbnQ7CisgICAgSElOVEVSTkVU IGludGVybmV0SGFuZGxlID0gSW50ZXJuZXRPcGVuVyh1c2VyQWdlbnRTdHJpbmcuY2hhcmFjdGVy c1dpdGhOdWxsVGVybWluYXRpb24oKSwgSU5URVJORVRfT1BFTl9UWVBFX1BSRUNPTkZJRywgMCwg MCwgYXN5bmNocm9ub3VzID8gSU5URVJORVRfRkxBR19BU1lOQyA6IDApOworCisgICAgaWYgKGFz eW5jaHJvbm91cykKKyAgICAgICAgSW50ZXJuZXRTZXRTdGF0dXNDYWxsYmFjayhpbnRlcm5ldEhh bmRsZSwgJlJlc291cmNlSGFuZGxlOjppbnRlcm5ldFN0YXR1c0NhbGxiYWNrKTsKKworICAgIHJl dHVybiBpbnRlcm5ldEhhbmRsZTsKK30KKworc3RhdGljIEhJTlRFUk5FVCBhc3luY2hyb25vdXNJ bnRlcm5ldEhhbmRsZShjb25zdCBTdHJpbmcmIHVzZXJBZ2VudCkKK3sKKyAgICBzdGF0aWMgSElO VEVSTkVUIGludGVybmV0SGFuZGxlID0gMDsKKworICAgIGlmICghaW50ZXJuZXRIYW5kbGUpCisg ICAgICAgIGludGVybmV0SGFuZGxlID0gY3JlYXRlSW50ZXJuZXRIYW5kbGUodXNlckFnZW50LCB0 cnVlKTsKKworICAgIHJldHVybiBpbnRlcm5ldEhhbmRsZTsKK30KKwogc3RhdGljIFN0cmluZyBx dWVyeUhUVFBIZWFkZXIoSElOVEVSTkVUIHJlcXVlc3RIYW5kbGUsIERXT1JEIGluZm9MZXZlbCkK IHsKICAgICBEV09SRCBidWZmZXJTaXplID0gMDsKQEAgLTE0Miw2ICsxNjMsOSBAQCBzdGF0aWMg dm9pZCBpbml0aWFsaXplT2ZmU2NyZWVuUmVzb3VyY2VICiBjbGFzcyBXZWJDb3JlU3luY2hyb25v dXNMb2FkZXIgOiBwdWJsaWMgUmVzb3VyY2VIYW5kbGVDbGllbnQsIHB1YmxpYyBOb25jb3B5YWJs ZSB7CiBwdWJsaWM6CiAgICAgV2ViQ29yZVN5bmNocm9ub3VzTG9hZGVyKFJlc291cmNlRXJyb3Im LCBSZXNvdXJjZVJlc3BvbnNlJiwgVmVjdG9yPGNoYXI+JiwgY29uc3QgU3RyaW5nJiB1c2VyQWdl bnQpOworICAgIH5XZWJDb3JlU3luY2hyb25vdXNMb2FkZXIoKTsKKworICAgIEhJTlRFUk5FVCBp bnRlcm5ldEhhbmRsZSgpIGNvbnN0IHsgcmV0dXJuIG1faW50ZXJuZXRIYW5kbGU7IH0KIAogICAg IHZpcnR1YWwgdm9pZCBkaWRSZWNlaXZlUmVzcG9uc2UoUmVzb3VyY2VIYW5kbGUqLCBjb25zdCBS ZXNvdXJjZVJlc3BvbnNlJik7CiAgICAgdmlydHVhbCB2b2lkIGRpZFJlY2VpdmVEYXRhKFJlc291 cmNlSGFuZGxlKiwgY29uc3QgY2hhciosIGludCwgaW50IGxlbmd0aFJlY2VpdmVkKTsKQEAgLTE1 Miw2ICsxNzYsNyBAQCBwcml2YXRlOgogICAgIFJlc291cmNlRXJyb3ImIG1fZXJyb3I7CiAgICAg UmVzb3VyY2VSZXNwb25zZSYgbV9yZXNwb25zZTsKICAgICBWZWN0b3I8Y2hhcj4mIG1fZGF0YTsK KyAgICBISU5URVJORVQgbV9pbnRlcm5ldEhhbmRsZTsKIH07CiAKIFdlYkNvcmVTeW5jaHJvbm91 c0xvYWRlcjo6V2ViQ29yZVN5bmNocm9ub3VzTG9hZGVyKFJlc291cmNlRXJyb3ImIGVycm9yLCBS ZXNvdXJjZVJlc3BvbnNlJiByZXNwb25zZSwgVmVjdG9yPGNoYXI+JiBkYXRhLCBjb25zdCBTdHJp bmcmIHVzZXJBZ2VudCkKQEAgLTE1OSw2ICsxODQsMTIgQEAgV2ViQ29yZVN5bmNocm9ub3VzTG9h ZGVyOjpXZWJDb3JlU3luY2hybwogICAgICwgbV9yZXNwb25zZShyZXNwb25zZSkKICAgICAsIG1f ZGF0YShkYXRhKQogeworICAgIG1faW50ZXJuZXRIYW5kbGUgPSBjcmVhdGVJbnRlcm5ldEhhbmRs ZSh1c2VyQWdlbnQsIGZhbHNlKTsKK30KKworV2ViQ29yZVN5bmNocm9ub3VzTG9hZGVyOjp+V2Vi Q29yZVN5bmNocm9ub3VzTG9hZGVyKCkKK3sKKyAgICBJbnRlcm5ldENsb3NlSGFuZGxlKG1faW50 ZXJuZXRIYW5kbGUpOwogfQogCiB2b2lkIFdlYkNvcmVTeW5jaHJvbm91c0xvYWRlcjo6ZGlkUmVj ZWl2ZVJlc3BvbnNlKFJlc291cmNlSGFuZGxlKiwgY29uc3QgUmVzb3VyY2VSZXNwb25zZSYgcmVz cG9uc2UpCg== 68245 2010-09-21 09:03:00 -0700 2010-09-22 00:37:30 -0700 Patch bug-46185b.patch text/plain 3423 paroga ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZWRiNGU5Ny4uZTQ1OTgyYyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMCBAQAorMjAxMC0wOS0yMSAgUGF0cmljayBHYW5z dGVyZXIgIDxwYXJvZ2FAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBBZGFtIFJv YmVuLgorCisgICAgICAgIFtXSU5dIEFkZCBpbnRlcm5ldEhhbmRsZSB0byBXZWJDb3JlU3luY2hy b25vdXNMb2FkZXIuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD00NjE4NQorCisgICAgICAgIEZvciBsb2FkaW5nIGNvbnRlbnQgdmlhIG5ldHdvcmsgdGhl IFdlYkNvcmVTeW5jaHJvbm91c0xvYWRlciBuZWVkcyBpdHMgb3duIChzeW5jaHJvbm91cykgaW50 ZXJuZXRIYW5kbGUuCisgICAgICAgIFRoaXMgYWxzbyBhZGRzIGFzeW5jaHJvbm91c0ludGVybmV0 SGFuZGxlKCkgdG8gY3JlYXRlIGEgc3RhdGljIGFzeW5jaHJvbm91cyBpbnRlcm5ldEhhbmRsZS4K KworICAgICAgICAqIHBsYXRmb3JtL25ldHdvcmsvd2luL1Jlc291cmNlSGFuZGxlV2luLmNwcDoK KyAgICAgICAgKFdlYkNvcmU6OmNyZWF0ZUludGVybmV0SGFuZGxlKToKKyAgICAgICAgKFdlYkNv cmU6OmFzeW5jaHJvbm91c0ludGVybmV0SGFuZGxlKToKKyAgICAgICAgKFdlYkNvcmU6OldlYkNv cmVTeW5jaHJvbm91c0xvYWRlcjo6aW50ZXJuZXRIYW5kbGUpOgorICAgICAgICAoV2ViQ29yZTo6 V2ViQ29yZVN5bmNocm9ub3VzTG9hZGVyOjpXZWJDb3JlU3luY2hyb25vdXNMb2FkZXIpOiBDcmVh dGUgc3luY2hyb25vdXMgaW50ZXJuZXRIYW5kbGUuCisgICAgICAgIChXZWJDb3JlOjpXZWJDb3Jl U3luY2hyb25vdXNMb2FkZXI6On5XZWJDb3JlU3luY2hyb25vdXNMb2FkZXIpOiBEZWxldGUgc3lu Y2hyb25vdXMgaW50ZXJuZXRIYW5kbGUuCisKIDIwMTAtMDktMjEgIFN0ZXZlIEJsb2NrICA8c3Rl dmVibG9ja0Bnb29nbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEplcmVteSBPcmxvdy4K ZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay93aW4vUmVzb3VyY2VIYW5kbGVX aW4uY3BwIGIvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3dpbi9SZXNvdXJjZUhhbmRsZVdpbi5j cHAKaW5kZXggNjdjNTRiYy4uOGYxMDJkZCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wbGF0Zm9ybS9u ZXR3b3JrL3dpbi9SZXNvdXJjZUhhbmRsZVdpbi5jcHAKKysrIGIvV2ViQ29yZS9wbGF0Zm9ybS9u ZXR3b3JrL3dpbi9SZXNvdXJjZUhhbmRsZVdpbi5jcHAKQEAgLTY1LDYgKzY1LDIzIEBAIHN0YXRp YyBjb25zdCBSZXNvdXJjZUhhbmRsZUV2ZW50SGFuZGxlciBtZXNzYWdlSGFuZGxlcnNbXSA9IHsK ICAgICAmUmVzb3VyY2VIYW5kbGU6Om9uUmVxdWVzdENvbXBsZXRlCiB9OwogCitzdGF0aWMgaW5s aW5lIEhJTlRFUk5FVCBjcmVhdGVJbnRlcm5ldEhhbmRsZShjb25zdCBTdHJpbmcmIHVzZXJBZ2Vu dCwgYm9vbCBhc3luY2hyb25vdXMpCit7CisgICAgU3RyaW5nIHVzZXJBZ2VudFN0cmluZyA9IHVz ZXJBZ2VudDsKKyAgICBISU5URVJORVQgaW50ZXJuZXRIYW5kbGUgPSBJbnRlcm5ldE9wZW5XKHVz ZXJBZ2VudFN0cmluZy5jaGFyYWN0ZXJzV2l0aE51bGxUZXJtaW5hdGlvbigpLCBJTlRFUk5FVF9P UEVOX1RZUEVfUFJFQ09ORklHLCAwLCAwLCBhc3luY2hyb25vdXMgPyBJTlRFUk5FVF9GTEFHX0FT WU5DIDogMCk7CisKKyAgICBpZiAoYXN5bmNocm9ub3VzKQorICAgICAgICBJbnRlcm5ldFNldFN0 YXR1c0NhbGxiYWNrKGludGVybmV0SGFuZGxlLCAmUmVzb3VyY2VIYW5kbGU6OmludGVybmV0U3Rh dHVzQ2FsbGJhY2spOworCisgICAgcmV0dXJuIGludGVybmV0SGFuZGxlOworfQorCitzdGF0aWMg SElOVEVSTkVUIGFzeW5jaHJvbm91c0ludGVybmV0SGFuZGxlKGNvbnN0IFN0cmluZyYgdXNlckFn ZW50KQoreworICAgIHN0YXRpYyBISU5URVJORVQgaW50ZXJuZXRIYW5kbGUgPSBjcmVhdGVJbnRl cm5ldEhhbmRsZSh1c2VyQWdlbnQsIHRydWUpOworICAgIHJldHVybiBpbnRlcm5ldEhhbmRsZTsK K30KKwogc3RhdGljIFN0cmluZyBxdWVyeUhUVFBIZWFkZXIoSElOVEVSTkVUIHJlcXVlc3RIYW5k bGUsIERXT1JEIGluZm9MZXZlbCkKIHsKICAgICBEV09SRCBidWZmZXJTaXplID0gMDsKQEAgLTE0 Miw2ICsxNTksOSBAQCBzdGF0aWMgdm9pZCBpbml0aWFsaXplT2ZmU2NyZWVuUmVzb3VyY2VIYW5k bGVXaW5kb3coKQogY2xhc3MgV2ViQ29yZVN5bmNocm9ub3VzTG9hZGVyIDogcHVibGljIFJlc291 cmNlSGFuZGxlQ2xpZW50LCBwdWJsaWMgTm9uY29weWFibGUgewogcHVibGljOgogICAgIFdlYkNv cmVTeW5jaHJvbm91c0xvYWRlcihSZXNvdXJjZUVycm9yJiwgUmVzb3VyY2VSZXNwb25zZSYsIFZl Y3RvcjxjaGFyPiYsIGNvbnN0IFN0cmluZyYgdXNlckFnZW50KTsKKyAgICB+V2ViQ29yZVN5bmNo cm9ub3VzTG9hZGVyKCk7CisKKyAgICBISU5URVJORVQgaW50ZXJuZXRIYW5kbGUoKSBjb25zdCB7 IHJldHVybiBtX2ludGVybmV0SGFuZGxlOyB9CiAKICAgICB2aXJ0dWFsIHZvaWQgZGlkUmVjZWl2 ZVJlc3BvbnNlKFJlc291cmNlSGFuZGxlKiwgY29uc3QgUmVzb3VyY2VSZXNwb25zZSYpOwogICAg IHZpcnR1YWwgdm9pZCBkaWRSZWNlaXZlRGF0YShSZXNvdXJjZUhhbmRsZSosIGNvbnN0IGNoYXIq LCBpbnQsIGludCBsZW5ndGhSZWNlaXZlZCk7CkBAIC0xNTIsMTMgKzE3MiwyMCBAQCBwcml2YXRl OgogICAgIFJlc291cmNlRXJyb3ImIG1fZXJyb3I7CiAgICAgUmVzb3VyY2VSZXNwb25zZSYgbV9y ZXNwb25zZTsKICAgICBWZWN0b3I8Y2hhcj4mIG1fZGF0YTsKKyAgICBISU5URVJORVQgbV9pbnRl cm5ldEhhbmRsZTsKIH07CiAKIFdlYkNvcmVTeW5jaHJvbm91c0xvYWRlcjo6V2ViQ29yZVN5bmNo cm9ub3VzTG9hZGVyKFJlc291cmNlRXJyb3ImIGVycm9yLCBSZXNvdXJjZVJlc3BvbnNlJiByZXNw b25zZSwgVmVjdG9yPGNoYXI+JiBkYXRhLCBjb25zdCBTdHJpbmcmIHVzZXJBZ2VudCkKICAgICA6 IG1fZXJyb3IoZXJyb3IpCiAgICAgLCBtX3Jlc3BvbnNlKHJlc3BvbnNlKQogICAgICwgbV9kYXRh KGRhdGEpCisgICAgLCBtX2ludGVybmV0SGFuZGxlKGNyZWF0ZUludGVybmV0SGFuZGxlKHVzZXJB Z2VudCwgZmFsc2UpKQoreworfQorCitXZWJDb3JlU3luY2hyb25vdXNMb2FkZXI6On5XZWJDb3Jl U3luY2hyb25vdXNMb2FkZXIoKQogeworICAgIEludGVybmV0Q2xvc2VIYW5kbGUobV9pbnRlcm5l dEhhbmRsZSk7CiB9CiAKIHZvaWQgV2ViQ29yZVN5bmNocm9ub3VzTG9hZGVyOjpkaWRSZWNlaXZl UmVzcG9uc2UoUmVzb3VyY2VIYW5kbGUqLCBjb25zdCBSZXNvdXJjZVJlc3BvbnNlJiByZXNwb25z ZSkK