46169 2010-09-21 01:12:40 -0700 media/video-controls-with-mutation-event-handler.html crashing 2010-09-23 01:39:05 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 pnormand darin alex atwilson commit-queue darin oldest_to_newest 282140 0 pnormand 2010-09-21 01:12:40 -0700 On Debug bots. Bisecting in progress. Program terminated with signal 11, Segmentation fault. #0 0x00007f49a351684f in WebCore::TreeShared<WebCore::ContainerNode>::ref (this=0x7f490953a178) at ../../WebCore/platform/TreeShared.h:63 63 ASSERT(!m_adoptionIsRequired); Thread 1 (Thread 13603): #0 0x00007f49a351684f in WebCore::TreeShared<WebCore::ContainerNode>::ref (this=0x7f490953a178) at ../../WebCore/platform/TreeShared.h:63 #1 0x00007f49a3706f70 in WebCore::Node::refEventTarget (this=0x7f490953a170) at ../../WebCore/dom/Node.h:690 #2 0x00007f49a37370ad in WebCore::EventTarget::ref (this=0x7f490953a170) at ../../WebCore/dom/EventTarget.h:94 #3 0x00007f49a3745e04 in WTF::refIfNotNull<WebCore::EventTarget> (ptr=0x7f490953a170) at ../../JavaScriptCore/wtf/PassRefPtr.h:52 #4 0x00007f49a377795d in WTF::RefPtr<WebCore::EventTarget>::RefPtr (this=0x7fffffffbb10, ptr=0x7f490953a170) at ../../JavaScriptCore/wtf/RefPtr.h:43 #5 0x00007f49a378cfbc in WebCore::Node::dispatchEvent (this=0x7f490953a170, prpEvent=...) at ../../WebCore/dom/Node.cpp:2567 #6 0x00007f49a378dc68 in WebCore::Node::dispatchSubtreeModifiedEvent (this=0x7f490953a170) at ../../WebCore/dom/Node.cpp:2728 #7 0x00007f49a3782d69 in WebCore::NamedNodeMap::addAttribute (this=0x7f490929c500, prpAttribute=...) at ../../WebCore/dom/NamedNodeMap.cpp:265 #8 0x00007f49a376bddf in WebCore::Element::setAttribute (this=0x7f490953a170, name=..., value=...) at ../../WebCore/dom/Element.cpp:609 #9 0x00007f49a376a3aa in WebCore::Element::setAttribute (this=0x7f490953a170, name=..., value=...) at ../../WebCore/dom/Element.cpp:180 #10 0x00007f49a38c2881 in WebCore::HTMLInputElement::setType (this=0x7f490953a170, t=...) at ../../WebCore/html/HTMLInputElement.cpp:852 #11 0x00007f49a3bce47c in WebCore::MediaControlInputElement::MediaControlInputElement (this=0x7f490953a170, mediaElement=0x7f4909215950, pseudo=WebCore::MEDIA_CONTROLS_REWIND_BUTTON, type=...) at ../../WebCore/rendering/MediaControlElements.cpp:353 #12 0x00007f49a3bd0bfb in WebCore::MediaControlRewindButtonElement::MediaControlRewindButtonElement (this=0x7f490953a170, element=0x7f4909215950) at ../../WebCore/rendering/MediaControlElements.cpp:606 #13 0x00007f49a3bcf5a4 in WebCore::MediaControlRewindButtonElement::create (mediaElement=0x7f4909215950) at ../../WebCore/rendering/MediaControlElements.cpp:612 #14 0x00007f49a3c74437 in WebCore::RenderMedia::createRewindButton (this=0x7f4909b75198) at ../../WebCore/rendering/RenderMedia.cpp:220 #15 0x00007f49a3c751fe in WebCore::RenderMedia::updateControls (this=0x7f4909b75198) at ../../WebCore/rendering/RenderMedia.cpp:346 #16 0x00007f49a3c74f2c in WebCore::RenderMedia::updateFromElement (this=0x7f4909b75198) at ../../WebCore/rendering/RenderMedia.cpp:308 #17 0x00007f49a3ceab96 in WebCore::RenderVideo::updateFromElement (this=0x7f4909b75198) at ../../WebCore/rendering/RenderVideo.cpp:222 #18 0x00007f49a38d4e57 in WebCore::HTMLMediaElement::attach (this=0x7f4909215950) at ../../WebCore/html/HTMLMediaElement.cpp:354 #19 0x00007f49a38f5dc7 in WebCore::HTMLVideoElement::attach (this=0x7f4909215950) at ../../WebCore/html/HTMLVideoElement.cpp:73 #20 0x00007f49a371444d in WebCore::ContainerNode::attach (this=0x7f490946e7d0) at ../../WebCore/dom/ContainerNode.cpp:700 #21 0x00007f49a376cd31 in WebCore::Element::attach (this=0x7f490946e7d0) at ../../WebCore/dom/Element.cpp:836 #22 0x00007f49a376d487 in WebCore::Element::recalcStyle (this=0x7f490946e7d0, change=WebCore::Node::NoChange) at ../../WebCore/dom/Element.cpp:926 #23 0x00007f49a376dae9 in WebCore::Element::recalcStyle (this=0x7f4909431bd0, change=WebCore::Node::NoChange) at ../../WebCore/dom/Element.cpp:989 #24 0x00007f49a376dae9 in WebCore::Element::recalcStyle (this=0x7f49094902f0, change=WebCore::Node::NoChange) at ../../WebCore/dom/Element.cpp:989 #25 0x00007f49a372aeb0 in WebCore::Document::recalcStyle (this=0x7f4909aba0e0, change=WebCore::Node::NoChange) at ../../WebCore/dom/Document.cpp:1492 #26 0x00007f49a372b0ae in WebCore::Document::updateStyleIfNeeded (this=0x7f4909aba0e0) at ../../WebCore/dom/Document.cpp:1536 #27 0x00007f49a372cbed in WebCore::Document::implicitClose (this=0x7f4909aba0e0) at ../../WebCore/dom/Document.cpp:2047 #28 0x00007f49a3a03583 in WebCore::FrameLoader::checkCallImplicitClose (this=0x506250) at ../../WebCore/loader/FrameLoader.cpp:900 #29 0x00007f49a3a03356 in WebCore::FrameLoader::checkCompleted (this=0x506250) at ../../WebCore/loader/FrameLoader.cpp:848 #30 0x00007f49a3a030d5 in WebCore::FrameLoader::finishedParsing (this=0x506250) at ../../WebCore/loader/FrameLoader.cpp:782 #31 0x00007f49a3734c5e in WebCore::Document::finishedParsing (this=0x7f4909aba0e0) at ../../WebCore/dom/Document.cpp:4121 #32 0x00007f49a392a40d in WebCore::HTMLTreeBuilder::finished (this=0x7f49091d90c0) at ../../WebCore/html/parser/HTMLTreeBuilder.cpp:2755 #33 0x00007f49a39032d8 in WebCore::HTMLDocumentParser::end (this=0x7f4909c5eff0) at ../../WebCore/html/parser/HTMLDocumentParser.cpp:342 #34 0x00007f49a39033cb in WebCore::HTMLDocumentParser::attemptToRunDeferredScriptsAndEnd (this=0x7f4909c5eff0) at ../../WebCore/html/parser/HTMLDocumentParser.cpp:351 #35 0x00007f49a3902868 in WebCore::HTMLDocumentParser::prepareToStopParsing (this=0x7f4909c5eff0) at ../../WebCore/html/parser/HTMLDocumentParser.cpp:153 #36 0x00007f49a3903410 in WebCore::HTMLDocumentParser::attemptToEnd (this=0x7f4909c5eff0) at ../../WebCore/html/parser/HTMLDocumentParser.cpp:363 #37 0x00007f49a39034c9 in WebCore::HTMLDocumentParser::finish (this=0x7f4909c5eff0) at ../../WebCore/html/parser/HTMLDocumentParser.cpp:391 #38 0x00007f49a372d036 in WebCore::Document::finishParsing (this=0x7f4909aba0e0) at ../../WebCore/dom/Document.cpp:2164 #39 0x00007f49a39fd0b7 in WebCore::DocumentWriter::endIfNotLoadingMainResource (this=0x5063d0) at ../../WebCore/loader/DocumentWriter.cpp:221 #40 0x00007f49a39fd00d in WebCore::DocumentWriter::end (this=0x5063d0) at ../../WebCore/loader/DocumentWriter.cpp:206 #41 0x00007f49a39f22f1 in WebCore::DocumentLoader::finishedLoading (this=0x7f49092573f0) at ../../WebCore/loader/DocumentLoader.cpp:271 #42 0x00007f49a3a096ad in WebCore::FrameLoader::finishedLoading (this=0x506250) at ../../WebCore/loader/FrameLoader.cpp:2156 #43 0x00007f49a3a434bd in WebCore::MainResourceLoader::didFinishLoading (this=0x7f49093694a0, finishTime=0) at ../../WebCore/loader/MainResourceLoader.cpp:441 #44 0x00007f49a3a4eba7 in WebCore::ResourceLoader::didFinishLoading (this=0x7f49093694a0, finishTime=0) at ../../WebCore/loader/ResourceLoader.cpp:446 #45 0x00007f49a3f00bb8 in WebCore::closeCallback (source=0x1348e40, res=0x1348de0) at ../../WebCore/platform/network/soup/ResourceHandleSoup.cpp:720 #46 0x00007f499f9cf620 in async_ready_close_callback_wrapper (source_object=0x1348e40, res=0x1348de0, user_data=0x0) at /tmp/buildd/glib2.0-2.24.1/gio/ginputstream.c:485 #47 0x00007f499f9ddac8 in complete_in_idle_cb_for_thread (_data=<value optimized out>) at /tmp/buildd/glib2.0-2.24.1/gio/gsimpleasyncresult.c:653 #48 0x00007f499ee966c2 in g_main_dispatch (context=0x46aa00) at /tmp/buildd/glib2.0-2.24.1/glib/gmain.c:1960 #49 IA__g_main_context_dispatch (context=0x46aa00) at /tmp/buildd/glib2.0-2.24.1/glib/gmain.c:2513 #50 0x00007f499ee9a538 in g_main_context_iterate (context=0x46aa00, block=<value optimized out>, dispatch=<value optimized out>, self=<value optimized out>) at /tmp/buildd/glib2.0-2.24.1/glib/gmain.c:2591 #51 0x00007f499ee9aa45 in IA__g_main_loop_run (loop=0x7f49098e7030) at /tmp/buildd/glib2.0-2.24.1/glib/gmain.c:2799 #52 0x00007f49a0d3a657 in gtk_main () from /usr/lib/libgtk-x11-2.0.so.0 #53 0x00000000004190fe in runTest (testPathOrURL=...) at ../../WebKitTools/DumpRenderTree/gtk/DumpRenderTree.cpp:573 #54 0x00000000004187ff in runTestingServerLoop () at ../../WebKitTools/DumpRenderTree/gtk/DumpRenderTree.cpp:383 #55 0x000000000041a6ae in main (argc=2, argv=0x7fffffffd218) at ../../WebKitTools/DumpRenderTree/gtk/DumpRenderTree.cpp:1013 282145 1 alex 2010-09-21 01:30:52 -0700 Test skipped http://trac.webkit.org/changeset/67932 282150 2 pnormand 2010-09-21 02:03:18 -0700 Kenneth, I did a git bisection to find out the commit that introduced this regression and it is http://trac.webkit.org/changeset/67903 ... Could you please have a look? Meanwhile I'll investigate too ;) 282151 3 pnormand 2010-09-21 02:04:47 -0700 Sorry, I meant asking you Darin ^^ 282352 4 darin 2010-09-21 09:29:55 -0700 The call to setType in the MediaControlInputElement constructor is new, and needs to be moved. There is a simple fix by putting it into the create function. 282361 5 68250 darin 2010-09-21 09:43:12 -0700 Created attachment 68250 Patch 282785 6 pnormand 2010-09-21 23:41:22 -0700 Thanks! I confirm this patch fixes the crashing test on gtk. Can you please unskip the test when landing? 282812 7 pnormand 2010-09-22 00:37:39 -0700 *** Bug 46163 has been marked as a duplicate of this bug. *** 282814 8 68250 cfleizach 2010-09-22 00:40:50 -0700 Comment on attachment 68250 Patch looks ok r=me 283547 9 68250 abarth 2010-09-23 01:16:30 -0700 Comment on attachment 68250 Patch I can haz test not crash? 283551 10 68250 commit-queue 2010-09-23 01:39:01 -0700 Comment on attachment 68250 Patch Clearing flags on attachment: 68250 Committed r68126: <http://trac.webkit.org/changeset/68126> 283552 11 commit-queue 2010-09-23 01:39:05 -0700 All reviewed patches have been landed. Closing bug. 68250 2010-09-21 09:43:12 -0700 2010-09-23 01:39:00 -0700 Patch bug-46169-20100921094310.patch text/plain 11740 darin SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2Nzk2MCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMzUgQEAKKzIwMTAtMDktMjEgIERhcmluIEFkbGVyICA8ZGFyaW5AYXBwbGUuY29t PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIG1lZGlh L3ZpZGVvLWNvbnRyb2xzLXdpdGgtbXV0YXRpb24tZXZlbnQtaGFuZGxlci5odG1sIGNyYXNoaW5n CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NjE2OQor CisgICAgICAgICogcmVuZGVyaW5nL01lZGlhQ29udHJvbEVsZW1lbnRzLmNwcDoKKyAgICAgICAg KFdlYkNvcmU6Ok1lZGlhQ29udHJvbElucHV0RWxlbWVudDo6TWVkaWFDb250cm9sSW5wdXRFbGVt ZW50KTogRG9uJ3QgdGFrZSBhIHR5cGUgYXJndW1lbnQuCisgICAgICAgIFdlIGNhbid0IHNldCB0 aGUgdHlwZSB1bnRpbCBhZnRlciB0aGUgZWxlbWVudCBpcyBjcmVhdGVkIGJlYWN1c2Ugb2YgcmVm ZXJlbmNlIGNvdW50aW5nIHJ1bGVzLgorICAgICAgICAoV2ViQ29yZTo6TWVkaWFDb250cm9sTXV0 ZUJ1dHRvbkVsZW1lbnQ6Ok1lZGlhQ29udHJvbE11dGVCdXR0b25FbGVtZW50KTogRG9uJ3QgcGFz cyB0aGUgdHlwZS4KKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlhQ29udHJvbE11dGVCdXR0b25FbGVt ZW50OjpjcmVhdGUpOiBTZXQgdGhlIHR5cGUuCisgICAgICAgIChXZWJDb3JlOjpNZWRpYUNvbnRy b2xQbGF5QnV0dG9uRWxlbWVudDo6TWVkaWFDb250cm9sUGxheUJ1dHRvbkVsZW1lbnQpOiBNb3Jl IG9mIHRoZSBzYW1lLgorICAgICAgICAoV2ViQ29yZTo6TWVkaWFDb250cm9sUGxheUJ1dHRvbkVs ZW1lbnQ6OmNyZWF0ZSk6IERpdHRvLgorICAgICAgICAoV2ViQ29yZTo6TWVkaWFDb250cm9sU2Vl a0J1dHRvbkVsZW1lbnQ6Ok1lZGlhQ29udHJvbFNlZWtCdXR0b25FbGVtZW50KTogRGl0dG8uCisg ICAgICAgIChXZWJDb3JlOjpNZWRpYUNvbnRyb2xTZWVrQnV0dG9uRWxlbWVudDo6Y3JlYXRlKTog RGl0dG8uCisgICAgICAgIChXZWJDb3JlOjpNZWRpYUNvbnRyb2xSZXdpbmRCdXR0b25FbGVtZW50 OjpNZWRpYUNvbnRyb2xSZXdpbmRCdXR0b25FbGVtZW50KTogRGl0dG8uCisgICAgICAgIChXZWJD b3JlOjpNZWRpYUNvbnRyb2xSZXdpbmRCdXR0b25FbGVtZW50OjpjcmVhdGUpOiBEaXR0by4KKyAg ICAgICAgKFdlYkNvcmU6Ok1lZGlhQ29udHJvbFJldHVyblRvUmVhbHRpbWVCdXR0b25FbGVtZW50 OjpNZWRpYUNvbnRyb2xSZXR1cm5Ub1JlYWx0aW1lQnV0dG9uRWxlbWVudCk6IERpdHRvLgorICAg ICAgICAoV2ViQ29yZTo6TWVkaWFDb250cm9sUmV0dXJuVG9SZWFsdGltZUJ1dHRvbkVsZW1lbnQ6 OmNyZWF0ZSk6IERpdHRvLgorICAgICAgICAoV2ViQ29yZTo6TWVkaWFDb250cm9sVG9nZ2xlQ2xv c2VkQ2FwdGlvbnNCdXR0b25FbGVtZW50OjpNZWRpYUNvbnRyb2xUb2dnbGVDbG9zZWRDYXB0aW9u c0J1dHRvbkVsZW1lbnQpOiBEaXR0by4KKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlhQ29udHJvbFRv Z2dsZUNsb3NlZENhcHRpb25zQnV0dG9uRWxlbWVudDo6Y3JlYXRlKTogRGl0dG8uCisgICAgICAg IChXZWJDb3JlOjpNZWRpYUNvbnRyb2xUaW1lbGluZUVsZW1lbnQ6Ok1lZGlhQ29udHJvbFRpbWVs aW5lRWxlbWVudCk6IERpdHRvLgorICAgICAgICAoV2ViQ29yZTo6TWVkaWFDb250cm9sVGltZWxp bmVFbGVtZW50OjpjcmVhdGUpOiBEaXR0by4KKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlhQ29udHJv bFZvbHVtZVNsaWRlckVsZW1lbnQ6Ok1lZGlhQ29udHJvbFZvbHVtZVNsaWRlckVsZW1lbnQpOiBE aXR0by4KKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlhQ29udHJvbFZvbHVtZVNsaWRlckVsZW1lbnQ6 OmNyZWF0ZSk6IERpdHRvLgorICAgICAgICAoV2ViQ29yZTo6TWVkaWFDb250cm9sRnVsbHNjcmVl bkJ1dHRvbkVsZW1lbnQ6Ok1lZGlhQ29udHJvbEZ1bGxzY3JlZW5CdXR0b25FbGVtZW50KTogRGl0 dG8uCisgICAgICAgIChXZWJDb3JlOjpNZWRpYUNvbnRyb2xGdWxsc2NyZWVuQnV0dG9uRWxlbWVu dDo6Y3JlYXRlKTogRGl0dG8uCisKKyAgICAgICAgKiByZW5kZXJpbmcvTWVkaWFDb250cm9sRWxl bWVudHMuaDogUmVtb3ZlZCB0aGUgdHlwZSBhcmd1bWVudCBmcm9tIHRoZSBNZWRpYUNvbnRyb2xJ bnB1dEVsZW1lbnQKKyAgICAgICAgY29uc3RydWN0b3IuCisKIDIwMTAtMDktMjEgIERhdmlkIEh5 YXR0ICA8aHlhdHRAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhbiBCZXJuc3Rl aW4uCkluZGV4OiBXZWJDb3JlL3JlbmRlcmluZy9NZWRpYUNvbnRyb2xFbGVtZW50cy5jcHAKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gV2ViQ29yZS9yZW5kZXJpbmcvTWVkaWFDb250cm9sRWxlbWVudHMuY3BwCShy ZXZpc2lvbiA2Nzk1OSkKKysrIFdlYkNvcmUvcmVuZGVyaW5nL01lZGlhQ29udHJvbEVsZW1lbnRz LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzQ1LDEyICszNDUsMTEgQEAgYm9vbCBNZWRpYUNvbnRy b2xTdGF0dXNEaXNwbGF5RWxlbWVudDo6cgogCiAvLyAtLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tCiAgICAgCi1NZWRpYUNvbnRyb2xJbnB1dEVsZW1lbnQ6Ok1lZGlhQ29udHJvbElucHV0RWxl bWVudChIVE1MTWVkaWFFbGVtZW50KiBtZWRpYUVsZW1lbnQsIFBzZXVkb0lkIHBzZXVkbywgY29u c3QgU3RyaW5nJiB0eXBlKQorTWVkaWFDb250cm9sSW5wdXRFbGVtZW50OjpNZWRpYUNvbnRyb2xJ bnB1dEVsZW1lbnQoSFRNTE1lZGlhRWxlbWVudCogbWVkaWFFbGVtZW50LCBQc2V1ZG9JZCBwc2V1 ZG8pCiAgICAgOiBIVE1MSW5wdXRFbGVtZW50KGlucHV0VGFnLCBtZWRpYUVsZW1lbnQtPmRvY3Vt ZW50KCkpCiAgICAgLCBtX21lZGlhRWxlbWVudChtZWRpYUVsZW1lbnQpCiAgICAgLCBtX3BzZXVk b1N0eWxlSWQocHNldWRvKQogewotICAgIHNldFR5cGUodHlwZSk7CiAgICAgc2V0SW5Eb2N1bWVu dCgpOwogCiAgICAgc3dpdGNoIChwc2V1ZG8pIHsKQEAgLTQ4NCwxMyArNDgzLDE1IEBAIHZvaWQg TWVkaWFDb250cm9sSW5wdXRFbGVtZW50OjpzZXREaXNwbGEKIC8vIC0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0KIAogaW5saW5lIE1lZGlhQ29udHJvbE11dGVCdXR0b25FbGVtZW50OjpNZWRp YUNvbnRyb2xNdXRlQnV0dG9uRWxlbWVudChIVE1MTWVkaWFFbGVtZW50KiBtZWRpYUVsZW1lbnQs IEJ1dHRvbkxvY2F0aW9uIGxvY2F0aW9uKQotICAgIDogTWVkaWFDb250cm9sSW5wdXRFbGVtZW50 KG1lZGlhRWxlbWVudCwgbG9jYXRpb24gPT0gQ29udHJvbGxlciA/IE1FRElBX0NPTlRST0xTX01V VEVfQlVUVE9OIDogTUVESUFfQ09OVFJPTFNfVk9MVU1FX1NMSURFUl9NVVRFX0JVVFRPTiwgImJ1 dHRvbiIpCisgICAgOiBNZWRpYUNvbnRyb2xJbnB1dEVsZW1lbnQobWVkaWFFbGVtZW50LCBsb2Nh dGlvbiA9PSBDb250cm9sbGVyID8gTUVESUFfQ09OVFJPTFNfTVVURV9CVVRUT04gOiBNRURJQV9D T05UUk9MU19WT0xVTUVfU0xJREVSX01VVEVfQlVUVE9OKQogewogfQogCiBQYXNzUmVmUHRyPE1l ZGlhQ29udHJvbE11dGVCdXR0b25FbGVtZW50PiBNZWRpYUNvbnRyb2xNdXRlQnV0dG9uRWxlbWVu dDo6Y3JlYXRlKEhUTUxNZWRpYUVsZW1lbnQqIG1lZGlhRWxlbWVudCwgQnV0dG9uTG9jYXRpb24g bG9jYXRpb24pCiB7Ci0gICAgcmV0dXJuIGFkb3B0UmVmKG5ldyBNZWRpYUNvbnRyb2xNdXRlQnV0 dG9uRWxlbWVudChtZWRpYUVsZW1lbnQsIGxvY2F0aW9uKSk7CisgICAgUmVmUHRyPE1lZGlhQ29u dHJvbE11dGVCdXR0b25FbGVtZW50PiBidXR0b24gPSBhZG9wdFJlZihuZXcgTWVkaWFDb250cm9s TXV0ZUJ1dHRvbkVsZW1lbnQobWVkaWFFbGVtZW50LCBsb2NhdGlvbikpOworICAgIGJ1dHRvbi0+ c2V0VHlwZSgiYnV0dG9uIik7CisgICAgcmV0dXJuIGJ1dHRvbi5yZWxlYXNlKCk7CiB9CiAKIHZv aWQgTWVkaWFDb250cm9sTXV0ZUJ1dHRvbkVsZW1lbnQ6OmRlZmF1bHRFdmVudEhhbmRsZXIoRXZl bnQqIGV2ZW50KQpAQCAtNTEwLDEzICs1MTEsMTUgQEAgdm9pZCBNZWRpYUNvbnRyb2xNdXRlQnV0 dG9uRWxlbWVudDo6dXBkYQogLy8gLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQogCiBpbmxp bmUgTWVkaWFDb250cm9sUGxheUJ1dHRvbkVsZW1lbnQ6Ok1lZGlhQ29udHJvbFBsYXlCdXR0b25F bGVtZW50KEhUTUxNZWRpYUVsZW1lbnQqIG1lZGlhRWxlbWVudCkKLSAgICA6IE1lZGlhQ29udHJv bElucHV0RWxlbWVudChtZWRpYUVsZW1lbnQsIE1FRElBX0NPTlRST0xTX1BMQVlfQlVUVE9OLCAi YnV0dG9uIikKKyAgICA6IE1lZGlhQ29udHJvbElucHV0RWxlbWVudChtZWRpYUVsZW1lbnQsIE1F RElBX0NPTlRST0xTX1BMQVlfQlVUVE9OKQogewogfQogCiBQYXNzUmVmUHRyPE1lZGlhQ29udHJv bFBsYXlCdXR0b25FbGVtZW50PiBNZWRpYUNvbnRyb2xQbGF5QnV0dG9uRWxlbWVudDo6Y3JlYXRl KEhUTUxNZWRpYUVsZW1lbnQqIG1lZGlhRWxlbWVudCkKIHsKLSAgICByZXR1cm4gYWRvcHRSZWYo bmV3IE1lZGlhQ29udHJvbFBsYXlCdXR0b25FbGVtZW50KG1lZGlhRWxlbWVudCkpOworICAgIFJl ZlB0cjxNZWRpYUNvbnRyb2xQbGF5QnV0dG9uRWxlbWVudD4gYnV0dG9uID0gYWRvcHRSZWYobmV3 IE1lZGlhQ29udHJvbFBsYXlCdXR0b25FbGVtZW50KG1lZGlhRWxlbWVudCkpOworICAgIGJ1dHRv bi0+c2V0VHlwZSgiYnV0dG9uIik7CisgICAgcmV0dXJuIGJ1dHRvbi5yZWxlYXNlKCk7CiB9CiAK IHZvaWQgTWVkaWFDb250cm9sUGxheUJ1dHRvbkVsZW1lbnQ6OmRlZmF1bHRFdmVudEhhbmRsZXIo RXZlbnQqIGV2ZW50KQpAQCAtNTM2LDcgKzUzOSw3IEBAIHZvaWQgTWVkaWFDb250cm9sUGxheUJ1 dHRvbkVsZW1lbnQ6OnVwZGEKIC8vIC0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KIAogaW5s aW5lIE1lZGlhQ29udHJvbFNlZWtCdXR0b25FbGVtZW50OjpNZWRpYUNvbnRyb2xTZWVrQnV0dG9u RWxlbWVudChIVE1MTWVkaWFFbGVtZW50KiBtZWRpYUVsZW1lbnQsIFBzZXVkb0lkIHBzZXVkb0lk KQotICAgIDogTWVkaWFDb250cm9sSW5wdXRFbGVtZW50KG1lZGlhRWxlbWVudCwgcHNldWRvSWQs ICJidXR0b24iKQorICAgIDogTWVkaWFDb250cm9sSW5wdXRFbGVtZW50KG1lZGlhRWxlbWVudCwg cHNldWRvSWQpCiAgICAgLCBtX3NlZWtpbmcoZmFsc2UpCiAgICAgLCBtX2NhcHR1cmluZyhmYWxz ZSkKICAgICAsIG1fc2Vla1RpbWVyKHRoaXMsICZNZWRpYUNvbnRyb2xTZWVrQnV0dG9uRWxlbWVu dDo6c2Vla1RpbWVyRmlyZWQpCkBAIC01NDUsNyArNTQ4LDkgQEAgaW5saW5lIE1lZGlhQ29udHJv bFNlZWtCdXR0b25FbGVtZW50OjpNZQogCiBQYXNzUmVmUHRyPE1lZGlhQ29udHJvbFNlZWtCdXR0 b25FbGVtZW50PiBNZWRpYUNvbnRyb2xTZWVrQnV0dG9uRWxlbWVudDo6Y3JlYXRlKEhUTUxNZWRp YUVsZW1lbnQqIG1lZGlhRWxlbWVudCwgUHNldWRvSWQgcHNldWRvU3R5bGVJZCkKIHsKLSAgICBy ZXR1cm4gYWRvcHRSZWYobmV3IE1lZGlhQ29udHJvbFNlZWtCdXR0b25FbGVtZW50KG1lZGlhRWxl bWVudCwgcHNldWRvU3R5bGVJZCkpOworICAgIFJlZlB0cjxNZWRpYUNvbnRyb2xTZWVrQnV0dG9u RWxlbWVudD4gYnV0dG9uID0gYWRvcHRSZWYobmV3IE1lZGlhQ29udHJvbFNlZWtCdXR0b25FbGVt ZW50KG1lZGlhRWxlbWVudCwgcHNldWRvU3R5bGVJZCkpOworICAgIGJ1dHRvbi0+c2V0VHlwZSgi YnV0dG9uIik7CisgICAgcmV0dXJuIGJ1dHRvbi5yZWxlYXNlKCk7CiB9CiAKIGlubGluZSBib29s IE1lZGlhQ29udHJvbFNlZWtCdXR0b25FbGVtZW50Ojppc0ZvcndhcmRCdXR0b24oKSBjb25zdApA QCAtNjAzLDEzICs2MDgsMTUgQEAgdm9pZCBNZWRpYUNvbnRyb2xTZWVrQnV0dG9uRWxlbWVudDo6 ZGV0YQogLy8gLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQogCiBpbmxpbmUgTWVkaWFDb250 cm9sUmV3aW5kQnV0dG9uRWxlbWVudDo6TWVkaWFDb250cm9sUmV3aW5kQnV0dG9uRWxlbWVudChI VE1MTWVkaWFFbGVtZW50KiBlbGVtZW50KQotICAgIDogTWVkaWFDb250cm9sSW5wdXRFbGVtZW50 KGVsZW1lbnQsIE1FRElBX0NPTlRST0xTX1JFV0lORF9CVVRUT04sICJidXR0b24iKQorICAgIDog TWVkaWFDb250cm9sSW5wdXRFbGVtZW50KGVsZW1lbnQsIE1FRElBX0NPTlRST0xTX1JFV0lORF9C VVRUT04pCiB7CiB9CiAKIFBhc3NSZWZQdHI8TWVkaWFDb250cm9sUmV3aW5kQnV0dG9uRWxlbWVu dD4gTWVkaWFDb250cm9sUmV3aW5kQnV0dG9uRWxlbWVudDo6Y3JlYXRlKEhUTUxNZWRpYUVsZW1l bnQqIG1lZGlhRWxlbWVudCkKIHsKLSAgICByZXR1cm4gYWRvcHRSZWYobmV3IE1lZGlhQ29udHJv bFJld2luZEJ1dHRvbkVsZW1lbnQobWVkaWFFbGVtZW50KSk7CisgICAgUmVmUHRyPE1lZGlhQ29u dHJvbFJld2luZEJ1dHRvbkVsZW1lbnQ+IGJ1dHRvbiA9IGFkb3B0UmVmKG5ldyBNZWRpYUNvbnRy b2xSZXdpbmRCdXR0b25FbGVtZW50KG1lZGlhRWxlbWVudCkpOworICAgIGJ1dHRvbi0+c2V0VHlw ZSgiYnV0dG9uIik7CisgICAgcmV0dXJuIGJ1dHRvbi5yZWxlYXNlKCk7CiB9CiAKIHZvaWQgTWVk aWFDb250cm9sUmV3aW5kQnV0dG9uRWxlbWVudDo6ZGVmYXVsdEV2ZW50SGFuZGxlcihFdmVudCog ZXZlbnQpCkBAIC02MjEsMTcgKzYyOCwxOCBAQCB2b2lkIE1lZGlhQ29udHJvbFJld2luZEJ1dHRv bkVsZW1lbnQ6OmRlCiAgICAgSFRNTElucHV0RWxlbWVudDo6ZGVmYXVsdEV2ZW50SGFuZGxlcihl dmVudCk7CiB9CiAKLQogLy8gLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQogCiBpbmxpbmUg TWVkaWFDb250cm9sUmV0dXJuVG9SZWFsdGltZUJ1dHRvbkVsZW1lbnQ6Ok1lZGlhQ29udHJvbFJl dHVyblRvUmVhbHRpbWVCdXR0b25FbGVtZW50KEhUTUxNZWRpYUVsZW1lbnQqIG1lZGlhRWxlbWVu dCkKLSAgICA6IE1lZGlhQ29udHJvbElucHV0RWxlbWVudChtZWRpYUVsZW1lbnQsIE1FRElBX0NP TlRST0xTX1JFVFVSTl9UT19SRUFMVElNRV9CVVRUT04sICJidXR0b24iKQorICAgIDogTWVkaWFD b250cm9sSW5wdXRFbGVtZW50KG1lZGlhRWxlbWVudCwgTUVESUFfQ09OVFJPTFNfUkVUVVJOX1RP X1JFQUxUSU1FX0JVVFRPTikKIHsKIH0KIAogUGFzc1JlZlB0cjxNZWRpYUNvbnRyb2xSZXR1cm5U b1JlYWx0aW1lQnV0dG9uRWxlbWVudD4gTWVkaWFDb250cm9sUmV0dXJuVG9SZWFsdGltZUJ1dHRv bkVsZW1lbnQ6OmNyZWF0ZShIVE1MTWVkaWFFbGVtZW50KiBtZWRpYUVsZW1lbnQpCiB7Ci0gICAg cmV0dXJuIGFkb3B0UmVmKG5ldyBNZWRpYUNvbnRyb2xSZXR1cm5Ub1JlYWx0aW1lQnV0dG9uRWxl bWVudChtZWRpYUVsZW1lbnQpKTsKKyAgICBSZWZQdHI8TWVkaWFDb250cm9sUmV0dXJuVG9SZWFs dGltZUJ1dHRvbkVsZW1lbnQ+IGJ1dHRvbiA9IGFkb3B0UmVmKG5ldyBNZWRpYUNvbnRyb2xSZXR1 cm5Ub1JlYWx0aW1lQnV0dG9uRWxlbWVudChtZWRpYUVsZW1lbnQpKTsKKyAgICBidXR0b24tPnNl dFR5cGUoImJ1dHRvbiIpOworICAgIHJldHVybiBidXR0b24ucmVsZWFzZSgpOwogfQogCiB2b2lk IE1lZGlhQ29udHJvbFJldHVyblRvUmVhbHRpbWVCdXR0b25FbGVtZW50OjpkZWZhdWx0RXZlbnRI YW5kbGVyKEV2ZW50KiBldmVudCkKQEAgLTY0NywxMyArNjU1LDE1IEBAIHZvaWQgTWVkaWFDb250 cm9sUmV0dXJuVG9SZWFsdGltZUJ1dHRvbkUKIC8vIC0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0KIAogaW5saW5lIE1lZGlhQ29udHJvbFRvZ2dsZUNsb3NlZENhcHRpb25zQnV0dG9uRWxlbWVu dDo6TWVkaWFDb250cm9sVG9nZ2xlQ2xvc2VkQ2FwdGlvbnNCdXR0b25FbGVtZW50KEhUTUxNZWRp YUVsZW1lbnQqIG1lZGlhRWxlbWVudCkKLSAgICA6IE1lZGlhQ29udHJvbElucHV0RWxlbWVudCht ZWRpYUVsZW1lbnQsIE1FRElBX0NPTlRST0xTX1RPR0dMRV9DTE9TRURfQ0FQVElPTlNfQlVUVE9O LCAiYnV0dG9uIikKKyAgICA6IE1lZGlhQ29udHJvbElucHV0RWxlbWVudChtZWRpYUVsZW1lbnQs IE1FRElBX0NPTlRST0xTX1RPR0dMRV9DTE9TRURfQ0FQVElPTlNfQlVUVE9OKQogewogfQogCiBQ YXNzUmVmUHRyPE1lZGlhQ29udHJvbFRvZ2dsZUNsb3NlZENhcHRpb25zQnV0dG9uRWxlbWVudD4g TWVkaWFDb250cm9sVG9nZ2xlQ2xvc2VkQ2FwdGlvbnNCdXR0b25FbGVtZW50OjpjcmVhdGUoSFRN TE1lZGlhRWxlbWVudCogbWVkaWFFbGVtZW50KQogewotICAgIHJldHVybiBhZG9wdFJlZihuZXcg TWVkaWFDb250cm9sVG9nZ2xlQ2xvc2VkQ2FwdGlvbnNCdXR0b25FbGVtZW50KG1lZGlhRWxlbWVu dCkpOworICAgIFJlZlB0cjxNZWRpYUNvbnRyb2xUb2dnbGVDbG9zZWRDYXB0aW9uc0J1dHRvbkVs ZW1lbnQ+IGJ1dHRvbiA9IGFkb3B0UmVmKG5ldyBNZWRpYUNvbnRyb2xUb2dnbGVDbG9zZWRDYXB0 aW9uc0J1dHRvbkVsZW1lbnQobWVkaWFFbGVtZW50KSk7CisgICAgYnV0dG9uLT5zZXRUeXBlKCJi dXR0b24iKTsKKyAgICByZXR1cm4gYnV0dG9uLnJlbGVhc2UoKTsKIH0KIAogdm9pZCBNZWRpYUNv bnRyb2xUb2dnbGVDbG9zZWRDYXB0aW9uc0J1dHRvbkVsZW1lbnQ6OmRlZmF1bHRFdmVudEhhbmRs ZXIoRXZlbnQqIGV2ZW50KQpAQCAtNjc0LDEzICs2ODQsMTUgQEAgdm9pZCBNZWRpYUNvbnRyb2xU b2dnbGVDbG9zZWRDYXB0aW9uc0J1dAogLy8gLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQog CiBNZWRpYUNvbnRyb2xUaW1lbGluZUVsZW1lbnQ6Ok1lZGlhQ29udHJvbFRpbWVsaW5lRWxlbWVu dChIVE1MTWVkaWFFbGVtZW50KiBtZWRpYUVsZW1lbnQpCi0gICAgOiBNZWRpYUNvbnRyb2xJbnB1 dEVsZW1lbnQobWVkaWFFbGVtZW50LCBNRURJQV9DT05UUk9MU19USU1FTElORSwgInJhbmdlIikK KyAgICA6IE1lZGlhQ29udHJvbElucHV0RWxlbWVudChtZWRpYUVsZW1lbnQsIE1FRElBX0NPTlRS T0xTX1RJTUVMSU5FKQogewogfQogCiBQYXNzUmVmUHRyPE1lZGlhQ29udHJvbFRpbWVsaW5lRWxl bWVudD4gTWVkaWFDb250cm9sVGltZWxpbmVFbGVtZW50OjpjcmVhdGUoSFRNTE1lZGlhRWxlbWVu dCogbWVkaWFFbGVtZW50KQogewotICAgIHJldHVybiBhZG9wdFJlZihuZXcgTWVkaWFDb250cm9s VGltZWxpbmVFbGVtZW50KG1lZGlhRWxlbWVudCkpOworICAgIFJlZlB0cjxNZWRpYUNvbnRyb2xU aW1lbGluZUVsZW1lbnQ+IHRpbWVsaW5lID0gYWRvcHRSZWYobmV3IE1lZGlhQ29udHJvbFRpbWVs aW5lRWxlbWVudChtZWRpYUVsZW1lbnQpKTsKKyAgICB0aW1lbGluZS0+c2V0VHlwZSgicmFuZ2Ui KTsKKyAgICByZXR1cm4gdGltZWxpbmUucmVsZWFzZSgpOwogfQogCiB2b2lkIE1lZGlhQ29udHJv bFRpbWVsaW5lRWxlbWVudDo6ZGVmYXVsdEV2ZW50SGFuZGxlcihFdmVudCogZXZlbnQpCkBAIC03 MjcsMTMgKzczOSwxNSBAQCB2b2lkIE1lZGlhQ29udHJvbFRpbWVsaW5lRWxlbWVudDo6dXBkYXRl CiAvLyAtLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCiAKIGlubGluZSBNZWRpYUNvbnRyb2xW b2x1bWVTbGlkZXJFbGVtZW50OjpNZWRpYUNvbnRyb2xWb2x1bWVTbGlkZXJFbGVtZW50KEhUTUxN ZWRpYUVsZW1lbnQqIG1lZGlhRWxlbWVudCkKLSAgICA6IE1lZGlhQ29udHJvbElucHV0RWxlbWVu dChtZWRpYUVsZW1lbnQsIE1FRElBX0NPTlRST0xTX1ZPTFVNRV9TTElERVIsICJyYW5nZSIpCisg ICAgOiBNZWRpYUNvbnRyb2xJbnB1dEVsZW1lbnQobWVkaWFFbGVtZW50LCBNRURJQV9DT05UUk9M U19WT0xVTUVfU0xJREVSKQogewogfQogCiBQYXNzUmVmUHRyPE1lZGlhQ29udHJvbFZvbHVtZVNs aWRlckVsZW1lbnQ+IE1lZGlhQ29udHJvbFZvbHVtZVNsaWRlckVsZW1lbnQ6OmNyZWF0ZShIVE1M TWVkaWFFbGVtZW50KiBtZWRpYUVsZW1lbnQpCiB7Ci0gICAgcmV0dXJuIGFkb3B0UmVmKG5ldyBN ZWRpYUNvbnRyb2xWb2x1bWVTbGlkZXJFbGVtZW50KG1lZGlhRWxlbWVudCkpOworICAgIFJlZlB0 cjxNZWRpYUNvbnRyb2xWb2x1bWVTbGlkZXJFbGVtZW50PiBzbGlkZXIgPSBhZG9wdFJlZihuZXcg TWVkaWFDb250cm9sVm9sdW1lU2xpZGVyRWxlbWVudChtZWRpYUVsZW1lbnQpKTsKKyAgICBzbGlk ZXItPnNldFR5cGUoInJhbmdlIik7CisgICAgcmV0dXJuIHNsaWRlci5yZWxlYXNlKCk7CiB9CiAK IHZvaWQgTWVkaWFDb250cm9sVm9sdW1lU2xpZGVyRWxlbWVudDo6ZGVmYXVsdEV2ZW50SGFuZGxl cihFdmVudCogZXZlbnQpCkBAIC03NjksMTMgKzc4MywxNSBAQCB2b2lkIE1lZGlhQ29udHJvbFZv bHVtZVNsaWRlckVsZW1lbnQ6OnVwCiAvLyAtLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCiAK IGlubGluZSBNZWRpYUNvbnRyb2xGdWxsc2NyZWVuQnV0dG9uRWxlbWVudDo6TWVkaWFDb250cm9s RnVsbHNjcmVlbkJ1dHRvbkVsZW1lbnQoSFRNTE1lZGlhRWxlbWVudCogbWVkaWFFbGVtZW50KQot ICAgIDogTWVkaWFDb250cm9sSW5wdXRFbGVtZW50KG1lZGlhRWxlbWVudCwgTUVESUFfQ09OVFJP TFNfRlVMTFNDUkVFTl9CVVRUT04sICJidXR0b24iKQorICAgIDogTWVkaWFDb250cm9sSW5wdXRF bGVtZW50KG1lZGlhRWxlbWVudCwgTUVESUFfQ09OVFJPTFNfRlVMTFNDUkVFTl9CVVRUT04pCiB7 CiB9CiAKIFBhc3NSZWZQdHI8TWVkaWFDb250cm9sRnVsbHNjcmVlbkJ1dHRvbkVsZW1lbnQ+IE1l ZGlhQ29udHJvbEZ1bGxzY3JlZW5CdXR0b25FbGVtZW50OjpjcmVhdGUoSFRNTE1lZGlhRWxlbWVu dCogbWVkaWFFbGVtZW50KQogewotICAgIHJldHVybiBhZG9wdFJlZihuZXcgTWVkaWFDb250cm9s RnVsbHNjcmVlbkJ1dHRvbkVsZW1lbnQobWVkaWFFbGVtZW50KSk7CisgICAgUmVmUHRyPE1lZGlh Q29udHJvbEZ1bGxzY3JlZW5CdXR0b25FbGVtZW50PiBidXR0b24gPSBhZG9wdFJlZihuZXcgTWVk aWFDb250cm9sRnVsbHNjcmVlbkJ1dHRvbkVsZW1lbnQobWVkaWFFbGVtZW50KSk7CisgICAgYnV0 dG9uLT5zZXRUeXBlKCJidXR0b24iKTsKKyAgICByZXR1cm4gYnV0dG9uLnJlbGVhc2UoKTsKIH0K IAogdm9pZCBNZWRpYUNvbnRyb2xGdWxsc2NyZWVuQnV0dG9uRWxlbWVudDo6ZGVmYXVsdEV2ZW50 SGFuZGxlcihFdmVudCogZXZlbnQpCkluZGV4OiBXZWJDb3JlL3JlbmRlcmluZy9NZWRpYUNvbnRy b2xFbGVtZW50cy5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcmVuZGVyaW5nL01lZGlhQ29udHJv bEVsZW1lbnRzLmgJKHJldmlzaW9uIDY3OTU5KQorKysgV2ViQ29yZS9yZW5kZXJpbmcvTWVkaWFD b250cm9sRWxlbWVudHMuaAkod29ya2luZyBjb3B5KQpAQCAtMTc4LDcgKzE3OCw3IEBAIHB1Ymxp YzoKICAgICBIVE1MTWVkaWFFbGVtZW50KiBtZWRpYUVsZW1lbnQoKSBjb25zdCB7IHJldHVybiBt X21lZGlhRWxlbWVudDsgfQogCiBwcm90ZWN0ZWQ6Ci0gICAgTWVkaWFDb250cm9sSW5wdXRFbGVt ZW50KEhUTUxNZWRpYUVsZW1lbnQqLCBQc2V1ZG9JZCwgY29uc3QgU3RyaW5nJiB0eXBlKTsKKyAg ICBNZWRpYUNvbnRyb2xJbnB1dEVsZW1lbnQoSFRNTE1lZGlhRWxlbWVudCosIFBzZXVkb0lkKTsK IAogICAgIHZvaWQgc2V0RGlzcGxheVR5cGUoTWVkaWFDb250cm9sRWxlbWVudFR5cGUpOwogCg==