46168 2010-09-21 00:53:29 -0700 [reviewtool] Publish button doesn't work 2010-09-21 09:26:25 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 abarth abarth darin oldest_to_newest 282134 0 abarth 2010-09-21 00:53:29 -0700 [reviewtool] Publish button doesn't work 282135 1 68199 abarth 2010-09-21 00:55:12 -0700 Created attachment 68199 Patch 282136 2 abarth 2010-09-21 01:02:30 -0700 Committed r67931: <http://trac.webkit.org/changeset/67931> 282138 3 68199 abarth 2010-09-21 01:05:39 -0700 Comment on attachment 68199 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=68199&action=review > BugsSite/code-review.js:478 > - review_form.find('form').submit(); > + $('#reviewform').contents().find('form').submit(); test 282350 4 darin 2010-09-21 09:26:25 -0700 Thanks for fixing that. Sorry I wasn’t around when the patch landed! 68199 2010-09-21 00:55:12 -0700 2010-09-21 01:05:39 -0700 Patch bug-46168-20100921005510.patch text/plain 995 abarth SW5kZXg6IEJ1Z3NTaXRlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBCdWdzU2l0ZS9DaGFuZ2VM b2cJKHJldmlzaW9uIDY3OTMwKQorKysgQnVnc1NpdGUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkp CkBAIC0xLDMgKzEsMTUgQEAKKzIwMTAtMDktMjEgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0 Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBb cmV2aWV3dG9vbF0gUHVibGlzaCBidXR0b24gZG9lc24ndCB3b3JrCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NjE2OAorCisgICAgICAgIERhcmluJ3Mg cmVjZW50IHBhdGNoIGhhZCBhIHJ1bnRpbWUgZXJyb3IuICBTYWRseSwgd2UgZG9uJ3QgaGF2ZSBh bnkKKyAgICAgICAgdGVzdGluZyBmb3IgdGhpcyBjb2RlLgorCisgICAgICAgICogY29kZS1yZXZp ZXcuanM6CisKIDIwMTAtMDktMjAgIERhcmluIEFkbGVyICA8ZGFyaW5AYXBwbGUuY29tPgogCiAg ICAgICAgIFJldmlld2VkIGJ5IEFkYW0gQmFydGguCkluZGV4OiBCdWdzU2l0ZS9jb2RlLXJldmll dy5qcwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBCdWdzU2l0ZS9jb2RlLXJldmlldy5qcwkocmV2aXNpb24gNjc5 MjcpCisrKyBCdWdzU2l0ZS9jb2RlLXJldmlldy5qcwkod29ya2luZyBjb3B5KQpAQCAtNDc1LDYg KzQ3NSw2IEBACiAKICAgJCgnI3Bvc3RfY29tbWVudHMnKS5saXZlKCdjbGljaycsIGZ1bmN0aW9u KCkgewogICAgIGZpbGxJblJldmlld0Zvcm0oKTsKLSAgICByZXZpZXdfZm9ybS5maW5kKCdmb3Jt Jykuc3VibWl0KCk7CisgICAgJCgnI3Jldmlld2Zvcm0nKS5jb250ZW50cygpLmZpbmQoJ2Zvcm0n KS5zdWJtaXQoKTsKICAgfSk7CiB9KSgpOwo=