46157 2010-09-20 19:03:58 -0700 Fix "operands of ? are integers of different signs" clang warnings 2010-09-20 20:46:38 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 thakis thakis abarth commit-queue eric oldest_to_newest 282020 0 thakis 2010-09-20 19:03:58 -0700 Fix "operands of ? are integers of different signs" clang warnings 282021 1 68175 thakis 2010-09-20 19:04:44 -0700 Created attachment 68175 Patch 282023 2 68175 abarth 2010-09-20 19:06:40 -0700 Comment on attachment 68175 Patch ok 282040 3 eric 2010-09-20 19:46:33 -0700 This is gonna fail the commit-queue due to the second OOPS in the ChangeLog. You should explain what tests you added or why testing is impossible/impractical. 282041 4 eric 2010-09-20 19:47:06 -0700 In the case of a build fix, we sometimes just delete that line or say "Build fix, no tests needed." 282043 5 68175 commit-queue 2010-09-20 20:01:58 -0700 Comment on attachment 68175 Patch Rejecting patch 68175 from commit-queue. Failed to run "[u'git', u'svn', u'dcommit']" exit_code: 1 Last 500 characters of output: ommitting to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/platform/graphics/mac/ComplexTextController.cpp M WebCore/rendering/RenderBox.cpp A repository hook failed: Commit blocked by pre-commit hook (exit code 1) with output: svnlook: Can't write to stream: Broken pipe The following ChangeLog files contain OOPS: trunk/WebCore/ChangeLog Please don't ever say "OOPS" in a ChangeLog file. at /usr/local/git/libexec/git-core/git-svn line 558 Full output: http://queues.webkit.org/results/4046095 282047 6 abarth 2010-09-20 20:08:52 -0700 Committed r67915: <http://trac.webkit.org/changeset/67915> 282060 7 thakis 2010-09-20 20:46:38 -0700 Thanks, abarth! 68175 2010-09-20 19:04:44 -0700 2010-09-20 20:01:58 -0700 Patch bug-46157-20100920190443.patch text/plain 2911 thakis ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg Y2NiNTk0ZTNhNzZhNjdlMTI3YmNmZmY4ZGM1MzE1NjAzOTBhYWU3MC4uOTM2ZGMzMDhlZDBjNWZh ZDE2Yjk5MGI1ZjNhNzgxZDRiNTcxMTY5ZiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxMC0wOS0yMCAgTmlj byBXZWJlciAgPHRoYWtpc0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgRml4ICJvcGVyYW5kcyBvZiA/IGFyZSBpbnRlZ2VycyBv ZiBkaWZmZXJlbnQgc2lnbnMiIGNsYW5nIHdhcm5pbmdzCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NjE1NworCisgICAgICAgIE5vIG5ldyB0ZXN0cy4g KE9PUFMhKQorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvbWFjL0NvbXBsZXhUZXh0Q29u dHJvbGxlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpDb21wbGV4VGV4dENvbnRyb2xsZXI6OmFk dmFuY2UpOgorICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJCb3guY3BwOgorICAgICAgICAoV2Vi Q29yZTo6UmVuZGVyQm94OjpjYWxjSGVpZ2h0KToKKwogMjAxMC0wOS0yMCAgQW5keSBFc3RlcyAg PGFlc3Rlc0BhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQWRhbSBCYXJ0aC4KZGlm ZiAtLWdpdCBhL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvbWFjL0NvbXBsZXhUZXh0Q29udHJv bGxlci5jcHAgYi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL21hYy9Db21wbGV4VGV4dENvbnRy b2xsZXIuY3BwCmluZGV4IGRhMzgxZjI2OGY0NDcwMDE3NjBiYWJhZDE0YjcyMDI0OGVhNGQ4ZDAu LjVkMjczMDIzZTQyMDI1ODRhZDU4YjMwMjBiNDYwNWIyNzljMGU4ZjAgMTAwNjQ0Ci0tLSBhL1dl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvbWFjL0NvbXBsZXhUZXh0Q29udHJvbGxlci5jcHAKKysr IGIvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9tYWMvQ29tcGxleFRleHRDb250cm9sbGVyLmNw cApAQCAtMzgyLDkgKzM4Miw5IEBAIHZvaWQgQ29tcGxleFRleHRDb250cm9sbGVyOjphZHZhbmNl KHVuc2lnbmVkIG9mZnNldCwgR2x5cGhCdWZmZXIqIGdseXBoQnVmZmVyKQogICAgICAgICAgICAg dW5zaWduZWQgZ2x5cGhFbmRPZmZzZXQ7CiAgICAgICAgICAgICBpZiAoY29tcGxleFRleHRSdW4u aXNNb25vdG9uaWMoKSkgewogICAgICAgICAgICAgICAgIGlmIChsdHIpCi0gICAgICAgICAgICAg ICAgICAgIGdseXBoRW5kT2Zmc2V0ID0gbWF4PHVuc2lnbmVkPihnbHlwaFN0YXJ0T2Zmc2V0LCBn ICsgMSA8IGdseXBoQ291bnQgPyBjb21wbGV4VGV4dFJ1bi5pbmRleEF0KGcgKyAxKSA6IGNvbXBs ZXhUZXh0UnVuLnN0cmluZ0xlbmd0aCgpKTsKKyAgICAgICAgICAgICAgICAgICAgZ2x5cGhFbmRP ZmZzZXQgPSBtYXg8dW5zaWduZWQ+KGdseXBoU3RhcnRPZmZzZXQsIGcgKyAxIDwgZ2x5cGhDb3Vu dCA/IHN0YXRpY19jYXN0PHVuc2lnbmVkPihjb21wbGV4VGV4dFJ1bi5pbmRleEF0KGcgKyAxKSkg OiBjb21wbGV4VGV4dFJ1bi5zdHJpbmdMZW5ndGgoKSk7CiAgICAgICAgICAgICAgICAgZWxzZQot ICAgICAgICAgICAgICAgICAgICBnbHlwaEVuZE9mZnNldCA9IG1heDx1bnNpZ25lZD4oZ2x5cGhT dGFydE9mZnNldCwgZyA+IDAgPyBjb21wbGV4VGV4dFJ1bi5pbmRleEF0KGcgLSAxKSA6IGNvbXBs ZXhUZXh0UnVuLnN0cmluZ0xlbmd0aCgpKTsKKyAgICAgICAgICAgICAgICAgICAgZ2x5cGhFbmRP ZmZzZXQgPSBtYXg8dW5zaWduZWQ+KGdseXBoU3RhcnRPZmZzZXQsIGcgPiAwID8gc3RhdGljX2Nh c3Q8dW5zaWduZWQ+KGNvbXBsZXhUZXh0UnVuLmluZGV4QXQoZyAtIDEpKSA6IGNvbXBsZXhUZXh0 UnVuLnN0cmluZ0xlbmd0aCgpKTsKICAgICAgICAgICAgIH0gZWxzZQogICAgICAgICAgICAgICAg IGdseXBoRW5kT2Zmc2V0ID0gY29tcGxleFRleHRSdW4uZW5kT2Zmc2V0QXQoZyk7CiAKZGlmZiAt LWdpdCBhL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJveC5jcHAgYi9XZWJDb3JlL3JlbmRlcmlu Zy9SZW5kZXJCb3guY3BwCmluZGV4IDY1YTZiMGJjZGJhZTU2Y2RkOTIxYjg3NWQzNjMyOTdiMTky OWRmZmIuLjRlYjRhNDJhMDlhYzE1ODRhNDZiYTBlZjk0YTQ2MWUxNjA3ZThjMGYgMTAwNjQ0Ci0t LSBhL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJveC5jcHAKKysrIGIvV2ViQ29yZS9yZW5kZXJp bmcvUmVuZGVyQm94LmNwcApAQCAtMTUxOSw3ICsxNTE5LDcgQEAgdm9pZCBSZW5kZXJCb3g6OmNh bGNIZWlnaHQoKQogICAgICAgICAmJiAoaXNSb290KCkgfHwgKGlzQm9keSgpICYmIGRvY3VtZW50 KCktPmRvY3VtZW50RWxlbWVudCgpLT5yZW5kZXJlcigpLT5zdHlsZSgpLT5oZWlnaHQoKS5pc1Bl cmNlbnQoKSkpOwogICAgIGlmIChzdHJldGNoZXNUb1ZpZXdIZWlnaHQoKSB8fCBwYWdpbmF0ZWRD b250ZW50TmVlZHNCYXNlSGVpZ2h0KSB7CiAgICAgICAgIGludCBtYXJnaW5zID0gY29sbGFwc2Vk TWFyZ2luVG9wKCkgKyBjb2xsYXBzZWRNYXJnaW5Cb3R0b20oKTsKLSAgICAgICAgaW50IHZpc0hl aWdodCA9IGRvY3VtZW50KCktPnByaW50aW5nKCkgPyB2aWV3KCktPnBhZ2VIZWlnaHQoKSA6IHZp ZXcoKS0+dmlld0hlaWdodCgpOworICAgICAgICBpbnQgdmlzSGVpZ2h0ID0gZG9jdW1lbnQoKS0+ cHJpbnRpbmcoKSA/IHN0YXRpY19jYXN0PGludD4odmlldygpLT5wYWdlSGVpZ2h0KCkpIDogdmll dygpLT52aWV3SGVpZ2h0KCk7CiAgICAgICAgIGlmIChpc1Jvb3QoKSkKICAgICAgICAgICAgIHNl dEhlaWdodChtYXgoaGVpZ2h0KCksIHZpc0hlaWdodCAtIG1hcmdpbnMpKTsKICAgICAgICAgZWxz ZSB7Cg==