46153 2010-09-20 18:23:35 -0700 Add Preview button to patch review bar 2010-09-21 09:40:13 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 darin darin abarth dbates oldest_to_newest 281989 0 darin 2010-09-20 18:23:35 -0700 Add Preview button and link to bug to patch review bar 281993 1 68169 darin 2010-09-20 18:28:01 -0700 Created attachment 68169 Patch 282115 2 68169 abarth 2010-09-20 23:27:37 -0700 Comment on attachment 68169 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=68169&action=review > BugsSite/code-review.js:257 > + $(document.body).prepend('<div id="toolbar"><div class="actions"><button id="preview_comments">Preview</button><button id="post_comments">Publish</button></div><div class="message"><a href="show_bug.cgi?id=' + bug_id + '" target="_blank">bug ' + bug_id + '</a> <span class="commentStatus"></span> <span class="help">Double-click a line or click or drag on line numbers to add a comment.</span></div></div>'); Thanks for writing this patch. This should work great. The only problem is that bug_id won't necessarily be defined when this code runs. This code runs on DOMContentLoaded, but we fetch the bug_id asynchronously by loading the details page for the attachment. I'll land a modified version of this patch with just the preview button. 282121 3 abarth 2010-09-20 23:45:14 -0700 Committed r67927: <http://trac.webkit.org/changeset/67927> 282357 4 darin 2010-09-21 09:39:18 -0700 (In reply to comment #2) > The only problem is that bug_id won't necessarily be defined when this code runs. This code runs on DOMContentLoaded, but we fetch the bug_id asynchronously by loading the details page for the attachment. I'll land a modified version of this patch with just the preview button. Can you help me create a version of this that adds the bug link when the details page loading is complete? 68169 2010-09-20 18:28:01 -0700 2010-09-20 23:27:37 -0700 Patch bug-46153-20100920182800.patch text/plain 3124 darin SW5kZXg6IEJ1Z3NTaXRlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBCdWdzU2l0ZS9DaGFuZ2VM b2cJKHJldmlzaW9uIDY3OTA0KQorKysgQnVnc1NpdGUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkp CkBAIC0xLDMgKzEsMTMgQEAKKzIwMTAtMDktMjAgIERhcmluIEFkbGVyICA8ZGFyaW5AYXBwbGUu Y29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFk ZCBQcmV2aWV3IGJ1dHRvbiBhbmQgbGluayB0byBidWcgdG8gcGF0Y2ggcmV2aWV3IGJhcgorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDYxNTMKKworICAg ICAgICAqIFByZXR0eVBhdGNoL1ByZXR0eVBhdGNoLnJiOiBCdW1wIHZlcnNpb24gbnVtYmVyIHRv IG1ha2UgY2FjaGVzIGhhcHB5LgorICAgICAgICAqIGNvZGUtcmV2aWV3LmpzOiBBZGRlZCBQcmV2 aWV3IGJ1dHRvbiBhbmQgbGluayB0byBidWcuCisKIDIwMTAtMDktMTkgIEFkYW0gQmFydGggIDxh YmFydGhAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBFcmljIFNlaWRlbC4KSW5k ZXg6IEJ1Z3NTaXRlL2NvZGUtcmV2aWV3LmpzCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEJ1Z3NTaXRlL2NvZGUt cmV2aWV3LmpzCShyZXZpc2lvbiA2NzkwMikKKysrIEJ1Z3NTaXRlL2NvZGUtcmV2aWV3LmpzCSh3 b3JraW5nIGNvcHkpCkBAIC0yNTQsNyArMjU0LDcgQEAKICAgJChkb2N1bWVudCkucmVhZHkoZnVu Y3Rpb24oKSB7CiAgICAgY3Jhd2xEaWZmKCk7CiAgICAgZmV0Y2hIaXN0b3J5KCk7Ci0gICAgJChk b2N1bWVudC5ib2R5KS5wcmVwZW5kKCc8ZGl2IGlkPSJ0b29sYmFyIj48ZGl2IGNsYXNzPSJhY3Rp b25zIj48YnV0dG9uIGlkPSJwb3N0X2NvbW1lbnRzIj5QdWJsaXNoPC9idXR0b24+PC9kaXY+PGRp diBjbGFzcz0ibWVzc2FnZSI+PHNwYW4gY2xhc3M9ImNvbW1lbnRTdGF0dXMiPjwvc3Bhbj4gPHNw YW4gY2xhc3M9ImhlbHAiPkRvdWJsZS1jbGljayBhIGxpbmUgdG8gYWRkIGEgY29tbWVudC48L3Nw YW4+PC9kaXY+PC9kaXY+Jyk7CisgICAgJChkb2N1bWVudC5ib2R5KS5wcmVwZW5kKCc8ZGl2IGlk PSJ0b29sYmFyIj48ZGl2IGNsYXNzPSJhY3Rpb25zIj48YnV0dG9uIGlkPSJwcmV2aWV3X2NvbW1l bnRzIj5QcmV2aWV3PC9idXR0b24+PGJ1dHRvbiBpZD0icG9zdF9jb21tZW50cyI+UHVibGlzaDwv YnV0dG9uPjwvZGl2PjxkaXYgY2xhc3M9Im1lc3NhZ2UiPjxhIGhyZWY9InNob3dfYnVnLmNnaT9p ZD0nICsgYnVnX2lkICsgJyIgdGFyZ2V0PSJfYmxhbmsiPmJ1ZyAnICsgYnVnX2lkICsgJzwvYT4g PHNwYW4gY2xhc3M9ImNvbW1lbnRTdGF0dXMiPjwvc3Bhbj4gPHNwYW4gY2xhc3M9ImhlbHAiPkRv dWJsZS1jbGljayBhIGxpbmUgb3IgY2xpY2sgb3IgZHJhZyBvbiBsaW5lIG51bWJlcnMgdG8gYWRk IGEgY29tbWVudC48L3NwYW4+PC9kaXY+PC9kaXY+Jyk7CiAgICAgJChkb2N1bWVudC5ib2R5KS5w cmVwZW5kKCc8ZGl2IGlkPSJjb21tZW50X2Zvcm0iIGNsYXNzPSJpbmFjdGl2ZSI+PGRpdiBjbGFz cz0id2ludGVyIj48L2Rpdj48ZGl2IGNsYXNzPSJsaWdodGJveCI+PGlmcmFtZSBpZD0icmV2aWV3 Zm9ybSIgc3JjPSJhdHRhY2htZW50LmNnaT9pZD0nICsgYXR0YWNobWVudF9pZCArICcmYWN0aW9u PXJldmlld2Zvcm0iPjwvaWZyYW1lPjwvZGl2PjwvZGl2PicpOwogICAgICQoZG9jdW1lbnQuYm9k eSkuYXBwZW5kKCc8ZGl2IGNsYXNzPSJvdmVyYWxsQ29tbWVudHMiPjxkaXYgY2xhc3M9ImRlc2Ny aXB0aW9uIj5PdmVyYWxsIGNvbW1lbnRzOjwvZGl2Pjx0ZXh0YXJlYT48L3RleHRhcmVhPjwvZGl2 PicpOwogICB9KTsKQEAgLTQzNCw3ICs0MzQsNyBAQAogICAgICQoJyNjb21tZW50X2Zvcm0nKS5h ZGRDbGFzcygnaW5hY3RpdmUnKTsKICAgfSk7CiAKLSAgJCgnI3Bvc3RfY29tbWVudHMnKS5saXZl KCdjbGljaycsIGZ1bmN0aW9uKCkgeworICBmdW5jdGlvbiBmaWxsSW5SZXZpZXdGb3JtKCkgewog ICAgIHZhciBjb21tZW50c19pbl9jb250ZXh0ID0gW10KICAgICBmb3JFYWNoTGluZShmdW5jdGlv bihsaW5lKSB7CiAgICAgICBpZiAobGluZS5hdHRyKCdkYXRhLWhhcy1jb21tZW50JykgIT0gJ3Ry dWUnKQpAQCAtNDY2LDYgKzQ2NiwxNSBAQAogICAgICAgICByZXR1cm47CiAgICAgICAkKHRoaXMp LmF0dHIoJ3NlbGVjdGVkSW5kZXgnLCBjb250cm9sLmF0dHIoJ3NlbGVjdGVkSW5kZXgnKSk7CiAg ICAgfSk7CisgIH0KKworICAkKCcjcHJldmlld19jb21tZW50cycpLmxpdmUoJ2NsaWNrJywgZnVu Y3Rpb24oKSB7CisgICAgZmlsbEluUmV2aWV3Rm9ybSgpOworICAgICQoJyNjb21tZW50X2Zvcm0n KS5yZW1vdmVDbGFzcygnaW5hY3RpdmUnKTsKKyAgfSk7CisKKyAgJCgnI3Bvc3RfY29tbWVudHMn KS5saXZlKCdjbGljaycsIGZ1bmN0aW9uKCkgeworICAgIGZpbGxJblJldmlld0Zvcm0oKTsKICAg ICByZXZpZXdfZm9ybS5maW5kKCdmb3JtJykuc3VibWl0KCk7CiAgIH0pOwogfSkoKTsKSW5kZXg6 IEJ1Z3NTaXRlL1ByZXR0eVBhdGNoL1ByZXR0eVBhdGNoLnJiCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEJ1Z3NT aXRlL1ByZXR0eVBhdGNoL1ByZXR0eVBhdGNoLnJiCShyZXZpc2lvbiA2NzkwMikKKysrIEJ1Z3NT aXRlL1ByZXR0eVBhdGNoL1ByZXR0eVBhdGNoLnJiCSh3b3JraW5nIGNvcHkpCkBAIC0zMDYsNyAr MzA2LDcgQEAgYm9keSB7CiB9CiA8L3N0eWxlPgogPHNjcmlwdCBzcmM9Imh0dHBzOi8vYWpheC5n b29nbGVhcGlzLmNvbS9hamF4L2xpYnMvanF1ZXJ5LzEuNC4yL2pxdWVyeS5taW4uanMiPjwvc2Ny aXB0PiAKLTxzY3JpcHQgc3JjPSJjb2RlLXJldmlldy5qcz92ZXJzaW9uPTkiPjwvc2NyaXB0PiAK KzxzY3JpcHQgc3JjPSJjb2RlLXJldmlldy5qcz92ZXJzaW9uPTEwIj48L3NjcmlwdD4gCiBFT0YK IAogICAgIGRlZiBzZWxmLnJldmlzaW9uT3JEZXNjcmlwdGlvbihzdHJpbmcpCg==