46133 2010-09-20 16:30:00 -0700 ProcessLauncherWin.cpp leaks the child process handle 2010-09-27 08:23:45 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) PC Windows XP RESOLVED FIXED InRadar, PlatformOnly P2 Normal --- 1 andersca aroben andersca oldest_to_newest 281896 0 andersca 2010-09-20 16:30:00 -0700 We should ::CloseHandle the handle. 281899 1 aroben 2010-09-20 16:31:31 -0700 According to MSDN: If the function succeeds, be sure to call the CloseHandle function to close the hProcess and hThread handles when you are finished with them. Otherwise, when the child process exits, the system cannot clean up the process structures for the child process because the parent process still has open handles to the child process. However, the system will close these handles when the parent process terminates, so the structures related to the child process object would be cleaned up at this point. http://msdn.microsoft.com/en-us/library/ms684873(v=VS.85).aspx 281900 2 aroben 2010-09-20 16:32:05 -0700 <rdar://problem/8455343> 285436 3 68905 aroben 2010-09-27 07:01:14 -0700 Created attachment 68905 Stop leaking the web process's process handle on Windows 285470 4 aroben 2010-09-27 08:23:45 -0700 Committed r68391: <http://trac.webkit.org/changeset/68391> 68905 2010-09-27 07:01:14 -0700 2010-09-27 08:09:12 -0700 Stop leaking the web process's process handle on Windows bug-46133-20100927100113.patch text/plain 4325 aroben ZGlmZiAtLWdpdCBhL1dlYktpdDIvQ2hhbmdlTG9nIGIvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXgg YWNhYmVmYzQ0MDZlMDE2YTBiOTA3ZTZiY2NmOWRhMDQxNzgwNzQxMy4uYzQ5MWNmM2QzMDgzYzZh MWU4NmZkYjQ5N2E5NWJhMzI5ZThkZTZmZSAxMDA2NDQKLS0tIGEvV2ViS2l0Mi9DaGFuZ2VMb2cK KysrIGIvV2ViS2l0Mi9DaGFuZ2VMb2cKQEAgLTEsNSArMSwyOCBAQAogMjAxMC0wOS0yNyAgQWRh bSBSb2JlbiAgPGFyb2JlbkBhcHBsZS5jb20+CiAKKyAgICAgICAgU3RvcCBsZWFraW5nIHRoZSB3 ZWIgcHJvY2VzcydzIHByb2Nlc3MgaGFuZGxlIG9uIFdpbmRvd3MKKworICAgICAgICBGaXhlcyA8 aHR0cDovL3dlYmtpdC5vcmcvYi80NjEzMz4gPHJkYXI6Ly9wcm9ibGVtLzg0NTUzNDM+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVSVByb2Nlc3Mv TGF1bmNoZXIvUHJvY2Vzc0xhdW5jaGVyLmNwcDoKKyAgICAgICAgKFdlYktpdDo6UHJvY2Vzc0xh dW5jaGVyOjppbnZhbGlkYXRlKTogQ2FsbCBwbGF0Zm9ybUludmFsaWRhdGUuCisKKyAgICAgICAg KiBVSVByb2Nlc3MvTGF1bmNoZXIvUHJvY2Vzc0xhdW5jaGVyLmg6IEFkZGVkIHBsYXRmb3JtSW52 YWxpZGF0ZS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9MYXVuY2hlci9tYWMvUHJvY2Vzc0xhdW5j aGVyTWFjLm1tOgorICAgICAgICAoV2ViS2l0OjpQcm9jZXNzTGF1bmNoZXI6OnBsYXRmb3JtSW52 YWxpZGF0ZSk6CisgICAgICAgICogVUlQcm9jZXNzL0xhdW5jaGVyL3F0L1Byb2Nlc3NMYXVuY2hl clF0LmNwcDoKKyAgICAgICAgKFdlYktpdDo6UHJvY2Vzc0xhdW5jaGVyOjpwbGF0Zm9ybUludmFs aWRhdGUpOgorICAgICAgICBTdHViYmVkIG91dC4KKworICAgICAgICAqIFVJUHJvY2Vzcy9MYXVu Y2hlci93aW4vUHJvY2Vzc0xhdW5jaGVyV2luLmNwcDoKKyAgICAgICAgKFdlYktpdDo6UHJvY2Vz c0xhdW5jaGVyOjpwbGF0Zm9ybUludmFsaWRhdGUpOiBDbG9zZSB0aGUgcHJvY2VzcworICAgICAg ICBoYW5kbGUgbGlrZSBNU0ROIHNheXMgd2Ugc2hvdWxkLgorCisyMDEwLTA5LTI3ICBBZGFtIFJv YmVuICA8YXJvYmVuQGFwcGxlLmNvbT4KKwogICAgICAgICBEb24ndCBkb3VibGUtZnJlZSBDRVJU X0NPTlRFWFRzIHdoZW4gY29weWluZyBQbGF0Zm9ybUNlcnRpZmljYXRlSW5mb3MKICAgICAgICAg b24gV2luZG93cwogCmRpZmYgLS1naXQgYS9XZWJLaXQyL1VJUHJvY2Vzcy9MYXVuY2hlci9Qcm9j ZXNzTGF1bmNoZXIuY3BwIGIvV2ViS2l0Mi9VSVByb2Nlc3MvTGF1bmNoZXIvUHJvY2Vzc0xhdW5j aGVyLmNwcAppbmRleCA0N2NlZGMxN2YyNWZhNjQ0NDc1MTYyZjJmODlhNzNiYTNmNzJmZjI2Li41 MDdlZGZhODNlMjZiODQ1NjFiMzBiYjFiMTAyNWRiYWY1YjU4NTkxIDEwMDY0NAotLS0gYS9XZWJL aXQyL1VJUHJvY2Vzcy9MYXVuY2hlci9Qcm9jZXNzTGF1bmNoZXIuY3BwCisrKyBiL1dlYktpdDIv VUlQcm9jZXNzL0xhdW5jaGVyL1Byb2Nlc3NMYXVuY2hlci5jcHAKQEAgLTYyLDYgKzYyLDcgQEAg dm9pZCBQcm9jZXNzTGF1bmNoZXI6OmRpZEZpbmlzaExhdW5jaGluZ1Byb2Nlc3MoUGxhdGZvcm1Q cm9jZXNzSWRlbnRpZmllciBwcm9jZXMKIHZvaWQgUHJvY2Vzc0xhdW5jaGVyOjppbnZhbGlkYXRl KCkKIHsKICAgICBtX2NsaWVudCA9IDA7CisgICAgcGxhdGZvcm1JbnZhbGlkYXRlKCk7CiB9CiAK IGNvbnN0IGNoYXIqIFByb2Nlc3NMYXVuY2hlcjo6cHJvY2Vzc1R5cGVBc1N0cmluZyhQcm9jZXNz VHlwZSBwcm9jZXNzVHlwZSkKZGlmZiAtLWdpdCBhL1dlYktpdDIvVUlQcm9jZXNzL0xhdW5jaGVy L1Byb2Nlc3NMYXVuY2hlci5oIGIvV2ViS2l0Mi9VSVByb2Nlc3MvTGF1bmNoZXIvUHJvY2Vzc0xh dW5jaGVyLmgKaW5kZXggM2NkODliYTI2NjZhN2ZkY2Q4OTM1YzU5YTFkZDBkZDNmMzY1NDRjNy4u MzFlZmQ0ZDQ3ZmNkYjJmMTAzOGNlNzFmZjY0MThhY2ZmYjVlYWE0OSAxMDA2NDQKLS0tIGEvV2Vi S2l0Mi9VSVByb2Nlc3MvTGF1bmNoZXIvUHJvY2Vzc0xhdW5jaGVyLmgKKysrIGIvV2ViS2l0Mi9V SVByb2Nlc3MvTGF1bmNoZXIvUHJvY2Vzc0xhdW5jaGVyLmgKQEAgLTg1LDYgKzg1LDggQEAgcHJp dmF0ZToKICAgICB2b2lkIGxhdW5jaFByb2Nlc3MoKTsKICAgICB2b2lkIGRpZEZpbmlzaExhdW5j aGluZ1Byb2Nlc3MoUGxhdGZvcm1Qcm9jZXNzSWRlbnRpZmllciwgQ29yZUlQQzo6Q29ubmVjdGlv bjo6SWRlbnRpZmllcik7CiAKKyAgICB2b2lkIHBsYXRmb3JtSW52YWxpZGF0ZSgpOworCiAgICAg Q2xpZW50KiBtX2NsaWVudDsKIAogICAgIGNvbnN0IExhdW5jaE9wdGlvbnMgbV9sYXVuY2hPcHRp b25zOwpkaWZmIC0tZ2l0IGEvV2ViS2l0Mi9VSVByb2Nlc3MvTGF1bmNoZXIvbWFjL1Byb2Nlc3NM YXVuY2hlck1hYy5tbSBiL1dlYktpdDIvVUlQcm9jZXNzL0xhdW5jaGVyL21hYy9Qcm9jZXNzTGF1 bmNoZXJNYWMubW0KaW5kZXggYmQwZDc1NWNiNDJlMWQ0MmMwMDM5NTFjY2I0YTc0ODc3OTMxNjI2 NC4uYmZmMDM1MDVlYzA2MGVhZjQ0ZjdlYjY5OTIwMzY4YmIyMDQ2ZTllMSAxMDA2NDQKLS0tIGEv V2ViS2l0Mi9VSVByb2Nlc3MvTGF1bmNoZXIvbWFjL1Byb2Nlc3NMYXVuY2hlck1hYy5tbQorKysg Yi9XZWJLaXQyL1VJUHJvY2Vzcy9MYXVuY2hlci9tYWMvUHJvY2Vzc0xhdW5jaGVyTWFjLm1tCkBA IC0xNTAsNCArMTUwLDggQEAgdm9pZCBQcm9jZXNzTGF1bmNoZXI6OnRlcm1pbmF0ZVByb2Nlc3Mo KQogICAgIGtpbGwobV9wcm9jZXNzSWRlbnRpZmllciwgU0lHS0lMTCk7CiB9CiAgICAgCit2b2lk IFByb2Nlc3NMYXVuY2hlcjo6cGxhdGZvcm1JbnZhbGlkYXRlKCkKK3sKK30KKwogfSAvLyBuYW1l c3BhY2UgV2ViS2l0CmRpZmYgLS1naXQgYS9XZWJLaXQyL1VJUHJvY2Vzcy9MYXVuY2hlci9xdC9Q cm9jZXNzTGF1bmNoZXJRdC5jcHAgYi9XZWJLaXQyL1VJUHJvY2Vzcy9MYXVuY2hlci9xdC9Qcm9j ZXNzTGF1bmNoZXJRdC5jcHAKaW5kZXggZTFiYTY4MmZlMzA5MDE3MjZlM2UyNzZjNzlmODMzYTg3 MjU2MGExMy4uNmIyZWU3MWNiOGU5NGNlZDBhMWM3ZjE3MGQ3YmY4ZDhjZjdhOTU3OCAxMDA2NDQK LS0tIGEvV2ViS2l0Mi9VSVByb2Nlc3MvTGF1bmNoZXIvcXQvUHJvY2Vzc0xhdW5jaGVyUXQuY3Bw CisrKyBiL1dlYktpdDIvVUlQcm9jZXNzL0xhdW5jaGVyL3F0L1Byb2Nlc3NMYXVuY2hlclF0LmNw cApAQCAtMjcsNiArMjcsNyBAQAogI2luY2x1ZGUgIlByb2Nlc3NMYXVuY2hlci5oIgogCiAjaW5j bHVkZSAiQ29ubmVjdGlvbi5oIgorI2luY2x1ZGUgIk5vdEltcGxlbWVudGVkLmgiCiAjaW5jbHVk ZSAiUnVuTG9vcC5oIgogI2luY2x1ZGUgIldlYlByb2Nlc3MuaCIKICNpbmNsdWRlIDxydW50aW1l L0luaXRpYWxpemVUaHJlYWRpbmcuaD4KQEAgLTE0MSw2ICsxNDIsMTEgQEAgUUxvY2FsU29ja2V0 KiBQcm9jZXNzTGF1bmNoZXI6OnRha2VQZW5kaW5nQ29ubmVjdGlvbigpCiAgICAgcmV0dXJuIFBy b2Nlc3NMYXVuY2hlckhlbHBlcjo6aW5zdGFuY2UoKS0+dGFrZVBlbmRpbmdDb25uZWN0aW9uKCk7 CiB9CiAKK3ZvaWQgUHJvY2Vzc0xhdW5jaGVyOjpwbGF0Zm9ybUludmFsaWRhdGUoKQoreworICAg IG5vdEltcGxlbWVudGVkKCk7Cit9CisKIH0gLy8gbmFtZXNwYWNlIFdlYktpdAogCiAjaW5jbHVk ZSAiUHJvY2Vzc0xhdW5jaGVyUXQubW9jIgpkaWZmIC0tZ2l0IGEvV2ViS2l0Mi9VSVByb2Nlc3Mv TGF1bmNoZXIvd2luL1Byb2Nlc3NMYXVuY2hlcldpbi5jcHAgYi9XZWJLaXQyL1VJUHJvY2Vzcy9M YXVuY2hlci93aW4vUHJvY2Vzc0xhdW5jaGVyV2luLmNwcAppbmRleCAxNmViMjE5NjE1NmY0NmY0 NDA1OTNiZjc4YjJiMjUwMDQxMDRlZWU5Li43ODRhZWZjODAwYTNjYWMwZGQwOWJmYzc1ZjIzNDkw NzI1YTgzMGZjIDEwMDY0NAotLS0gYS9XZWJLaXQyL1VJUHJvY2Vzcy9MYXVuY2hlci93aW4vUHJv Y2Vzc0xhdW5jaGVyV2luLmNwcAorKysgYi9XZWJLaXQyL1VJUHJvY2Vzcy9MYXVuY2hlci93aW4v UHJvY2Vzc0xhdW5jaGVyV2luLmNwcApAQCAtMTA2LDQgKzEwNiwxMyBAQCB2b2lkIFByb2Nlc3NM YXVuY2hlcjo6dGVybWluYXRlUHJvY2VzcygpCiAgICAgOjpUZXJtaW5hdGVQcm9jZXNzKG1fcHJv Y2Vzc0lkZW50aWZpZXIsIDApOwogfQogCit2b2lkIFByb2Nlc3NMYXVuY2hlcjo6cGxhdGZvcm1J bnZhbGlkYXRlKCkKK3sKKyAgICBpZiAoIW1fcHJvY2Vzc0lkZW50aWZpZXIpCisgICAgICAgIHJl dHVybjsKKworICAgIDo6Q2xvc2VIYW5kbGUobV9wcm9jZXNzSWRlbnRpZmllcik7CisgICAgbV9w cm9jZXNzSWRlbnRpZmllciA9IDA7Cit9CisKIH0gLy8gbmFtZXNwYWNlIFdlYktpdAo=