<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>4613</bug_id>
          
          <creation_ts>2005-08-23 20:25:58 -0700</creation_ts>
          <short_desc>A --guard-malloc option to run-webkit-tests could be useful</short_desc>
          <delta_ts>2005-09-19 18:23:34 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>420+</version>
          <rep_platform>Mac</rep_platform>
          <op_sys>OS X 10.4</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P4</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Eric Seidel (no email)">eric</reporter>
          <assigned_to name="Eric Seidel (no email)">eric</assigned_to>
          
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>17303</commentid>
    <comment_count>0</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2005-08-23 20:25:58 -0700</bug_when>
    <thetext>A --guard-malloc option to run-webkit-tests could be useful

Otherwise launching DumpRenderTree under libgmalloc is rather painful.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>17304</commentid>
    <comment_count>1</comment_count>
      <attachid>3547</attachid>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2005-08-23 20:27:14 -0700</bug_when>
    <thetext>Created attachment 3547
a patch to add --guard-malloc to run-webkit-tests</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>17308</commentid>
    <comment_count>2</comment_count>
      <attachid>3547</attachid>
    <who name="Darin Adler">darin</who>
    <bug_when>2005-08-23 22:21:30 -0700</bug_when>
    <thetext>Comment on attachment 3547
a patch to add --guard-malloc to run-webkit-tests

I don&apos;t think we want the diff tool to run under GuardMalloc. I suggest doing
this in a way that only affects the test tools.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>17323</commentid>
    <comment_count>3</comment_count>
      <attachid>3547</attachid>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2005-08-24 03:18:19 -0700</bug_when>
    <thetext>Comment on attachment 3547
a patch to add --guard-malloc to run-webkit-tests

Darin asked that this env setting be localized to the tool launch.  I&apos;ll
investigate how to do that with open2()</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>19992</commentid>
    <comment_count>4</comment_count>
      <attachid>3944</attachid>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2005-09-18 20:25:30 -0700</bug_when>
    <thetext>Created attachment 3944
A better --guard-malloc patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>20049</commentid>
    <comment_count>5</comment_count>
      <attachid>3944</attachid>
    <who name="Darin Adler">darin</who>
    <bug_when>2005-09-19 16:03:25 -0700</bug_when>
    <thetext>Comment on attachment 3944
A better --guard-malloc patch

Looks fine.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>3547</attachid>
            <date>2005-08-23 20:27:14 -0700</date>
            <delta_ts>2005-09-18 20:25:30 -0700</delta_ts>
            <desc>a patch to add --guard-malloc to run-webkit-tests</desc>
            <filename>guard.patch</filename>
            <type>text/plain</type>
            <size>1015</size>
            <attacher name="Eric Seidel (no email)">eric</attacher>
            
              <data encoding="base64">SW5kZXg6IFNjcmlwdHMvcnVuLXdlYmtpdC10ZXN0cwo9PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09ClJDUyBmaWxlOiAvY3Zz
L3Jvb3QvV2ViS2l0VG9vbHMvU2NyaXB0cy9ydW4td2Via2l0LXRlc3RzLHYKcmV0cmlldmluZyBy
ZXZpc2lvbiAxLjE4CmRpZmYgLXAgLXUgLXIxLjE4IFNjcmlwdHMvcnVuLXdlYmtpdC10ZXN0cwot
LS0gU2NyaXB0cy9ydW4td2Via2l0LXRlc3RzCTIzIEF1ZyAyMDA1IDIzOjAzOjAwIC0wMDAwCTEu
MTgKKysrIFNjcmlwdHMvcnVuLXdlYmtpdC10ZXN0cwkyNCBBdWcgMjAwNSAwMzoyOToxMSAtMDAw
MApAQCAtNTksNiArNTksNyBAQCBjaGRpcldlYktpdCgpOwogbXkgJHRlc3RTVkdzID0gJyc7CiBt
eSAkcGl4ZWxUZXN0cyA9ICcnOwogbXkgJGNoZWNrTGVha3MgPSAnJzsKK215ICRndWFyZE1hbGxv
YyA9ICcnOwogbXkgJG1heFdpZHRoID0gJyc7CiBteSAkbWF4SGVpZ2h0ID0gJyc7CiBteSAkdmVy
Ym9zZSA9ICcnOwpAQCAtNjcsNiArNjgsNyBAQCBteSAkcXVpZXQgPSAnJzsKIEdldE9wdGlvbnMo
J3N2ZycgPT4gXCR0ZXN0U1ZHcywgCiAgICAgJ3BpeGVsLXRlc3RzJyA9PiBcJHBpeGVsVGVzdHMs
CiAgICAgJ2xlYWtzJyA9PiBcJGNoZWNrTGVha3MsCisgICAgJ2d1YXJkLW1hbGxvYycgPT4gXCRn
dWFyZE1hbGxvYywKICAgICAnbWF4LXdpZHRoJyA9PiBcJG1heFdpZHRoLAogICAgICdtYXgtaGVp
Z2h0JyA9PiBcJG1heEhlaWdodCwgCiAgICAgJ3ZlcmJvc2UnID0+IFwkdmVyYm9zZSwKQEAgLTEw
OSw2ICsxMTEsOSBAQCAkRU5We0RZTERfRlJBTUVXT1JLX1BBVEh9ID0gJHByb2R1Y3REaXI7CiBp
ZiAoJGNoZWNrTGVha3MpIHsKICAgICAkRU5We01hbGxvY1N0YWNrTG9nZ2luZ30gPSAxOwogfQor
aWYgKCRndWFyZE1hbGxvYykgeworICAgICRFTlZ7RFlMRF9JTlNFUlRfTElCUkFSSUVTfSA9ICIv
dXNyL2xpYi9saWJnbWFsbG9jLmR5bGliIjsKK30KIAogbXkgQHRlc3RzOwogCg==
</data>
<flag name="review"
          id="436"
          type_id="1"
          status="-"
          setter="eric"
    />
          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>3944</attachid>
            <date>2005-09-18 20:25:30 -0700</date>
            <delta_ts>2005-09-19 16:03:25 -0700</delta_ts>
            <desc>A better --guard-malloc patch</desc>
            <filename>guard.patch</filename>
            <type>text/plain</type>
            <size>1123</size>
            <attacher name="Eric Seidel (no email)">eric</attacher>
            
              <data encoding="base64">SW5kZXg6IHJ1bi13ZWJraXQtdGVzdHMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpSQ1MgZmlsZTogL2N2cy9yb290L1dl
YktpdFRvb2xzL1NjcmlwdHMvcnVuLXdlYmtpdC10ZXN0cyx2CnJldHJpZXZpbmcgcmV2aXNpb24g
MS4yNQpkaWZmIC1wIC11IC1yMS4yNSBydW4td2Via2l0LXRlc3RzCi0tLSBydW4td2Via2l0LXRl
c3RzCTE1IFNlcCAyMDA1IDA1OjEzOjUyIC0wMDAwCTEuMjUKKysrIHJ1bi13ZWJraXQtdGVzdHMJ
MTkgU2VwIDIwMDUgMDM6Mjg6MjcgLTAwMDAKQEAgLTU5LDYgKzU5LDcgQEAgY2hkaXJXZWJLaXQo
KTsKIG15ICR0ZXN0U1ZHcyA9ICcnOwogbXkgJHBpeGVsVGVzdHMgPSAnJzsKIG15ICRjaGVja0xl
YWtzID0gJyc7CitteSAkZ3VhcmRNYWxsb2MgPSAwOwogbXkgJG1heFdpZHRoID0gJyc7CiBteSAk
bWF4SGVpZ2h0ID0gJyc7CiBteSAkdmVyYm9zZSA9IDA7CkBAIC02OCw2ICs2OSw3IEBAIG15ICRz
aW5nbHkgPSAwOwogR2V0T3B0aW9ucygnc3ZnJyA9PiBcJHRlc3RTVkdzLCAKICAgICAncGl4ZWwt
dGVzdHN8cCcgPT4gXCRwaXhlbFRlc3RzLAogICAgICdsZWFrc3xsJyA9PiBcJGNoZWNrTGVha3Ms
CisgICAgJ2d1YXJkLW1hbGxvY3xnJyA9PiBcJGd1YXJkTWFsbG9jLAogICAgICdtYXgtd2lkdGh8
dycgPT4gXCRtYXhXaWR0aCwKICAgICAnbWF4LWhlaWdodHxoJyA9PiBcJG1heEhlaWdodCwgCiAg
ICAgJ3ZlcmJvc2V8dicgPT4gXCR2ZXJib3NlLApAQCAtMTcyLDYgKzE3NCw3IEBAIGZvciBteSAk
dGVzdCAoQHRlc3RzKSB7CiAgICAgICAgIGxvY2FsICVFTlY7CiAgICAgICAgICRFTlZ7RFlMRF9G
UkFNRVdPUktfUEFUSH0gPSAkcHJvZHVjdERpcjsKICAgICAgICAgJEVOVntNYWxsb2NTdGFja0xv
Z2dpbmd9ID0gMSBpZiAkY2hlY2tMZWFrczsKKyAgICAgICAgJEVOVntEWUxEX0lOU0VSVF9MSUJS
QVJJRVN9ID0gIi91c3IvbGliL2xpYmdtYWxsb2MuZHlsaWIiIGlmICRndWFyZE1hbGxvYzsKICAg
ICAgICAgJGR1bXBUb29sUElEID0gb3BlbjIoXCpJTiwgXCpPVVQsICR0b29sLCBAdG9vbEFyZ3Mp
IG9yIGRpZTsKICAgICAgICAgJHRvb2xPcGVuID0gMTsKICAgICB9Cg==
</data>
<flag name="review"
          id="588"
          type_id="1"
          status="+"
          setter="darin"
    />
          </attachment>
      

    </bug>

</bugzilla>