46126 2010-09-20 14:55:23 -0700 Add availableLogicalWidth to RenderBox. 2010-09-20 15:36:27 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 46127 46124 1 hyatt hyatt oldest_to_newest 281834 0 hyatt 2010-09-20 14:55:23 -0700 availableLogicalWidth() needs to be implemented, since percentage padding depends on it. 281855 1 68147 hyatt 2010-09-20 15:28:56 -0700 Created attachment 68147 Patch 281859 2 68147 mitz 2010-09-20 15:31:24 -0700 Comment on attachment 68147 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=68147&action=review > WebCore/rendering/RenderBox.cpp:1739 > + if (style()->blockFlow() == TopToBottomBlockFlow || style()->blockFlow() == BottomToTopBlockFlow) I think you should start considering RenderStyle::blockFlowAxis() or RenderStyle::isVerticalBlockFlow() or something. 281862 3 hyatt 2010-09-20 15:36:27 -0700 Yeah I'll add isVerticalTextFlow() in another patch and fix this. Fixed in r67886. 68147 2010-09-20 15:28:56 -0700 2010-09-20 15:31:23 -0700 Patch patch.txt text/plain 3938 hyatt SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2Nzg4NCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTggQEAKKzIwMTAtMDktMjAgIERhdmlkIEh5YXR0ICA8aHlhdHRAYXBwbGUuY29t PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NjEyNiwgYWRkIGF2YWlsYWJsZUxv Z2ljYWxXaWR0aCgpIHRvIFJlbmRlckJveC4KKyAgICAgICAgCisgICAgICAgICogcmVuZGVyaW5n L1JlbmRlckJsb2NrLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckJsb2NrOjphdmFpbGFi bGVXaWR0aCk6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJCbG9jazo6YXZhaWxhYmxlTG9naWNh bFdpZHRoKToKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyQmxvY2suaDoKKyAgICAgICAgKiBy ZW5kZXJpbmcvUmVuZGVyQm94LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckJveDo6YXZh aWxhYmxlTG9naWNhbFdpZHRoKToKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyQm94Lmg6Cisg ICAgICAgIChXZWJDb3JlOjpSZW5kZXJCb3g6OmF2YWlsYWJsZVdpZHRoKToKKwogMjAxMC0wOS0y MCAgRGF2aWQgSHlhdHQgIDxoeWF0dEBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkg RGFuIEJlcm5zdGVpbi4KSW5kZXg6IFdlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrLmNwcAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBXZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9jay5jcHAJKHJldmlzaW9u IDY3ODYwKQorKysgV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2suY3BwCSh3b3JraW5nIGNv cHkpCkBAIC00MzA1LDcgKzQzMDUsMTUgQEAgaW50IFJlbmRlckJsb2NrOjphdmFpbGFibGVXaWR0 aCgpIGNvbnN0CiAgICAgLy8gSWYgd2UgaGF2ZSBtdWx0aXBsZSBjb2x1bW5zLCB0aGVuIHRoZSBh dmFpbGFibGUgd2lkdGggaXMgcmVkdWNlZCB0byBvdXIgY29sdW1uIHdpZHRoLgogICAgIGlmICho YXNDb2x1bW5zKCkpCiAgICAgICAgIHJldHVybiBkZXNpcmVkQ29sdW1uV2lkdGgoKTsKLSAgICBy ZXR1cm4gY29udGVudFdpZHRoKCk7CisgICAgcmV0dXJuIFJlbmRlckJveDo6YXZhaWxhYmxlV2lk dGgoKTsKK30KKworaW50IFJlbmRlckJsb2NrOjphdmFpbGFibGVMb2dpY2FsV2lkdGgoKSBjb25z dAoreworICAgIC8vIElmIHdlIGhhdmUgbXVsdGlwbGUgY29sdW1ucywgdGhlbiB0aGUgYXZhaWxh YmxlIGxvZ2ljYWwgd2lkdGggaXMgcmVkdWNlZCB0byBvdXIgY29sdW1uIHdpZHRoLgorICAgIGlm IChoYXNDb2x1bW5zKCkpCisgICAgICAgIHJldHVybiBkZXNpcmVkQ29sdW1uV2lkdGgoKTsKKyAg ICByZXR1cm4gUmVuZGVyQm94OjphdmFpbGFibGVMb2dpY2FsV2lkdGgoKTsKIH0KIAogaW50IFJl bmRlckJsb2NrOjpjb2x1bW5HYXAoKSBjb25zdApJbmRleDogV2ViQ29yZS9yZW5kZXJpbmcvUmVu ZGVyQmxvY2suaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9jay5o CShyZXZpc2lvbiA2Nzg2MCkKKysrIFdlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrLmgJKHdv cmtpbmcgY29weSkKQEAgLTExNCw4ICsxMTQsOSBAQCBwdWJsaWM6CiAgICAgdmlydHVhbCBWaXNp YmxlUG9zaXRpb24gcG9zaXRpb25Gb3JQb2ludChjb25zdCBJbnRQb2ludCYpOwogICAgIAogICAg IC8vIEJsb2NrIGZsb3dzIHN1YmNsYXNzIGF2YWlsYWJsZVdpZHRoIHRvIGhhbmRsZSBtdWx0aSBj b2x1bW4gbGF5b3V0IChzaHJpbmtpbmcgdGhlIHdpZHRoIGF2YWlsYWJsZSB0byBjaGlsZHJlbiB3 aGVuIGxheWluZyBvdXQuKQotICAgIHZpcnR1YWwgaW50IGF2YWlsYWJsZVdpZHRoKCkgY29uc3Q7 Ci0gICAgCisgICAgdmlydHVhbCBpbnQgYXZhaWxhYmxlV2lkdGgoKSBjb25zdDsgLy8gRklYTUU6 IFNob3VsZCBiZSBwb3NzaWJsZSB0byByZW1vdmUgdGhpcy4gU2VlIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NjEyNworICAgIHZpcnR1YWwgaW50IGF2YWlsYWJsZUxv Z2ljYWxXaWR0aCgpIGNvbnN0OworCiAgICAgUm9vdElubGluZUJveCogZmlyc3RSb290Qm94KCkg Y29uc3QgeyByZXR1cm4gc3RhdGljX2Nhc3Q8Um9vdElubGluZUJveCo+KGZpcnN0TGluZUJveCgp KTsgfQogICAgIFJvb3RJbmxpbmVCb3gqIGxhc3RSb290Qm94KCkgY29uc3QgeyByZXR1cm4gc3Rh dGljX2Nhc3Q8Um9vdElubGluZUJveCo+KGxhc3RMaW5lQm94KCkpOyB9CiAKSW5kZXg6IFdlYkNv cmUvcmVuZGVyaW5nL1JlbmRlckJveC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9yZW5kZXJp bmcvUmVuZGVyQm94LmNwcAkocmV2aXNpb24gNjc4NjApCisrKyBXZWJDb3JlL3JlbmRlcmluZy9S ZW5kZXJCb3guY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xNzM0LDYgKzE3MzQsMTMgQEAgaW50IFJl bmRlckJveDo6YXZhaWxhYmxlSGVpZ2h0VXNpbmcoY29ucwogICAgIHJldHVybiBjb250YWluaW5n QmxvY2soKS0+YXZhaWxhYmxlSGVpZ2h0KCk7CiB9CiAKK2ludCBSZW5kZXJCb3g6OmF2YWlsYWJs ZUxvZ2ljYWxXaWR0aCgpIGNvbnN0Cit7CisgICAgaWYgKHN0eWxlKCktPmJsb2NrRmxvdygpID09 IFRvcFRvQm90dG9tQmxvY2tGbG93IHx8IHN0eWxlKCktPmJsb2NrRmxvdygpID09IEJvdHRvbVRv VG9wQmxvY2tGbG93KQorICAgICAgICByZXR1cm4gY29udGVudFdpZHRoKCk7CisgICAgcmV0dXJu IGNvbnRlbnRIZWlnaHQoKTsKK30KKwogdm9pZCBSZW5kZXJCb3g6OmNhbGNWZXJ0aWNhbE1hcmdp bnMoKQogewogICAgIGlmIChpc1RhYmxlQ2VsbCgpKSB7CkluZGV4OiBXZWJDb3JlL3JlbmRlcmlu Zy9SZW5kZXJCb3guaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCb3gu aAkocmV2aXNpb24gNjc4NjApCisrKyBXZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCb3guaAkod29y a2luZyBjb3B5KQpAQCAtMjM4LDkgKzIzOCwxMCBAQCBwdWJsaWM6CiAgICAgaW50IGNhbGNQZXJj ZW50YWdlSGVpZ2h0KGNvbnN0IExlbmd0aCYgaGVpZ2h0KTsKIAogICAgIC8vIEJsb2NrIGZsb3dz IHN1YmNsYXNzIGF2YWlsYWJsZVdpZHRoIHRvIGhhbmRsZSBtdWx0aSBjb2x1bW4gbGF5b3V0IChz aHJpbmtpbmcgdGhlIHdpZHRoIGF2YWlsYWJsZSB0byBjaGlsZHJlbiB3aGVuIGxheWluZyBvdXQu KQotICAgIHZpcnR1YWwgaW50IGF2YWlsYWJsZVdpZHRoKCkgY29uc3QgeyByZXR1cm4gY29udGVu dFdpZHRoKCk7IH0KKyAgICB2aXJ0dWFsIGludCBhdmFpbGFibGVXaWR0aCgpIGNvbnN0IHsgcmV0 dXJuIGNvbnRlbnRXaWR0aCgpOyB9IC8vIEZJWE1FOiBJbnZlc3RpZ2F0ZSByZW1vdmluZyBldmVu dHVhbGx5LiBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDYxMjcKICAg ICB2aXJ0dWFsIGludCBhdmFpbGFibGVIZWlnaHQoKSBjb25zdDsKICAgICBpbnQgYXZhaWxhYmxl SGVpZ2h0VXNpbmcoY29uc3QgTGVuZ3RoJikgY29uc3Q7CisgICAgdmlydHVhbCBpbnQgYXZhaWxh YmxlTG9naWNhbFdpZHRoKCkgY29uc3Q7CiAKICAgICB2b2lkIGNhbGNWZXJ0aWNhbE1hcmdpbnMo KTsKIAo=