46122 2010-09-20 14:45:10 -0700 Check endianness with __BIG_ENDIAN in RVCT. 2010-10-24 21:39:33 -0700 1 1 1 Unclassified WebKit Web Template Framework 528+ (Nightly build) Other Other RESOLVED FIXED P2 Normal --- 1 skyul webkit-unassigned commit-queue ddkilzer laszlo.gombos loki oldest_to_newest 281825 0 skyul 2010-09-20 14:45:10 -0700 RVCT defines __BIG_ENDIAN if compiling for a big-endian target. 281827 1 68140 skyul 2010-09-20 14:46:40 -0700 Created attachment 68140 Patch 281829 2 skyul 2010-09-20 14:49:30 -0700 CC'ing Laszlo for review. 288302 3 skyul 2010-10-01 09:47:44 -0700 CC'ing Gabor 298591 4 68140 ddkilzer 2010-10-24 08:49:38 -0700 Comment on attachment 68140 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=68140&action=review r- to update the test > JavaScriptCore/wtf/Platform.h:213 > +#if defined(__ARMEB__) || defined(__BIG_ENDIAN) /* RVCT defines __BIG_ENDIAN */ Please use this instead since it's self-documenting: #if deined(__ARMEB__) || COMPILER(RVCT) && defined(__BIG_ENDIAN) 298709 5 71710 skyul 2010-10-24 20:14:12 -0700 Created attachment 71710 Patch Check COMPILER(RVCT) && defined(__BIG_ENDIAN) 298714 6 71710 ddkilzer 2010-10-24 20:47:38 -0700 Comment on attachment 71710 Patch Thanks! r=me 298725 7 71710 commit-queue 2010-10-24 21:39:27 -0700 Comment on attachment 71710 Patch Clearing flags on attachment: 71710 Committed r70434: <http://trac.webkit.org/changeset/70434> 298726 8 commit-queue 2010-10-24 21:39:33 -0700 All reviewed patches have been landed. Closing bug. 68140 2010-09-20 14:46:40 -0700 2010-10-24 20:14:12 -0700 Patch endian.patch text/plain 1045 skyul SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDY3ODg0KQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTAtMDktMjAgIEt3YW5nIFl1 bCBTZW8gIDxza3l1bEBjb21wYW55MTAwLm5ldD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBDaGVjayBlbmRpYW5uZXNzIHdpdGggX19CSUdfRU5ESUFO IGluIFJWQ1QuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD00NjEyMgorCisgICAgICAgIFJWQ1QgZGVmaW5lcyBfX0JJR19FTkRJQU4gaWYgY29tcGlsaW5n IGZvciBhIGJpZy1lbmRpYW4gdGFyZ2V0LgorCisgICAgICAgICogd3RmL1BsYXRmb3JtLmg6CisK IDIwMTAtMDktMjAgIFBldGVyIFZhcmdhICA8cHZhcmdhQGluZi51LXN6ZWdlZC5odT4KIAogICAg ICAgICBSZXZpZXdlZCBieSBHZW9mZnJleSBHYXJlbi4KSW5kZXg6IEphdmFTY3JpcHRDb3JlL3d0 Zi9QbGF0Zm9ybS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEphdmFTY3JpcHRDb3JlL3d0Zi9QbGF0Zm9ybS5o CShyZXZpc2lvbiA2Nzg1NikKKysrIEphdmFTY3JpcHRDb3JlL3d0Zi9QbGF0Zm9ybS5oCSh3b3Jr aW5nIGNvcHkpCkBAIC0yMTAsNyArMjEwLDcgQEAKICAgICB8fCBkZWZpbmVkKF9BUk1fKQogI2Rl ZmluZSBXVEZfQ1BVX0FSTSAxCiAKLSNpZiBkZWZpbmVkKF9fQVJNRUJfXykKKyNpZiBkZWZpbmVk KF9fQVJNRUJfXykgfHwgZGVmaW5lZChfX0JJR19FTkRJQU4pIC8qIFJWQ1QgZGVmaW5lcyBfX0JJ R19FTkRJQU4gKi8KICNkZWZpbmUgV1RGX0NQVV9CSUdfRU5ESUFOIDEKIAogI2VsaWYgIWRlZmlu ZWQoX19BUk1fRUFCSV9fKSBcCg== 71710 2010-10-24 20:14:12 -0700 2010-10-24 21:39:27 -0700 Patch endian.patch text/plain 1046 skyul SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDcwNDMxKQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTAtMTAtMjQgIEt3YW5nIFl1 bCBTZW8gIDxza3l1bEBjb21wYW55MTAwLm5ldD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBDaGVjayBlbmRpYW5uZXNzIHdpdGggX19CSUdfRU5ESUFO IGluIFJWQ1QuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD00NjEyMgorCisgICAgICAgIFJWQ1QgZGVmaW5lcyBfX0JJR19FTkRJQU4gaWYgY29tcGlsaW5n IGZvciBhIGJpZy1lbmRpYW4gdGFyZ2V0LgorCisgICAgICAgICogd3RmL1BsYXRmb3JtLmg6CisK IDIwMTAtMTAtMjQgIFBhdHJpY2sgR2Fuc3RlcmVyICA8cGFyb2dhQHdlYmtpdC5vcmc+CiAKICAg ICAgICAgVW5yZXZpZXdlZCwgZml4IHR5cG8gb2YgbGFzdCBidWlsZCBmaXguCkluZGV4OiBKYXZh U2NyaXB0Q29yZS93dGYvUGxhdGZvcm0uaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0Q29yZS93 dGYvUGxhdGZvcm0uaAkocmV2aXNpb24gNzA0MzEpCisrKyBKYXZhU2NyaXB0Q29yZS93dGYvUGxh dGZvcm0uaAkod29ya2luZyBjb3B5KQpAQCAtMjEwLDcgKzIxMCw3IEBACiAgICAgfHwgZGVmaW5l ZChfQVJNXykKICNkZWZpbmUgV1RGX0NQVV9BUk0gMQogCi0jaWYgZGVmaW5lZChfX0FSTUVCX18p CisjaWYgZGVmaW5lZChfX0FSTUVCX18pIHx8IChDT01QSUxFUihSVkNUKSAmJiBkZWZpbmVkKF9f QklHX0VORElBTikpCiAjZGVmaW5lIFdURl9DUFVfQklHX0VORElBTiAxCiAKICNlbGlmICFkZWZp bmVkKF9fQVJNX0VBQklfXykgXAo=