46111 2010-09-20 11:53:10 -0700 video-served-as-text.html failing on Windows 2010-10-07 05:10:57 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) PC Windows 7 RESOLVED DUPLICATE 45603 InRadar P2 Normal --- 1 eric.carlson jer.noble aroben oldest_to_newest 281717 0 eric.carlson 2010-09-20 11:53:10 -0700 LayoutTests/http/tests/media/video-served-as-text.html is failing on Windows, eg. http://trac.webkit.org/export/67846/trunk/LayoutTests/http/tests/media/video-served-as-text.html 281803 1 eric.carlson 2010-09-20 14:08:51 -0700 Test skipped in http://trac.webkit.org/changeset/67883. 281810 2 eric.carlson 2010-09-20 14:21:39 -0700 <rdar://problem/8454284> 290717 3 70019 jer.noble 2010-10-06 17:27:48 -0700 Created attachment 70019 Patch 290730 4 70019 darin 2010-10-06 17:58:47 -0700 Comment on attachment 70019 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=70019&action=review > WebCore/platform/graphics/win/QTMovie.cpp:65 > +static bool sDisabledComponents = 0; The “s” prefix here is not WebKit style. I think we were talking about a style like s_disabledComponents for static data members, but I don’t think we planned to use a prefix at all for file-scoped globals. But further, this global does not have to exist outside the disableUnsupportedComponents function. You can just put the static bool in there. > WebCore/platform/graphics/win/QTMovie.cpp:279 > + ComponentDescription components[] = { Code needs a why comment. > WebCore/platform/graphics/win/QTMovie.cpp:287 > + ComponentDescription nullDesc = {'null', 'base', kAppleManufacturer, 0, 0}; > + Component nullComp = FindNextComponent(0, &nullDesc); I would like the code better if there was less Desc and Comp and more Description and Component. > WebCore/platform/graphics/win/QTMovie.cpp:294 > + Component disabledComp = 0; > + while (disabledComp = FindNextComponent(disabledComp, &components[i])) Ditto. 290743 5 jer.noble 2010-10-06 18:21:48 -0700 Actually, I don't much like the way this code is factored either. I'm going to submit a new patch which moves around where some of the implementation lives. 290749 6 jer.noble 2010-10-06 18:33:42 -0700 Embarrassing. This bug is a duplicate of https://bugs.webkit.org/show_bug.cgi?id=45603. The Radar was never updated with the original bugzilla bug. Even more embarrassing, my two different implementations lived in entirely different places. No wonder I didn't like how it was factored! I'm going to obsolete my patch, and hopefully we can all forget this ever happened. 290927 7 aroben 2010-10-07 05:10:57 -0700 *** This bug has been marked as a duplicate of bug 45603 *** 70019 2010-10-06 17:27:48 -0700 2010-10-06 18:35:19 -0700 Patch bug-46111-20101006172718.patch text/plain 2523 jer.noble SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2OTI0NykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTAtMTAtMDYgIEplciBOb2JsZSAgPGplci5ub2JsZUBhcHBsZS5j b20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ2MTExCisgICAgICAgIDxyZGFy Oi8vcHJvYmxlbS84NDU0Mjg0PgorICAgICAgICAKKyAgICAgICAgdmlkZW8tc2VydmVkLWFzLXRl eHQuaHRtbCBmYWlsaW5nIG9uIFdpbmRvd3MKKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNz L3dpbi9RVE1vdmllLmNwcDogRGlzYWJsZSB0ZXh0IGltcG9ydAorICAgICAgICAgICAgY29tcG9u ZW50cyBiZWZvcmUgbG9hZGluZyBhbnkgbWVkaWEuCisKIDIwMTAtMTAtMDYgIEFuZHJlaSBQb3Bl c2N1ICA8YW5kcmVpcEBnb29nbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEplcmVteSBP cmxvdy4KSW5kZXg6IFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvd2luL1FUTW92aWUuY3BwCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvd2luL1FUTW92aWUuY3BwCShy ZXZpc2lvbiA2OTI0NykKKysrIFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvd2luL1FUTW92aWUu Y3BwCSh3b3JraW5nIGNvcHkpCkBAIC02Miw2ICs2Miw3IEBAIHVuaW9uIFVwcFBhcmFtIHsKIAog c3RhdGljIFZlY3RvcjxDRlN0cmluZ1JlZj4qIGdTdXBwb3J0ZWRUeXBlcyA9IDA7CiBzdGF0aWMg U0ludDMyIHF1aWNrVGltZVZlcnNpb24gPSAwOworc3RhdGljIGJvb2wgc0Rpc2FibGVkQ29tcG9u ZW50cyA9IDA7CiAKIGNsYXNzIFFUTW92aWVQcml2YXRlIDogcHVibGljIE5vbmNvcHlhYmxlLCBw dWJsaWMgUVRNb3ZpZVRhc2tDbGllbnQgewogcHVibGljOgpAQCAtNzQsNiArNzUsOCBAQCBwdWJs aWM6CiAgICAgdm9pZCBjcmVhdGVNb3ZpZUNvbnRyb2xsZXIoKTsKICAgICB2b2lkIGNhY2hlTW92 aWVTY2FsZSgpOwogCisgICAgc3RhdGljIHZvaWQgZGlzYWJsZVVuc3VwcG9ydGVkQ29tcG9uZW50 cygpOworCiAgICAgUVRNb3ZpZSogbV9tb3ZpZVdpbjsKICAgICBNb3ZpZSBtX21vdmllOwogICAg IE1vdmllQ29udHJvbGxlciBtX21vdmllQ29udHJvbGxlcjsKQEAgLTEyMyw2ICsxMjYsNyBAQCBR VE1vdmllUHJpdmF0ZTo6UVRNb3ZpZVByaXZhdGUoKQogICAgICwgbV9zY2FsZUNhY2hlZChmYWxz ZSkKICNlbmRpZgogeworICAgIGRpc2FibGVVbnN1cHBvcnRlZENvbXBvbmVudHMoKTsKIH0KIAog UVRNb3ZpZVByaXZhdGU6On5RVE1vdmllUHJpdmF0ZSgpCkBAIC0yNjYsNiArMjcwLDMzIEBAIHZv aWQgUVRNb3ZpZVByaXZhdGU6OmNhY2hlTW92aWVTY2FsZSgpCiAjZW5kaWYKIH0KIAordm9pZCBR VE1vdmllUHJpdmF0ZTo6ZGlzYWJsZVVuc3VwcG9ydGVkQ29tcG9uZW50cygpCit7CisgICAgaWYg KHNEaXNhYmxlZENvbXBvbmVudHMpCisgICAgICAgIHJldHVybjsKKyAgICBzRGlzYWJsZWRDb21w b25lbnRzID0gMTsKKworICAgIENvbXBvbmVudERlc2NyaXB0aW9uIGNvbXBvbmVudHNbXSA9IHsK KyAgICAgICAgeydlYXQgJywgJ1RFWFQnLCAndGV4dCcsIDAsIDB9LCAKKyAgICAgICAgeydlYXQg JywgJ1RYVCAnLCAndGV4dCcsIDAsIDB9LCAgICAgCisgICAgICAgIHsnZWF0ICcsICd1dHh0Jywg J3RleHQnLCAwLCAwfSwgICAKKyAgICAgICAgeydlYXQgJywgJ1RFWFQnLCAndHgzZycsIDAsIDB9 LCAgIAorICAgIH07CisKKyAgICBDb21wb25lbnREZXNjcmlwdGlvbiBudWxsRGVzYyA9IHsnbnVs bCcsICdiYXNlJywga0FwcGxlTWFudWZhY3R1cmVyLCAwLCAwfTsKKyAgICBDb21wb25lbnQgbnVs bENvbXAgPSBGaW5kTmV4dENvbXBvbmVudCgwLCAmbnVsbERlc2MpOworICAgIGlmICghbnVsbENv bXApCisgICAgICAgIHJldHVybjsKKworICAgIHNpemVfdCBudW1Db21wb25lbnRzID0gc2l6ZW9m KGNvbXBvbmVudHMpIC8gc2l6ZW9mKGNvbXBvbmVudHNbMF0pOworICAgIGZvciAoc2l6ZV90IGkg PSAwOyBpIDwgbnVtQ29tcG9uZW50czsgKytpKSB7CisgICAgICAgIENvbXBvbmVudCBkaXNhYmxl ZENvbXAgPSAwOworICAgICAgICB3aGlsZSAoZGlzYWJsZWRDb21wID0gRmluZE5leHRDb21wb25l bnQoZGlzYWJsZWRDb21wLCAmY29tcG9uZW50c1tpXSkpCisgICAgICAgICAgICBDYXB0dXJlQ29t cG9uZW50KGRpc2FibGVkQ29tcCwgbnVsbENvbXApOworICAgIH0KK30KKworCiBRVE1vdmllOjpR VE1vdmllKFFUTW92aWVDbGllbnQqIGNsaWVudCkKICAgICA6IG1fcHJpdmF0ZShuZXcgUVRNb3Zp ZVByaXZhdGUoKSkKIHsK