46104 2010-09-20 11:04:34 -0700 [BREWMP] Handle tab key 2010-09-20 22:25:32 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Other Other RESOLVED FIXED P2 Normal --- 33564 0 skyul webkit-unassigned commit-queue dbates oldest_to_newest 281669 0 skyul 2010-09-20 11:04:34 -0700 In Brew MP, AVK_FUNCTION is the key code for tab. Process AVK_FUNCTION as tab in PlatformKeyboardEvent. 281670 1 68112 skyul 2010-09-20 11:05:52 -0700 Created attachment 68112 Patch 282095 2 68112 dbates 2010-09-20 22:09:50 -0700 Comment on attachment 68112 Patch Looks sane to me. r=me 282096 3 skyul 2010-09-20 22:10:55 -0700 (In reply to comment #2) > (From update of attachment 68112 [details]) > Looks sane to me. > > r=me Would you turn on the cq+ too? 282097 4 dbates 2010-09-20 22:11:50 -0700 (In reply to comment #3) > (In reply to comment #2) > > (From update of attachment 68112 [details] [details]) > > Looks sane to me. > > > > r=me > > Would you turn on the cq+ too? Done. 282100 5 68112 commit-queue 2010-09-20 22:25:27 -0700 Comment on attachment 68112 Patch Clearing flags on attachment: 68112 Committed r67925: <http://trac.webkit.org/changeset/67925> 282101 6 commit-queue 2010-09-20 22:25:32 -0700 All reviewed patches have been landed. Closing bug. 68112 2010-09-20 11:05:52 -0700 2010-09-20 22:25:27 -0700 Patch tab.patch text/plain 1546 skyul SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2Nzg2MikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTcgQEAKKzIwMTAtMDktMjAgIEt3YW5nIFl1bCBTZW8gIDxza3l1bEBjb21wYW55 MTAwLm5ldD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBbQlJFV01QXSBIYW5kbGUgdGFiIGtleQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9NDYxMDQKKworICAgICAgICBJbiBCcmV3IE1QLCBBVktfRlVOQ1RJ T04gaXMgdGhlIGtleSBjb2RlIGZvciB0YWIuCisgICAgICAgIFByb2Nlc3MgQVZLX0ZVTkNUSU9O IGFzIHRhYiBpbiBQbGF0Zm9ybUtleWJvYXJkRXZlbnQuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9i cmV3L1BsYXRmb3JtS2V5Ym9hcmRFdmVudEJyZXcuY3BwOgorICAgICAgICAoV2ViQ29yZTo6a2V5 SWRlbnRpZmllckZvckJyZXdLZXlDb2RlKToKKyAgICAgICAgKFdlYkNvcmU6OndpbmRvd3NLZXlD b2RlRm9yS2V5RXZlbnQpOgorCiAyMDEwLTA5LTIwICBZb25nIExpICA8eW9saUByaW0uY29tPgog CiAgICAgICAgIFJldmlld2VkIGJ5IEFsZXhleSBQcm9za3VyeWFrb3YuCkluZGV4OiBXZWJDb3Jl L3BsYXRmb3JtL2JyZXcvUGxhdGZvcm1LZXlib2FyZEV2ZW50QnJldy5jcHAKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gV2ViQ29yZS9wbGF0Zm9ybS9icmV3L1BsYXRmb3JtS2V5Ym9hcmRFdmVudEJyZXcuY3BwCShy ZXZpc2lvbiA2Nzg1NikKKysrIFdlYkNvcmUvcGxhdGZvcm0vYnJldy9QbGF0Zm9ybUtleWJvYXJk RXZlbnRCcmV3LmNwcAkod29ya2luZyBjb3B5KQpAQCAtOTgsNiArOTgsOCBAQCBzdGF0aWMgU3Ry aW5nIGtleUlkZW50aWZpZXJGb3JCcmV3S2V5Q29kCiAgICAgICAgIHJldHVybiAiUGFnZVVwIjsK ICAgICBjYXNlIEFWS19UWFBHRE9XTjoKICAgICAgICAgcmV0dXJuICJQYWdlRG93biI7CisgICAg Y2FzZSBBVktfRlVOQ1RJT046CisgICAgICAgIHJldHVybiAiVSswMDA5IjsKICAgICBkZWZhdWx0 OgogICAgICAgICByZXR1cm4gU3RyaW5nOjpmb3JtYXQoIlUrJTA0WCIsIHRvQVNDSUlVcHBlcihr ZXlDb2RlKSk7CiAgICAgfQpAQCAtMTMyLDYgKzEzNCw4IEBAIHN0YXRpYyBpbnQgd2luZG93c0tl eUNvZGVGb3JLZXlFdmVudCh1aW4KICAgICAgICAgcmV0dXJuIFZLX0lOU0VSVDsgLy8gKDJEKSBJ TlMga2V5CiAgICAgY2FzZSBBVktfVFhERUxFVEU6CiAgICAgICAgIHJldHVybiBWS19ERUxFVEU7 IC8vICgyRSkgREVMIGtleQorICAgIGNhc2UgQVZLX0ZVTkNUSU9OOgorICAgICAgICByZXR1cm4g VktfVEFCOyAvLyAoMDkpIFRBQiBrZXkKICAgICBkZWZhdWx0OgogICAgICAgICByZXR1cm4gMDsK ICAgICB9Cg==