<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>46103</bug_id>
          
          <creation_ts>2010-09-20 10:53:56 -0700</creation_ts>
          <short_desc>Add explicit --force-patch flag to webkitpy tools</short_desc>
          <delta_ts>2010-09-20 17:12:50 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Other</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Mihai Parparita">mihaip</reporter>
          <assigned_to name="Mihai Parparita">mihaip</assigned_to>
          <cc>abarth</cc>
    
    <cc>commit-queue</cc>
    
    <cc>eric</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>281663</commentid>
    <comment_count>0</comment_count>
    <who name="Mihai Parparita">mihaip</who>
    <bug_when>2010-09-20 10:53:56 -0700</bug_when>
    <thetext>Add explicit --force-patch flag to webkitpy tools</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>281664</commentid>
    <comment_count>1</comment_count>
      <attachid>68111</attachid>
    <who name="Mihai Parparita">mihaip</who>
    <bug_when>2010-09-20 10:55:12 -0700</bug_when>
    <thetext>Created attachment 68111
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>281890</commentid>
    <comment_count>2</comment_count>
      <attachid>68111</attachid>
    <who name="Adam Barth">abarth</who>
    <bug_when>2010-09-20 16:25:18 -0700</bug_when>
    <thetext>Comment on attachment 68111
Patch

okiedokes.  Is there some reason we don&apos;t just force the patch always?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>281923</commentid>
    <comment_count>3</comment_count>
      <attachid>68111</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2010-09-20 17:04:48 -0700</bug_when>
    <thetext>Comment on attachment 68111
Patch

Rejecting patch 68111 from commit-queue.

Failed to run &quot;[&apos;WebKitTools/Scripts/run-webkit-tests&apos;, &apos;--no-launch-safari&apos;, &apos;--exit-after-n-failures=1&apos;, &apos;--wait-for-httpd&apos;, &apos;--quiet&apos;]&quot; exit_code: 1
Running build-dumprendertree
Compiling Java tests
make: Nothing to be done for `default&apos;.
Running tests from /Projects/CommitQueue/LayoutTests
Testing 21322 test cases.
http/tests/security/xssAuditor/object-src-inject.html -&gt; failed

Exiting early after 1 failures. 21026 tests run.
533.25s total testing time

21025 test cases (99%) succeeded
1 test case (&lt;1%) had incorrect layout
34 test cases (&lt;1%) had stderr output

Full output: http://queues.webkit.org/results/4092018</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>281927</commentid>
    <comment_count>4</comment_count>
    <who name="Mihai Parparita">mihaip</who>
    <bug_when>2010-09-20 17:07:14 -0700</bug_when>
    <thetext>Bleh, more flaky tests. websocket/tests/close-on-unload-reference-in-parent.htm failed the first try, http/tests/security/xssAuditor/object-src-inject.html the second. Will land this myself.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>281935</commentid>
    <comment_count>5</comment_count>
      <attachid>68111</attachid>
    <who name="Mihai Parparita">mihaip</who>
    <bug_when>2010-09-20 17:12:44 -0700</bug_when>
    <thetext>Comment on attachment 68111
Patch

Clearing flags on attachment: 68111

Committed r67896: &lt;http://trac.webkit.org/changeset/67896&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>281936</commentid>
    <comment_count>6</comment_count>
    <who name="Mihai Parparita">mihaip</who>
    <bug_when>2010-09-20 17:12:50 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>68111</attachid>
            <date>2010-09-20 10:55:12 -0700</date>
            <delta_ts>2010-09-20 17:12:44 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-46103-20100920105511.patch</filename>
            <type>text/plain</type>
            <size>3369</size>
            <attacher name="Mihai Parparita">mihaip</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv
ZwppbmRleCAxMzQ1MDdjMjdkOWVkOTBkMjA1YzA3MmI5YmI2M2JmNDNmYWQ0ZDE2Li5jMDY2MDFk
NzUxYjgyNDY0MGQyNmM3OWM4NTA3ZmZjOTY2NmY0YmVhIDEwMDY0NAotLS0gYS9XZWJLaXRUb29s
cy9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAK
KzIwMTAtMDktMjAgIE1paGFpIFBhcnBhcml0YSAgPG1paGFpcEBjaHJvbWl1bS5vcmc+CisKKyAg
ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIGV4cGxpY2l0
IC0tZm9yY2UtcGF0Y2ggZmxhZyB0byB3ZWJraXRweSB0b29scworICAgICAgICBodHRwczovL2J1
Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDYxMDMKKyAgICAgICAgCisgICAgICAgIEl0
IHdhc24ndCBvYnZpb3VzIHVudGlsIEkgcmVhZCB0aGUgYXBwbHlwYXRjaC5weSBzb3VyY2UgY29k
ZSB0aGF0CisgICAgICAgIC0tbm9uLWludGVyZmFjdGl2ZSBpbXBsaWVzIHBhc3NpbmcgLS1mb3Jj
ZSB0byBwYXRjaC4gQWRkIC0tZm9yY2UtcGF0Y2gKKyAgICAgICAgYXMgYW4gYWxpYXMgdG8gdGhl
IGZsYWcsIHNvIHRoYXQgdGhpcyBiZWhhdmlvciBpcyBtb3JlIGRpc2NvdmVyYWJsZS4KKworICAg
ICAgICAqIFNjcmlwdHMvd2Via2l0cHkvdG9vbC9zdGVwcy9hcHBseXBhdGNoLnB5OgorICAgICAg
ICAqIFNjcmlwdHMvd2Via2l0cHkvdG9vbC9zdGVwcy9vcHRpb25zLnB5OgorCiAyMDEwLTA5LTIw
ICBBZGFtIFJvYmVuICA8YXJvYmVuQGFwcGxlLmNvbT4KIAogICAgICAgICBNYWtlIFdlYktpdFRl
c3RSdW5uZXIncyB3YWl0LXRvLWR1bXAgd2F0Y2hkb2cgdGltZXIgd29yayBvbiBXaW5kb3dzCmRp
ZmYgLS1naXQgYS9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvc3RlcHMvYXBwbHlw
YXRjaC5weSBiL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9zdGVwcy9hcHBseXBh
dGNoLnB5CmluZGV4IDZjZGVkMjcwZTFmMzkwMmNkZWExOGRlZGQ1YzcyODRmNWUzNmJiNzQuLjMy
N2FjMDljMWUxNDM5MThjMjMyNWEzZGIxZDRlMjljZjg5OWJlYjIgMTAwNjQ0Ci0tLSBhL1dlYktp
dFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9zdGVwcy9hcHBseXBhdGNoLnB5CisrKyBiL1dl
YktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9zdGVwcy9hcHBseXBhdGNoLnB5CkBAIC0z
NSw4ICszNSw5IEBAIGNsYXNzIEFwcGx5UGF0Y2goQWJzdHJhY3RTdGVwKToKICAgICBkZWYgb3B0
aW9ucyhjbHMpOgogICAgICAgICByZXR1cm4gQWJzdHJhY3RTdGVwLm9wdGlvbnMoKSArIFsKICAg
ICAgICAgICAgIE9wdGlvbnMubm9uX2ludGVyYWN0aXZlLAorICAgICAgICAgICAgT3B0aW9ucy5m
b3JjZV9wYXRjaCwKICAgICAgICAgXQogCiAgICAgZGVmIHJ1bihzZWxmLCBzdGF0ZSk6CiAgICAg
ICAgIGxvZygiUHJvY2Vzc2luZyBwYXRjaCAlcyBmcm9tIGJ1ZyAlcy4iICUgKHN0YXRlWyJwYXRj
aCJdLmlkKCksIHN0YXRlWyJwYXRjaCJdLmJ1Z19pZCgpKSkKLSAgICAgICAgc2VsZi5fdG9vbC5j
aGVja291dCgpLmFwcGx5X3BhdGNoKHN0YXRlWyJwYXRjaCJdLCBmb3JjZT1zZWxmLl9vcHRpb25z
Lm5vbl9pbnRlcmFjdGl2ZSkKKyAgICAgICAgc2VsZi5fdG9vbC5jaGVja291dCgpLmFwcGx5X3Bh
dGNoKHN0YXRlWyJwYXRjaCJdLCBmb3JjZT1zZWxmLl9vcHRpb25zLm5vbl9pbnRlcmFjdGl2ZSBv
ciBzZWxmLl9vcHRpb25zLmZvcmNlX3BhdGNoKQpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvU2Ny
aXB0cy93ZWJraXRweS90b29sL3N0ZXBzL29wdGlvbnMucHkgYi9XZWJLaXRUb29scy9TY3JpcHRz
L3dlYmtpdHB5L3Rvb2wvc3RlcHMvb3B0aW9ucy5weQppbmRleCBlN2UzODU1ZmY2ZTViMzY5ZTFl
YTEwZjlmNWJkZDAzM2I0ODMwN2RiLi4zZGMxOTYzOTVkMWY4NjlkYzllYmZjNTc3Y2VhZjY1YjYw
ZDBmZmQ0IDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvc3Rl
cHMvb3B0aW9ucy5weQorKysgYi9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvc3Rl
cHMvb3B0aW9ucy5weQpAQCAtNDMsNiArNDMsNyBAQCBjbGFzcyBPcHRpb25zKG9iamVjdCk6CiAg
ICAgZGVzY3JpcHRpb24gPSBtYWtlX29wdGlvbigiLW0iLCAiLS1kZXNjcmlwdGlvbiIsIGFjdGlv
bj0ic3RvcmUiLCB0eXBlPSJzdHJpbmciLCBkZXN0PSJkZXNjcmlwdGlvbiIsIGhlbHA9IkRlc2Ny
aXB0aW9uIHN0cmluZyBmb3IgdGhlIGF0dGFjaG1lbnQgKGRlZmF1bHQ6IFwicGF0Y2hcIikiKQog
ICAgIGVtYWlsID0gbWFrZV9vcHRpb24oIi0tZW1haWwiLCBhY3Rpb249InN0b3JlIiwgdHlwZT0i
c3RyaW5nIiwgZGVzdD0iZW1haWwiLCBoZWxwPSJFbWFpbCBhZGRyZXNzIHRvIHVzZSBpbiBDaGFu
Z2VMb2dzLiIpCiAgICAgZm9yY2VfY2xlYW4gPSBtYWtlX29wdGlvbigiLS1mb3JjZS1jbGVhbiIs
IGFjdGlvbj0ic3RvcmVfdHJ1ZSIsIGRlc3Q9ImZvcmNlX2NsZWFuIiwgZGVmYXVsdD1GYWxzZSwg
aGVscD0iQ2xlYW4gd29ya2luZyBkaXJlY3RvcnkgYmVmb3JlIGFwcGx5aW5nIHBhdGNoZXMgKHJl
bW92ZXMgbG9jYWwgY2hhbmdlcyBhbmQgY29tbWl0cykiKQorICAgIGZvcmNlX3BhdGNoID0gbWFr
ZV9vcHRpb24oIi0tZm9yY2UtcGF0Y2giLCBhY3Rpb249InN0b3JlX3RydWUiLCBkZXN0PSJmb3Jj
ZV9wYXRjaCIsIGRlZmF1bHQ9RmFsc2UsIGhlbHA9IkZvcmNlZnVsbHkgYXBwbGllcyB0aGUgcGF0
Y2gsIGNvbnRpbnVpbmcgcGFzdCBlcnJvcnMuIikKICAgICBnaXRfY29tbWl0ID0gbWFrZV9vcHRp
b24oIi1nIiwgIi0tZ2l0LWNvbW1pdCIsIGFjdGlvbj0ic3RvcmUiLCBkZXN0PSJnaXRfY29tbWl0
IiwgaGVscD0iT3BlcmF0ZSBvbiBhIGxvY2FsIGNvbW1pdC4gSWYgYSByYW5nZSwgdGhlIGNvbW1p
dHMgYXJlIHNxdWFzaGVkIGludG8gb25lLiBIRUFELi4gb3BlcmF0ZXMgb24gd29ya2luZyBjb3B5
IGNoYW5nZXMgb25seS4iKQogICAgIGxvY2FsX2NvbW1pdCA9IG1ha2Vfb3B0aW9uKCItLWxvY2Fs
LWNvbW1pdCIsIGFjdGlvbj0ic3RvcmVfdHJ1ZSIsIGRlc3Q9ImxvY2FsX2NvbW1pdCIsIGRlZmF1
bHQ9RmFsc2UsIGhlbHA9Ik1ha2UgYSBsb2NhbCBjb21taXQgZm9yIGVhY2ggYXBwbGllZCBwYXRj
aCIpCiAgICAgbm9uX2ludGVyYWN0aXZlID0gbWFrZV9vcHRpb24oIi0tbm9uLWludGVyYWN0aXZl
IiwgYWN0aW9uPSJzdG9yZV90cnVlIiwgZGVzdD0ibm9uX2ludGVyYWN0aXZlIiwgZGVmYXVsdD1G
YWxzZSwgaGVscD0iTmV2ZXIgcHJvbXB0IHRoZSB1c2VyLCBmYWlsIGFzIGZhc3QgYXMgcG9zc2li
bGUuIikK
</data>

          </attachment>
      

    </bug>

</bugzilla>