46097 2010-09-20 08:55:05 -0700 [Qt] Make build work with QT_NO_CURSOR 2010-10-05 08:52:52 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 1 jpetsovits webkit-unassigned oldest_to_newest 281578 0 jpetsovits 2010-09-20 08:55:05 -0700 On Friday I tried building the Qt port with QT_NO_CURSOR because that spares me from adding further #ifdefs to my modified Qt/OpenVG port. Seems to me like nobody has actually tried enabling that define yet. Here's two patches that made my build work. 281581 1 68090 jpetsovits 2010-09-20 08:59:19 -0700 Created attachment 68090 [Qt] Avoid GCC warning when QT_NO_CURSOR is defined For Qt, warnings are errors now, so this also breaks the build. Will add ChangeLog change and bug number on landing. 281582 2 68091 jpetsovits 2010-09-20 09:01:35 -0700 Created attachment 68091 [Qt] Fix obvious build errors Those ones are actual errors, and make it pretty clear that this code has never actually been compiled. Will add ChangeLog and bug number when landing. 281615 3 68090 kling 2010-09-20 09:52:21 -0700 Comment on attachment 68090 [Qt] Avoid GCC warning when QT_NO_CURSOR is defined r=me 289634 4 jpetsovits 2010-10-05 08:45:23 -0700 Committed r69110: <http://trac.webkit.org/changeset/69110> 289640 5 jpetsovits 2010-10-05 08:52:52 -0700 Committed r69111: <http://trac.webkit.org/changeset/69111> 68090 2010-09-20 08:59:19 -0700 2010-09-20 09:52:21 -0700 [Qt] Avoid GCC warning when QT_NO_CURSOR is defined a355b3391820d9fd66679f4a56cceef4948fdac2.patch text/plain 1363 jpetsovits RnJvbSBhMzU1YjMzOTE4MjBkOWZkNjY2NzlmNGE1NmNjZWVmNDk0OGZkYWMyIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKYWtvYiBQZXRzb3ZpdHMgPGpwZXRzb3ZpdHNAcmltLmNvbT4K RGF0ZTogRnJpLCAxNyBTZXAgMjAxMCAxMjo0NzoyNyAtMDQwMApTdWJqZWN0OiBbUEFUQ0hdIDIw MTAtMDktMTcgIEpha29iIFBldHNvdml0cyAgPGpwZXRzb3ZpdHNAcmltLmNvbT4KCiAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCgogICAgICAgIFtRdF0gQXZvaWQgR0NDIHdhcm5p bmcgd2hlbiBRVF9OT19DVVJTT1IgaXMgZGVmaW5lZC4KCiAgICAgICAgY3JlYXRlQ3VzdG9tQ3Vy c29yKCkgaXMgYSBzdGF0aWMgZnVuY3Rpb24gYW5kIG5vdCB1c2VkCiAgICAgICAgaW4gdGhhdCBm aWxlIGlmIFFUX05PX0NVUlNPUiBpcyBkZWZpbmVkLCBzbyByYXRoZXIgdGhhbgogICAgICAgIG1h a2luZyBpdCByZXR1cm4gMCwgaXQgc2hvdWxkIG5vdCBleGlzdCBhbHRvZ2V0aGVyLgoKICAgICAg ICAqIHBsYXRmb3JtL3F0L0N1cnNvclF0LmNwcDoKICAgICAgICAoV2ViQ29yZTo6Y3JlYXRlQ3Vz dG9tQ3Vyc29yKToKLS0tCiBXZWJDb3JlL3BsYXRmb3JtL3F0L0N1cnNvclF0LmNwcCB8ICAgIDYg KystLS0tCiAxIGZpbGVzIGNoYW5nZWQsIDIgaW5zZXJ0aW9ucygrKSwgNCBkZWxldGlvbnMoLSkK CmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRmb3JtL3F0L0N1cnNvclF0LmNwcCBiL1dlYkNvcmUv cGxhdGZvcm0vcXQvQ3Vyc29yUXQuY3BwCmluZGV4IDIyN2I4MGMuLjU4ODM2MDAgMTAwNjQ0Ci0t LSBhL1dlYkNvcmUvcGxhdGZvcm0vcXQvQ3Vyc29yUXQuY3BwCisrKyBiL1dlYkNvcmUvcGxhdGZv cm0vcXQvQ3Vyc29yUXQuY3BwCkBAIC03MiwxNSArNzIsMTMgQEAgQ3Vyc29yJiBDdXJzb3I6Om9w ZXJhdG9yPShjb25zdCBDdXJzb3ImIG90aGVyKQogICAgIHJldHVybiAqdGhpczsKIH0KIAorI2lm bmRlZiBRVF9OT19DVVJTT1IKIHN0YXRpYyBRQ3Vyc29yKiBjcmVhdGVDdXN0b21DdXJzb3IoSW1h Z2UqIGltYWdlLCBjb25zdCBJbnRQb2ludCYgaG90U3BvdCkKIHsKLSNpZm5kZWYgUVRfTk9fQ1VS U09SCiAgICAgSW50UG9pbnQgZWZmZWN0aXZlSG90U3BvdCA9IGRldGVybWluZUhvdFNwb3QoaW1h Z2UsIGhvdFNwb3QpOwogICAgIHJldHVybiBuZXcgUUN1cnNvcigqKGltYWdlLT5uYXRpdmVJbWFn ZUZvckN1cnJlbnRGcmFtZSgpKSwgZWZmZWN0aXZlSG90U3BvdC54KCksIGVmZmVjdGl2ZUhvdFNw b3QueSgpKTsKLSNlbHNlCi0gICAgcmV0dXJuIDA7Ci0jZW5kaWYKIH0KKyNlbmRpZgogCiB2b2lk IEN1cnNvcjo6ZW5zdXJlUGxhdGZvcm1DdXJzb3IoKSBjb25zdAogewotLSAKMS43LjIKCg== 68091 2010-09-20 09:01:35 -0700 2010-09-20 09:53:21 -0700 [Qt] Fix obvious build errors c5d1ddbd822b7a83952bc119784d666ab170a2f1.patch text/plain 1536 jpetsovits RnJvbSBjNWQxZGRiZDgyMmI3YTgzOTUyYmMxMTk3ODRkNjY2YWIxNzBhMmYxIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKYWtvYiBQZXRzb3ZpdHMgPGpwZXRzb3ZpdHNAcmltLmNvbT4K RGF0ZTogRnJpLCAxNyBTZXAgMjAxMCAxMjo1Njo0NyAtMDQwMApTdWJqZWN0OiBbUEFUQ0hdIFdl YkNvcmU6CgoyMDEwLTA5LTE3ICBKYWtvYiBQZXRzb3ZpdHMgIDxqcGV0c292aXRzQHJpbS5jb20+ CgogICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgoKICAgICAgICBGaXggYnVpbGQg d2hlbiBRVF9OT19DVVJTT1IgaXMgZGVmaW5lZC4KCiAgICAgICAgKiBwbGF0Zm9ybS9xdC9RV2Vi UGFnZUNsaWVudC5oOgoKV2ViS2l0L3F0OgoKMjAxMC0wOS0xNyAgSmFrb2IgUGV0c292aXRzICA8 anBldHNvdml0c0ByaW0uY29tPgoKICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K CiAgICAgICAgRml4IGJ1aWxkIHdoZW4gUVRfTk9fQ1VSU09SIGlzIGRlZmluZWQuCgogICAgICAg ICogV2ViQ29yZVN1cHBvcnQvQ2hyb21lQ2xpZW50UXQuY3BwOgogICAgICAgIChXZWJDb3JlOjpD aHJvbWVDbGllbnRRdDo6c2V0Q3Vyc29yKToKLS0tCiBXZWJDb3JlL3BsYXRmb3JtL3F0L1FXZWJQ YWdlQ2xpZW50LmggICAgICAgIHwgICAgMSArCiBXZWJLaXQvcXQvV2ViQ29yZVN1cHBvcnQvQ2hy b21lQ2xpZW50UXQuY3BwIHwgICAgMiArLQogMiBmaWxlcyBjaGFuZ2VkLCAyIGluc2VydGlvbnMo KyksIDEgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wbGF0Zm9ybS9xdC9RV2Vi UGFnZUNsaWVudC5oIGIvV2ViQ29yZS9wbGF0Zm9ybS9xdC9RV2ViUGFnZUNsaWVudC5oCmluZGV4 IGEwYTAyMTguLjI5YmE3M2MgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGxhdGZvcm0vcXQvUVdlYlBh Z2VDbGllbnQuaAorKysgYi9XZWJDb3JlL3BsYXRmb3JtL3F0L1FXZWJQYWdlQ2xpZW50LmgKQEAg LTMwLDYgKzMwLDcgQEAKICNpbmNsdWRlIDxRQ3Vyc29yPgogI2VuZGlmCiAKKyNpbmNsdWRlIDxR UGFsZXR0ZT4KICNpbmNsdWRlIDxRUmVjdD4KIAogUVRfQkVHSU5fTkFNRVNQQUNFCmRpZmYgLS1n aXQgYS9XZWJLaXQvcXQvV2ViQ29yZVN1cHBvcnQvQ2hyb21lQ2xpZW50UXQuY3BwIGIvV2ViS2l0 L3F0L1dlYkNvcmVTdXBwb3J0L0Nocm9tZUNsaWVudFF0LmNwcAppbmRleCBhNWRmZGM3Li5hZmI2 MjY4IDEwMDY0NAotLS0gYS9XZWJLaXQvcXQvV2ViQ29yZVN1cHBvcnQvQ2hyb21lQ2xpZW50UXQu Y3BwCisrKyBiL1dlYktpdC9xdC9XZWJDb3JlU3VwcG9ydC9DaHJvbWVDbGllbnRRdC5jcHAKQEAg LTU2Niw3ICs1NjYsNyBAQCB2b2lkIENocm9tZUNsaWVudFF0OjpzZXRDdXJzb3IoY29uc3QgQ3Vy c29yJiBjdXJzb3IpCiAgICAgICAgIHJldHVybjsKICAgICBwYWdlQ2xpZW50LT5zZXRDdXJzb3Io KmN1cnNvci5wbGF0Zm9ybUN1cnNvcigpKTsKICNlbHNlCi0gICAgVU5VU0VEX1BBUkFNKGN1cnNv cikKKyAgICBVTlVTRURfUEFSQU0oY3Vyc29yKTsKICNlbmRpZgogfQogCi0tIAoxLjcuMgoK