46096 2010-09-20 08:39:59 -0700 Enable ARM VFP on hardware that defines VFP and isn't LINUX 2010-10-25 12:30:31 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Other Other RESOLVED FIXED P2 Normal --- 1 dave+webkit webkit-unassigned commit-queue ddkilzer laszlo.gombos loki staikos webkit.review.bot zherczeg oldest_to_newest 281570 0 dave+webkit 2010-09-20 08:39:59 -0700 The isVFPPresent implementation of MacroAssemblerARM.cpp could take into account the current compiler setting for setting the default of whether a VFP is present or not. 281633 1 68106 dave+webkit 2010-09-20 10:16:24 -0700 Created attachment 68106 Add define to test if VFP is enabled by RVCT compiler 281721 2 zherczeg 2010-09-20 11:57:15 -0700 Would be good to add the same condition for GCC as well. 281723 3 dave+webkit 2010-09-20 11:59:58 -0700 (In reply to comment #2) > Would be good to add the same condition for GCC as well. I'd be happy to add it but do you know what it defines when hardware FPU is set? I couldn't find the appropriate documentation on it. 298585 4 ddkilzer 2010-10-24 08:44:15 -0700 (In reply to comment #3) > (In reply to comment #2) > > Would be good to add the same condition for GCC as well. > > I'd be happy to add it but do you know what it defines when hardware FPU is set? I couldn't find the appropriate documentation on it. It appears that Apple's gcc-4.2 compilers use __VFP_FP__: $ gcc-4.2 -x c -arch armv6 -isysroot /Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS4.2.sdk -dM -E /dev/null | grep -i vfp #define __VFP_FP__ 1 $ gcc-4.2 -x c -arch armv7 -isysroot /Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS4.2.sdk -dM -E /dev/null | grep -i vfp #define __VFP_FP__ 1 298587 5 68106 ddkilzer 2010-10-24 08:45:06 -0700 Comment on attachment 68106 Add define to test if VFP is enabled by RVCT compiler r- to include support for gcc as well. Otherwise this looks good! 298593 6 68106 ddkilzer 2010-10-24 08:53:02 -0700 Comment on attachment 68106 Add define to test if VFP is enabled by RVCT compiler View in context: https://bugs.webkit.org/attachment.cgi?id=68106&action=review > JavaScriptCore/assembler/MacroAssemblerARM.cpp:59 > +#if defined(__TARGET_FPU_VFP) Also, I think you should add compiler checks: #if COMPILER(RVCT) && defined(__TARGET_FPU_VFP) || COMPILER(GCC) && defined(__VFP_FP__) 298821 7 71742 dave+webkit 2010-10-25 06:51:07 -0700 Created attachment 71742 Add GCC defines to VFP present setting 298824 8 webkit.review.bot 2010-10-25 06:52:07 -0700 Attachment 71742 did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 JavaScriptCore/assembler/MacroAssemblerARM.cpp:59: More than one command on the same line in if [whitespace/parens] [4] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 298868 9 71742 ddkilzer 2010-10-25 08:36:50 -0700 Comment on attachment 71742 Add GCC defines to VFP present setting View in context: https://bugs.webkit.org/attachment.cgi?id=71742&action=review Thanks! r=me > JavaScriptCore/assembler/MacroAssemblerARM.cpp:-59 > - Nit: I would leave this blank line in place. 298878 10 71755 dave+webkit 2010-10-25 08:57:45 -0700 Created attachment 71755 Add GCC defines to VFP present setting preserving line 59 298879 11 webkit.review.bot 2010-10-25 08:59:16 -0700 Attachment 71755 did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 JavaScriptCore/assembler/MacroAssemblerARM.cpp:60: More than one command on the same line in if [whitespace/parens] [4] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 298890 12 71755 ddkilzer 2010-10-25 09:05:54 -0700 Comment on attachment 71755 Add GCC defines to VFP present setting preserving line 59 r=me 298987 13 71742 eric 2010-10-25 11:31:39 -0700 Comment on attachment 71742 Add GCC defines to VFP present setting Cleared David Kilzer's review+ from obsolete attachment 71742 so that this bug does not appear in http://webkit.org/pending-commit. 299028 14 commit-queue 2010-10-25 12:27:57 -0700 The commit-queue encountered the following flaky tests while processing attachment 71755: http/tests/appcache/fail-on-update.html Please file bugs against the tests. The author(s) of the test(s) are ap@webkit.org, ap@webkit.org, and ap@webkit.org. The commit-queue is continuing to process your patch. 299031 15 71755 commit-queue 2010-10-25 12:30:24 -0700 Comment on attachment 71755 Add GCC defines to VFP present setting preserving line 59 Clearing flags on attachment: 71755 Committed r70474: <http://trac.webkit.org/changeset/70474> 299032 16 commit-queue 2010-10-25 12:30:31 -0700 All reviewed patches have been landed. Closing bug. 68106 2010-09-20 10:16:24 -0700 2010-10-25 06:51:07 -0700 Add define to test if VFP is enabled by RVCT compiler 46096.txt text/plain 1518 dave+webkit Y29tbWl0IDViMDM0YmQzNWYwOTAwNTQ2N2ZjOWZlZWRiZDViOGM5ZjQxODZiMjgKQXV0aG9yOiBE YXZlIFRhcHVza2EgPGR0YXB1c2thQHJpbS5jb20+CkRhdGU6ICAgTW9uIFNlcCAyMCAxMzoxMjoz MSAyMDEwIC0wNDAwCgogICAgMjAxMC0wOS0yMCAgRGF2ZSBUYXB1c2thICA8ZHRhcHVza2FAcmlt LmNvbT4KICAgIAogICAgICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KICAgIAog ICAgICAgICAgICBFbmFibGUgVkZQIGlmIG91ciBjb21waWxlciBzZXR0aW5ncyBpbmRpY2F0ZWQg d2UgaGFkIGEgaGFyZHdhcmUKICAgICAgICAgICAgVkZQLgogICAgCiAgICAgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NjA5NgogICAgCiAgICAgICAgICAg ICogYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyQVJNLmNwcDoKICAgICAgICAgICAgKEpTQzo6aXNW RlBQcmVzZW50KToKCmRpZmYgLS1naXQgYS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9KYXZh U2NyaXB0Q29yZS9DaGFuZ2VMb2cKaW5kZXggZWZmNjc5MS4uYzMyNGY0YSAxMDA2NDQKLS0tIGEv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCisrKyBiL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwpA QCAtMSwzICsxLDE1IEBACisyMDEwLTA5LTIwICBEYXZpZCBUYXB1c2thICA8ZHRhcHVza2FAcmlt LmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBF bmFibGUgVkZQIGlmIG91ciBjb21waWxlciBzZXR0aW5ncyBpbmRpY2F0ZWQgd2UgaGFkIGEgaGFy ZHdhcmUKKyAgICAgICAgVkZQLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD00NjA5NgorCisgICAgICAgICogYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVy QVJNLmNwcDoKKyAgICAgICAgKEpTQzo6aXNWRlBQcmVzZW50KToKKwogMjAxMC0wOS0yMCAgRGF2 ZSBUYXB1c2thICA8ZHRhcHVza2FAcmltLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9NYWNyb0Fz c2VtYmxlckFSTS5jcHAgYi9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJB Uk0uY3BwCmluZGV4IGI1YjIwZmEuLmVlNGU2YjEgMTAwNjQ0Ci0tLSBhL0phdmFTY3JpcHRDb3Jl L2Fzc2VtYmxlci9NYWNyb0Fzc2VtYmxlckFSTS5jcHAKKysrIGIvSmF2YVNjcmlwdENvcmUvYXNz ZW1ibGVyL01hY3JvQXNzZW1ibGVyQVJNLmNwcApAQCAtNTYsOCArNTYsMTEgQEAgc3RhdGljIGJv b2wgaXNWRlBQcmVzZW50KCkKICAgICAgICAgY2xvc2UoZmQpOwogICAgIH0KICNlbmRpZgotCisj aWYgZGVmaW5lZChfX1RBUkdFVF9GUFVfVkZQKQorICAgIHJldHVybiB0cnVlOworI2Vsc2UKICAg ICByZXR1cm4gZmFsc2U7CisjZW5kaWYKIH0KIAogY29uc3QgYm9vbCBNYWNyb0Fzc2VtYmxlckFS TTo6c19pc1ZGUFByZXNlbnQgPSBpc1ZGUFByZXNlbnQoKTsK 71742 2010-10-25 06:51:07 -0700 2010-10-25 11:31:39 -0700 Add GCC defines to VFP present setting 46096.txt text/plain 1580 dave+webkit Y29tbWl0IDViMDM0YmQzNWYwOTAwNTQ2N2ZjOWZlZWRiZDViOGM5ZjQxODZiMjgKQXV0aG9yOiBE YXZlIFRhcHVza2EgPGR0YXB1c2thQHJpbS5jb20+CkRhdGU6ICAgTW9uIFNlcCAyMCAxMzoxMjoz MSAyMDEwIC0wNDAwCgogICAgMjAxMC0wOS0yMCAgRGF2ZSBUYXB1c2thICA8ZHRhcHVza2FAcmlt LmNvbT4KICAgIAogICAgICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KICAgIAog ICAgICAgICAgICBFbmFibGUgVkZQIGlmIG91ciBjb21waWxlciBzZXR0aW5ncyBpbmRpY2F0ZWQg d2UgaGFkIGEgaGFyZHdhcmUKICAgICAgICAgICAgVkZQLgogICAgCiAgICAgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NjA5NgogICAgCiAgICAgICAgICAg ICogYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyQVJNLmNwcDoKICAgICAgICAgICAgKEpTQzo6aXNW RlBQcmVzZW50KToKCmRpZmYgLS1naXQgYS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9KYXZh U2NyaXB0Q29yZS9DaGFuZ2VMb2cKaW5kZXggZWZmNjc5MS4uYzMyNGY0YSAxMDA2NDQKLS0tIGEv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCisrKyBiL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwpA QCAtMSwzICsxLDE1IEBACisyMDEwLTA5LTIwICBEYXZpZCBUYXB1c2thICA8ZHRhcHVza2FAcmlt LmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBF bmFibGUgVkZQIGlmIG91ciBjb21waWxlciBzZXR0aW5ncyBpbmRpY2F0ZWQgd2UgaGFkIGEgaGFy ZHdhcmUKKyAgICAgICAgVkZQLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD00NjA5NgorCisgICAgICAgICogYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVy QVJNLmNwcDoKKyAgICAgICAgKEpTQzo6aXNWRlBQcmVzZW50KToKKwogMjAxMC0wOS0yMCAgRGF2 ZSBUYXB1c2thICA8ZHRhcHVza2FAcmltLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9NYWNyb0Fz c2VtYmxlckFSTS5jcHAgYi9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJB Uk0uY3BwCmluZGV4IGI1YjIwZmEuLmVlNGU2YjEgMTAwNjQ0Ci0tLSBhL0phdmFTY3JpcHRDb3Jl L2Fzc2VtYmxlci9NYWNyb0Fzc2VtYmxlckFSTS5jcHAKKysrIGIvSmF2YVNjcmlwdENvcmUvYXNz ZW1ibGVyL01hY3JvQXNzZW1ibGVyQVJNLmNwcApAQCAtNTYsOCArNTYsMTEgQEAgc3RhdGljIGJv b2wgaXNWRlBQcmVzZW50KCkKICAgICAgICAgY2xvc2UoZmQpOwogICAgIH0KICNlbmRpZgotCisj aWYgKENPTVBJTEVSKFJWQ1QpICYmIGRlZmluZWQoX19UQVJHRVRfRlBVX1ZGUCkpIHx8IChDT01Q SUxFUihHQ0MpICYmIGRlZmluZWQoX19WRlBfRlBfXykpCisgICAgcmV0dXJuIHRydWU7CisjZWxz ZQogICAgIHJldHVybiBmYWxzZTsKKyNlbmRpZgogfQogCiBjb25zdCBib29sIE1hY3JvQXNzZW1i bGVyQVJNOjpzX2lzVkZQUHJlc2VudCA9IGlzVkZQUHJlc2VudCgpOwo= 71755 2010-10-25 08:57:45 -0700 2010-10-25 12:30:24 -0700 Add GCC defines to VFP present setting preserving line 59 46096.txt text/plain 1579 dave+webkit Y29tbWl0IDViMDM0YmQzNWYwOTAwNTQ2N2ZjOWZlZWRiZDViOGM5ZjQxODZiMjgKQXV0aG9yOiBE YXZlIFRhcHVza2EgPGR0YXB1c2thQHJpbS5jb20+CkRhdGU6ICAgTW9uIFNlcCAyMCAxMzoxMjoz MSAyMDEwIC0wNDAwCgogICAgMjAxMC0wOS0yMCAgRGF2ZSBUYXB1c2thICA8ZHRhcHVza2FAcmlt LmNvbT4KICAgIAogICAgICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KICAgIAog ICAgICAgICAgICBFbmFibGUgVkZQIGlmIG91ciBjb21waWxlciBzZXR0aW5ncyBpbmRpY2F0ZWQg d2UgaGFkIGEgaGFyZHdhcmUKICAgICAgICAgICAgVkZQLgogICAgCiAgICAgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NjA5NgogICAgCiAgICAgICAgICAg ICogYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyQVJNLmNwcDoKICAgICAgICAgICAgKEpTQzo6aXNW RlBQcmVzZW50KToKCmRpZmYgLS1naXQgYS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9KYXZh U2NyaXB0Q29yZS9DaGFuZ2VMb2cKaW5kZXggZWZmNjc5MS4uYzMyNGY0YSAxMDA2NDQKLS0tIGEv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCisrKyBiL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwpA QCAtMSwzICsxLDE1IEBACisyMDEwLTA5LTIwICBEYXZpZCBUYXB1c2thICA8ZHRhcHVza2FAcmlt LmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBF bmFibGUgVkZQIGlmIG91ciBjb21waWxlciBzZXR0aW5ncyBpbmRpY2F0ZWQgd2UgaGFkIGEgaGFy ZHdhcmUKKyAgICAgICAgVkZQLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD00NjA5NgorCisgICAgICAgICogYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVy QVJNLmNwcDoKKyAgICAgICAgKEpTQzo6aXNWRlBQcmVzZW50KToKKwogMjAxMC0wOS0yMCAgRGF2 ZSBUYXB1c2thICA8ZHRhcHVza2FAcmltLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9NYWNyb0Fz c2VtYmxlckFSTS5jcHAgYi9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJB Uk0uY3BwCmluZGV4IGI1YjIwZmEuLmVlNGU2YjEgMTAwNjQ0Ci0tLSBhL0phdmFTY3JpcHRDb3Jl L2Fzc2VtYmxlci9NYWNyb0Fzc2VtYmxlckFSTS5jcHAKKysrIGIvSmF2YVNjcmlwdENvcmUvYXNz ZW1ibGVyL01hY3JvQXNzZW1ibGVyQVJNLmNwcApAQCAtNTYsNyArNTYsMTEgQEAgc3RhdGljIGJv b2wgaXNWRlBQcmVzZW50KCkKICAgICAgICAgY2xvc2UoZmQpOwogICAgIH0KICNlbmRpZgogCisj aWYgKENPTVBJTEVSKFJWQ1QpICYmIGRlZmluZWQoX19UQVJHRVRfRlBVX1ZGUCkpIHx8IChDT01Q SUxFUihHQ0MpICYmIGRlZmluZWQoX19WRlBfRlBfXykpCisgICAgcmV0dXJuIHRydWU7CisjZWxz ZQogICAgIHJldHVybiBmYWxzZTsKKyNlbmRpZgogfQogCiBjb25zdCBib29sIE1hY3JvQXNzZW1i bGVyQVJNOjpzX2lzVkZQUHJlc2VudCA9IGlzVkZQUHJlc2VudCgpOw==