46088 2010-09-20 07:46:36 -0700 Style update error by autofocus processing in recalcStyle() 2011-06-02 19:54:41 -0700 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) All All RESOLVED FIXED http://dev.deeptechinc.com/sidney/share/webkit_autofocus_autofill/ P1 Major --- 1 s+webkit webkit-unassigned abarth adele ap bharathwaaj.s bolinfest cfleizach dglazkov johan martin michelangelo mihaip mitz musicisair paulirish tkent webkit.review.bot oldest_to_newest 281535 0 s+webkit 2010-09-20 07:46:36 -0700 This bug is reproducible under a strange set of conditions. It's in the Safari 5.0.2 release. If a form has `autofocus` on an input, the focus rings do not display on that page and autofill does not happen as long as: - The page has an external style sheet (`<link>` or `@import`) - You did not visit the page directly from a link (the bug *does* appear after a reload or navigating to the URL manually) - You did not visit the page using the back button. The bug goes away the first time you mouse down on a button or link. See the URL for a demo. 281536 1 s+webkit 2010-09-20 07:48:09 -0700 Forgot to mention: because the bug doesn't reproduce on a page visited from a link, reload the demo page to see it in action. 301695 2 72317 martin 2010-10-29 05:08:58 -0700 Created attachment 72317 Self-contained demonstration of the bug. I think I have come across the same bug, but in another form. The stylesheet does not need to be external. Not only does the focus-ring not show, but hidden elements, that you try to show using javascript, doesn't get displayed, before you hover over an element that has a :hover pseudoclass style. I have made an example that is self-contained and doesn't use an external stylesheet. 334053 3 mihaip 2011-01-13 17:37:44 -0800 This was also reported as http://crbug.com/69607, and has a possibly better test-case at http://bolinfest.com/webkit/chrome8bug.html. Also cc-ing the author of autofocus support (from http://trac.webkit.org/changeset/34626). 336374 4 tkent 2011-01-19 00:50:02 -0800 http://crbug.com/65695 also looks the same issue. Style recalc or repainting is blocked? 337085 5 tkent 2011-01-19 20:30:24 -0800 (In reply to comment #4) > Style recalc or repainting is blocked? I found :focus style is not applied to the element with autofocus. Document::recalcStyle() is called after setFocusedNode(), but CSSStyleSelector::SelectorChecker::checkOneSelector() for the element is not called. 337133 6 tkent 2011-01-19 22:26:00 -0800 ok, probably I understand. When an external stylesheet is linked or a sub-tree with autofocus is shown, an input element with autofocus is attached in Element::recalcStyle(). HTMLFormControlElement::attach() calls focus(), and focus() tries to call recalcStyle() to apply :focus style, but the latter recalStyle() is skipped because we are already in recalcStyle(). 337212 7 79569 tkent 2011-01-20 02:39:22 -0800 Created attachment 79569 Patch 340083 8 dglazkov 2011-01-25 18:39:30 -0800 It seems wrong to need an extra message loop cycle to get this right. 344871 9 musicisair 2011-02-03 11:25:54 -0800 Here is another test case for this bug: http://test.vervestudios.co/test.html To reproduced the bug in Webkit: 1. Focus your browser's address bar and press enter. 2. Hover over any button to see that its background-color will not change. 3. Try clicking a button. Hm, the style doesn't change. 4. Press F5 5. Now try hovering over a button. Viola! It works. so does clicking it. So, what triggers this bug? - An external stylesheet (even if it is empty). - An input[type=text] (or just <input>) with the [autofocus] attribute - A button - Both the text-input and button need to be inside the same containing element (and <body> won't trigger the bug) Some interesting stuff: - The buttons' onclick, onmouseover, etc. events are fired even when bug is present. - If you use javascript to edit a className the styles won't update. - In certain circumstances, if you hover over an anchor link the bug disappears. I haven't been able to reproduce this in a reduced test-case. (corresponding bug ion webkit's bug-tracker says that the anchor needs a :hover style...I haven't tried it though) 353625 10 82969 bharathwaaj.s 2011-02-18 09:22:29 -0800 Created attachment 82969 Patch 353626 11 webkit.review.bot 2011-02-18 09:25:17 -0800 Attachment 82969 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast..." exit_code: 1 Source/WebCore/html/HTMLFormControlElement.cpp:125: Declaration has space between type name and * in HTMLFormControlElement *control [whitespace/declaration] [3] Source/WebCore/html/HTMLFormControlElement.cpp:147: One line control clauses should not use braces. [whitespace/braces] [4] Source/WebCore/ChangeLog:9: Line contains tab character. [whitespace/tab] [5] Total errors found: 3 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style. 353628 12 82970 bharathwaaj.s 2011-02-18 09:30:48 -0800 Created attachment 82970 Fixed webkit coding style. 353993 13 bharathwaaj.s 2011-02-18 19:19:14 -0800 I don't know why it is failing to apply in efl-ews bot. 353996 14 abarth 2011-02-18 19:22:09 -0800 fatal: Unable to create '/mnt/eflews/git/webkit/.git/index.lock': File exists. Looks like the efl ews bot has a git lock problem. I wouldn't worry about it. 354020 15 82970 tkent 2011-02-18 19:40:10 -0800 Comment on attachment 82970 Fixed webkit coding style. queuePostAttachCallback() looks better. However I shouldn't set review+ because the patch is based on my code :-D 356834 16 82970 eric 2011-02-24 03:12:22 -0800 Comment on attachment 82970 Fixed webkit coding style. View in context: https://bugs.webkit.org/attachment.cgi?id=82970&action=review > Source/WebCore/html/HTMLFormControlElement.cpp:146 > + queuePostAttachCallback(updateAutoFocusCallback, this); post attach callbacks are the work of the devil! :( 356932 17 bharathwaaj.s 2011-02-24 06:30:39 -0800 (In reply to comment #16) > (From update of attachment 82970 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=82970&action=review > > > Source/WebCore/html/HTMLFormControlElement.cpp:146 > > + queuePostAttachCallback(updateAutoFocusCallback, this); > > post attach callbacks are the work of the devil! :( Thank you for the comment. I will come up with another solution. But can you please help me understand why it is not advisable to use queuePostAttachCallback? I would like to learn so that I don't repeat this in the future. 364852 18 tkent 2011-03-09 16:06:50 -0800 *** Bug 55063 has been marked as a duplicate of this bug. *** 376936 19 tkent 2011-03-30 21:38:33 -0700 *** Bug 57431 has been marked as a duplicate of this bug. *** 376937 20 tkent 2011-03-30 21:39:52 -0700 According to Bug 57431, this autofocus problem causes a crash. Raise to P1. 407787 21 tkent 2011-05-23 00:07:04 -0700 This was fixed by another similar patch in another bug. https://trac.webkit.org/changeset/86976 414394 22 s+webkit 2011-06-02 13:31:51 -0700 "Self-contained demonstration of the bug." still does not work properly. Is that the same bug or a different one? 414593 23 tkent 2011-06-02 18:28:05 -0700 (In reply to comment #22) > "Self-contained demonstration of the bug." still does not work properly. Is that the same bug or a different one? I worked on Google Chrome 13.0.782.1 (WebKit r87771). 414615 24 s+webkit 2011-06-02 19:54:41 -0700 (In reply to comment #23) > (In reply to comment #22) > > "Self-contained demonstration of the bug." still does not work properly. Is that the same bug or a different one? > > I worked on Google Chrome 13.0.782.1 (WebKit r87771). Oh. Brain fart, I was in Chrome 11 (r86024). Looking good here too! Thanks :) . 72317 2010-10-29 05:08:58 -0700 2010-10-29 05:08:58 -0700 Self-contained demonstration of the bug. index.html text/html 846 martin PCFET0NUWVBFIGh0bWwgUFVCTElDICItLy9XM0MvL0RURCBYSFRNTCAxLjAgVHJhbnNpdGlvbmFs Ly9FTiIgImh0dHA6Ly93d3cudzMub3JnL1RSL3hodG1sMS9EVEQveGh0bWwxLXRyYW5zaXRpb25h bC5kdGQiPgo8aHRtbCB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMTk5OS94aHRtbCIgeG1sOmxh bmc9ImVuIiBsYW5nPSJlbiI+CjxoZWFkPgogIDxtZXRhIGh0dHAtZXF1aXY9IkNvbnRlbnQtVHlw ZSIgY29udGVudD0idGV4dC9odG1sOyBjaGFyc2V0PXV0Zi04IiAvPgogIDx0aXRsZT5XZWJraXQg YXV0b2ZvY3VzIGJ1ZzwvdGl0bGU+CjxzdHlsZSB0eXBlPSJ0ZXh0L2NzcyIgbWVkaWE9InNjcmVl biI+CiAgICBhOmhvdmVyIHsgY29sb3I6ICNjY2M7IH0KICAgIC5wb3Age2Rpc3BsYXk6bm9uZTt9 Cjwvc3R5bGU+CjwvaGVhZD4KPGJvZHk+CiAgPGJ1dHRvbiBvbmNsaWNrPSJkb2N1bWVudC5nZXRF bGVtZW50QnlJZCgncG9wdXAnKS5zdHlsZS5kaXNwbGF5ID0gJ2Jsb2NrJzsiPk9wZW4gcG9wdXA8 L2J1dHRvbj4KCjxkaXYgY2xhc3M9InBvcCIgaWQ9InBvcHVwIj4KICA8ZGl2PgogICAgPGJ1dHRv biBvbmNsaWNrPSJkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgndGVzdCcpLnN0eWxlLmRpc3BsYXkg PSAnYmxvY2snOyI+U2hvdyBpdCE8L2J1dHRvbj4KICAgIDxkaXYgaWQ9InRlc3QiIHN0eWxlPSJk aXNwbGF5Om5vbmU7Ij5Ob3cgeW91IHNlZSBtZSE8L2Rpdj4KICAgIDxiciAvPgogICAgPGlucHV0 IGF1dG9mb2N1cz0idHJ1ZSIgdHlwZT0idGV4dCIgLz4KICA8L2Rpdj4KCiAgPGJyIC8+CiAgPGEg aHJlZj0iIyI+SG92ZXIgaGVyZTwvYT4KPC9kaXY+Cgo8L2JvZHk+CjwvaHRtbD4K 79569 2011-01-20 02:39:22 -0800 2011-02-18 19:40:29 -0800 Patch bug-46088-20110120193920.patch text/plain 6469 tkent ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBhZWM1ZTY1ZTk0N2E0MzJhMGNkOGQwZjIzNTIzZmY4ODE4M2MxZTk5Li4yY2ZhZDRh NjE5ZWJiNTZlNjg1MmFmY2YwYzc3NmE0ZWExOGEwY2I3IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAK KzIwMTEtMDEtMjAgIEtlbnQgVGFtdXJhICA8dGtlbnRAY2hyb21pdW0ub3JnPgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFN0eWxlIHVwZGF0ZSBlcnJv ciBieSBhdXRvZm9jdXMgcHJvY2Vzc2luZyBpbiByZWNhbGNTdHlsZSgpCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NjA4OAorCisgICAgICAgICogZmFz dC9mb3Jtcy9hdXRvZm9jdXMtaW4tYXR0YWNoLWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAg ICogZmFzdC9mb3Jtcy9hdXRvZm9jdXMtaW4tYXR0YWNoLmh0bWw6IEFkZGVkLgorCiAyMDExLTAx LTE5ICBBbmRyZXkgS29zeWFrb3YgIDxjYXNlcUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2 aWV3ZWQgYnkgWXVyeSBTZW1pa2hhdHNreS4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3Qv Zm9ybXMvYXV0b2ZvY3VzLWluLWF0dGFjaC1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9mYXN0 L2Zvcm1zL2F1dG9mb2N1cy1pbi1hdHRhY2gtZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAw NjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLmNjMDA3 OWMwZDFmMzU2NDc3NWEyOWM0OWQ2MmIxZjNjZjdkODY3ZWMKLS0tIC9kZXYvbnVsbAorKysgYi9M YXlvdXRUZXN0cy9mYXN0L2Zvcm1zL2F1dG9mb2N1cy1pbi1hdHRhY2gtZXhwZWN0ZWQudHh0CkBA IC0wLDAgKzEsOCBAQAorVGVzdCBpZiA6Zm9jdXMgaXMgY29ycmVjdGx5IGFwcGxpZWQgdG8gYW4g ZWxlbWVudCB3aXRoIGF1dG9mb2N1cy4gVGhlIGVsZW1lbnQgaXMgc2hvd24gZHVyaW5nIHN0eWxl IGNhbGN1bGF0aW9uLgorCitPbiBzdWNjZXNzLCB5b3Ugd2lsbCBzZWUgYSBzZXJpZXMgb2YgIlBB U1MiIG1lc3NhZ2VzLCBmb2xsb3dlZCBieSAiVEVTVCBDT01QTEVURSIuCisKKworUEFTUyBiYWNr Z3JvdW5kT2YoaW5wdXQpIGlzIGZvY3VzQ29sb3IKK1RFU1QgQ09NUExFVEUKKwpkaWZmIC0tZ2l0 IGEvTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9hdXRvZm9jdXMtaW4tYXR0YWNoLmh0bWwgYi9MYXlv dXRUZXN0cy9mYXN0L2Zvcm1zL2F1dG9mb2N1cy1pbi1hdHRhY2guaHRtbApuZXcgZmlsZSBtb2Rl IDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi5h MWIzZmE3MjcwMzQ0ZGEyMjQ5N2NjOGM3YWYzMGYwYTZiYTdjYjBmCi0tLSAvZGV2L251bGwKKysr IGIvTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9hdXRvZm9jdXMtaW4tYXR0YWNoLmh0bWwKQEAgLTAs MCArMSw0NiBAQAorPCFET0NUWVBFIEhUTUwgUFVCTElDICItLy9JRVRGLy9EVEQgSFRNTC8vRU4i PgorPGh0bWw+Cis8aGVhZD4KKzxsaW5rIHJlbD0ic3R5bGVzaGVldCIgaHJlZj0iLi4vLi4vZmFz dC9qcy9yZXNvdXJjZXMvanMtdGVzdC1zdHlsZS5jc3MiPgorPHN0eWxlPgorI3BhcmVudCB7Cisg ICAgZGlzcGxheTogbm9uZTsKK30KKzpmb2N1cyB7CisgICAgYmFja2dyb3VuZC1jb2xvcjogcmdi KDAsIDI1NSwgMCk7Cit9Cis8L3N0eWxlPgorPHNjcmlwdCBzcmM9Ii4uLy4uL2Zhc3QvanMvcmVz b3VyY2VzL2pzLXRlc3QtcHJlLmpzIj48L3NjcmlwdD4KKzwvaGVhZD4KKzxib2R5PgorPHAgaWQ9 ImRlc2NyaXB0aW9uIj48L3A+Cis8ZGl2IGlkPSJjb25zb2xlIj48L2Rpdj4KKzxkaXYgaWQ9InBh cmVudCI+Cis8aW5wdXQgYXV0b2ZvY3VzPgorPC9kaXY+Cis8c2NyaXB0PgorZGVzY3JpcHRpb24o J1Rlc3QgaWYgOmZvY3VzIGlzIGNvcnJlY3RseSBhcHBsaWVkIHRvIGFuIGVsZW1lbnQgd2l0aCBh dXRvZm9jdXMuIFRoZSBlbGVtZW50IGlzIHNob3duIGR1cmluZyBzdHlsZSBjYWxjdWxhdGlvbi4n KTsKKworZnVuY3Rpb24gYmFja2dyb3VuZE9mKGVsKSB7CisgICAgcmV0dXJuIGRvY3VtZW50LmRl ZmF1bHRWaWV3LmdldENvbXB1dGVkU3R5bGUoZWwsIG51bGwpLmdldFByb3BlcnR5VmFsdWUoJ2Jh Y2tncm91bmQtY29sb3InKTsKK30KKworZnVuY3Rpb24gY2hlY2soKSB7CisgICAgc2hvdWxkQmUo J2JhY2tncm91bmRPZihpbnB1dCknLCAnZm9jdXNDb2xvcicpOworICAgIGRlYnVnKCdURVNUIENP TVBMRVRFJyk7CisgICAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ3BhcmVudCcpLnN0eWxlLmRp c3BsYXkgPSAnbm9uZSc7CisgICAgaWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikKKyAg ICAgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIubm90aWZ5RG9uZSgpOworfQorCit2YXIgZm9jdXND b2xvciA9ICdyZ2IoMCwgMjU1LCAwKSc7Cit2YXIgaW5wdXQgPSBkb2N1bWVudC5nZXRFbGVtZW50 c0J5VGFnTmFtZSgnaW5wdXQnKVswXTsKKworaWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxl cikKKyAgICBsYXlvdXRUZXN0Q29udHJvbGxlci53YWl0VW50aWxEb25lKCk7CisKK2RvY3VtZW50 LmdldEVsZW1lbnRCeUlkKCdwYXJlbnQnKS5zdHlsZS5kaXNwbGF5ID0gJ2Jsb2NrJzsKK3NldFRp bWVvdXQoY2hlY2ssIDApOworPC9zY3JpcHQ+Cis8L2JvZHk+Cis8L2h0bWw+CmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5k ZXggNTZkMjRiM2Q3Y2Q1ZjA0NjNkYzZmNDFjZDllMGI3ZWQ1NGRjNmE0Ny4uY2NlNGZhYTdiNDBm ZjI4NzMzN2E0MWU0OWZkMjVjOGY2NWVlYmNiMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv Q2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBA CisyMDExLTAxLTIwICBLZW50IFRhbXVyYSAgPHRrZW50QGNocm9taXVtLm9yZz4KKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTdHlsZSB1cGRhdGUgZXJy b3IgYnkgYXV0b2ZvY3VzIHByb2Nlc3NpbmcgaW4gcmVjYWxjU3R5bGUoKQorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDYwODgKKworICAgICAgICBTdHls ZSB1cGRhdGUgYnkgYXV0b2ZvY3VzIGF0dHJpYnV0ZSB3YXMgbm90IGhhbmRsZWQgaWYgdGhlIGRv Y3VtZW50IGhhZAorICAgICAgICBhbiBleHRlcm5hbCBzdHlsZXNoZWV0IG9yIHRoZSBlbGVtZW50 IHdhcyBhdHRhY2hlZCBieSByZWNhbGNTdHlsZSgpIG9mCisgICAgICAgIGFub3RoZXIgZWxlbWVu dCBiZWNhdXNlIHJlY2FsY1N0eWxlKCkgZG9lc24ndCBhc3N1bWUgYXR0YWNoKCkgdXBkYXRlcwor ICAgICAgICB0aGUgc3R5bGUgYW5kIHJlY2FsY1N0eWxlKCkgcmVqZWN0cyByZS1lbnRyYW5jZS4K KworICAgICAgICBUZXN0OiBmYXN0L2Zvcm1zL2F1dG9mb2N1cy1pbi1hdHRhY2guaHRtbAorCisg ICAgICAgICogaHRtbC9IVE1MRm9ybUNvbnRyb2xFbGVtZW50LmNwcDoKKyAgICAgICAgKFdlYkNv cmU6OkF1dG9mb2N1c1Rhc2s6OmNyZWF0ZSk6CisgICAgICAgIChXZWJDb3JlOjpBdXRvZm9jdXNU YXNrOjpBdXRvZm9jdXNUYXNrKToKKyAgICAgICAgKFdlYkNvcmU6OkF1dG9mb2N1c1Rhc2s6OnBl cmZvcm1UYXNrKToKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxGb3JtQ29udHJvbEVsZW1lbnQ6OmF0 dGFjaCk6IENhbGxzIGZvY3VzKCkgbGF0ZXIgYnkgQXV0b2ZvY3VzVGFzay4KKwogMjAxMS0wMS0x OSAgRG9taW5pYyBDb29uZXkgIDxkb21pbmljY0Bnb29nbGUuY29tPgogCiAgICAgICAgIFJldmll d2VkIGJ5IEtlbnQgVGFtdXJhLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1M Rm9ybUNvbnRyb2xFbGVtZW50LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTEZvcm1Db250 cm9sRWxlbWVudC5jcHAKaW5kZXggYmI0MmRmZDdmODEwMjI2ZjQzODA3NTRlZmQxOWY0OWQ0MGJh YTNiYS4uZTEyMWZkYWI2MDY5YjVkNjNlM2U0OTExM2ZmMDYwN2IyNDE4Y2FjZSAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MRm9ybUNvbnRyb2xFbGVtZW50LmNwcAorKysgYi9T b3VyY2UvV2ViQ29yZS9odG1sL0hUTUxGb3JtQ29udHJvbEVsZW1lbnQuY3BwCkBAIC0xMTksNiAr MTE5LDI2IEBAIHZvaWQgSFRNTEZvcm1Db250cm9sRWxlbWVudDo6cGFyc2VNYXBwZWRBdHRyaWJ1 dGUoQXR0cmlidXRlKiBhdHRyKQogICAgIHNldE5lZWRzV2lsbFZhbGlkYXRlQ2hlY2soKTsKIH0K IAorY2xhc3MgQXV0b2ZvY3VzVGFzayA6IHB1YmxpYyBTY3JpcHRFeGVjdXRpb25Db250ZXh0OjpU YXNrIHsKK3B1YmxpYzoKKyAgICBzdGF0aWMgUGFzc093blB0cjxBdXRvZm9jdXNUYXNrPiBjcmVh dGUoSFRNTEZvcm1Db250cm9sRWxlbWVudCogZWxlbWVudCkgeyByZXR1cm4gbmV3IEF1dG9mb2N1 c1Rhc2soZWxlbWVudCk7IH0KKworcHJpdmF0ZToKKyAgICBBdXRvZm9jdXNUYXNrKEhUTUxGb3Jt Q29udHJvbEVsZW1lbnQqIGVsZW1lbnQpIDogbV9lbGVtZW50KGVsZW1lbnQpIHsgfQorCisgICAg dmlydHVhbCB2b2lkIHBlcmZvcm1UYXNrKFNjcmlwdEV4ZWN1dGlvbkNvbnRleHQqKQorICAgIHsK KyAgICAgICAgYm9vbCBpc0lucHV0VHlwZUhpZGRlbiA9IGZhbHNlOworICAgICAgICBpZiAobV9l bGVtZW50LT5oYXNUYWdOYW1lKGlucHV0VGFnKSkKKyAgICAgICAgICAgIGlzSW5wdXRUeXBlSGlk ZGVuID0gc3RhdGljX2Nhc3Q8SFRNTElucHV0RWxlbWVudCo+KG1fZWxlbWVudC5nZXQoKSktPmlz SW5wdXRUeXBlSGlkZGVuKCk7CisKKyAgICAgICAgaWYgKG1fZWxlbWVudC0+YXV0b2ZvY3VzKCkg JiYgbV9lbGVtZW50LT5yZW5kZXJlcigpICYmICFtX2VsZW1lbnQtPmlzUmVhZE9ubHlGb3JtQ29u dHJvbCgpICYmICFpc0lucHV0VHlwZUhpZGRlbikKKyAgICAgICAgICAgIG1fZWxlbWVudC0+Zm9j dXMoKTsKKyAgICB9CisKKyAgICBSZWZQdHI8SFRNTEZvcm1Db250cm9sRWxlbWVudD4gbV9lbGVt ZW50OworfTsKKwogdm9pZCBIVE1MRm9ybUNvbnRyb2xFbGVtZW50OjphdHRhY2goKQogewogICAg IEFTU0VSVCghYXR0YWNoZWQoKSk7CkBAIC0xMzAsMTggKzE1MCwxMiBAQCB2b2lkIEhUTUxGb3Jt Q29udHJvbEVsZW1lbnQ6OmF0dGFjaCgpCiAgICAgLy8gb24gdGhlIHJlbmRlcmVyLgogICAgIGlm IChyZW5kZXJlcigpKQogICAgICAgICByZW5kZXJlcigpLT51cGRhdGVGcm9tRWxlbWVudCgpOwot ICAgICAgICAKLSAgICAvLyBGb2N1cyB0aGUgZWxlbWVudCBpZiBpdCBzaG91bGQgaG9ub3VyIGl0 cyBhdXRvZm9jdXMgYXR0cmlidXRlLgotICAgIC8vIFdlIGhhdmUgdG8gZGV0ZXJtaW5lIGlmIHRo ZSBlbGVtZW50IGlzIGEgVGV4dEFyZWEvSW5wdXQvQnV0dG9uL1NlbGVjdCwKLSAgICAvLyBpZiBp bnB1dCB0eXBlIGhpZGRlbiBpZ25vcmUgYXV0b2ZvY3VzLiBTbyBpZiBkaXNhYmxlZCBvciByZWFk b25seS4KLSAgICBib29sIGlzSW5wdXRUeXBlSGlkZGVuID0gZmFsc2U7Ci0gICAgaWYgKGhhc1Rh Z05hbWUoaW5wdXRUYWcpKQotICAgICAgICBpc0lucHV0VHlwZUhpZGRlbiA9IHN0YXRpY19jYXN0 PEhUTUxJbnB1dEVsZW1lbnQqPih0aGlzKS0+aXNJbnB1dFR5cGVIaWRkZW4oKTsKLQotICAgIGlm IChhdXRvZm9jdXMoKSAmJiByZW5kZXJlcigpICYmICFkb2N1bWVudCgpLT5pZ25vcmVBdXRvZm9j dXMoKSAmJiAhaXNSZWFkT25seUZvcm1Db250cm9sKCkgJiYKLSAgICAgICAgICAgICgoaGFzVGFn TmFtZShpbnB1dFRhZykgJiYgIWlzSW5wdXRUeXBlSGlkZGVuKSB8fCBoYXNUYWdOYW1lKHNlbGVj dFRhZykgfHwKLSAgICAgICAgICAgICAgaGFzVGFnTmFtZShidXR0b25UYWcpIHx8IGhhc1RhZ05h bWUodGV4dGFyZWFUYWcpKSkKLSAgICAgICAgIGZvY3VzKCk7CisKKyAgICBpZiAoIWRvY3VtZW50 KCktPmlnbm9yZUF1dG9mb2N1cygpICYmIChoYXNUYWdOYW1lKGlucHV0VGFnKSB8fCBoYXNUYWdO YW1lKHNlbGVjdFRhZykgfHwgaGFzVGFnTmFtZShidXR0b25UYWcpIHx8IGhhc1RhZ05hbWUodGV4 dGFyZWFUYWcpKSkgeworICAgICAgICAvLyBIYW5kbGUgYXV0b2ZvY3VzIGxhdGVyIGJlY2F1c2Ug YXR0YWNoKCkgY2FuIGJlIGNhbGxlZCBpbiByZWNhbGNTdHlsZSgpCisgICAgICAgIC8vIGFuZCB3 ZSBzaG91bGQgbm90IGNhbGwgZnVuY3Rpb25zIHdoaWNoIHVwZGF0ZSB0aGUgc3R5bGUgb2YgdGhp cyBlbGVtZW50LgorICAgICAgICBkb2N1bWVudCgpLT5wb3N0VGFzayhBdXRvZm9jdXNUYXNrOjpj cmVhdGUodGhpcykpOworICAgIH0KIH0KIAogdm9pZCBIVE1MRm9ybUNvbnRyb2xFbGVtZW50Ojp3 aWxsTW92ZVRvTmV3T3duZXJEb2N1bWVudCgpCg== 82969 2011-02-18 09:22:29 -0800 2011-02-18 09:31:05 -0800 Patch patch text/plain 5603 bharathwaaj.s SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDc5MDAzKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTEtMDItMTggIEJoYXJhdGh3 YWFqIFNyaW5pdmFzYW4gIDxiaGFyYXRod2Fhai5zQGdtYWlsLmNvbT4KKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTdHlsZSB1cGRhdGUgZXJyb3IgYnkg YXV0b2ZvY3VzIHByb2Nlc3NpbmcgaW4gcmVjYWxjU3R5bGUoKQorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDYwODgKKworICAgICAgICBTdHlsZSB1cGRh dGUgYnkgYXV0b2ZvY3VzIGF0dHJpYnV0ZSB3YXMgbm90IGhhbmRsZWQgaWYgdGhlIGRvY3VtZW50 CisgICAgICAgIGhhZAlhbiBleHRlcm5hbCBzdHlsZXNoZWV0IG9yIHRoZSBlbGVtZW50IHdhcyBh dHRhY2hlZCBieSByZWNhbGNTdHlsZSgpCisgICAgICAgIG9mIGFub3RoZXIgZWxlbWVudCBiZWNh dXNlIHJlY2FsY1N0eWxlKCkgZG9lc24ndCBhc3N1bWUgYXR0YWNoKCkgdXBkYXRlcworICAgICAg ICB0aGUgc3R5bGUgYW5kIHJlY2FsY1N0eWxlKCkgcmVqZWN0cyByZS1lbnRyYW5jZS4KKworICAg ICAgICBUZXN0OiBmYXN0L2Zvcm1zL2F1dG9mb2N1cy1pbi1hdHRhY2guaHRtbAorCisgICAgICAg ICogaHRtbC9IVE1MRm9ybUNvbnRyb2xFbGVtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OnVw ZGF0ZUF1dG9Gb2N1c0NhbGxiYWNrKToKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxGb3JtQ29udHJv bEVsZW1lbnQ6OmF0dGFjaCk6CisKIDIwMTEtMDItMTggIENzYWJhIE9zenRyb2dvbsOhYyAgPG9z c3lAd2Via2l0Lm9yZz4KIAogICAgICAgICBSdWJiZXItc3RhbXBlZCBieSBBbmRyZWFzIEtsaW5n LgpJbmRleDogU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MRm9ybUNvbnRyb2xFbGVtZW50LmNwcAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxGb3JtQ29udHJvbEVsZW1lbnQu Y3BwCShyZXZpc2lvbiA3ODg0NSkKKysrIFNvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTEZvcm1Db250 cm9sRWxlbWVudC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTExOSw2ICsxMTksMTcgQEAgdm9pZCBI VE1MRm9ybUNvbnRyb2xFbGVtZW50OjpwYXJzZU1hcHBlZAogICAgIHNldE5lZWRzV2lsbFZhbGlk YXRlQ2hlY2soKTsKIH0KIAorc3RhdGljIHZvaWQgdXBkYXRlQXV0b0ZvY3VzQ2FsbGJhY2soTm9k ZSogbm9kZSkKK3sKKyAgICBib29sIGlzSW5wdXRUeXBlSGlkZGVuID0gZmFsc2U7CisgICAgSFRN TEZvcm1Db250cm9sRWxlbWVudCAqY29udHJvbCA9IHN0YXRpY19jYXN0PEhUTUxGb3JtQ29udHJv bEVsZW1lbnQqPihub2RlKTsKKyAgICBpZiAoY29udHJvbC0+aGFzVGFnTmFtZShpbnB1dFRhZykp CisgICAgICAgIGlzSW5wdXRUeXBlSGlkZGVuID0gc3RhdGljX2Nhc3Q8SFRNTElucHV0RWxlbWVu dCo+KGNvbnRyb2wpLT5pc0lucHV0VHlwZUhpZGRlbigpOworCisgICAgaWYgKGNvbnRyb2wtPmF1 dG9mb2N1cygpICYmIGNvbnRyb2wtPnJlbmRlcmVyKCkgJiYgIWNvbnRyb2wtPmlzUmVhZE9ubHlG b3JtQ29udHJvbCgpICYmICFpc0lucHV0VHlwZUhpZGRlbikKKyAgICAgICAgY29udHJvbC0+Zm9j dXMoKTsgCit9CisKIHZvaWQgSFRNTEZvcm1Db250cm9sRWxlbWVudDo6YXR0YWNoKCkKIHsKICAg ICBBU1NFUlQoIWF0dGFjaGVkKCkpOwpAQCAtMTMxLDE3ICsxNDIsOSBAQCB2b2lkIEhUTUxGb3Jt Q29udHJvbEVsZW1lbnQ6OmF0dGFjaCgpCiAgICAgaWYgKHJlbmRlcmVyKCkpCiAgICAgICAgIHJl bmRlcmVyKCktPnVwZGF0ZUZyb21FbGVtZW50KCk7CiAgICAgICAgIAotICAgIC8vIEZvY3VzIHRo ZSBlbGVtZW50IGlmIGl0IHNob3VsZCBob25vdXIgaXRzIGF1dG9mb2N1cyBhdHRyaWJ1dGUuCi0g ICAgLy8gV2UgaGF2ZSB0byBkZXRlcm1pbmUgaWYgdGhlIGVsZW1lbnQgaXMgYSBUZXh0QXJlYS9J bnB1dC9CdXR0b24vU2VsZWN0LAotICAgIC8vIGlmIGlucHV0IHR5cGUgaGlkZGVuIGlnbm9yZSBh dXRvZm9jdXMuIFNvIGlmIGRpc2FibGVkIG9yIHJlYWRvbmx5LgotICAgIGJvb2wgaXNJbnB1dFR5 cGVIaWRkZW4gPSBmYWxzZTsKLSAgICBpZiAoaGFzVGFnTmFtZShpbnB1dFRhZykpCi0gICAgICAg IGlzSW5wdXRUeXBlSGlkZGVuID0gc3RhdGljX2Nhc3Q8SFRNTElucHV0RWxlbWVudCo+KHRoaXMp LT5pc0lucHV0VHlwZUhpZGRlbigpOwotCi0gICAgaWYgKGF1dG9mb2N1cygpICYmIHJlbmRlcmVy KCkgJiYgIWRvY3VtZW50KCktPmlnbm9yZUF1dG9mb2N1cygpICYmICFpc1JlYWRPbmx5Rm9ybUNv bnRyb2woKSAmJgotICAgICAgICAgICAgKChoYXNUYWdOYW1lKGlucHV0VGFnKSAmJiAhaXNJbnB1 dFR5cGVIaWRkZW4pIHx8IGhhc1RhZ05hbWUoc2VsZWN0VGFnKSB8fAotICAgICAgICAgICAgICBo YXNUYWdOYW1lKGJ1dHRvblRhZykgfHwgaGFzVGFnTmFtZSh0ZXh0YXJlYVRhZykpKQotICAgICAg ICAgZm9jdXMoKTsKKyAgICBpZiAoIWRvY3VtZW50KCktPmlnbm9yZUF1dG9mb2N1cygpICYmICho YXNUYWdOYW1lKGlucHV0VGFnKSB8fCBoYXNUYWdOYW1lKHNlbGVjdFRhZykgfHwgaGFzVGFnTmFt ZShidXR0b25UYWcpIHx8IGhhc1RhZ05hbWUodGV4dGFyZWFUYWcpKSkgeworICAgICAgICBxdWV1 ZVBvc3RBdHRhY2hDYWxsYmFjayh1cGRhdGVBdXRvRm9jdXNDYWxsYmFjaywgdGhpcyk7CisgICAg fQogfQogCiB2b2lkIEhUTUxGb3JtQ29udHJvbEVsZW1lbnQ6OndpbGxNb3ZlVG9OZXdPd25lckRv Y3VtZW50KCkKSW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlv dXRUZXN0cy9DaGFuZ2VMb2cJKHJldmlzaW9uIDc5MDAzKQorKysgTGF5b3V0VGVzdHMvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMDItMTggIEtlbnQgVGFt dXJhIDx0a2VudEBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgU3R5bGUgdXBkYXRlIGVycm9yIGJ5IGF1dG9mb2N1cyBwcm9jZXNz aW5nIGluIHJlY2FsY1N0eWxlKCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTQ2MDg4CisKKyAgICAgICAgKiBmYXN0L2Zvcm1zL2F1dG9mb2N1cy1pbi1h dHRhY2gtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L2Zvcm1zL2F1dG9mb2N1 cy1pbi1hdHRhY2guaHRtbDogQWRkZWQuCisKIDIwMTEtMDItMTggIENzYWJhIE9zenRyb2dvbsOh YyAgPG9zc3lAd2Via2l0Lm9yZz4KIAogICAgICAgICBVbnJldmlld2VkLgpJbmRleDogTGF5b3V0 VGVzdHMvZmFzdC9mb3Jtcy9hdXRvZm9jdXMtaW4tYXR0YWNoLWV4cGVjdGVkLnR4dAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL2F1dG9mb2N1cy1pbi1hdHRhY2gtZXhwZWN0 ZWQudHh0CShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9hdXRvZm9jdXMt aW4tYXR0YWNoLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSw4IEBACitUZXN0 IGlmIDpmb2N1cyBpcyBjb3JyZWN0bHkgYXBwbGllZCB0byBhbiBlbGVtZW50IHdpdGggYXV0b2Zv Y3VzLiBUaGUgZWxlbWVudCBpcyBzaG93biBkdXJpbmcgc3R5bGUgY2FsY3VsYXRpb24uCisKK09u IHN1Y2Nlc3MsIHlvdSB3aWxsIHNlZSBhIHNlcmllcyBvZiAiUEFTUyIgbWVzc2FnZXMsIGZvbGxv d2VkIGJ5ICJURVNUIENPTVBMRVRFIi4KKworCitQQVNTIGJhY2tncm91bmRPZihpbnB1dCkgaXMg Zm9jdXNDb2xvcgorVEVTVCBDT01QTEVURQorCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2Zvcm1z L2F1dG9mb2N1cy1pbi1hdHRhY2guaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0 L2Zvcm1zL2F1dG9mb2N1cy1pbi1hdHRhY2guaHRtbAkocmV2aXNpb24gMCkKKysrIExheW91dFRl c3RzL2Zhc3QvZm9ybXMvYXV0b2ZvY3VzLWluLWF0dGFjaC5odG1sCShyZXZpc2lvbiAwKQpAQCAt MCwwICsxLDQ2IEBACis8IURPQ1RZUEUgSFRNTCBQVUJMSUMgIi0vL0lFVEYvL0RURCBIVE1MLy9F TiI+Cis8aHRtbD4KKzxoZWFkPgorPGxpbmsgcmVsPSJzdHlsZXNoZWV0IiBocmVmPSIuLi8uLi9m YXN0L2pzL3Jlc291cmNlcy9qcy10ZXN0LXN0eWxlLmNzcyI+Cis8c3R5bGU+CisjcGFyZW50IHsK KyBkaXNwbGF5OiBub25lOworfQorOmZvY3VzIHsKKyBiYWNrZ3JvdW5kLWNvbG9yOiByZ2IoMCwg MjU1LCAwKTsKK30KKzwvc3R5bGU+Cis8c2NyaXB0IHNyYz0iLi4vLi4vZmFzdC9qcy9yZXNvdXJj ZXMvanMtdGVzdC1wcmUuanMiPjwvc2NyaXB0PgorPC9oZWFkPgorPGJvZHk+Cis8cCBpZD0iZGVz Y3JpcHRpb24iPjwvcD4KKzxkaXYgaWQ9ImNvbnNvbGUiPjwvZGl2PgorPGRpdiBpZD0icGFyZW50 Ij4KKzxpbnB1dCBhdXRvZm9jdXM+Cis8L2Rpdj4KKzxzY3JpcHQ+CitkZXNjcmlwdGlvbignVGVz dCBpZiA6Zm9jdXMgaXMgY29ycmVjdGx5IGFwcGxpZWQgdG8gYW4gZWxlbWVudCB3aXRoIGF1dG9m b2N1cy4gVGhlIGVsZW1lbnQgaXMgc2hvd24gZHVyaW5nIHN0eWxlIGNhbGN1bGF0aW9uLicpOwor CitmdW5jdGlvbiBiYWNrZ3JvdW5kT2YoZWwpIHsKKyByZXR1cm4gZG9jdW1lbnQuZGVmYXVsdFZp ZXcuZ2V0Q29tcHV0ZWRTdHlsZShlbCwgbnVsbCkuZ2V0UHJvcGVydHlWYWx1ZSgnYmFja2dyb3Vu ZC1jb2xvcicpOworfQorCitmdW5jdGlvbiBjaGVjaygpIHsKKyBzaG91bGRCZSgnYmFja2dyb3Vu ZE9mKGlucHV0KScsICdmb2N1c0NvbG9yJyk7CisgZGVidWcoJ1RFU1QgQ09NUExFVEUnKTsKKyBk b2N1bWVudC5nZXRFbGVtZW50QnlJZCgncGFyZW50Jykuc3R5bGUuZGlzcGxheSA9ICdub25lJzsK KyBpZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKQorIGxheW91dFRlc3RDb250cm9sbGVy Lm5vdGlmeURvbmUoKTsKK30KKwordmFyIGZvY3VzQ29sb3IgPSAncmdiKDAsIDI1NSwgMCknOwor dmFyIGlucHV0ID0gZG9jdW1lbnQuZ2V0RWxlbWVudHNCeVRhZ05hbWUoJ2lucHV0JylbMF07CisK K2lmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpCisgbGF5b3V0VGVzdENvbnRyb2xsZXIu d2FpdFVudGlsRG9uZSgpOworCitkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgncGFyZW50Jykuc3R5 bGUuZGlzcGxheSA9ICdibG9jayc7CitzZXRUaW1lb3V0KGNoZWNrLCAwKTsKKzwvc2NyaXB0Pgor PC9ib2R5PgorPC9odG1sPgo= 82970 2011-02-18 09:30:48 -0800 2011-05-23 00:07:14 -0700 Fixed webkit coding style. patch text/plain 0 bharathwaaj.s