46078 2010-09-20 02:35:51 -0700 [Qt] PluginStrategy implementation is broken 2010-09-22 07:26:09 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 45857 1 kbalazs webkit-unassigned kling webkit-ews webkit.review.bot oldest_to_newest 281462 0 kbalazs 2010-09-20 02:35:51 -0700 As Kling pointed out on webkit-qt@lists.webkit.org the PluginStrategy implementation is wrong. It causes API regression and crashiness. 281576 1 68089 kbalazs 2010-09-20 08:50:12 -0700 Created attachment 68089 proposed patch 281577 2 webkit.review.bot 2010-09-20 08:52:33 -0700 Attachment 68089 did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebKit/qt/WebCoreSupport/WebPlatformStrategies.cpp:36: Alphabetical sorting problem. [build/include_order] [4] WARNING: File exempt from style guide. Skipping: "WebKit/qt/Api/qwebpage.cpp" Total errors found: 1 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style. 281579 3 kbalazs 2010-09-20 08:57:51 -0700 > If any of these errors are false positives, please file a bug against check-webkit-style. Sort orders these in the same order so maybe it is a check-webkit-syle bug. 281580 4 webkit-ews 2010-09-20 08:58:02 -0700 Attachment 68089 did not build on qt: Build output: http://queues.webkit.org/results/4030081 281634 5 kbalazs 2010-09-20 10:19:35 -0700 Finally I have realized that check-webkit-style expects system style includes after normal ones. (I have created a bug for the style guideline page that is ambigous: https://bugs.webkit.org/show_bug.cgi?id=46099). I could fix the include order before commit. 282921 6 68089 kling 2010-09-22 07:25:58 -0700 Comment on attachment 68089 proposed patch Clearing flags on attachment: 68089 Committed r68039: <http://trac.webkit.org/changeset/68039> 282922 7 kling 2010-09-22 07:26:09 -0700 All reviewed patches have been landed. Closing bug. 68089 2010-09-20 08:50:12 -0700 2010-09-22 07:25:58 -0700 proposed patch land_wpsfix.diff text/plain 6324 kbalazs ZGlmZiAtLWdpdCBhL1dlYktpdC9xdC9BcGkvcXdlYnBhZ2UuY3BwIGIvV2ViS2l0L3F0L0FwaS9x d2VicGFnZS5jcHAKaW5kZXggMTgxYjNhNi4uYmMzMGJmNSAxMDA2NDQKLS0tIGEvV2ViS2l0L3F0 L0FwaS9xd2VicGFnZS5jcHAKKysrIGIvV2ViS2l0L3F0L0FwaS9xd2VicGFnZS5jcHAKQEAgLTI3 Miw3ICsyNzIsNyBAQCBRV2ViUGFnZVByaXZhdGU6OlFXZWJQYWdlUHJpdmF0ZShRV2ViUGFnZSAq cXEpCiAgICAgV2ViQ29yZTo6Rm9udDo6c2V0Q29kZVBhdGgoV2ViQ29yZTo6Rm9udDo6Q29tcGxl eCk7CiAjZW5kaWYKIAotICAgIFdlYlBsYXRmb3JtU3RyYXRlZ2llczo6aW5pdGlhbGl6ZShxcSk7 CisgICAgV2ViUGxhdGZvcm1TdHJhdGVnaWVzOjppbml0aWFsaXplKCk7CiAKICAgICBQYWdlOjpQ YWdlQ2xpZW50cyBwYWdlQ2xpZW50czsKICAgICBwYWdlQ2xpZW50cy5jaHJvbWVDbGllbnQgPSBu ZXcgQ2hyb21lQ2xpZW50UXQocSk7CmRpZmYgLS1naXQgYS9XZWJLaXQvcXQvQ2hhbmdlTG9nIGIv V2ViS2l0L3F0L0NoYW5nZUxvZwppbmRleCBiMWM0NDI1Li5iYjdiZWFiIDEwMDY0NAotLS0gYS9X ZWJLaXQvcXQvQ2hhbmdlTG9nCisrKyBiL1dlYktpdC9xdC9DaGFuZ2VMb2cKQEAgLTEsMyArMSwy MiBAQAorMjAxMC0wOS0yMCAgQmFsYXpzIEtlbGVtZW4gIDxrYkBpbmYudS1zemVnZWQuaHU+CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW1F0XSBQbHVn aW5TdHJhdGVneSBpbXBsZW1lbnRhdGlvbiBpcyBicm9rZW4KKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ2MDc4CisKKyAgICAgICAgUmVtb3ZlIHRoZSBR V2ViUGFnZSogbWVtYmVyIGZyb20gV2ViUGxhdGZvcm1TdHJhdGVnaWVzLgorICAgICAgICBHZXQg dGhlIG9yaWdpbmF0b3IgUVdlYlBhZ2Ugb2YgdGhlIGdldFBsdWdpbkluZm8gY2FsbCB2aWEKKyAg ICAgICAgdGhlIFBhZ2UqIGFyZ3VtZW50LgorICAgICAgICAqIEFwaS9xd2VicGFnZS5jcHA6Cisg ICAgICAgIChRV2ViUGFnZVByaXZhdGU6OlFXZWJQYWdlUHJpdmF0ZSk6CisgICAgICAgICogV2Vi Q29yZVN1cHBvcnQvV2ViUGxhdGZvcm1TdHJhdGVnaWVzLmNwcDoKKyAgICAgICAgKFdlYlBsYXRm b3JtU3RyYXRlZ2llczo6aW5pdGlhbGl6ZSk6IAorICAgICAgICAoV2ViUGxhdGZvcm1TdHJhdGVn aWVzOjpXZWJQbGF0Zm9ybVN0cmF0ZWdpZXMpOgorICAgICAgICAoV2ViUGxhdGZvcm1TdHJhdGVn aWVzOjpnZXRQbHVnaW5JbmZvKToKKyAgICAgICAgVXNlIHRoZSBDaHJvbWVDbGllbnQgZm9yIGFj Y2Vzc2luZyB0aGUgb3JpZ2luYXRvciBRV2ViUGFnZS4KKyAgICAgICAgKiBXZWJDb3JlU3VwcG9y dC9XZWJQbGF0Zm9ybVN0cmF0ZWdpZXMuaDoKKwogMjAxMC0wOS0xOCAgQWRlbWFyIGRlIFNvdXph IFJlaXMgSnIgIDxhZGVtYXIucmVpc0BvcGVuYm9zc2Eub3JnPgogCiAgICAgICAgIFJldmlld2Vk IGJ5IEtlbm5ldGggUm9oZGUgQ2hyaXN0aWFuc2VuLgpkaWZmIC0tZ2l0IGEvV2ViS2l0L3F0L1dl YkNvcmVTdXBwb3J0L1dlYlBsYXRmb3JtU3RyYXRlZ2llcy5jcHAgYi9XZWJLaXQvcXQvV2ViQ29y ZVN1cHBvcnQvV2ViUGxhdGZvcm1TdHJhdGVnaWVzLmNwcAppbmRleCA5NDhlMGNkLi40NjczNzc3 IDEwMDY0NAotLS0gYS9XZWJLaXQvcXQvV2ViQ29yZVN1cHBvcnQvV2ViUGxhdGZvcm1TdHJhdGVn aWVzLmNwcAorKysgYi9XZWJLaXQvcXQvV2ViQ29yZVN1cHBvcnQvV2ViUGxhdGZvcm1TdHJhdGVn aWVzLmNwcApAQCAtMzAsOCArMzAsMTAgQEAKICNpbmNsdWRlICJjb25maWcuaCIKICNpbmNsdWRl ICJXZWJQbGF0Zm9ybVN0cmF0ZWdpZXMuaCIKIAotI2luY2x1ZGUgIk5vdEltcGxlbWVudGVkLmgi CisjaW5jbHVkZSAiQ2hyb21lLmgiCisjaW5jbHVkZSAiQ2hyb21lQ2xpZW50UXQuaCIKICNpbmNs dWRlIDxJbnRTaXplLmg+CisjaW5jbHVkZSAiTm90SW1wbGVtZW50ZWQuaCIKICNpbmNsdWRlIDxQ YWdlLmg+CiAjaW5jbHVkZSA8UGFnZUdyb3VwLmg+CiAjaW5jbHVkZSA8UGx1Z2luRGF0YWJhc2Uu aD4KQEAgLTQzLDE0ICs0NSwxMyBAQAogCiB1c2luZyBuYW1lc3BhY2UgV2ViQ29yZTsKIAotdm9p ZCBXZWJQbGF0Zm9ybVN0cmF0ZWdpZXM6OmluaXRpYWxpemUoUVdlYlBhZ2UqIHdlYlBhZ2UpCit2 b2lkIFdlYlBsYXRmb3JtU3RyYXRlZ2llczo6aW5pdGlhbGl6ZSgpCiB7Ci0gICAgREVGSU5FX1NU QVRJQ19MT0NBTChXZWJQbGF0Zm9ybVN0cmF0ZWdpZXMsIHBsYXRmb3JtU3RyYXRlZ2llcywgKHdl YlBhZ2UpKTsKKyAgICBERUZJTkVfU1RBVElDX0xPQ0FMKFdlYlBsYXRmb3JtU3RyYXRlZ2llcywg cGxhdGZvcm1TdHJhdGVnaWVzLCAoKSk7CiAgICAgUV9VTlVTRUQocGxhdGZvcm1TdHJhdGVnaWVz KTsKIH0KIAotV2ViUGxhdGZvcm1TdHJhdGVnaWVzOjpXZWJQbGF0Zm9ybVN0cmF0ZWdpZXMoUVdl YlBhZ2UqIHdlYlBhZ2UpCi0gICAgOiBtX3BhZ2Uod2ViUGFnZSkKK1dlYlBsYXRmb3JtU3RyYXRl Z2llczo6V2ViUGxhdGZvcm1TdHJhdGVnaWVzKCkKIHsKICAgICBzZXRQbGF0Zm9ybVN0cmF0ZWdp ZXModGhpcyk7CiB9CkBAIC03OCwxMCArNzksMTEgQEAgdm9pZCBXZWJQbGF0Zm9ybVN0cmF0ZWdp ZXM6OnJlZnJlc2hQbHVnaW5zKCkKICAgICBQbHVnaW5EYXRhYmFzZTo6aW5zdGFsbGVkUGx1Z2lu cygpLT5yZWZyZXNoKCk7CiB9CiAKLXZvaWQgV2ViUGxhdGZvcm1TdHJhdGVnaWVzOjpnZXRQbHVn aW5JbmZvKFZlY3RvcjxXZWJDb3JlOjpQbHVnaW5JbmZvPiYgb3V0UGx1Z2lucykKK3ZvaWQgV2Vi UGxhdGZvcm1TdHJhdGVnaWVzOjpnZXRQbHVnaW5JbmZvKGNvbnN0IFdlYkNvcmU6OlBhZ2UqIHBh Z2UsIFZlY3RvcjxXZWJDb3JlOjpQbHVnaW5JbmZvPiYgb3V0UGx1Z2lucykKIHsKLSAgICBRV2Vi UGx1Z2luRmFjdG9yeSogZmFjdG9yeSA9IG1fcGFnZS0+cGx1Z2luRmFjdG9yeSgpOwotICAgIGlm IChmYWN0b3J5KSB7CisgICAgUVdlYlBhZ2UqIHFQYWdlID0gc3RhdGljX2Nhc3Q8Q2hyb21lQ2xp ZW50UXQqPihwYWdlLT5jaHJvbWUoKS0+Y2xpZW50KCkpLT5tX3dlYlBhZ2U7CisgICAgUVdlYlBs dWdpbkZhY3RvcnkqIGZhY3Rvcnk7CisgICAgaWYgKHFQYWdlICYmIChmYWN0b3J5ID0gcVBhZ2Ut PnBsdWdpbkZhY3RvcnkoKSkpIHsKIAogICAgICAgICBRTGlzdDxRV2ViUGx1Z2luRmFjdG9yeTo6 UGx1Z2luPiBxcGx1Z2lucyA9IGZhY3RvcnktPnBsdWdpbnMoKTsKICAgICAgICAgZm9yIChpbnQg aSA9IDA7IGkgPCBxcGx1Z2lucy5jb3VudCgpOyArK2kpIHsKZGlmZiAtLWdpdCBhL1dlYktpdC9x dC9XZWJDb3JlU3VwcG9ydC9XZWJQbGF0Zm9ybVN0cmF0ZWdpZXMuaCBiL1dlYktpdC9xdC9XZWJD b3JlU3VwcG9ydC9XZWJQbGF0Zm9ybVN0cmF0ZWdpZXMuaAppbmRleCA4ZWE2MGQ5Li5jZmM5NTk1 IDEwMDY0NAotLS0gYS9XZWJLaXQvcXQvV2ViQ29yZVN1cHBvcnQvV2ViUGxhdGZvcm1TdHJhdGVn aWVzLmgKKysrIGIvV2ViS2l0L3F0L1dlYkNvcmVTdXBwb3J0L1dlYlBsYXRmb3JtU3RyYXRlZ2ll cy5oCkBAIC0zMywxNCArMzMsMTYgQEAKICNpbmNsdWRlIDxQbHVnaW5TdHJhdGVneS5oPgogI2lu Y2x1ZGUgPFZpc2l0ZWRMaW5rU3RyYXRlZ3kuaD4KIAotY2xhc3MgUVdlYlBhZ2U7CituYW1lc3Bh Y2UgV2ViQ29yZSB7CitjbGFzcyBQYWdlOworfQogCiBjbGFzcyBXZWJQbGF0Zm9ybVN0cmF0ZWdp ZXMgOiBwdWJsaWMgV2ViQ29yZTo6UGxhdGZvcm1TdHJhdGVnaWVzLCBwcml2YXRlIFdlYkNvcmU6 OlBsdWdpblN0cmF0ZWd5LCBwcml2YXRlIFdlYkNvcmU6OkxvY2FsaXphdGlvblN0cmF0ZWd5LCBw cml2YXRlIFdlYkNvcmU6OlZpc2l0ZWRMaW5rU3RyYXRlZ3kgewogcHVibGljOgotICAgIHN0YXRp YyB2b2lkIGluaXRpYWxpemUoUVdlYlBhZ2UqIHdlYlBhZ2UpOworICAgIHN0YXRpYyB2b2lkIGlu aXRpYWxpemUoKTsKIAogcHJpdmF0ZToKLSAgICBXZWJQbGF0Zm9ybVN0cmF0ZWdpZXMoUVdlYlBh Z2UqIHdlYlBhZ2UpOworICAgIFdlYlBsYXRmb3JtU3RyYXRlZ2llcygpOwogCiAgICAgLy8gV2Vi Q29yZTo6UGxhdGZvcm1TdHJhdGVnaWVzCiAgICAgdmlydHVhbCBXZWJDb3JlOjpQbHVnaW5TdHJh dGVneSogY3JlYXRlUGx1Z2luU3RyYXRlZ3koKTsKQEAgLTQ5LDcgKzUxLDcgQEAgcHJpdmF0ZToK IAogICAgIC8vIFdlYkNvcmU6OlBsdWdpblN0cmF0ZWd5CiAgICAgdmlydHVhbCB2b2lkIHJlZnJl c2hQbHVnaW5zKCk7Ci0gICAgdmlydHVhbCB2b2lkIGdldFBsdWdpbkluZm8oVmVjdG9yPFdlYkNv cmU6OlBsdWdpbkluZm8+Jik7CisgICAgdmlydHVhbCB2b2lkIGdldFBsdWdpbkluZm8oY29uc3Qg V2ViQ29yZTo6UGFnZSosIFZlY3RvcjxXZWJDb3JlOjpQbHVnaW5JbmZvPiYpOwogCiAgICAgLy8g V2ViQ29yZTo6TG9jYWxpemF0aW9uU3RyYXRlZ3kKICAgICB2aXJ0dWFsIFdURjo6U3RyaW5nIGlu cHV0RWxlbWVudEFsdFRleHQoKTsKQEAgLTEzNCw4ICsxMzYsNiBAQCBwcml2YXRlOgogICAgIC8v IFdlYkNvcmU6OlZpc2l0ZWRMaW5rU3RyYXRlZ3kKICAgICB2aXJ0dWFsIGJvb2wgaXNMaW5rVmlz aXRlZChXZWJDb3JlOjpQYWdlKiwgV2ViQ29yZTo6TGlua0hhc2gpOwogICAgIHZpcnR1YWwgdm9p ZCBhZGRWaXNpdGVkTGluayhXZWJDb3JlOjpQYWdlKiwgV2ViQ29yZTo6TGlua0hhc2gpOwotCi0g ICAgUVdlYlBhZ2UqIG1fcGFnZTsKIH07CiAKICNlbmRpZiAvLyBXZWJQbGF0Zm9ybVN0cmF0ZWdp ZXNfaApkaWZmIC0tZ2l0IGEvV2ViS2l0Mi9DaGFuZ2VMb2cgYi9XZWJLaXQyL0NoYW5nZUxvZwpp bmRleCA2NTkwM2UxLi41NDc5M2FiIDEwMDY0NAotLS0gYS9XZWJLaXQyL0NoYW5nZUxvZworKysg Yi9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEwLTA5LTIwICBCYWxhenMg S2VsZW1lbiAgPGtiQGluZi51LXN6ZWdlZC5odT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBbUXRdIFBsdWdpblN0cmF0ZWd5IGltcGxlbWVudGF0aW9u IGlzIGJyb2tlbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9NDYwNzgKKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvcXQvcXdrcGFnZS5jcHA6CisgICAg ICAgIChRV0tQYWdlUHJpdmF0ZTo6UVdLUGFnZVByaXZhdGUpOgorICAgICAgICBJbml0aWFsaXpl IHRoZSBXZWJQbGF0Zm9ybVN0cmF0ZWdpZXMgYXQgdGhlIFVJIHNpZGUgYXMgd2VsbCBiZWNhdXNl CisgICAgICAgIHdlIGFyZSB1c2luZyB0aGUgTG9jYWxpemF0aW9uU3RyYXRlZ3kgaW4gdGhlIFVJ IHByb2Nlc3MuCisgICAgICAgIEFkZGVkIGEgRklYTUUgc2luY2UgdGhpcyBzaG91bGQgYmUgZml4 ZWQgaW4gdGhlIGZ1dHVyZS4KKwogMjAxMC0wOS0xNiAgQmFsYXpzIEtlbGVtZW4gIDxrYkBpbmYu dS1zemVnZWQuaHU+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCmRpZmYg LS1naXQgYS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvcXdrcGFnZS5jcHAgYi9XZWJLaXQyL1VJ UHJvY2Vzcy9BUEkvcXQvcXdrcGFnZS5jcHAKaW5kZXggNzIzYWEwYi4uMTUzMjMyMyAxMDA2NDQK LS0tIGEvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3F3a3BhZ2UuY3BwCisrKyBiL1dlYktpdDIv VUlQcm9jZXNzL0FQSS9xdC9xd2twYWdlLmNwcApAQCAtMjMsNyArMjMsOSBAQAogCiAjaW5jbHVk ZSAiQ2xpZW50SW1wbC5oIgogI2luY2x1ZGUgIkxvY2FsaXplZFN0cmluZ3MuaCIKKyNpbmNsdWRl ICJXZWJDb250ZXh0LmgiCiAjaW5jbHVkZSAiV2ViRXZlbnRGYWN0b3J5UXQuaCIKKyNpbmNsdWRl ICJXZWJQbGF0Zm9ybVN0cmF0ZWdpZXMuaCIKICNpbmNsdWRlICJXS1N0cmluZ1F0LmgiCiAjaW5j bHVkZSAiV0tVUkxRdC5oIgogI2luY2x1ZGUgPFFBY3Rpb24+CkBAIC00NSw2ICs0NywxMCBAQCBR V0tQYWdlUHJpdmF0ZTo6UVdLUGFnZVByaXZhdGUoUVdLUGFnZSogcXEsIFdLUGFnZU5hbWVzcGFj ZVJlZiBuYW1lc3BhY2VSZWYpCiAgICAgOiBxKHFxKQogICAgICwgY3JlYXRlTmV3UGFnZUZuKDAp CiB7CisgICAgLy8gV2Ugd2FudCB0byB1c2UgdGhlIExvY2FsaXphdGlvblN0cmF0ZWd5IGF0IHRo ZSBVSSBzaWRlIGFzIHdlbGwuCisgICAgLy8gRklYTUU6IHRoaXMgc2hvdWxkIGJlIGF2b2lkZWQu CisgICAgV2ViUGxhdGZvcm1TdHJhdGVnaWVzOjppbml0aWFsaXplKCk7CisKICAgICBtZW1zZXQo YWN0aW9ucywgMCwgc2l6ZW9mKGFjdGlvbnMpKTsKICAgICBwYWdlID0gdG9XSyhuYW1lc3BhY2VS ZWYpLT5jcmVhdGVXZWJQYWdlKCk7CiAgICAgcGFnZS0+c2V0UGFnZUNsaWVudCh0aGlzKTsK