46074 2010-09-19 22:21:15 -0700 [reviewtool] Publish button should actually publish the review comments 2010-09-20 09:38:21 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 abarth abarth eric joepeck oldest_to_newest 281383 0 abarth 2010-09-19 22:21:15 -0700 [reviewtool] Publish button should actually publish the review comments 281385 1 68051 abarth 2010-09-19 22:22:52 -0700 Created attachment 68051 Patch 281399 2 68051 abarth 2010-09-19 23:16:44 -0700 Comment on attachment 68051 Patch Clearing flags on attachment: 68051 Committed r67839: <http://trac.webkit.org/changeset/67839> 281400 3 abarth 2010-09-19 23:16:49 -0700 All reviewed patches have been landed. Closing bug. 281569 4 ap 2010-09-20 08:38:24 -0700 + publishes the comments directly. If there's demand for a "Preview" + button, we can find a way to add that feature. That would be a useful addition. 281609 5 joepeck 2010-09-20 09:38:21 -0700 (In reply to comment #4) > + publishes the comments directly. If there's demand for a "Preview" > + button, we can find a way to add that feature. > > That would be a useful addition. I agree! 68051 2010-09-19 22:22:52 -0700 2010-09-19 23:16:44 -0700 Patch bug-46074-20100919222250.patch text/plain 1400 abarth SW5kZXg6IEJ1Z3NTaXRlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBCdWdzU2l0ZS9DaGFuZ2VM b2cJKHJldmlzaW9uIDY3ODM2KQorKysgQnVnc1NpdGUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkp CkBAIC0xLDMgKzEsMTYgQEAKKzIwMTAtMDktMTkgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0 Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBb cmV2aWV3dG9vbF0gUHVibGlzaCBidXR0b24gc2hvdWxkIGFjdHVhbGx5IHB1Ymxpc2ggdGhlIHJl dmlldyBjb21tZW50cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9NDYwNzQKKworICAgICAgICBJbnN0ZWFkIG9mIHNob3dpbmcgdGhlIGNvbmZpcm1hdGlv biBsaWdodGJveCwgdGhlIFB1Ymxpc2ggYnV0dG9uIG5vdworICAgICAgICBwdWJsaXNoZXMgdGhl IGNvbW1lbnRzIGRpcmVjdGx5LiAgSWYgdGhlcmUncyBkZW1hbmQgZm9yIGEgIlByZXZpZXciCisg ICAgICAgIGJ1dHRvbiwgd2UgY2FuIGZpbmQgYSB3YXkgdG8gYWRkIHRoYXQgZmVhdHVyZS4KKwor ICAgICAgICAqIGNvZGUtcmV2aWV3LmpzOgorCiAyMDEwLTA5LTE5ICBBZGFtIEJhcnRoICA8YWJh cnRoQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRXJpYyBTZWlkZWwuCkluZGV4 OiBCdWdzU2l0ZS9jb2RlLXJldmlldy5qcwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBCdWdzU2l0ZS9jb2RlLXJl dmlldy5qcwkocmV2aXNpb24gNjc4MzUpCisrKyBCdWdzU2l0ZS9jb2RlLXJldmlldy5qcwkod29y a2luZyBjb3B5KQpAQCAtNDUyLDcgKzQ1Miw2IEBACiAgICAgICBjb21tZW50X3dpdGhfY29udGV4 dC5wdXNoKCdcbicgKyBjb21tZW50KTsKICAgICAgIGNvbW1lbnRzX2luX2NvbnRleHQucHVzaChj b21tZW50X3dpdGhfY29udGV4dC5qb2luKCdcbicpKTsKICAgICB9KTsKLSAgICAkKCcjY29tbWVu dF9mb3JtJykucmVtb3ZlQ2xhc3MoJ2luYWN0aXZlJyk7CiAgICAgdmFyIGNvbW1lbnQgPSAkKCcu b3ZlcmFsbENvbW1lbnRzIHRleHRhcmVhJykudmFsKCkudHJpbSgpOwogICAgIGlmIChjb21tZW50 ICE9ICcnKQogICAgICAgY29tbWVudCArPSAnXG5cbic7CkBAIC00NjcsNSArNDY2LDYgQEAKICAg ICAgICAgcmV0dXJuOwogICAgICAgJCh0aGlzKS5hdHRyKCdzZWxlY3RlZEluZGV4JywgY29udHJv bC5hdHRyKCdzZWxlY3RlZEluZGV4JykpOwogICAgIH0pOworICAgIHJldmlld19mb3JtLmZpbmQo J2Zvcm0nKS5zdWJtaXQoKTsKICAgfSk7CiB9KSgpOwo=