46071 2010-09-19 20:31:05 -0700 Move reviewtool to action=review 2010-09-19 21:45:48 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 abarth abarth ddkilzer eric jparent oldest_to_newest 281364 0 abarth 2010-09-19 20:31:05 -0700 Move reviewtool to action=review 281366 1 68048 abarth 2010-09-19 20:32:33 -0700 Created attachment 68048 Patch 281369 2 68048 eric 2010-09-19 21:24:56 -0700 Comment on attachment 68048 Patch LGTM. 281370 3 abarth 2010-09-19 21:27:03 -0700 Committed r67835: <http://trac.webkit.org/changeset/67835> 281374 4 68048 abarth 2010-09-19 21:45:48 -0700 Comment on attachment 68048 Patch Rejecting patch 68048 from commit-queue. Failed to run "[u'/Users/abarth/git/webkit-queue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Eric Seidel', u'--force']" exit_code: 1 Parsed 3 diffs from patch file(s). patching file BugsSite/ChangeLog Hunk #1 succeeded at 1 with fuzz 1. patching file BugsSite/attachment.cgi Hunk #1 FAILED at 129. 1 out of 1 hunk FAILED -- saving rejects to file BugsSite/attachment.cgi.rej patching file BugsSite/code-review.js Hunk #1 FAILED at 31. 1 out of 1 hunk FAILED -- saving rejects to file BugsSite/code-review.js.rej Full output: http://queues.webkit.org/results/4073070 68048 2010-09-19 20:32:33 -0700 2010-09-19 21:45:48 -0700 Patch bug-46071-20100919203232.patch text/plain 1592 abarth SW5kZXg6IEJ1Z3NTaXRlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBCdWdzU2l0ZS9DaGFuZ2VM b2cJKHJldmlzaW9uIDY3ODMzKQorKysgQnVnc1NpdGUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkp CkBAIC0xLDMgKzEsMTYgQEAKKzIwMTAtMDktMTkgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0 Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBN b3ZlIHJldmlld3Rvb2wgdG8gYWN0aW9uPXJldmlldworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDYwNzEKKworICAgICAgICBUaGlzIHBhdGNoIHJlbW92 ZXMgdGhlIG9sZCBSZXZpZXcgUGF0Y2ggc2NyZWVuIGFuZCBtb3ZlcyB0aGUgbmV3CisgICAgICAg IHJldmlld3Rvb2wgZnJvbSBQcmV0dHkgRGlmZiB0byBSZXZpZXcgUGF0Y2guCisKKyAgICAgICAg KiBhdHRhY2htZW50LmNnaToKKyAgICAgICAgKiBjb2RlLXJldmlldy5qczoKKwogMjAxMC0wOS0x OSAgQWRhbSBCYXJ0aCAgPGFiYXJ0aEB3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlldyB0b29s IFVJIHR3ZWFrLiAgVGhpcyBwYXRjaCBsZW5ndGhlbnMgdGhlIHN0YXR1cyBidWJibGVzIHNvIGFs bApJbmRleDogQnVnc1NpdGUvYXR0YWNobWVudC5jZ2kKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gQnVnc1NpdGUv YXR0YWNobWVudC5jZ2kJKHJldmlzaW9uIDY3ODMyKQorKysgQnVnc1NpdGUvYXR0YWNobWVudC5j Z2kJKHdvcmtpbmcgY29weSkKQEAgLTEyOSw3ICsxMjksNyBAQCBlbHNpZiAoJGFjdGlvbiBlcSAi ZWRpdCIpIAogI2lmIFdFQktJVF9DSEFOR0VTCiBlbHNpZiAoJGFjdGlvbiBlcSAicmV2aWV3IikK IHsKLSAgICBlZGl0KCJyZXZpZXciKTsKKyAgICBwcmV0dHlQYXRjaCgpOwogfQogZWxzaWYgKCRh Y3Rpb24gZXEgInJldmlld2Zvcm0iKQogewpJbmRleDogQnVnc1NpdGUvY29kZS1yZXZpZXcuanMK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gQnVnc1NpdGUvY29kZS1yZXZpZXcuanMJKHJldmlzaW9uIDY3ODMyKQor KysgQnVnc1NpdGUvY29kZS1yZXZpZXcuanMJKHdvcmtpbmcgY29weSkKQEAgLTMxLDkgKzMxLDEx IEBACiAgICAgfQogICB9CiAKLSAgLy8gQXR0ZW1wdCB0byBhY3RpdmF0ZSBvbmx5IGluIHRoZSAi Rm9ybWF0dGVkIERpZmYiIGNvbnRleHQuCisgIC8vIEF0dGVtcHQgdG8gYWN0aXZhdGUgb25seSBp biB0aGUgIlJldmlldyBQYXRjaCIgY29udGV4dC4KICAgaWYgKHdpbmRvdy50b3AgIT0gd2luZG93 KQogICAgIHJldHVybjsKKyAgaWYgKCF3aW5kb3cubG9jYXRpb24uc2VhcmNoLm1hdGNoKC9hY3Rp b249cmV2aWV3LykpCisgICAgcmV0dXJuOwogICB2YXIgYXR0YWNobWVudF9pZCA9IGRldGVybWlu ZUF0dGFjaG1lbnRJRCgpOwogICBpZiAoIWF0dGFjaG1lbnRfaWQpCiAgICAgcmV0dXJuOwo=