46055 2010-09-19 10:54:19 -0700 http/tests/security/xssAuditor/link-opens-new-window.html doesn't pass with Chromium DRT 2010-09-19 17:55:57 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Other All RESOLVED DUPLICATE 45945 P2 Normal --- 1 mihaip mihaip abarth dbates tkent tony oldest_to_newest 281285 0 mihaip 2010-09-19 10:54:19 -0700 http/tests/security/xssAuditor/link-opens-new-window.html doesn't pass with Chromium DRT 281286 1 68029 mihaip 2010-09-19 10:56:18 -0700 Created attachment 68029 Patch 281287 2 mihaip 2010-09-19 10:58:13 -0700 Another option is to copy all of the WebSettings from the parent WebView into the newly created one (not sure how many other settings we'd want to actually propagate though). 281290 3 abarth 2010-09-19 11:18:41 -0700 What do you think tkent? 281313 4 mihaip 2010-09-19 14:16:53 -0700 FWIW, this works in test_shell because the XSS auditor is a global flag there: http://www.google.com/codesearch/p?hl=en#OAMlx_jo-ck/src/webkit/tools/test_shell/layout_test_controller.cc&q=xssauditor%20file:test_shell&exact_package=chromium&sa=N&cd=1&ct=rc&l=1070 And on the Mac DRT, unless otherwise overridden (which is not the case here) all WebViews use the same WebPreferences instance (from [WebPreferences standardPreferences]): http://www.google.com/codesearch/p?hl=en#OAMlx_jo-ck/src/third_party/WebKit/WebKitTools/DumpRenderTree/mac/LayoutTestControllerMac.mm&q=xssauditor%20file:dumprendertree%20file:mac&exact_package=chromium&sa=N&cd=2&ct=rc&l=410 http://www.google.com/codesearch/p?hl=en#OAMlx_jo-ck/src/third_party/WebKit/WebKit/mac/WebView/WebView.h&q=webview%20preferences%20file:mac&exact_package=chromium&l=460 281315 5 abarth 2010-09-19 14:19:00 -0700 This seems related to this recent change by tkent: http://trac.webkit.org/changeset/67809 281316 6 mihaip 2010-09-19 14:20:44 -0700 Nevermind, I see this got fixed with http://trac.webkit.org/changeset/67809, not sure how I didn't see that this morning. *** This bug has been marked as a duplicate of bug 45945 *** 281338 7 68029 dglazkov 2010-09-19 17:55:57 -0700 Comment on attachment 68029 Patch clearing review flags to remove from queue. 68029 2010-09-19 10:56:18 -0700 2010-09-19 17:55:57 -0700 Patch bug-46055-20100919105616.patch text/plain 6064 mihaip ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA1NTM1MGY5MmEzMDE4YWNjMzJmNTRhNjIyNDMzOWE5YTQzYTE3YTA4Li4zMGM5Nzc5 MDk4YjA0MjAxMDVjNGU2YzNiMWUyNDNmYWRhMTdlM2MwIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAK KzIwMTAtMDktMTkgIE1paGFpIFBhcnBhcml0YSAgPG1paGFpcEBjaHJvbWl1bS5vcmc+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgaHR0cC90ZXN0cy9z ZWN1cml0eS94c3NBdWRpdG9yL2xpbmstb3BlbnMtbmV3LXdpbmRvdy5odG1sIGRvZXNuJ3QgcGFz cyB3aXRoIENocm9taXVtIERSVAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9NDYwNTUKKworICAgICAgICBSZW1vdmUgdGVzdCB0aGF0IHNob3VsZCBub3cg cGFzcy4KKworICAgICAgICAqIHBsYXRmb3JtL2Nocm9taXVtL2RydF9leHBlY3RhdGlvbnMudHh0 OgorCiAyMDEwLTA5LTE4ICBFcmlrIEFydmlkc3NvbiAgPGFydkBjaHJvbWl1bS5vcmc+CiAKICAg ICAgICAgUmV2aWV3ZWQgYnkgTmF0ZSBDaGFwaW4uCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9w bGF0Zm9ybS9jaHJvbWl1bS9kcnRfZXhwZWN0YXRpb25zLnR4dCBiL0xheW91dFRlc3RzL3BsYXRm b3JtL2Nocm9taXVtL2RydF9leHBlY3RhdGlvbnMudHh0CmluZGV4IGI4NGQwMWFlNzI4NDgyY2M2 MzE3MWJjNjc4MzgyZmRjYzJhMjMyMDcuLjBhYmQ5ZjA5MTUwMzFmNjNhNGQ3ZmQwMjEzMDA1MDAw YmQ5OGU2NmIgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL2RydF9l eHBlY3RhdGlvbnMudHh0CisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL2RydF9l eHBlY3RhdGlvbnMudHh0CkBAIC0xMTYsNyArMTE2LDYgQEAgQlVHX0RSVCBMSU5VWCA6IHN2Zy9i YXRpay90ZXh0L3ZlcnRpY2FsVGV4dC5zdmcgPSBJTUFHRStURVhUCiAKIC8vIE1pc2MuCiBCVUdf RFJUIFdJTiBNQUMgTElOVVggOiBmYXN0L2R5bmFtaWMvd2luZG93LXJlc2l6ZS1zY3JvbGxiYXJz LXRlc3QuaHRtbCA9IElNQUdFK1RFWFQKLUJVR19EUlQgV0lOIE1BQyBMSU5VWCA6IGh0dHAvdGVz dHMvc2VjdXJpdHkveHNzQXVkaXRvci9saW5rLW9wZW5zLW5ldy13aW5kb3cuaHRtbCA9IFRFWFQK IEJVR19EUlQgV0lOIE1BQyBMSU5VWCA6IHN0b3JhZ2UvZG9tc3RvcmFnZS9xdW90YS5odG1sID0g VEVYVAogQlVHX0RSVCBXSU4gTUFDIExJTlVYIDogc3RvcmFnZS9pbmRleGVkZGIvb2JqZWN0c3Rv cmUtYmFzaWNzLmh0bWwgPSBURVhUCiBCVUdfRFJUIFdJTiBNQUMgTElOVVggOiB1c2Vyc2NyaXB0 cy91c2VyLXNjcmlwdC10b3AtZnJhbWUtb25seS5odG1sID0gVEVYVApkaWZmIC0tZ2l0IGEvV2Vi S2l0VG9vbHMvQ2hhbmdlTG9nIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCmluZGV4IDFmZWU4ZWVl YzA0N2MwZDAzZDUwNjY2OTdkOTM1NWMwNzVlOThmNzQuLjhmMGIyNjMxYWQyYzljYjljZWIyYTM1 MzI5YmQ0YzA5OTYwZTA1ZTEgMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZworKysg Yi9XZWJLaXRUb29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMSBAQAorMjAxMC0wOS0xOSAgTWlo YWkgUGFycGFyaXRhICA8bWloYWlwQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBodHRwL3Rlc3RzL3NlY3VyaXR5L3hzc0F1ZGl0 b3IvbGluay1vcGVucy1uZXctd2luZG93Lmh0bWwgZG9lc24ndCBwYXNzIHdpdGggQ2hyb21pdW0g RFJUCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NjA1 NQorCisgICAgICAgIFByb3BhZ2F0ZSBYU1MgYXVkaXRvciBzZXR0aW5nIHRvIGFueSBuZXcgV2Vi Vmlld3MgdGhhdCBhcmUgY3JlYXRlZCBieQorICAgICAgICB0aGUgY3VycmVudCB0ZXN0LgorCisg ICAgICAgICogRHVtcFJlbmRlclRyZWUvY2hyb21pdW0vTGF5b3V0VGVzdENvbnRyb2xsZXIuY3Bw OgorICAgICAgICAoTGF5b3V0VGVzdENvbnRyb2xsZXI6OnJlc2V0KToKKyAgICAgICAgKExheW91 dFRlc3RDb250cm9sbGVyOjpzZXRYU1NBdWRpdG9yRW5hYmxlZCk6CisgICAgICAgICogRHVtcFJl bmRlclRyZWUvY2hyb21pdW0vTGF5b3V0VGVzdENvbnRyb2xsZXIuaDoKKyAgICAgICAgKExheW91 dFRlc3RDb250cm9sbGVyOjp4c3NBdWRpdG9yRW5hYmxlZCk6CisgICAgICAgICogRHVtcFJlbmRl clRyZWUvY2hyb21pdW0vV2ViVmlld0hvc3QuY3BwOgorICAgICAgICAoV2ViVmlld0hvc3Q6OmNy ZWF0ZVZpZXcpOgorCiAyMDEwLTA5LTE4ICBQcmFzYWQgVGFtbWFuYSAgPHByYXNhZHRAY2hyb21p dW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhdmlkIExldmluLgpkaWZmIC0tZ2l0IGEv V2ViS2l0VG9vbHMvRHVtcFJlbmRlclRyZWUvY2hyb21pdW0vTGF5b3V0VGVzdENvbnRyb2xsZXIu Y3BwIGIvV2ViS2l0VG9vbHMvRHVtcFJlbmRlclRyZWUvY2hyb21pdW0vTGF5b3V0VGVzdENvbnRy b2xsZXIuY3BwCmluZGV4IDVkMzgxNjcxMDY3ZmNhMWY1Y2M1MTJkZjlhNjNkMzBhYWM3ODc5ZTYu LmQzMTMwMjAxMzgzMzNhZmQyMjU0YzRkODYyMTdmM2NkMWY1Yjc0MDQgMTAwNjQ0Ci0tLSBhL1dl YktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL2Nocm9taXVtL0xheW91dFRlc3RDb250cm9sbGVyLmNw cAorKysgYi9XZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9MYXlvdXRUZXN0Q29u dHJvbGxlci5jcHAKQEAgLTUzOSw2ICs1MzksNyBAQCB2b2lkIExheW91dFRlc3RDb250cm9sbGVy OjpyZXNldCgpCiAgICAgbV9nbG9iYWxGbGFnLnNldChmYWxzZSk7CiAgICAgbV93ZWJIaXN0b3J5 SXRlbUNvdW50LnNldCgwKTsKICAgICBtX3VzZXJTdHlsZVNoZWV0TG9jYXRpb24gPSBXZWJVUkwo KTsKKyAgICBtX3hzc0F1ZGl0b3JFbmFibGVkID0gZmFsc2U7CiAKICAgICB3ZWJraXRfc3VwcG9y dDo6U2V0QWNjZXB0QWxsQ29va2llcyhmYWxzZSk7CiAgICAgV2ViU2VjdXJpdHlQb2xpY3k6OnJl c2V0T3JpZ2luQWNjZXNzV2hpdGVsaXN0cygpOwpAQCAtMTA5Nyw4ICsxMDk4LDEyIEBAIHZvaWQg TGF5b3V0VGVzdENvbnRyb2xsZXI6OnNldEphdmFTY3JpcHRDYW5BY2Nlc3NDbGlwYm9hcmQoY29u c3QgQ3BwQXJndW1lbnRMaXN0CiAKIHZvaWQgTGF5b3V0VGVzdENvbnRyb2xsZXI6OnNldFhTU0F1 ZGl0b3JFbmFibGVkKGNvbnN0IENwcEFyZ3VtZW50TGlzdCYgYXJndW1lbnRzLCBDcHBWYXJpYW50 KiByZXN1bHQpCiB7Ci0gICAgaWYgKGFyZ3VtZW50cy5zaXplKCkgPiAwICYmIGFyZ3VtZW50c1sw XS5pc0Jvb2woKSkKLSAgICAgICAgbV9zaGVsbC0+d2ViVmlldygpLT5zZXR0aW5ncygpLT5zZXRY U1NBdWRpdG9yRW5hYmxlZChhcmd1bWVudHNbMF0udmFsdWUuYm9vbFZhbHVlKTsKKyAgICBpZiAo YXJndW1lbnRzLnNpemUoKSA+IDAgJiYgYXJndW1lbnRzWzBdLmlzQm9vbCgpKSB7CisgICAgICAg IC8vIFBlcnNpc3QgdGhlIHZhbHVlIGZvciBhbnkgd2ViIHZpZXdzIHRoYXQgYXJlIGNyZWF0ZWQg YnkgdGhlIGN1cnJlbnQgb25lLi4uCisgICAgICAgIG1feHNzQXVkaXRvckVuYWJsZWQgPSBhcmd1 bWVudHNbMF0udmFsdWUuYm9vbFZhbHVlOworICAgICAgICAvLyAuLi5pbiBhZGRpdGlvbiB0byBh cHBseWluZyBpdCB0byB0aGUgY3VycmVudCB3ZWIgdmlldy4KKyAgICAgICAgbV9zaGVsbC0+d2Vi VmlldygpLT5zZXR0aW5ncygpLT5zZXRYU1NBdWRpdG9yRW5hYmxlZChtX3hzc0F1ZGl0b3JFbmFi bGVkKTsKKyAgICB9CiAgICAgcmVzdWx0LT5zZXROdWxsKCk7CiB9CiAKZGlmZiAtLWdpdCBhL1dl YktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL2Nocm9taXVtL0xheW91dFRlc3RDb250cm9sbGVyLmgg Yi9XZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9MYXlvdXRUZXN0Q29udHJvbGxl ci5oCmluZGV4IGVjMjUwM2YzYzMwODczY2IxNTA0NmM3OTU4NThiYTAwNGU1NzdjMTMuLjllNTlh MWZiYTBmNjgyYzYwZGM5Njc0MzZlZjVjYzIxNWQ3ZjZiZGQgMTAwNjQ0Ci0tLSBhL1dlYktpdFRv b2xzL0R1bXBSZW5kZXJUcmVlL2Nocm9taXVtL0xheW91dFRlc3RDb250cm9sbGVyLmgKKysrIGIv V2ViS2l0VG9vbHMvRHVtcFJlbmRlclRyZWUvY2hyb21pdW0vTGF5b3V0VGVzdENvbnRyb2xsZXIu aApAQCAtMzUxLDYgKzM1MSw3IEBAIHB1YmxpYzoKICAgICBib29sIHNob3VsZEFkZEZpbGVUb1Bh c3RlYm9hcmQoKSB7IHJldHVybiBtX3Nob3VsZEFkZEZpbGVUb1Bhc3RlYm9hcmQ7IH0KICAgICBi b29sIHN0b3BQcm92aXNpb25hbEZyYW1lTG9hZHMoKSB7IHJldHVybiBtX3N0b3BQcm92aXNpb25h bEZyYW1lTG9hZHM7IH0KICAgICBib29sIGRlZmVyTWFpblJlc291cmNlRGF0YUxvYWQoKSB7IHJl dHVybiBtX2RlZmVyTWFpblJlc291cmNlRGF0YUxvYWQ7IH0KKyAgICBib29sIHhzc0F1ZGl0b3JF bmFibGVkKCkge3JldHVybiBtX3hzc0F1ZGl0b3JFbmFibGVkOyB9CiAKICAgICBib29sIHRlc3RS ZXBhaW50KCkgY29uc3QgeyByZXR1cm4gbV90ZXN0UmVwYWludDsgfQogICAgIGJvb2wgc3dlZXBI b3Jpem9udGFsbHkoKSBjb25zdCB7IHJldHVybiBtX3N3ZWVwSG9yaXpvbnRhbGx5OyB9CkBAIC01 MTksNiArNTIwLDkgQEAgcHJpdmF0ZToKIAogICAgIC8vIElmIGZhbHNlLCBhbGwgbmV3IHJlcXVl c3RzIHdpbGwgbm90IGRlZmVyIHRoZSBtYWluIHJlc291cmNlIGRhdGEgbG9hZC4KICAgICBib29s IG1fZGVmZXJNYWluUmVzb3VyY2VEYXRhTG9hZDsKKyAgICAKKyAgICAvLyBJZiB0cnVlLCB0aGUg WFNTIGF1ZGl0b3IgaXMgZW5hYmxlZC4gQnkgZGVmYXVsdCwgc2V0IHRvIGZhbHNlLgorICAgIGJv b2wgbV94c3NBdWRpdG9yRW5hYmxlZDsKIAogICAgIFdvcmtRdWV1ZSBtX3dvcmtRdWV1ZTsKIApk aWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvRHVtcFJlbmRlclRyZWUvY2hyb21pdW0vV2ViVmlld0hv c3QuY3BwIGIvV2ViS2l0VG9vbHMvRHVtcFJlbmRlclRyZWUvY2hyb21pdW0vV2ViVmlld0hvc3Qu Y3BwCmluZGV4IDlhMDg2ZTQxMzg3OTE4OTI2NzY3YWU2MTVlOTQ0NjI0MmM2MzU0ZWMuLmZkMDg1 ZmRmZDcyNTAyYmRiMTgwM2VkODcxNjgzZTIzMWY2ODdhNmUgMTAwNjQ0Ci0tLSBhL1dlYktpdFRv b2xzL0R1bXBSZW5kZXJUcmVlL2Nocm9taXVtL1dlYlZpZXdIb3N0LmNwcAorKysgYi9XZWJLaXRU b29scy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9XZWJWaWV3SG9zdC5jcHAKQEAgLTQ4LDYgKzQ4 LDcgQEAKICNpbmNsdWRlICJwdWJsaWMvV2ViUmFuZ2UuaCIKICNpbmNsdWRlICJwdWJsaWMvV2Vi UmVjdC5oIgogI2luY2x1ZGUgInB1YmxpYy9XZWJTY3JlZW5JbmZvLmgiCisjaW5jbHVkZSAicHVi bGljL1dlYlNldHRpbmdzLmgiCiAjaW5jbHVkZSAicHVibGljL1dlYlNpemUuaCIKICNpbmNsdWRl ICJwdWJsaWMvV2ViU3RvcmFnZU5hbWVzcGFjZS5oIgogI2luY2x1ZGUgInB1YmxpYy9XZWJVUkxS ZXF1ZXN0LmgiCkBAIC0yMjksNyArMjMwLDkgQEAgV2ViVmlldyogV2ViVmlld0hvc3Q6OmNyZWF0 ZVZpZXcoV2ViRnJhbWUqLCBjb25zdCBXZWJXaW5kb3dGZWF0dXJlcyYsIGNvbnN0IFdlYlMKIHsK ICAgICBpZiAoIWxheW91dFRlc3RDb250cm9sbGVyKCktPmNhbk9wZW5XaW5kb3dzKCkpCiAgICAg ICAgIHJldHVybiAwOwotICAgIHJldHVybiBtX3NoZWxsLT5jcmVhdGVXZWJWaWV3KCktPndlYlZp ZXcoKTsKKyAgICBXZWJWaWV3KiBuZXdXZWJWaWV3ID0gbV9zaGVsbC0+Y3JlYXRlV2ViVmlldygp LT53ZWJWaWV3KCk7CisgICAgbmV3V2ViVmlldy0+c2V0dGluZ3MoKS0+c2V0WFNTQXVkaXRvckVu YWJsZWQobGF5b3V0VGVzdENvbnRyb2xsZXIoKS0+eHNzQXVkaXRvckVuYWJsZWQoKSk7CisgICAg cmV0dXJuIG5ld1dlYlZpZXc7CiB9CiAKIFdlYldpZGdldCogV2ViVmlld0hvc3Q6OmNyZWF0ZVBv cHVwTWVudShXZWJQb3B1cFR5cGUpCg==