46046 2010-09-18 18:16:50 -0700 Add unit tests for diffs that delete or modify a change log entry or describe changes that are far apart 2010-09-19 19:41:28 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 dbates dbates eric webkit.review.bot oldest_to_newest 281237 0 dbates 2010-09-18 18:16:50 -0700 We could use additional test coverage for VCSUtils::fixChangeLogPatch. In particular, we don't seem to have test coverage for the early return on line 1324 of VCSUtils.pm <http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/VCSUtils.pm?rev=66800#L1324>. For instance, this early return is taken for a diff that contains deletions (such as removing or modifying a change log entry), or has changes that are far apart from each other. 281240 1 68021 dbates 2010-09-18 18:26:41 -0700 Created attachment 68021 Unit tests 281241 2 webkit.review.bot 2010-09-18 18:28:15 -0700 Attachment 68021 did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebKitTools/Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:64: Line contains tab character. [whitespace/tab] [5] WebKitTools/Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:65: Line contains tab character. [whitespace/tab] [5] Total errors found: 2 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 281242 3 68022 dbates 2010-09-18 18:30:01 -0700 Created attachment 68022 Unit tests 281325 4 68022 mrobinson 2010-09-19 15:45:20 -0700 Comment on attachment 68022 Unit tests Looks sane! 281360 5 68022 dbates 2010-09-19 19:41:22 -0700 Comment on attachment 68022 Unit tests Clearing flags on attachment: 68022 Committed r67832: <http://trac.webkit.org/changeset/67832> 281361 6 dbates 2010-09-19 19:41:28 -0700 All reviewed patches have been landed. Closing bug. 68021 2010-09-18 18:26:41 -0700 2010-09-18 18:30:01 -0700 Unit tests Bug46046.patch text/plain 3488 dbates SW5kZXg6IFdlYktpdFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9D aGFuZ2VMb2cJKHJldmlzaW9uIDY3ODA1KQorKysgV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMjIgQEAKKzIwMTAtMDktMTggIERhbmllbCBCYXRlcyAgPGRi YXRlc0ByaW0uY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIEFkZCB1bml0IHRlc3RzIGZvciBkaWZmcyB0aGF0IGRlbGV0ZSBvciBtb2RpZnkgYSBj aGFuZ2Vsb2cgZW50cnkKKyAgICAgICAgb3IgZGVzY3JpYmUgY2hhbmdlcyB0aGF0IGFyZSBmYXIg YXBhcnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ2 MDQ2CisKKyAgICAgICAgQWRkIGFkZGl0aW9uYWwgdW5pdCB0ZXN0cyB0byB0ZXN0IGNoYW5nZSBs b2cgZGlmZnMgdGhhdCBjb250YWluCisgICAgICAgIGRlbGV0aW9ucyBvciBjaGFuZ2VzIHRoYXQg YXJlIGZhciBhcGFydCBmcm9tIGVhY2ggb3RoZXIgaW4gdGhlCisgICAgICAgIENoYW5nZUxvZyBm aWxlLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRwZXJsL1ZDU1V0aWxzX3VuaXR0ZXN0L2Zp eENoYW5nZUxvZ1BhdGNoLnBsOgorICAgICAgICAgIC0gQWRkZWQgdGhlIGZvbGxvd2luZyB1bml0 IHRlc3RzOgorICAgICAgICAgICJmaXhDaGFuZ2VMb2dQYXRjaDogW25vIGNoYW5nZV0gSW4tcGxh Y2UgY2hhbmdlLiIKKyAgICAgICAgICAiZml4Q2hhbmdlTG9nUGF0Y2g6IFtubyBjaGFuZ2VdIFJl bW92ZSBmaXJzdCBlbnRyeS4iCisgICAgICAgICAgImZpeENoYW5nZUxvZ1BhdGNoOiBbbm8gY2hh bmdlXSBSZW1vdmUgZW50cnkgaW4gdGhlIG1pZGRsZS4iCisgICAgICAgICAgImZpeENoYW5nZUxv Z1BhdGNoOiBbbm8gY2hhbmdlXSBGYXIgYXBhcnQgY2hhbmdlcyAoaS5lLiBtb3JlIHRoYW4gb25l IGNodW5rKS4iCisKIDIwMTAtMDktMTggIFNhbSBXZWluaWcgIDxzYW1Ad2Via2l0Lm9yZz4KIAog ICAgICAgICBSZXZpZXdlZCBieSBEYW4gQmVybnN0ZWluLgpJbmRleDogV2ViS2l0VG9vbHMvU2Ny aXB0cy93ZWJraXRwZXJsL1ZDU1V0aWxzX3VuaXR0ZXN0L2ZpeENoYW5nZUxvZ1BhdGNoLnBsCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFdlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cGVybC9WQ1NVdGlsc191bml0 dGVzdC9maXhDaGFuZ2VMb2dQYXRjaC5wbAkocmV2aXNpb24gNjc3ODUpCisrKyBXZWJLaXRUb29s cy9TY3JpcHRzL3dlYmtpdHBlcmwvVkNTVXRpbHNfdW5pdHRlc3QvZml4Q2hhbmdlTG9nUGF0Y2gu cGwJKHdvcmtpbmcgY29weSkKQEAgLTMwLDcgKzMwLDcgQEAKIAogIyBVbml0IHRlc3RzIG9mIFZD U1V0aWxzOjpmaXhDaGFuZ2VMb2dQYXRjaCgpLgogCi11c2UgVGVzdDo6U2ltcGxlIHRlc3RzID0+ IDg7Cit1c2UgVGVzdDo6U2ltcGxlIHRlc3RzID0+IDEyOwogdXNlIFZDU1V0aWxzOwogCiAjIFRo ZSBzb3VyY2UgQ2hhbmdlTG9nIGZvciB0aGVzZSB0ZXN0cyBpcyB0aGUgZm9sbG93aW5nOgpAQCAt NTgsNiArNTgsOTMgQEAgbXkgJGluOwogbXkgJG91dDsKIAogIyBOZXcgdGVzdAorJHRpdGxlID0g ImZpeENoYW5nZUxvZ1BhdGNoOiBbbm8gY2hhbmdlXSBJbi1wbGFjZSBjaGFuZ2UuIjsKKworJGlu ID0gPDwnRU5EJzsKKy0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDY3Nzg1KQorKysrIENoYW5nZUxv Zwkod29ya2luZyBjb3B5KQorQEAgLTEsNSArMSw1IEBACisgMjAxMC0xMi0yMiAgQm9iICA8Ym9i QGVtYWlsLmFkZHJlc3M+CisgCistICAgICAgICBSZXZpZXdlZCBieSBTdWUuCisrICAgICAgICBS ZXZpZXdlZCBieSBSYXkuCisgCisgICAgICAgICBDaGFuZ2VkIHNvbWUgY29kZSBvbiAyMDEwLTEy LTIyLgorRU5ECisKK29rKGZpeENoYW5nZUxvZ1BhdGNoKCRpbikgZXEgJGluLCAkdGl0bGUpOwor CisjIE5ldyB0ZXN0CiskdGl0bGUgPSAiZml4Q2hhbmdlTG9nUGF0Y2g6IFtubyBjaGFuZ2VdIFJl bW92ZSBmaXJzdCBlbnRyeS4iOworCiskaW4gPSA8PCdFTkQnOworLS0tIENoYW5nZUxvZworKysr IENoYW5nZUxvZworQEAgLTEsMTEgKzEsMyBAQAorLTIwMTAtMTItMjIgIEJvYiAgPGJvYkBlbWFp bC5hZGRyZXNzPgorLQorLSAgICAgICAgUmV2aWV3ZWQgYnkgUmF5LgorLQorLSAgICAgICAgQ2hh bmdlZCBzb21lIGNvZGUgb24gMjAxMC0xMi0yMi4KKy0KKy0gICAgICAgICogRmlsZToKKy0KKyAy MDEwLTEyLTIyICBBbGljZSAgPGFsaWNlQGVtYWlsLmFkZHJlc3M+CisgCisgICAgICAgICBSZXZp ZXdlZCBieSBSYXkuCitFTkQKKworb2soZml4Q2hhbmdlTG9nUGF0Y2goJGluKSBlcSAkaW4sICR0 aXRsZSk7CisKKyMgTmV3IHRlc3QKKyR0aXRsZSA9ICJmaXhDaGFuZ2VMb2dQYXRjaDogW25vIGNo YW5nZV0gUmVtb3ZlIGVudHJ5IGluIHRoZSBtaWRkbGUuIjsKKworJGluID0gPDwnRU5EJzsKKy0t LSBDaGFuZ2VMb2cKKysrKyBDaGFuZ2VMb2cKK0BAQCAtNywxMCArNyw2IEBACisgCisgICAgICAg ICAqIEZpbGU6CisgCistMjAxMC0xMi0yMiAgQm9iICA8Ym9iQGVtYWlsLmFkZHJlc3M+CistCist ICAgICAgICBDaGFuZ2VkIHNvbWUgY29kZSBvbiAyMDEwLTEyLTIyLgorLQorIDIwMTAtMTItMjIg IEFsaWNlICA8YWxpY2VAZW1haWwuYWRkcmVzcz4KKyAKKyAgICAgICAgIFJldmlld2VkIGJ5IFJh eS4KK0VORAorCitvayhmaXhDaGFuZ2VMb2dQYXRjaCgkaW4pIGVxICRpbiwgJHRpdGxlKTsKKwor IyBOZXcgdGVzdAorJHRpdGxlID0gImZpeENoYW5nZUxvZ1BhdGNoOiBbbm8gY2hhbmdlXSBGYXIg YXBhcnQgY2hhbmdlcyAoaS5lLiBtb3JlIHRoYW4gb25lIGNodW5rKS4iOworCiskaW4gPSA8PCdF TkQnOworLS0tIENoYW5nZUxvZworKysrIENoYW5nZUxvZworQEAgLTcsNyArNyw3IEBACisgCisg ICAgICAgICAqIEZpbGU6CisgCistMjAxMC0xMi0yMiAgQm9iICA8Ym9iQGVtYWlsLmFkZHJlc3M+ CisrMjAxMC0xMi0yMiAgQm9iYnkgPGJvYkBlbWFpbC5hZGRyZXNzPgorIAorICAgICAgICAgQ2hh bmdlZCBzb21lIGNvZGUgb24gMjAxMC0xMi0yMi4KKyAKK0BAIC0yMSw3ICsyMSw3IEBACisgCisg ICAgICAgICAqIEZpbGUyOgorIAorLTIwMTAtMTItMjEgIEJvYiAgPGJvYkBlbWFpbC5hZGRyZXNz PgorKzIwMTAtMTItMjEgIEJvYmJ5IDxib2JAZW1haWwuYWRkcmVzcz4KKyAKKyAgICAgICAgIENo YW5nZWQgc29tZSBjb2RlIG9uIDIwMTAtMTItMjEuCitFTkQKKworb2soZml4Q2hhbmdlTG9nUGF0 Y2goJGluKSBlcSAkaW4sICR0aXRsZSk7CisKKyMgTmV3IHRlc3QKICR0aXRsZSA9ICJmaXhDaGFu Z2VMb2dQYXRjaDogW25vIGNoYW5nZV0gRmlyc3QgbGluZSBpcyBuZXcgbGluZS4iOwogCiAkaW4g PSA8PCdFTkQnOwo= 68022 2010-09-18 18:30:01 -0700 2010-09-19 19:41:22 -0700 Unit tests Bug46046.patch text/plain 3457 dbates SW5kZXg6IFdlYktpdFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9D aGFuZ2VMb2cJKHJldmlzaW9uIDY3ODA1KQorKysgV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMjIgQEAKKzIwMTAtMDktMTggIERhbmllbCBCYXRlcyAgPGRi YXRlc0ByaW0uY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIEFkZCB1bml0IHRlc3RzIGZvciBkaWZmcyB0aGF0IGRlbGV0ZSBvciBtb2RpZnkgYSBj aGFuZ2UgbG9nIGVudHJ5CisgICAgICAgIG9yIGRlc2NyaWJlIGNoYW5nZXMgdGhhdCBhcmUgZmFy IGFwYXJ0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00 NjA0NgorCisgICAgICAgIEFkZCBhZGRpdGlvbmFsIHVuaXQgdGVzdHMgdG8gdGVzdCBjaGFuZ2Ug bG9nIGRpZmZzIHRoYXQgY29udGFpbgorICAgICAgICBkZWxldGlvbnMgb3IgY2hhbmdlcyB0aGF0 IGFyZSBmYXIgYXBhcnQgZnJvbSBlYWNoIG90aGVyIGluIHRoZQorICAgICAgICBDaGFuZ2VMb2cg ZmlsZS4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cGVybC9WQ1NVdGlsc191bml0dGVzdC9m aXhDaGFuZ2VMb2dQYXRjaC5wbDoKKyAgICAgICAgICAtIEFkZGVkIHRoZSBmb2xsb3dpbmcgdW5p dCB0ZXN0czoKKyAgICAgICAgICAiZml4Q2hhbmdlTG9nUGF0Y2g6IFtubyBjaGFuZ2VdIEluLXBs YWNlIGNoYW5nZS4iCisgICAgICAgICAgImZpeENoYW5nZUxvZ1BhdGNoOiBbbm8gY2hhbmdlXSBS ZW1vdmUgZmlyc3QgZW50cnkuIgorICAgICAgICAgICJmaXhDaGFuZ2VMb2dQYXRjaDogW25vIGNo YW5nZV0gUmVtb3ZlIGVudHJ5IGluIHRoZSBtaWRkbGUuIgorICAgICAgICAgICJmaXhDaGFuZ2VM b2dQYXRjaDogW25vIGNoYW5nZV0gRmFyIGFwYXJ0IGNoYW5nZXMgKGkuZS4gbW9yZSB0aGFuIG9u ZSBjaHVuaykuIgorCiAyMDEwLTA5LTE4ICBTYW0gV2VpbmlnICA8c2FtQHdlYmtpdC5vcmc+CiAK ICAgICAgICAgUmV2aWV3ZWQgYnkgRGFuIEJlcm5zdGVpbi4KSW5kZXg6IFdlYktpdFRvb2xzL1Nj cmlwdHMvd2Via2l0cGVybC9WQ1NVdGlsc191bml0dGVzdC9maXhDaGFuZ2VMb2dQYXRjaC5wbAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHBlcmwvVkNTVXRpbHNfdW5p dHRlc3QvZml4Q2hhbmdlTG9nUGF0Y2gucGwJKHJldmlzaW9uIDY3Nzg1KQorKysgV2ViS2l0VG9v bHMvU2NyaXB0cy93ZWJraXRwZXJsL1ZDU1V0aWxzX3VuaXR0ZXN0L2ZpeENoYW5nZUxvZ1BhdGNo LnBsCSh3b3JraW5nIGNvcHkpCkBAIC0zMCw3ICszMCw3IEBACiAKICMgVW5pdCB0ZXN0cyBvZiBW Q1NVdGlsczo6Zml4Q2hhbmdlTG9nUGF0Y2goKS4KIAotdXNlIFRlc3Q6OlNpbXBsZSB0ZXN0cyA9 PiA4OwordXNlIFRlc3Q6OlNpbXBsZSB0ZXN0cyA9PiAxMjsKIHVzZSBWQ1NVdGlsczsKIAogIyBU aGUgc291cmNlIENoYW5nZUxvZyBmb3IgdGhlc2UgdGVzdHMgaXMgdGhlIGZvbGxvd2luZzoKQEAg LTU4LDYgKzU4LDkzIEBAIG15ICRpbjsKIG15ICRvdXQ7CiAKICMgTmV3IHRlc3QKKyR0aXRsZSA9 ICJmaXhDaGFuZ2VMb2dQYXRjaDogW25vIGNoYW5nZV0gSW4tcGxhY2UgY2hhbmdlLiI7CisKKyRp biA9IDw8J0VORCc7CistLS0gQ2hhbmdlTG9nCisrKysgQ2hhbmdlTG9nCitAQCAtMSw1ICsxLDUg QEAKKyAyMDEwLTEyLTIyICBCb2IgIDxib2JAZW1haWwuYWRkcmVzcz4KKyAKKy0gICAgICAgIFJl dmlld2VkIGJ5IFN1ZS4KKysgICAgICAgIFJldmlld2VkIGJ5IFJheS4KKyAKKyAgICAgICAgIENo YW5nZWQgc29tZSBjb2RlIG9uIDIwMTAtMTItMjIuCitFTkQKKworb2soZml4Q2hhbmdlTG9nUGF0 Y2goJGluKSBlcSAkaW4sICR0aXRsZSk7CisKKyMgTmV3IHRlc3QKKyR0aXRsZSA9ICJmaXhDaGFu Z2VMb2dQYXRjaDogW25vIGNoYW5nZV0gUmVtb3ZlIGZpcnN0IGVudHJ5LiI7CisKKyRpbiA9IDw8 J0VORCc7CistLS0gQ2hhbmdlTG9nCisrKysgQ2hhbmdlTG9nCitAQCAtMSwxMSArMSwzIEBACist MjAxMC0xMi0yMiAgQm9iICA8Ym9iQGVtYWlsLmFkZHJlc3M+CistCistICAgICAgICBSZXZpZXdl ZCBieSBSYXkuCistCistICAgICAgICBDaGFuZ2VkIHNvbWUgY29kZSBvbiAyMDEwLTEyLTIyLgor LQorLSAgICAgICAgKiBGaWxlOgorLQorIDIwMTAtMTItMjIgIEFsaWNlICA8YWxpY2VAZW1haWwu YWRkcmVzcz4KKyAKKyAgICAgICAgIFJldmlld2VkIGJ5IFJheS4KK0VORAorCitvayhmaXhDaGFu Z2VMb2dQYXRjaCgkaW4pIGVxICRpbiwgJHRpdGxlKTsKKworIyBOZXcgdGVzdAorJHRpdGxlID0g ImZpeENoYW5nZUxvZ1BhdGNoOiBbbm8gY2hhbmdlXSBSZW1vdmUgZW50cnkgaW4gdGhlIG1pZGRs ZS4iOworCiskaW4gPSA8PCdFTkQnOworLS0tIENoYW5nZUxvZworKysrIENoYW5nZUxvZworQEBA IC03LDEwICs3LDYgQEAKKyAKKyAgICAgICAgICogRmlsZToKKyAKKy0yMDEwLTEyLTIyICBCb2Ig IDxib2JAZW1haWwuYWRkcmVzcz4KKy0KKy0gICAgICAgIENoYW5nZWQgc29tZSBjb2RlIG9uIDIw MTAtMTItMjIuCistCisgMjAxMC0xMi0yMiAgQWxpY2UgIDxhbGljZUBlbWFpbC5hZGRyZXNzPgor IAorICAgICAgICAgUmV2aWV3ZWQgYnkgUmF5LgorRU5ECisKK29rKGZpeENoYW5nZUxvZ1BhdGNo KCRpbikgZXEgJGluLCAkdGl0bGUpOworCisjIE5ldyB0ZXN0CiskdGl0bGUgPSAiZml4Q2hhbmdl TG9nUGF0Y2g6IFtubyBjaGFuZ2VdIEZhciBhcGFydCBjaGFuZ2VzIChpLmUuIG1vcmUgdGhhbiBv bmUgY2h1bmspLiI7CisKKyRpbiA9IDw8J0VORCc7CistLS0gQ2hhbmdlTG9nCisrKysgQ2hhbmdl TG9nCitAQCAtNyw3ICs3LDcgQEAKKyAKKyAgICAgICAgICogRmlsZToKKyAKKy0yMDEwLTEyLTIy ICBCb2IgIDxib2JAZW1haWwuYWRkcmVzcz4KKysyMDEwLTEyLTIyICBCb2JieSA8Ym9iQGVtYWls LmFkZHJlc3M+CisgCisgICAgICAgICBDaGFuZ2VkIHNvbWUgY29kZSBvbiAyMDEwLTEyLTIyLgor IAorQEAgLTIxLDcgKzIxLDcgQEAKKyAKKyAgICAgICAgICogRmlsZTI6CisgCistMjAxMC0xMi0y MSAgQm9iICA8Ym9iQGVtYWlsLmFkZHJlc3M+CisrMjAxMC0xMi0yMSAgQm9iYnkgPGJvYkBlbWFp bC5hZGRyZXNzPgorIAorICAgICAgICAgQ2hhbmdlZCBzb21lIGNvZGUgb24gMjAxMC0xMi0yMS4K K0VORAorCitvayhmaXhDaGFuZ2VMb2dQYXRjaCgkaW4pIGVxICRpbiwgJHRpdGxlKTsKKworIyBO ZXcgdGVzdAogJHRpdGxlID0gImZpeENoYW5nZUxvZ1BhdGNoOiBbbm8gY2hhbmdlXSBGaXJzdCBs aW5lIGlzIG5ldyBsaW5lLiI7CiAKICRpbiA9IDw8J0VORCc7Cg==