46045 2010-09-18 17:43:09 -0700 Gradient: Fast-path for the ideal case in sortStopsIfNecessary() 2010-09-18 17:52:19 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) All All RESOLVED FIXED Performance P2 Normal --- 1 kling webkit-unassigned oliver oldest_to_newest 281226 0 kling 2010-09-18 17:43:09 -0700 If the gradient has 2 stops and is already ordered, there's no need to call std::stable_sort. This yields a 0.3% speedup on Parcycle <http://www.mrspeaker.net/dev/parcycle/> Note: Only relevant for Qt and CG. 281227 1 68020 kling 2010-09-18 17:45:04 -0700 Created attachment 68020 Proposed patch 281230 2 68020 oliver 2010-09-18 17:48:35 -0700 Comment on attachment 68020 Proposed patch r=me 281232 3 68020 kling 2010-09-18 17:52:09 -0700 Comment on attachment 68020 Proposed patch Clearing flags on attachment: 68020 Committed r67804: <http://trac.webkit.org/changeset/67804> 281233 4 kling 2010-09-18 17:52:19 -0700 All reviewed patches have been landed. Closing bug. 68020 2010-09-18 17:45:04 -0700 2010-09-18 17:52:09 -0700 Proposed patch bug-46045.diff text/plain 1512 kling ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NzIzY2MyNC4uNGJhMTRiYSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsNSArMSwxNyBAQAogMjAxMC0wOS0xOCAgQW5kcmVhcyBLbGlu ZyAgPGFuZHJlYXMua2xpbmdAbm9raWEuY29tPgogCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIEdyYWRpZW50OiBGYXN0LXBhdGggZm9yIHRoZSBpZGVhbCBj YXNlIGluIHNvcnRTdG9wc0lmTmVjZXNzYXJ5KCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTQ2MDQ1CisKKyAgICAgICAgQXZvaWQgY2FsbGluZyBzdGQ6 OnN0YWJsZV9zb3J0IGZvciAyLXN0b3AgZ3JhZGllbnRzIHRoYXQgYXJlIGFscmVhZHkgaW4gb3Jk ZXIuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9HcmFkaWVudC5jcHA6CisgICAgICAg IChXZWJDb3JlOjpHcmFkaWVudDo6c29ydFN0b3BzSWZOZWNlc3NhcnkpOgorCisyMDEwLTA5LTE4 ICBBbmRyZWFzIEtsaW5nICA8YW5kcmVhcy5rbGluZ0Bub2tpYS5jb20+CisKICAgICAgICAgUmV2 aWV3ZWQgYnkgT2xpdmVyIEh1bnQuCiAKICAgICAgICAgR3JhZGllbnQ6IFByZS1yZXNlcnZlIHNw YWNlIGZvciAyIGNvbG9yIHN0b3BzCmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBo aWNzL0dyYWRpZW50LmNwcCBiL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvR3JhZGllbnQuY3Bw CmluZGV4IDdlYTZiNDcuLjhiYzliM2YgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3MvR3JhZGllbnQuY3BwCisrKyBiL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvR3JhZGll bnQuY3BwCkBAIC0xMTcsOSArMTE3LDE2IEBAIHZvaWQgR3JhZGllbnQ6OnNvcnRTdG9wc0lmTmVj ZXNzYXJ5KCkKICAgICBpZiAobV9zdG9wc1NvcnRlZCkKICAgICAgICAgcmV0dXJuOwogCi0gICAg aWYgKG1fc3RvcHMuc2l6ZSgpKQotICAgICAgICBzdGQ6OnN0YWJsZV9zb3J0KG1fc3RvcHMuYmVn aW4oKSwgbV9zdG9wcy5lbmQoKSwgY29tcGFyZVN0b3BzKTsKICAgICBtX3N0b3BzU29ydGVkID0g dHJ1ZTsKKworICAgIGlmICghbV9zdG9wcy5zaXplKCkpCisgICAgICAgIHJldHVybjsKKworICAg IC8vIFNob3J0Y3V0IGZvciB0aGUgaWRlYWwgY2FzZSAob3JkZXJlZCAyLXN0b3AgZ3JhZGllbnQp CisgICAgaWYgKG1fc3RvcHMuc2l6ZSgpID09IDIgJiYgY29tcGFyZVN0b3BzKCptX3N0b3BzLmJl Z2luKCksICptX3N0b3BzLmVuZCgpKSkKKyAgICAgICAgcmV0dXJuOworCisgICAgc3RkOjpzdGFi bGVfc29ydChtX3N0b3BzLmJlZ2luKCksIG1fc3RvcHMuZW5kKCksIGNvbXBhcmVTdG9wcyk7CiB9 CiAKIHZvaWQgR3JhZGllbnQ6OmdldENvbG9yKGZsb2F0IHZhbHVlLCBmbG9hdCogciwgZmxvYXQq IGcsIGZsb2F0KiBiLCBmbG9hdCogYSkgY29uc3QK