<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>46044</bug_id>
          
          <creation_ts>2010-09-18 17:05:45 -0700</creation_ts>
          <short_desc>Gradient: Pre-reserve space for 2 color stops</short_desc>
          <delta_ts>2010-09-18 17:23:50 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Layout and Rendering</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>Performance</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Andreas Kling">kling</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>oliver</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>281218</commentid>
    <comment_count>0</comment_count>
    <who name="Andreas Kling">kling</who>
    <bug_when>2010-09-18 17:05:45 -0700</bug_when>
    <thetext>Most gradients have only 2 color stops. We can avoid growing the Vector&lt;ColorStop&gt; dynamically in the common case by using an inlineCapacity of 2.

This yields a 0.4% speedup on Parcycle &lt;http://www.mrspeaker.net/dev/parcycle/&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>281219</commentid>
    <comment_count>1</comment_count>
      <attachid>68019</attachid>
    <who name="Andreas Kling">kling</who>
    <bug_when>2010-09-18 17:06:54 -0700</bug_when>
    <thetext>Created attachment 68019
Proposed patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>281220</commentid>
    <comment_count>2</comment_count>
      <attachid>68019</attachid>
    <who name="Oliver Hunt">oliver</who>
    <bug_when>2010-09-18 17:18:05 -0700</bug_when>
    <thetext>Comment on attachment 68019
Proposed patch

r=me, i suspect this will actually save memory in the common case</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>281221</commentid>
    <comment_count>3</comment_count>
      <attachid>68019</attachid>
    <who name="Andreas Kling">kling</who>
    <bug_when>2010-09-18 17:23:40 -0700</bug_when>
    <thetext>Comment on attachment 68019
Proposed patch

Clearing flags on attachment: 68019

Committed r67801: &lt;http://trac.webkit.org/changeset/67801&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>281222</commentid>
    <comment_count>4</comment_count>
    <who name="Andreas Kling">kling</who>
    <bug_when>2010-09-18 17:23:50 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>68019</attachid>
            <date>2010-09-18 17:06:54 -0700</date>
            <delta_ts>2010-09-18 17:23:40 -0700</delta_ts>
            <desc>Proposed patch</desc>
            <filename>bug-46044.diff</filename>
            <type>text/plain</type>
            <size>1164</size>
            <attacher name="Andreas Kling">kling</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg
ZGE3ZDIyNy4uMzk4ZjM0OSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi
Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMC0wOS0xOCAgQW5kcmVhcyBLbGlu
ZyAgPGFuZHJlYXMua2xpbmdAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E
WSAoT09QUyEpLgorCisgICAgICAgIEdyYWRpZW50OiBQcmUtcmVzZXJ2ZSBzcGFjZSBmb3IgMiBj
b2xvciBzdG9wcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/
aWQ9NDYwNDQKKworICAgICAgICBNb3N0IGdyYWRpZW50cyBoYXZlIG9ubHkgMiBjb2xvciBzdG9w
cywgcHJlLXJlc2VydmUgc3BhY2UgZm9yIHRoZXNlIGluIG1fc3RvcHMKKyAgICAgICAgdG8gYXZv
aWQgZ3Jvd2luZyB0aGUgdmVjdG9yIGR5bmFtaWNhbGx5IGluIHRoZSBjb21tb24gY2FzZS4KKwor
ICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL0dyYWRpZW50Lmg6CisKIDIwMTAtMDktMTggIE1p
aGFpIFBhcnBhcml0YSAgPG1paGFpcEBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQg
YnkgU2ltb24gRnJhc2VyLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9H
cmFkaWVudC5oIGIvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9HcmFkaWVudC5oCmluZGV4IDYw
NTJhZWYuLjVmOTQxNmEgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvR3Jh
ZGllbnQuaAorKysgYi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0dyYWRpZW50LmgKQEAgLTE0
Miw3ICsxNDIsNyBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAgICAgICAgIEZsb2F0UG9pbnQgbV9w
MTsKICAgICAgICAgZmxvYXQgbV9yMDsKICAgICAgICAgZmxvYXQgbV9yMTsKLSAgICAgICAgbXV0
YWJsZSBWZWN0b3I8Q29sb3JTdG9wPiBtX3N0b3BzOworICAgICAgICBtdXRhYmxlIFZlY3RvcjxD
b2xvclN0b3AsIDI+IG1fc3RvcHM7CiAgICAgICAgIG11dGFibGUgYm9vbCBtX3N0b3BzU29ydGVk
OwogICAgICAgICBtdXRhYmxlIGludCBtX2xhc3RTdG9wOwogICAgICAgICBHcmFkaWVudFNwcmVh
ZE1ldGhvZCBtX3NwcmVhZE1ldGhvZDsK
</data>

          </attachment>
      

    </bug>

</bugzilla>