46031 2010-09-18 00:50:15 -0700 REGRESSION (r67762): Over 160 layout tests failing due to incorrect zoom factors in subframes 2010-09-18 15:59:32 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Mac All RESOLVED FIXED LayoutTestFailure, Regression P1 Normal --- 1 mitz webkit-unassigned darin sam oldest_to_newest 281092 0 mitz 2010-09-18 00:50:15 -0700 Patch forthcoming. 281093 1 67999 mitz 2010-09-18 00:52:40 -0700 Created attachment 67999 Make parent{Page,Text}ZoomFactor() return the parent frame’s zoom factor 281104 2 67999 eric 2010-09-18 03:00:00 -0700 Comment on attachment 67999 Make parent{Page,Text}ZoomFactor() return the parent frame’s zoom factor LGTM. You'll need to remove the OOPS about the no new tests of course. 281105 3 mitz 2010-09-18 03:04:30 -0700 Fixed in <http://trac.webkit.org/changeset/67777> 281196 4 67999 darin 2010-09-18 15:59:32 -0700 Comment on attachment 67999 Make parent{Page,Text}ZoomFactor() return the parent frame’s zoom factor Oops! Thanks for fixing this! 67999 2010-09-18 00:52:40 -0700 2010-09-18 15:59:32 -0700 Make parent{Page,Text}ZoomFactor() return the parent frame’s zoom factor 46031_r1.diff text/plain 1505 mitz SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2Nzc3NikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMTAtMDktMTggIERhbiBCZXJuc3RlaW4gIDxtaXR6QGFwcGxlLmNv bT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSRUdS RVNTSU9OIChyNjc3NjIpOiBPdmVyIDE2MCBsYXlvdXQgdGVzdHMgZmFpbGluZyBkdWUgdG8gaW5j b3JyZWN0IHpvb20gZmFjdG9ycyBpbiBzdWJmcmFtZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ2MDMxCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLiAo T09QUyEpCisKKyAgICAgICAgKiBwYWdlL0ZyYW1lLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OnBh cmVudFBhZ2Vab29tRmFjdG9yKTogUmV0dXJuIHRoZSB6b29tIGZhY3RvciBvZiB0aGUgcGFyZW50 IGZyYW1lLgorICAgICAgICAoV2ViQ29yZTo6cGFyZW50VGV4dFpvb21GYWN0b3IpOiBEaXR0by4K KwogMjAxMC0wOS0xNyAgU2FtIFdlaW5pZyAgPHNhbUB3ZWJraXQub3JnPgogCiAgICAgICAgIFJl dmlld2VkIGJ5IEpvbiBIb25leWN1dHQuCkluZGV4OiBXZWJDb3JlL3BhZ2UvRnJhbWUuY3BwCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFdlYkNvcmUvcGFnZS9GcmFtZS5jcHAJKHJldmlzaW9uIDY3Nzc2KQorKysg V2ViQ29yZS9wYWdlL0ZyYW1lLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTM0LDcgKzEzNCw3IEBA IHN0YXRpYyBpbmxpbmUgZmxvYXQgcGFyZW50UGFnZVpvb21GYWN0b3IKICAgICBGcmFtZSogcGFy ZW50ID0gZnJhbWUtPnRyZWUoKS0+cGFyZW50KCk7CiAgICAgaWYgKCFwYXJlbnQpCiAgICAgICAg IHJldHVybiAxOwotICAgIHJldHVybiBmcmFtZS0+cGFnZVpvb21GYWN0b3IoKTsKKyAgICByZXR1 cm4gcGFyZW50LT5wYWdlWm9vbUZhY3RvcigpOwogfQogCiBzdGF0aWMgaW5saW5lIGZsb2F0IHBh cmVudFRleHRab29tRmFjdG9yKEZyYW1lKiBmcmFtZSkKQEAgLTE0Miw3ICsxNDIsNyBAQCBzdGF0 aWMgaW5saW5lIGZsb2F0IHBhcmVudFRleHRab29tRmFjdG9yCiAgICAgRnJhbWUqIHBhcmVudCA9 IGZyYW1lLT50cmVlKCktPnBhcmVudCgpOwogICAgIGlmICghcGFyZW50KQogICAgICAgICByZXR1 cm4gMTsKLSAgICByZXR1cm4gZnJhbWUtPnRleHRab29tRmFjdG9yKCk7CisgICAgcmV0dXJuIHBh cmVudC0+dGV4dFpvb21GYWN0b3IoKTsKIH0KIAogaW5saW5lIEZyYW1lOjpGcmFtZShQYWdlKiBw YWdlLCBIVE1MRnJhbWVPd25lckVsZW1lbnQqIG93bmVyRWxlbWVudCwgRnJhbWVMb2FkZXJDbGll bnQqIGZyYW1lTG9hZGVyQ2xpZW50KQo=