46018 2010-09-17 17:25:55 -0700 Add IsFloatingPoint and IsArithmetic type traits 2010-09-17 17:41:18 -0700 1 1 1 Unclassified WebKit Web Template Framework 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 andersca andersca webkit.review.bot oldest_to_newest 281015 0 andersca 2010-09-17 17:25:55 -0700 Add IsFloatingPoint and IsArithmetic type traits 281016 1 67978 andersca 2010-09-17 17:27:59 -0700 Created attachment 67978 Patch 281020 2 webkit.review.bot 2010-09-17 17:31:35 -0700 Attachment 67978 did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 JavaScriptCore/wtf/TypeTraits.h:65: More than one command on the same line [whitespace/newline] [4] JavaScriptCore/wtf/TypeTraits.h:66: More than one command on the same line [whitespace/newline] [4] JavaScriptCore/wtf/TypeTraits.h:67: More than one command on the same line [whitespace/newline] [4] JavaScriptCore/wtf/TypeTraits.h:68: More than one command on the same line [whitespace/newline] [4] JavaScriptCore/wtf/TypeTraits.h:70: More than one command on the same line [whitespace/newline] [4] JavaScriptCore/wtf/TypeTraits.h:74: More than one command on the same line [whitespace/newline] [4] Total errors found: 6 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 281022 3 67978 sam 2010-09-17 17:32:43 -0700 Comment on attachment 67978 Patch You should add tests in the .cpp file (as COMPILE_ASSERTS). 281029 4 andersca 2010-09-17 17:41:18 -0700 Committed r67765: <http://trac.webkit.org/changeset/67765> 67978 2010-09-17 17:27:59 -0700 2010-09-17 17:32:43 -0700 Patch bug-46018-20100917172758.patch text/plain 2207 andersca ZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBiL0phdmFTY3JpcHRDb3JlL0No YW5nZUxvZwppbmRleCA0NjgyMDFhZmE0NjU1OWFiNTdlNjE3ZTc2NDFmNGRiNTI1N2NlZTI1Li4y NmQ1ODJjNmU3YmRiYzQyZGQ0ODVjN2EwZWNjOTMxN2M0ZTZkMDc0IDEwMDY0NAotLS0gYS9KYXZh U2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMTIgQEAKKzIwMTAtMDktMTcgIEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxl LmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBB ZGQgSXNGbG9hdGluZ1BvaW50IGFuZCBJc0FyaXRobWV0aWMgdHlwZSB0cmFpdHMKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ2MDE4CisKKyAgICAgICAg KiB3dGYvVHlwZVRyYWl0cy5oOgorCiAyMDEwLTA5LTE3ICBNYXJ0aW4gUm9iaW5zb24gIDxtcm9i aW5zb25AaWdhbGlhLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBPbGl2ZXIgSHVudC4KZGlm ZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL3d0Zi9UeXBlVHJhaXRzLmggYi9KYXZhU2NyaXB0Q29y ZS93dGYvVHlwZVRyYWl0cy5oCmluZGV4IDYyZGJjNDkyNmMxYzEzMTczMWNlYzlkYjMzM2UyZTI1 ODAzYTEzODQuLmNmOWI0YWZlZWY1MDY4MzhiZWU5ZTQ0NjU1MWY5ZTI1YmYxZWU1MTggMTAwNjQ0 Ci0tLSBhL0phdmFTY3JpcHRDb3JlL3d0Zi9UeXBlVHJhaXRzLmgKKysrIGIvSmF2YVNjcmlwdENv cmUvd3RmL1R5cGVUcmFpdHMuaApAQCAtNjIsMTIgKzYyLDE2IEBAIG5hbWVzcGFjZSBXVEYgewog ICAgIHRlbXBsYXRlPD4gc3RydWN0IElzSW50ZWdlcjx3Y2hhcl90PiAgICAgICAgICAgIHsgc3Rh dGljIGNvbnN0IGJvb2wgdmFsdWUgPSB0cnVlOyB9OwogI2VuZGlmCiAKKyAgICB0ZW1wbGF0ZTx0 eXBlbmFtZSBUPiBzdHJ1Y3QgSXNGbG9hdGluZ1BvaW50ICAgICB7IHN0YXRpYyBjb25zdCBib29s IHZhbHVlID0gZmFsc2U7IH07CisgICAgdGVtcGxhdGU8PiBzdHJ1Y3QgSXNGbG9hdGluZ1BvaW50 PGZsb2F0PiAgICAgICAgeyBzdGF0aWMgY29uc3QgYm9vbCB2YWx1ZSA9IHRydWU7IH07CisgICAg dGVtcGxhdGU8PiBzdHJ1Y3QgSXNGbG9hdGluZ1BvaW50PGRvdWJsZT4gICAgICAgeyBzdGF0aWMg Y29uc3QgYm9vbCB2YWx1ZSA9IHRydWU7IH07CisgICAgdGVtcGxhdGU8PiBzdHJ1Y3QgSXNGbG9h dGluZ1BvaW50PGxvbmcgZG91YmxlPiAgeyBzdGF0aWMgY29uc3QgYm9vbCB2YWx1ZSA9IHRydWU7 IH07CisKKyAgICB0ZW1wbGF0ZTx0eXBlbmFtZSBUPiBzdHJ1Y3QgSXNBcml0aG1ldGljICAgICB7 IHN0YXRpYyBjb25zdCBib29sIHZhbHVlID0gSXNJbnRlZ2VyPFQ+Ojp2YWx1ZSB8fCBJc0Zsb2F0 aW5nUG9pbnQ8VD46OnZhbHVlOyB9OworCiAgICAgLy8gSXNQb2QgaXMgbWlzbmFtZWQgYXMgaXQg ZG9lc24ndCBjb3ZlciBhbGwgcGxhaW4gb2xkIGRhdGEgKHBvZCkgdHlwZXMuCiAgICAgLy8gU3Bl Y2lmaWNhbGx5LCBpdCBkb2Vzbid0IGFsbG93IGZvciBlbnVtcyBvciBmb3Igc3RydWN0cy4KLSAg ICB0ZW1wbGF0ZSA8dHlwZW5hbWUgVD4gc3RydWN0IElzUG9kICAgICAgICAgICB7IHN0YXRpYyBj b25zdCBib29sIHZhbHVlID0gSXNJbnRlZ2VyPFQ+Ojp2YWx1ZTsgfTsKLSAgICB0ZW1wbGF0ZSA8 PiBzdHJ1Y3QgSXNQb2Q8ZmxvYXQ+ICAgICAgICAgICAgICB7IHN0YXRpYyBjb25zdCBib29sIHZh bHVlID0gdHJ1ZTsgfTsKLSAgICB0ZW1wbGF0ZSA8PiBzdHJ1Y3QgSXNQb2Q8ZG91YmxlPiAgICAg ICAgICAgICB7IHN0YXRpYyBjb25zdCBib29sIHZhbHVlID0gdHJ1ZTsgfTsKLSAgICB0ZW1wbGF0 ZSA8PiBzdHJ1Y3QgSXNQb2Q8bG9uZyBkb3VibGU+ICAgICAgICB7IHN0YXRpYyBjb25zdCBib29s IHZhbHVlID0gdHJ1ZTsgfTsKKyAgICB0ZW1wbGF0ZSA8dHlwZW5hbWUgVD4gc3RydWN0IElzUG9k ICAgICAgICAgICB7IHN0YXRpYyBjb25zdCBib29sIHZhbHVlID0gSXNBcml0aG1ldGljPFQ+Ojp2 YWx1ZTsgfTsKICAgICB0ZW1wbGF0ZSA8dHlwZW5hbWUgUD4gc3RydWN0IElzUG9kPFAqPiAgICAg ICB7IHN0YXRpYyBjb25zdCBib29sIHZhbHVlID0gdHJ1ZTsgfTsKIAogICAgIHRlbXBsYXRlPHR5 cGVuYW1lIFQ+IGNsYXNzIElzQ29udmVydGlibGVUb0ludGVnZXIgewo=