46003 2010-09-17 15:25:46 -0700 [BREWMP] Fix a typo in key code name 2010-09-18 18:05:21 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Other Other RESOLVED FIXED P2 Normal --- 33564 0 skyul webkit-unassigned abarth commit-queue eric oldest_to_newest 280911 0 skyul 2010-09-17 15:25:46 -0700 AVK_CLR is the right Brew MP key code name for VK_BACK. 280915 1 67961 skyul 2010-09-17 15:26:48 -0700 Created attachment 67961 Patch 281066 2 67961 kling 2010-09-17 19:09:45 -0700 Comment on attachment 67961 Patch r=me 281228 3 67961 abarth 2010-09-18 17:47:14 -0700 Comment on attachment 67961 Patch Clearing flags on attachment: 67961 Committed r67803: <http://trac.webkit.org/changeset/67803> 281229 4 abarth 2010-09-18 17:47:19 -0700 All reviewed patches have been landed. Closing bug. 281231 5 67961 commit-queue 2010-09-18 17:48:53 -0700 Comment on attachment 67961 Patch Rejecting patch 67961 from commit-queue. Failed to run "[u'/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--force']" exit_code: 1 Parsed 2 diffs from patch file(s). patching file WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file WebCore/platform/brew/PlatformKeyboardEventBrew.cpp Hunk #1 FAILED at 106. 1 out of 1 hunk FAILED -- saving rejects to file WebCore/platform/brew/PlatformKeyboardEventBrew.cpp.rej Full output: http://queues.webkit.org/results/4064060 281234 6 abarth 2010-09-18 18:05:21 -0700 Interesting. This patch hit a race condition in the commit-cluster. I think the first commit-queue instance took long enough to process the patch that the lock was released. Maybe we need to up the timeout? 67961 2010-09-17 15:26:48 -0700 2010-09-18 17:48:53 -0700 Patch typo.patch text/plain 1204 skyul SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2Nzc1MSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTAtMDktMTcgIEt3YW5nIFl1bCBTZW8gIDxza3l1bEBjb21wYW55 MTAwLm5ldD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBbQlJFV01QXSBGaXggYSB0eXBvIGluIGtleSBjb2RlIG5hbWUKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ2MDAzCisKKyAgICAgICAgQVZLX0NMUiBp cyB0aGUgcmlnaHQgQnJldyBNUCBrZXkgY29kZSBuYW1lIGZvciBWS19CQUNLLgorCisgICAgICAg ICogcGxhdGZvcm0vYnJldy9QbGF0Zm9ybUtleWJvYXJkRXZlbnRCcmV3LmNwcDoKKyAgICAgICAg KFdlYkNvcmU6OndpbmRvd3NLZXlDb2RlRm9yS2V5RXZlbnQpOgorCiAyMDEwLTA5LTE3ICBNYXJj LUFudG9pbmUgUnVlbCAgPG1hcnVlbEBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQg YnkgRGltaXRyaSBHbGF6a292LgpJbmRleDogV2ViQ29yZS9wbGF0Zm9ybS9icmV3L1BsYXRmb3Jt S2V5Ym9hcmRFdmVudEJyZXcuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcGxhdGZvcm0vYnJl dy9QbGF0Zm9ybUtleWJvYXJkRXZlbnRCcmV3LmNwcAkocmV2aXNpb24gNjc3NTEpCisrKyBXZWJD b3JlL3BsYXRmb3JtL2JyZXcvUGxhdGZvcm1LZXlib2FyZEV2ZW50QnJldy5jcHAJKHdvcmtpbmcg Y29weSkKQEAgLTEwNiw3ICsxMDYsNyBAQCBzdGF0aWMgU3RyaW5nIGtleUlkZW50aWZpZXJGb3JC cmV3S2V5Q29kCiBzdGF0aWMgaW50IHdpbmRvd3NLZXlDb2RlRm9yS2V5RXZlbnQodWludDE2IGNv ZGUpCiB7CiAgICAgc3dpdGNoIChjb2RlKSB7Ci0gICAgY2FzZSBBVktfQToKKyAgICBjYXNlIEFW S19DTFI6CiAgICAgICAgIHJldHVybiBWS19CQUNLOyAvLyAoMDgpIEJBQ0tTUEFDRSBrZXkKICAg ICBjYXNlIEFWS19FTlRFUjoKICAgICAgICAgcmV0dXJuIFZLX1JFVFVSTjsgLy8gKDBEKSBSZXR1 cm4ga2V5Cg==