45999 2010-09-17 14:33:12 -0700 CoreIPC argument coder improvements 2010-12-14 09:23:35 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 andersca andersca eric oldest_to_newest 280872 0 andersca 2010-09-17 14:33:12 -0700 CoreIPC argument coder improvements 280876 1 67953 andersca 2010-09-17 14:35:07 -0700 Created attachment 67953 Patch 321841 2 eric 2010-12-14 01:59:34 -0800 I assume this was landed but just not closed? 322005 3 andersca 2010-12-14 09:23:35 -0800 Committed r67754: <http://trac.webkit.org/changeset/67754> 67953 2010-09-17 14:35:07 -0700 2010-09-17 15:04:37 -0700 Patch bug-45999-20100917143506.patch text/plain 7460 andersca ZGlmZiAtLWdpdCBhL1dlYktpdDIvQ2hhbmdlTG9nIGIvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXgg ZTBiNzY4MzY1NmVjM2FkMTkwNGFjMGE0NzNhNjRkM2ZlYmI1NzhhYi4uOTUzNmNmODM2ZDVlY2U5 ZTMxOTdjNDc0ZTlmMWRkM2VlM2RlNmVhMyAxMDA2NDQKLS0tIGEvV2ViS2l0Mi9DaGFuZ2VMb2cK KysrIGIvV2ViS2l0Mi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyOSBAQAorMjAxMC0wOS0xNyAgQW5k ZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENvcmVJUEMgYXJndW1lbnQgY29kZXIgaW1wcm92 ZW1lbnRzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00 NTk5OQorCisgICAgICAgICogUGxhdGZvcm0vQ29yZUlQQy9Bcmd1bWVudENvZGVycy5oOgorICAg ICAgICBBZGQgZXhwbGljaXQgc3BlY2lhbGl6YXRpb24gZm9yIGEgdmVjdG9yIG9mIGJ5dGVzLgor CisgICAgICAgICogUGxhdGZvcm0vQ29yZUlQQy9Bcmd1bWVudHMuaDoKKyAgICAgICAgKENvcmVJ UEM6OkFyZ3VtZW50czE6OmRlY29kZSk6CisgICAgICAgIChDb3JlSVBDOjpBcmd1bWVudHMyOjpk ZWNvZGUpOgorICAgICAgICAoQ29yZUlQQzo6QXJndW1lbnRzMzo6ZGVjb2RlKToKKyAgICAgICAg KENvcmVJUEM6OkFyZ3VtZW50czQ6OmRlY29kZSk6CisgICAgICAgIChDb3JlSVBDOjpBcmd1bWVu dHM1OjpkZWNvZGUpOgorICAgICAgICAoQ29yZUlQQzo6QXJndW1lbnRzNjo6ZGVjb2RlKToKKyAg ICAgICAgVXNlIHRoZSBpbmplY3RlZCBjbGFzcyBuYW1lIGZvciBsZXNzIHR5cGluZy4KKworICAg ICAgICAoQ29yZUlQQzo6QXJndW1lbnRzNzo6QXJndW1lbnRzNyk6CisgICAgICAgIChDb3JlSVBD OjpBcmd1bWVudHM3OjplbmNvZGUpOgorICAgICAgICAoQ29yZUlQQzo6QXJndW1lbnRzNzo6ZGVj b2RlKToKKyAgICAgICAgKENvcmVJUEM6OkluKToKKyAgICAgICAgKENvcmVJUEM6Ok91dCk6Cisg ICAgICAgIEFkZCBBcmd1bWVudHM3IGNsYXNzLgorCiAyMDEwLTA5LTE3ICBTYW0gV2VpbmlnICA8 c2FtQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQW5kZXJzIENhcmxzc29uLgpk aWZmIC0tZ2l0IGEvV2ViS2l0Mi9QbGF0Zm9ybS9Db3JlSVBDL0FyZ3VtZW50Q29kZXJzLmggYi9X ZWJLaXQyL1BsYXRmb3JtL0NvcmVJUEMvQXJndW1lbnRDb2RlcnMuaAppbmRleCAyNjY4NDM5NmQx OGUzYmYyNzZkMTQ3NjhiMjQzY2M4Mjc3NTg2ODhmLi42ZGY4NDI0MzkzYTllYzdlNjE4ZjcwZGUy YmI5YTNiZDI5YWM5MzBiIDEwMDY0NAotLS0gYS9XZWJLaXQyL1BsYXRmb3JtL0NvcmVJUEMvQXJn dW1lbnRDb2RlcnMuaAorKysgYi9XZWJLaXQyL1BsYXRmb3JtL0NvcmVJUEMvQXJndW1lbnRDb2Rl cnMuaApAQCAtMjksNiArMjksNyBAQAogI2luY2x1ZGUgIkFyZ3VtZW50RGVjb2Rlci5oIgogI2lu Y2x1ZGUgIkFyZ3VtZW50RW5jb2Rlci5oIgogI2luY2x1ZGUgPHV0aWxpdHk+CisjaW5jbHVkZSA8 d3RmL0hhc2hNYXAuaD4KICNpbmNsdWRlIDx3dGYvVmVjdG9yLmg+CiAKIG5hbWVzcGFjZSBDb3Jl SVBDIHsKQEAgLTEwMyw3ICsxMDQsNTcgQEAgdGVtcGxhdGU8dHlwZW5hbWUgVD4gc3RydWN0IEFy Z3VtZW50Q29kZXI8VmVjdG9yPFQ+ID4gewogICAgICAgICByZXR1cm4gdHJ1ZTsKICAgICB9CiB9 OwotICAgIAorCisvLyBTcGVjaWFsaXphdGlvbiBmb3IgVmVjdG9yPHVpbnQ4X3Q+Cit0ZW1wbGF0 ZTw+IHN0cnVjdCBBcmd1bWVudENvZGVyPFZlY3Rvcjx1aW50OF90PiA+IHsKKyAgICBzdGF0aWMg dm9pZCBlbmNvZGUoQXJndW1lbnRFbmNvZGVyKiBlbmNvZGVyLCBjb25zdCBWZWN0b3I8dWludDhf dD4mIHZlY3RvcikKKyAgICB7CisgICAgICAgIGVuY29kZXItPmVuY29kZUJ5dGVzKHZlY3Rvci5k YXRhKCksIHZlY3Rvci5zaXplKCkpOworICAgIH0KKworICAgIHN0YXRpYyBib29sIGRlY29kZShB cmd1bWVudERlY29kZXIqIGRlY29kZXIsIFZlY3Rvcjx1aW50OF90PiYgdmVjdG9yKQorICAgIHsK KyAgICAgICAgcmV0dXJuIGRlY29kZXItPmRlY29kZUJ5dGVzKHZlY3Rvcik7CisgICAgfQorfTsK KwordGVtcGxhdGU8dHlwZW5hbWUgS2V5QXJnLCB0eXBlbmFtZSBNYXBwZWRBcmcsIHR5cGVuYW1l IEhhc2hBcmcsIHR5cGVuYW1lIEtleVRyYWl0c0FyZywgdHlwZW5hbWUgTWFwcGVkVHJhaXRzQXJn PiBzdHJ1Y3QgQXJndW1lbnRDb2RlcjxIYXNoTWFwPEtleUFyZywgTWFwcGVkQXJnLCBIYXNoQXJn LCBLZXlUcmFpdHNBcmcsIE1hcHBlZFRyYWl0c0FyZz4gPiB7CisgICAgdHlwZWRlZiBIYXNoTWFw PEtleUFyZywgTWFwcGVkQXJnLCBIYXNoQXJnLCBLZXlUcmFpdHNBcmcsIE1hcHBlZFRyYWl0c0Fy Zz4gSGFzaE1hcFR5cGU7CisKKyAgICBzdGF0aWMgdm9pZCBlbmNvZGUoQXJndW1lbnRFbmNvZGVy KiBlbmNvZGVyLCBjb25zdCBIYXNoTWFwVHlwZSYgaGFzaE1hcCkKKyAgICB7CisgICAgICAgIGVu Y29kZXItPmVuY29kZVVJbnQ2NChoYXNoTWFwLnNpemUoKSk7CisgICAgICAgIGZvciAodHlwZW5h bWUgSGFzaE1hcFR5cGU6OmNvbnN0X2l0ZXJhdG9yIGl0ID0gaGFzaE1hcC5iZWdpbigpLCBlbmQg PSBoYXNoTWFwLmVuZCgpOyBpdCAhPSBlbmQ7ICsraXQpCisgICAgICAgICAgICBlbmNvZGVyLT5l bmNvZGUoKml0KTsKKyAgICB9CisKKyAgICBzdGF0aWMgYm9vbCBkZWNvZGUoQXJndW1lbnREZWNv ZGVyKiBkZWNvZGVyLCBIYXNoTWFwVHlwZSYgaGFzaE1hcCkKKyAgICB7CisgICAgICAgIHVpbnQ2 NF90IGhhc2hNYXBTaXplOworICAgICAgICBpZiAoIWRlY29kZXItPmRlY29kZShoYXNoTWFwU2l6 ZSkpCisgICAgICAgICAgICByZXR1cm4gZmFsc2U7CisKKyAgICAgICAgSGFzaE1hcFR5cGUgdGVt cEhhc2hNYXA7CisgICAgICAgIGZvciAodWludDY0X3QgaSA9IDA7IGkgPCBoYXNoTWFwU2l6ZTsg KytpKSB7CisgICAgICAgICAgICBLZXlBcmcga2V5OworICAgICAgICAgICAgTWFwcGVkQXJnIHZh bHVlOworICAgICAgICAgICAgaWYgKCFkZWNvZGVyLT5kZWNvZGUoa2V5KSkKKyAgICAgICAgICAg ICAgICByZXR1cm4gZmFsc2U7CisgICAgICAgICAgICBpZiAoIWRlY29kZXItPmRlY29kZSh2YWx1 ZSkpCisgICAgICAgICAgICAgICAgcmV0dXJuIGZhbHNlOworCisgICAgICAgICAgICBpZiAoIXRl bXBIYXNoTWFwLmFkZChrZXksIHZhbHVlKS5zZWNvbmQpIHsKKyAgICAgICAgICAgICAgICAvLyBU aGUgaGFzaCBtYXAgYWxyZWFkeSBoYXMgdGhlIHNwZWNpZmllZCBrZXksIGJhaWwuCisgICAgICAg ICAgICAgICAgZGVjb2Rlci0+bWFya0ludmFsaWQoKTsKKyAgICAgICAgICAgICAgICByZXR1cm4g ZmFsc2U7CisgICAgICAgICAgICB9CisgICAgICAgIH0KKworICAgICAgICBoYXNoTWFwLnN3YXAo dGVtcEhhc2hNYXApOworICAgICAgICByZXR1cm4gdHJ1ZTsKKyAgICB9Cit9OworCiB9IC8vIG5h bWVzcGFjZSBDb3JlSVBDCiAKICNlbmRpZiAvLyBTaW1wbGVBcmd1bWVudENvZGVyX2gKZGlmZiAt LWdpdCBhL1dlYktpdDIvUGxhdGZvcm0vQ29yZUlQQy9Bcmd1bWVudHMuaCBiL1dlYktpdDIvUGxh dGZvcm0vQ29yZUlQQy9Bcmd1bWVudHMuaAppbmRleCAwNTMzZGM1MjUxMjllMDAwNzU0Y2Y1ZDVl OTllY2UzYTkxMzY3NTE1Li42NzVhNzVlNWVhOWU4MjE2ZjcxMGM4MjJjYzc4NWY4ZjZlZGY1YTIz IDEwMDY0NAotLS0gYS9XZWJLaXQyL1BsYXRmb3JtL0NvcmVJUEMvQXJndW1lbnRzLmgKKysrIGIv V2ViS2l0Mi9QbGF0Zm9ybS9Db3JlSVBDL0FyZ3VtZW50cy5oCkBAIC02NSw3ICs2NSw3IEBAIHB1 YmxpYzoKICAgICAgICAgZW5jb2Rlci0+ZW5jb2RlKG1fdmFsdWUpOwogICAgIH0KIAotICAgIHN0 YXRpYyBib29sIGRlY29kZShBcmd1bWVudERlY29kZXIqIGRlY29kZXIsIEFyZ3VtZW50czE8VDE+ JiByZXN1bHQpCisgICAgc3RhdGljIGJvb2wgZGVjb2RlKEFyZ3VtZW50RGVjb2RlciogZGVjb2Rl ciwgQXJndW1lbnRzMSYgcmVzdWx0KQogICAgIHsKICAgICAgICAgcmV0dXJuIGRlY29kZXItPmRl Y29kZShyZXN1bHQubV92YWx1ZSk7CiAgICAgfQpAQCAtOTgsNyArOTgsNyBAQCBwdWJsaWM6CiAg ICAgICAgIGVuY29kZXItPmVuY29kZShtX3ZhbHVlKTsKICAgICB9CiAKLSAgICBzdGF0aWMgYm9v bCBkZWNvZGUoQXJndW1lbnREZWNvZGVyKiBkZWNvZGVyLCBBcmd1bWVudHMyPFQxLCBUMj4mIHJl c3VsdCkKKyAgICBzdGF0aWMgYm9vbCBkZWNvZGUoQXJndW1lbnREZWNvZGVyKiBkZWNvZGVyLCBB cmd1bWVudHMyJiByZXN1bHQpCiAgICAgewogICAgICAgICBpZiAoIUFyZ3VtZW50czE8VDE+Ojpk ZWNvZGUoZGVjb2RlciwgcmVzdWx0KSkKICAgICAgICAgICAgIHJldHVybiBmYWxzZTsKQEAgLTEz NCw3ICsxMzQsNyBAQCBwdWJsaWM6CiAgICAgICAgIGVuY29kZXItPmVuY29kZShtX3ZhbHVlKTsK ICAgICB9CiAKLSAgICBzdGF0aWMgYm9vbCBkZWNvZGUoQXJndW1lbnREZWNvZGVyKiBkZWNvZGVy LCBBcmd1bWVudHMzPFQxLCBUMiwgVDM+JiByZXN1bHQpCisgICAgc3RhdGljIGJvb2wgZGVjb2Rl KEFyZ3VtZW50RGVjb2RlciogZGVjb2RlciwgQXJndW1lbnRzMyYgcmVzdWx0KQogICAgIHsKICAg ICAgICAgaWYgKCFBcmd1bWVudHMyPFQxLCBUMj46OmRlY29kZShkZWNvZGVyLCByZXN1bHQpKQog ICAgICAgICAgICAgcmV0dXJuIGZhbHNlOwpAQCAtMTcwLDcgKzE3MCw3IEBAIHB1YmxpYzoKICAg ICAgICAgZW5jb2Rlci0+ZW5jb2RlKG1fdmFsdWUpOwogICAgIH0KICAgICAKLSAgICBzdGF0aWMg Ym9vbCBkZWNvZGUoQXJndW1lbnREZWNvZGVyKiBkZWNvZGVyLCBBcmd1bWVudHM0PFQxLCBUMiwg VDMsIFQ0PiYgcmVzdWx0KQorICAgIHN0YXRpYyBib29sIGRlY29kZShBcmd1bWVudERlY29kZXIq IGRlY29kZXIsIEFyZ3VtZW50czQmIHJlc3VsdCkKICAgICB7CiAgICAgICAgIGlmICghQXJndW1l bnRzMzxUMSwgVDIsIFQzPjo6ZGVjb2RlKGRlY29kZXIsIHJlc3VsdCkpCiAgICAgICAgICAgICBy ZXR1cm4gZmFsc2U7CkBAIC0yMDYsNyArMjA2LDcgQEAgcHVibGljOgogICAgICAgICBlbmNvZGVy LT5lbmNvZGUobV92YWx1ZSk7CiAgICAgfQogICAgIAotICAgIHN0YXRpYyBib29sIGRlY29kZShB cmd1bWVudERlY29kZXIqIGRlY29kZXIsIEFyZ3VtZW50czU8VDEsIFQyLCBUMywgVDQsIFQ1PiYg cmVzdWx0KQorICAgIHN0YXRpYyBib29sIGRlY29kZShBcmd1bWVudERlY29kZXIqIGRlY29kZXIs IEFyZ3VtZW50czUmIHJlc3VsdCkKICAgICB7CiAgICAgICAgIGlmICghQXJndW1lbnRzNDxUMSwg VDIsIFQzLCBUND46OmRlY29kZShkZWNvZGVyLCByZXN1bHQpKQogICAgICAgICAgICAgcmV0dXJu IGZhbHNlOwpAQCAtMjQyLDcgKzI0Miw3IEBAIHB1YmxpYzoKICAgICAgICAgZW5jb2Rlci0+ZW5j b2RlKG1fdmFsdWUpOwogICAgIH0KICAgICAKLSAgICBzdGF0aWMgYm9vbCBkZWNvZGUoQXJndW1l bnREZWNvZGVyKiBkZWNvZGVyLCBBcmd1bWVudHM2PFQxLCBUMiwgVDMsIFQ0LCBUNSwgVDY+JiBy ZXN1bHQpCisgICAgc3RhdGljIGJvb2wgZGVjb2RlKEFyZ3VtZW50RGVjb2RlciogZGVjb2Rlciwg QXJndW1lbnRzNiYgcmVzdWx0KQogICAgIHsKICAgICAgICAgaWYgKCFBcmd1bWVudHM1PFQxLCBU MiwgVDMsIFQ0LCBUNT46OmRlY29kZShkZWNvZGVyLCByZXN1bHQpKQogICAgICAgICAgICAgcmV0 dXJuIGZhbHNlOwpAQCAtMjY0LDYgKzI2NCw0MiBAQCB0ZW1wbGF0ZTx0eXBlbmFtZSBUMSwgdHlw ZW5hbWUgVDIsIHR5cGVuYW1lIFQzLCB0eXBlbmFtZSBUNCwgdHlwZW5hbWUgVDUsIHR5cGVuYQog ICAgIHJldHVybiBBcmd1bWVudHM2PFQxJiwgVDImLCBUMyYsIFQ0JiwgVDUmLCBUNiY+KHQxLCB0 MiwgdDMsIHQ0LCB0NSwgdDYpOwogfQogCit0ZW1wbGF0ZTx0eXBlbmFtZSBUMSwgdHlwZW5hbWUg VDIsIHR5cGVuYW1lIFQzLCB0eXBlbmFtZSBUNCwgdHlwZW5hbWUgVDUsIHR5cGVuYW1lIFQ2LCB0 eXBlbmFtZSBUNz4gY2xhc3MgQXJndW1lbnRzNyA6IEFyZ3VtZW50czY8VDEsIFQyLCBUMywgVDQs IFQ1LCBUNj4geworcHVibGljOgorICAgIEFyZ3VtZW50czcoVDEgdDEsIFQyIHQyLCBUMyB0Mywg VDQgdDQsIFQ1IHQ1LCBUNiB0NiwgVDcgdDcpCisgICAgICAgIDogQXJndW1lbnRzNjxUMSwgVDIs IFQzLCBUNCwgVDUsIFQ2Pih0MSwgdDIsIHQzLCB0NCwgdDUsIHQ2KQorICAgICAgICAsIG1fdmFs dWUodDcpCisgICAgeworICAgIH0KKworICAgIHZvaWQgZW5jb2RlKEFyZ3VtZW50RW5jb2Rlciog ZW5jb2RlcikgY29uc3QKKyAgICB7CisgICAgICAgIEFyZ3VtZW50czY8VDEsIFQyLCBUMywgVDQs IFQ1LCBUNj46OmVuY29kZShlbmNvZGVyKTsKKyAgICAgICAgZW5jb2Rlci0+ZW5jb2RlKG1fdmFs dWUpOworICAgIH0KKyAgICAKKyAgICBzdGF0aWMgYm9vbCBkZWNvZGUoQXJndW1lbnREZWNvZGVy KiBkZWNvZGVyLCBBcmd1bWVudHM3JiByZXN1bHQpCisgICAgeworICAgICAgICBpZiAoIUFyZ3Vt ZW50czY8VDEsIFQyLCBUMywgVDQsIFQ1LCBUNj46OmRlY29kZShkZWNvZGVyLCByZXN1bHQpKQor ICAgICAgICAgICAgcmV0dXJuIGZhbHNlOworICAgICAgICAKKyAgICAgICAgcmV0dXJuIGRlY29k ZXItPmRlY29kZShyZXN1bHQubV92YWx1ZSk7CisgICAgfQorCitwcml2YXRlOgorICAgIFQ3IG1f dmFsdWU7Cit9OworCit0ZW1wbGF0ZTx0eXBlbmFtZSBUMSwgdHlwZW5hbWUgVDIsIHR5cGVuYW1l IFQzLCB0eXBlbmFtZSBUNCwgdHlwZW5hbWUgVDUsIHR5cGVuYW1lIFQ2LCB0eXBlbmFtZSBUNz4g QXJndW1lbnRzNzxjb25zdCBUMSYsIGNvbnN0IFQyJiwgY29uc3QgVDMmLCBjb25zdCBUNCYsIGNv bnN0IFQ1JiwgY29uc3QgVDYmLCBjb25zdCBUNyY+IEluKGNvbnN0IFQxJiB0MSwgY29uc3QgVDIm IHQyLCBjb25zdCBUMyAmdDMsIGNvbnN0IFQ0JiB0NCwgY29uc3QgVDUmIHQ1LCBjb25zdCBUNiYg dDYsIGNvbnN0IFQ3JiB0NykKK3sKKyAgICByZXR1cm4gQXJndW1lbnRzNzxjb25zdCBUMSYsIGNv bnN0IFQyJiwgY29uc3QgVDMmLCBjb25zdCBUNCYsIGNvbnN0IFQ1JiwgY29uc3QgVDYmLCBjb25z dCBUNyY+KHQxLCB0MiwgdDMsIHQ0LCB0NSwgdDYsIHQ3KTsKK30KKwordGVtcGxhdGU8dHlwZW5h bWUgVDEsIHR5cGVuYW1lIFQyLCB0eXBlbmFtZSBUMywgdHlwZW5hbWUgVDQsIHR5cGVuYW1lIFQ1 LCB0eXBlbmFtZSBUNiwgdHlwZW5hbWUgVDc+IEFyZ3VtZW50czc8VDEmLCBUMiYsIFQzJiwgVDQm LCBUNSYsIFQ2JiwgVDcmPiBPdXQoVDEmIHQxLCBUMiYgdDIsIFQzJiB0MywgVDQmIHQ0LCBUNSYg dDUsIFQ2JiB0NiwgVDcmIHQ3KQoreworICAgIHJldHVybiBBcmd1bWVudHM3PFQxJiwgVDImLCBU MyYsIFQ0JiwgVDUmLCBUNiYsIFQ3Jj4odDEsIHQyLCB0MywgdDQsIHQ1LCB0NiwgdDcpOworfQor CiB9IC8vIG5hbWVzcGFjZSBDb3JlSVBDCiAKICNlbmRpZiAvLyBBcmd1bWVudHNfaAo=