45985 2010-09-17 12:26:28 -0700 Add bool wrapper for WebKit2 API 2010-09-17 12:48:33 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 sam webkit-unassigned webkit.review.bot oldest_to_newest 280787 0 sam 2010-09-17 12:26:28 -0700 Add bool wrapper for WebKit2 API 280789 1 67934 sam 2010-09-17 12:27:13 -0700 Created attachment 67934 Patch 280792 2 webkit.review.bot 2010-09-17 12:29:13 -0700 Attachment 67934 did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebKit2/UIProcess/API/C/WKAPICast.h:68: More than one command on the same line [whitespace/newline] [4] WebKit2/UIProcess/API/C/WKAPICast.h:99: More than one command on the same line [whitespace/newline] [4] Total errors found: 2 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style. 280793 3 67934 sullivan 2010-09-17 12:31:27 -0700 Comment on attachment 67934 Patch r+, assuming the style complaints are bogus (or you fix them). 280813 4 sam 2010-09-17 12:48:33 -0700 Landed in http://trac.webkit.org/changeset/67738. 67934 2010-09-17 12:27:13 -0700 2010-09-17 12:31:27 -0700 Patch bool.diff text/plain 5431 sam SW5kZXg6IFdlYktpdDIvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdDIvQ2hhbmdlTG9n CShyZXZpc2lvbiA2NzczNykKKysrIFdlYktpdDIvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjEgQEAKKzIwMTAtMDktMTcgIFNhbSBXZWluaWcgIDxzYW1Ad2Via2l0Lm9yZz4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgYm9v bCB3cmFwcGVyIGZvciBXZWJLaXQyIEFQSQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9NDU5ODUKKworICAgICAgICAqIFNoYXJlZC9BUElPYmplY3QuaDoK KyAgICAgICAgKiBTaGFyZWQvV2ViTnVtYmVyLmg6CisgICAgICAgICogVUlQcm9jZXNzL0FQSS9D L1dLQVBJQ2FzdC5oOgorICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvQy9XS0Jhc2UuaDoKKyAgICAg ICAgKiBVSVByb2Nlc3MvQVBJL0MvV0tOdW1iZXIuY3BwOgorICAgICAgICAoV0tCb29sZWFuR2V0 VHlwZUlEKToKKyAgICAgICAgKFdLQm9vbGVhbkNyZWF0ZSk6CisgICAgICAgIChXS0Jvb2xlYW5H ZXRWYWx1ZSk6CisgICAgICAgIChXS0Jvb2xlYW5TZXRWYWx1ZSk6CisgICAgICAgICogVUlQcm9j ZXNzL0FQSS9DL1dLTnVtYmVyLmg6CisKIDIwMTAtMDktMTYgIFNhbSBXZWluaWcgIDxzYW1Ad2Vi a2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBBbmRlcnMgQ2FybHNzb24uCkluZGV4OiBX ZWJLaXQyL1NoYXJlZC9BUElPYmplY3QuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXQyL1NoYXJlZC9B UElPYmplY3QuaAkocmV2aXNpb24gNjc2NTgpCisrKyBXZWJLaXQyL1NoYXJlZC9BUElPYmplY3Qu aAkod29ya2luZyBjb3B5KQpAQCAtNDYsNiArNDYsNyBAQCBwdWJsaWM6CiAgICAgICAgIFR5cGVV UkxSZXNwb25zZSwKIAogICAgICAgICAvLyBCYXNlIG51bWVyaWMgdHlwZXMKKyAgICAgICAgVHlw ZUJvb2xlYW4sCiAgICAgICAgIFR5cGVEb3VibGUsCiAgICAgICAgIFR5cGVVSW50NjQsCiAgICAg ICAgIApJbmRleDogV2ViS2l0Mi9TaGFyZWQvV2ViTnVtYmVyLmgKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2Vi S2l0Mi9TaGFyZWQvV2ViTnVtYmVyLmgJKHJldmlzaW9uIDY3NjU4KQorKysgV2ViS2l0Mi9TaGFy ZWQvV2ViTnVtYmVyLmgJKHdvcmtpbmcgY29weSkKQEAgLTU1LDYgKzU1LDcgQEAgcHJpdmF0ZToK ICAgICBOdW1iZXJUeXBlIG1fdmFsdWU7CiB9OwogCit0eXBlZGVmIFdlYk51bWJlcjxib29sLCBB UElPYmplY3Q6OlR5cGVCb29sZWFuPiBXZWJCb29sZWFuOwogdHlwZWRlZiBXZWJOdW1iZXI8ZG91 YmxlLCBBUElPYmplY3Q6OlR5cGVEb3VibGU+IFdlYkRvdWJsZTsKIHR5cGVkZWYgV2ViTnVtYmVy PHVpbnQ2NF90LCBBUElPYmplY3Q6OlR5cGVVSW50NjQ+IFdlYlVJbnQ2NDsKIApJbmRleDogV2Vi S2l0Mi9VSVByb2Nlc3MvQVBJL0MvV0tBUElDYXN0LmgKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0Mi9V SVByb2Nlc3MvQVBJL0MvV0tBUElDYXN0LmgJKHJldmlzaW9uIDY3NjU4KQorKysgV2ViS2l0Mi9V SVByb2Nlc3MvQVBJL0MvV0tBUElDYXN0LmgJKHdvcmtpbmcgY29weSkKQEAgLTY1LDYgKzY1LDcg QEAgdGVtcGxhdGU8dHlwZW5hbWUgQVBJVHlwZT4gc3RydWN0IEFQSVR5cAogdGVtcGxhdGU8PiBz dHJ1Y3QgQVBJVHlwZUluZm88V0tBcnJheVJlZj4gICAgICAgICAgICAgICAgICAgICAgIHsgdHlw ZWRlZiBJbW11dGFibGVBcnJheSogSW1wbFR5cGU7IH07CiB0ZW1wbGF0ZTw+IHN0cnVjdCBBUElU eXBlSW5mbzxXS0JhY2tGb3J3YXJkTGlzdEl0ZW1SZWY+ICAgICAgICAgeyB0eXBlZGVmIFdlYkJh Y2tGb3J3YXJkTGlzdEl0ZW0qIEltcGxUeXBlOyB9OwogdGVtcGxhdGU8PiBzdHJ1Y3QgQVBJVHlw ZUluZm88V0tCYWNrRm9yd2FyZExpc3RSZWY+ICAgICAgICAgICAgIHsgdHlwZWRlZiBXZWJCYWNr Rm9yd2FyZExpc3QqIEltcGxUeXBlOyB9OwordGVtcGxhdGU8PiBzdHJ1Y3QgQVBJVHlwZUluZm88 V0tCb29sZWFuUmVmPiAgICAgICAgICAgICAgICAgICAgIHsgdHlwZWRlZiBXZWJCb29sZWFuKiBJ bXBsVHlwZTsgfTsKIHRlbXBsYXRlPD4gc3RydWN0IEFQSVR5cGVJbmZvPFdLQ29udGV4dFJlZj4g ICAgICAgICAgICAgICAgICAgICB7IHR5cGVkZWYgV2ViQ29udGV4dCogSW1wbFR5cGU7IH07CiB0 ZW1wbGF0ZTw+IHN0cnVjdCBBUElUeXBlSW5mbzxXS0RhdGFSZWY+ICAgICAgICAgICAgICAgICAg ICAgICAgeyB0eXBlZGVmIFdlYkRhdGEqIEltcGxUeXBlOyB9OwogdGVtcGxhdGU8PiBzdHJ1Y3Qg QVBJVHlwZUluZm88V0tEaWN0aW9uYXJ5UmVmPiAgICAgICAgICAgICAgICAgIHsgdHlwZWRlZiBJ bW11dGFibGVEaWN0aW9uYXJ5KiBJbXBsVHlwZTsgfTsKQEAgLTk1LDYgKzk2LDcgQEAgdGVtcGxh dGU8PiBzdHJ1Y3QgSW1wbFR5cGVJbmZvPE11dGFibGVBcgogdGVtcGxhdGU8PiBzdHJ1Y3QgSW1w bFR5cGVJbmZvPE11dGFibGVEaWN0aW9uYXJ5Kj4gICAgICAgICAgICAgIHsgdHlwZWRlZiBXS011 dGFibGVEaWN0aW9uYXJ5UmVmIEFQSVR5cGU7IH07CiB0ZW1wbGF0ZTw+IHN0cnVjdCBJbXBsVHlw ZUluZm88V2ViQmFja0ZvcndhcmRMaXN0Kj4gICAgICAgICAgICAgeyB0eXBlZGVmIFdLQmFja0Zv cndhcmRMaXN0UmVmIEFQSVR5cGU7IH07CiB0ZW1wbGF0ZTw+IHN0cnVjdCBJbXBsVHlwZUluZm88 V2ViQmFja0ZvcndhcmRMaXN0SXRlbSo+ICAgICAgICAgeyB0eXBlZGVmIFdLQmFja0ZvcndhcmRM aXN0SXRlbVJlZiBBUElUeXBlOyB9OwordGVtcGxhdGU8PiBzdHJ1Y3QgSW1wbFR5cGVJbmZvPFdl YkJvb2xlYW4qPiAgICAgICAgICAgICAgICAgICAgIHsgdHlwZWRlZiBXS0Jvb2xlYW5SZWYgQVBJ VHlwZTsgfTsKIHRlbXBsYXRlPD4gc3RydWN0IEltcGxUeXBlSW5mbzxXZWJDb250ZXh0Kj4gICAg ICAgICAgICAgICAgICAgICB7IHR5cGVkZWYgV0tDb250ZXh0UmVmIEFQSVR5cGU7IH07CiB0ZW1w bGF0ZTw+IHN0cnVjdCBJbXBsVHlwZUluZm88V2ViRGF0YSo+ICAgICAgICAgICAgICAgICAgICAg ICAgeyB0eXBlZGVmIFdLRGF0YVJlZiBBUElUeXBlOyB9OwogdGVtcGxhdGU8PiBzdHJ1Y3QgSW1w bFR5cGVJbmZvPFdlYkRvdWJsZSo+ICAgICAgICAgICAgICAgICAgICAgIHsgdHlwZWRlZiBXS0Rv dWJsZVJlZiBBUElUeXBlOyB9OwpJbmRleDogV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0MvV0tCYXNl LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0MvV0tCYXNlLmgJKHJldmlz aW9uIDY3NjU4KQorKysgV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0MvV0tCYXNlLmgJKHdvcmtpbmcg Y29weSkKQEAgLTQzLDYgKzQzLDcgQEAgdHlwZWRlZiBzdHJ1Y3QgT3BhcXVlV0tEaWN0aW9uYXJ5 KiBXS011dAogCiB0eXBlZGVmIGNvbnN0IHN0cnVjdCBPcGFxdWVXS0JhY2tGb3J3YXJkTGlzdCog V0tCYWNrRm9yd2FyZExpc3RSZWY7CiB0eXBlZGVmIGNvbnN0IHN0cnVjdCBPcGFxdWVXS0JhY2tG b3J3YXJkTGlzdEl0ZW0qIFdLQmFja0ZvcndhcmRMaXN0SXRlbVJlZjsKK3R5cGVkZWYgY29uc3Qg c3RydWN0IE9wYXF1ZVdLQm9vbGVhbiogV0tCb29sZWFuUmVmOwogdHlwZWRlZiBjb25zdCBzdHJ1 Y3QgT3BhcXVlV0tDb250ZXh0KiBXS0NvbnRleHRSZWY7CiB0eXBlZGVmIGNvbnN0IHN0cnVjdCBP cGFxdWVXS0RhdGEqIFdLRGF0YVJlZjsKIHR5cGVkZWYgY29uc3Qgc3RydWN0IE9wYXF1ZVdLRG91 YmxlKiBXS0RvdWJsZVJlZjsKSW5kZXg6IFdlYktpdDIvVUlQcm9jZXNzL0FQSS9DL1dLTnVtYmVy LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQy9XS051bWJlci5jcHAJ KHJldmlzaW9uIDY3NjU4KQorKysgV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0MvV0tOdW1iZXIuY3Bw CSh3b3JraW5nIGNvcHkpCkBAIC0zMCw2ICszMCwyNyBAQAogCiB1c2luZyBuYW1lc3BhY2UgV2Vi S2l0OwogCitXS1R5cGVJRCBXS0Jvb2xlYW5HZXRUeXBlSUQoKQoreworICAgIHJldHVybiB0b1Jl ZihXZWJCb29sZWFuOjpBUElUeXBlKTsKK30KKworV0tCb29sZWFuUmVmIFdLQm9vbGVhbkNyZWF0 ZShib29sIHZhbHVlKQoreworICAgIFJlZlB0cjxXZWJCb29sZWFuPiBib29sZWFuT2JqZWN0ID0g V2ViQm9vbGVhbjo6Y3JlYXRlKHZhbHVlKTsKKyAgICByZXR1cm4gdG9SZWYoYm9vbGVhbk9iamVj dC5yZWxlYXNlKCkucmVsZWFzZVJlZigpKTsKK30KKworYm9vbCBXS0Jvb2xlYW5HZXRWYWx1ZShX S0Jvb2xlYW5SZWYgYm9vbGVhblJlZikKK3sKKyAgICByZXR1cm4gdG9XSyhib29sZWFuUmVmKS0+ dmFsdWUoKTsKK30KKwordm9pZCBXS0Jvb2xlYW5TZXRWYWx1ZShXS0Jvb2xlYW5SZWYgYm9vbGVh blJlZiwgYm9vbCB2YWx1ZSkKK3sKKyAgICB0b1dLKGJvb2xlYW5SZWYpLT5zZXRWYWx1ZSh2YWx1 ZSk7Cit9CisKIFdLVHlwZUlEIFdLRG91YmxlR2V0VHlwZUlEKCkKIHsKICAgICByZXR1cm4gdG9S ZWYoV2ViRG91YmxlOjpBUElUeXBlKTsKSW5kZXg6IFdlYktpdDIvVUlQcm9jZXNzL0FQSS9DL1dL TnVtYmVyLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0MvV0tOdW1iZXIu aAkocmV2aXNpb24gNjc2NTgpCisrKyBXZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQy9XS051bWJlci5o CSh3b3JraW5nIGNvcHkpCkBAIC0zMiw2ICszMiwxMiBAQAogZXh0ZXJuICJDIiB7CiAjZW5kaWYK IAorLyogV0tCb29sZWFuICovCitXS19FWFBPUlQgV0tUeXBlSUQgV0tCb29sZWFuR2V0VHlwZUlE KCk7CitXS19FWFBPUlQgV0tCb29sZWFuUmVmIFdLQm9vbGVhbkNyZWF0ZShib29sIHZhbHVlKTsK K1dLX0VYUE9SVCBib29sIFdLQm9vbGVhbkdldFZhbHVlKFdLQm9vbGVhblJlZiBib29sZWFuUmVm KTsKK1dLX0VYUE9SVCB2b2lkIFdLQm9vbGVhblNldFZhbHVlKFdLQm9vbGVhblJlZiBib29sZWFu UmVmLCBib29sIHZhbHVlKTsKKwogLyogV0tEb3VibGUgKi8KIFdLX0VYUE9SVCBXS1R5cGVJRCBX S0RvdWJsZUdldFR5cGVJRCgpOwogV0tfRVhQT1JUIFdLRG91YmxlUmVmIFdLRG91YmxlQ3JlYXRl KGRvdWJsZSB2YWx1ZSk7Cg==