45968 2010-09-17 08:58:29 -0700 [CHROMIUM] GPU-accelerated canvas should work in test_shell. 2010-09-17 11:02:03 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) PC Windows 7 RESOLVED FIXED P2 Normal --- 1 senorblanco senorblanco jamesr kbr zmo oldest_to_newest 280667 0 senorblanco 2010-09-17 08:58:29 -0700 The shaders for GPU-accelerated canvas should be modified to work in the in-process Mesa backend in test_shell. 280670 1 67913 senorblanco 2010-09-17 09:07:54 -0700 Created attachment 67913 Patch 280681 2 kbr 2010-09-17 09:23:43 -0700 While I think this might be a good idea in the short term, I'm not sure it's a good idea in the long term. zmo was working on integrating the ANGLE shader translator with the in-process WebGL implementation, which should allow the precision qualifiers to work unmodified. 280684 3 senorblanco 2010-09-17 09:31:22 -0700 (In reply to comment #2) > While I think this might be a good idea in the short term, I'm not sure it's a good idea in the long term. zmo was working on integrating the ANGLE shader translator with the in-process WebGL implementation, which should allow the precision qualifiers to work unmodified. As I'm sure you know, this technique has been used on a lot of WebGL content to satisfy the recent spec change while still remaining compatible with older browsers. It should work fine after the translator is implemented, at which point we can remove the #ifdefs at our leisure. Testing is a pretty high priority IMHO, so could we let this in for now? 280701 4 67913 kbr 2010-09-17 10:10:59 -0700 Comment on attachment 67913 Patch OK. 280744 5 senorblanco 2010-09-17 11:02:03 -0700 Committed r67727: <http://trac.webkit.org/changeset/67727> 67913 2010-09-17 09:07:54 -0700 2010-09-17 10:10:58 -0700 Patch bug-45968-20100917120752.patch text/plain 2366 senorblanco SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2NzcwOCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjIgQEAKKzIwMTAtMDktMTcgIFN0ZXBoZW4gV2hpdGUgIDxzZW5vcmJsYW5jb0Bj aHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgW0NIUk9NSVVNXSBHUFUtYWNjZWxlcmF0ZWQgY2FudmFzIHNob3VsZCB3b3JrIGluIHRl c3Rfc2hlbGwuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD00NTk2OAorCisgICAgICAgIEluIG9yZGVyIGZvciB0aGUgc2hhZGVycyBpbiBHUFUtYWNjZWxl cmF0ZWQgY2FudmFzIHRvIHdvcmsgaW4gYm90aCB0aGUKKyAgICAgICAgR3JhcGhpY3NDb250ZXh0 M0QgLyBHTEVTMiBwYXRoIGFzIHdlbGwgYXMgY2hyb21pdW0ncyB0ZXN0X3NoZWxsICh3aGljaAor ICAgICAgICBwYXNzZXMgdGhlbSB0byB0aGUgTWVzYSBiYWNrZW5kIHVubW9kaWZpZWQpLCB0aGUg cHJlY2lzaW9uIHNwZWNpZmllcnMKKyAgICAgICAgaW4gdGhlIGZyYWdtZW50IHNoYWRlciBoYXZl IHRvIGJlIHdyYXBwZWQgaW4gI2lmIEdMX0VTLgorCisgICAgICAgIFNvb24gdG8gYmUgY292ZXJl ZCBieSBtYW55IGxheW91dCB0ZXN0cy4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2dw dS9Tb2xpZEZpbGxTaGFkZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6U29saWRGaWxsU2hhZGVy OjpjcmVhdGUpOgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2dwdS9UZXhTaGFkZXIuY3Bw OgorICAgICAgICAoV2ViQ29yZTo6VGV4U2hhZGVyOjpjcmVhdGUpOgorCiAyMDEwLTA5LTE3ICBB bGV4YW5kZXIgUGF2bG92ICA8YXBhdmxvdkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgVW5yZXZp ZXdlZCwgYnVpbGQgZml4LiBBZGQgZmlsZXMgbWlzc2VkIGluIHRoZSBwcmV2aW91cyBjb21taXQu CkluZGV4OiBXZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dwdS9Tb2xpZEZpbGxTaGFkZXIuY3Bw Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3B1L1NvbGlkRmlsbFNo YWRlci5jcHAJKHJldmlzaW9uIDY3NzA3KQorKysgV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9n cHUvU29saWRGaWxsU2hhZGVyLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNTQsNyArNTQsOSBAQCBQ YXNzT3duUHRyPFNvbGlkRmlsbFNoYWRlcj4gU29saWRGaWxsU2hhCiAgICAgICAgICAgICAiICAg IGdsX1Bvc2l0aW9uID0gdmVjNChtYXRyaXggKiBwb3NpdGlvbiwgMS4wKTtcbiIKICAgICAgICAg ICAgICJ9XG4iOwogICAgIHN0YXRpYyBjb25zdCBjaGFyKiBmcmFnbWVudFNoYWRlclNvdXJjZSA9 CisgICAgICAgICAgICAiI2lmZGVmIEdMX0VTXG4iCiAgICAgICAgICAgICAicHJlY2lzaW9uIG1l ZGl1bXAgZmxvYXQ7XG4iCisgICAgICAgICAgICAiI2VuZGlmXG4iCiAgICAgICAgICAgICAidW5p Zm9ybSBtYXQzIG1hdHJpeDtcbiIKICAgICAgICAgICAgICJ1bmlmb3JtIHZlYzQgY29sb3I7XG4i CiAgICAgICAgICAgICAidm9pZCBtYWluKCkge1xuIgpJbmRleDogV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy9ncHUvVGV4U2hhZGVyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL2dwdS9UZXhTaGFkZXIuY3BwCShyZXZpc2lvbiA2NzcwNykKKysrIFdlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3MvZ3B1L1RleFNoYWRlci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTU3 LDcgKzU3LDkgQEAgUGFzc093blB0cjxUZXhTaGFkZXI+IFRleFNoYWRlcjo6Y3JlYXRlKAogICAg ICAgICAiICAgIGdsX1Bvc2l0aW9uID0gdmVjNChtYXRyaXggKiBwb3NpdGlvbiwgMS4wKTtcbiIK ICAgICAgICAgIn1cbiI7CiAgICAgc3RhdGljIGNvbnN0IGNoYXIqIGZyYWdtZW50U2hhZGVyU291 cmNlID0KKyAgICAgICAgIiNpZmRlZiBHTF9FU1xuIgogICAgICAgICAicHJlY2lzaW9uIG1lZGl1 bXAgZmxvYXQ7XG4iCisgICAgICAgICIjZW5kaWZcbiIKICAgICAgICAgInVuaWZvcm0gc2FtcGxl cjJEIHNhbXBsZXI7XG4iCiAgICAgICAgICJ1bmlmb3JtIGZsb2F0IGFscGhhO1xuIgogICAgICAg ICAidmFyeWluZyB2ZWMzIHRleENvb3JkO1xuIgo=