<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>4596</bug_id>
          
          <creation_ts>2005-08-23 00:21:06 -0700</creation_ts>
          <short_desc>cvs-create-patch --include-unknowns should ignore hidden files</short_desc>
          <delta_ts>2005-08-27 09:29:32 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>420+</version>
          <rep_platform>Mac</rep_platform>
          <op_sys>OS X 10.4</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Minor</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Anders Carlsson">andersca</reporter>
          <assigned_to name="Darin Adler">darin</assigned_to>
          
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>17171</commentid>
    <comment_count>0</comment_count>
    <who name="Anders Carlsson">andersca</who>
    <bug_when>2005-08-23 00:21:06 -0700</bug_when>
    <thetext>In my tree, I get a lot of .gdb_history files which cvs-create-patch --include-unknowns picks up. Since we 
don&apos;t have any hidden files in our tree and since it&apos;s unlikely that we&apos;ll ever have, --include-unknowns 
should simply ignore dotfiles.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>17229</commentid>
    <comment_count>1</comment_count>
    <who name="Darin Adler">darin</who>
    <bug_when>2005-08-23 09:48:24 -0700</bug_when>
    <thetext>It&apos;s challenging to ignore hidden files without using the special perl module that knows how to do it, which 
is not installed by default. I don&apos;t know if we&apos;re going to be able to do this in a complete way. But we 
might be able to do something good enough to handle .gdbhistory.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>17230</commentid>
    <comment_count>2</comment_count>
    <who name="Darin Adler">darin</who>
    <bug_when>2005-08-23 09:48:51 -0700</bug_when>
    <thetext>Oh, duh -- &quot;just ignore dotfiles&quot;. Easy to do, and good suggestion. Sorry, I misread this.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>