45937 2010-09-16 17:40:47 -0700 [chromium] ImageLayerChromium texture updates must be clipped to the size of the texture 2010-09-17 09:28:44 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 vangelis vangelis jamesr oldest_to_newest 280475 0 vangelis 2010-09-16 17:40:47 -0700 Currently the dirty rect used to update the texture can be larger than the size of the texture which can result in a crash. Dirty rects can get out of sync with image sizes if the compositor is behind in rendering and the Image has changed size in the meantime. 280476 1 67867 vangelis 2010-09-16 17:47:04 -0700 Created attachment 67867 Proposed patch 280682 2 vangelis 2010-09-17 09:28:44 -0700 Committed r67714: <http://trac.webkit.org/changeset/67714> 67867 2010-09-16 17:47:04 -0700 2010-09-16 19:37:39 -0700 Proposed patch clipImageUpdate_45937.txt text/plain 1676 vangelis SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2NzY4MCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMTAtMDktMTYgIFZhbmdlbGlzIEtva2tldmlzICA8dmFuZ2VsaXNA Y2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFtjaHJvbWl1bV0gQ2xpcCB0aGUgdXBkYXRlIHJlZ2lvbiBvZiBhbiBJbWFnZUxheWVy Q2hyb21pdW0gdG8gYWN0dWFsIHNpemUKKyAgICAgICAgb2YgdGhlIGltYWdlIGJpdG1hcCB0byBw cmV2ZW50IHVuaW5pdGlhbGl6ZWQgbWVtb3J5IGFjY2VzcyB3aGVuIHVwbG9hZGluZworICAgICAg ICB0aGUgZGlydHkgcmVnaW9uIHRvIHRoZSB0ZXh0dXJlLgorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDU5MzcKKworCisgICAgICAgICogcGxhdGZvcm0v Z3JhcGhpY3MvY2hyb21pdW0vSW1hZ2VMYXllckNocm9taXVtLmNwcDoKKyAgICAgICAgKFdlYkNv cmU6OkltYWdlTGF5ZXJDaHJvbWl1bTo6dXBkYXRlQ29udGVudHMpOgorCiAyMDEwLTA5LTE2ICBB bmRyZWFzIEtsaW5nICA8YW5kcmVhcy5rbGluZ0Bub2tpYS5jb20+CiAKICAgICAgICAgUmV2aWV3 ZWQgYnkgQXJpeWEgSGlkYXlhdC4KSW5kZXg6IFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hy b21pdW0vSW1hZ2VMYXllckNocm9taXVtLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL2Nocm9taXVtL0ltYWdlTGF5ZXJDaHJvbWl1bS5jcHAJKHJldmlzaW9uIDY3 NjM3KQorKysgV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9JbWFnZUxheWVyQ2hy b21pdW0uY3BwCSh3b3JraW5nIGNvcHkpCkBAIC03Niw3ICs3Niw2IEBAIHZvaWQgSW1hZ2VMYXll ckNocm9taXVtOjp1cGRhdGVDb250ZW50cygKICAgICBBU1NFUlQobGF5ZXJSZW5kZXJlcigpKTsK IAogICAgIHZvaWQqIHBpeGVscyA9IDA7Ci0gICAgSW50UmVjdCBkaXJ0eVJlY3QobV9kaXJ0eVJl Y3QpOwogICAgIEludFNpemUgcmVxdWlyZWRUZXh0dXJlU2l6ZTsKICAgICBJbnRTaXplIGJpdG1h cFNpemU7CiAKQEAgLTE0OCw2ICsxNDcsMTAgQEAgdm9pZCBJbWFnZUxheWVyQ2hyb21pdW06OnVw ZGF0ZUNvbnRlbnRzKAogICAgIGlmICghdGV4dHVyZUlkKQogICAgICAgICB0ZXh0dXJlSWQgPSBs YXllclJlbmRlcmVyKCktPmNyZWF0ZUxheWVyVGV4dHVyZSgpOwogCisgICAgLy8gQ2xpcCB0aGUg ZGlydHkgcmVjdCB0byB0aGUgYml0bWFwIGRpbWVuc2lvbnMuCisgICAgSW50UmVjdCBkaXJ0eVJl Y3QobV9kaXJ0eVJlY3QpOworICAgIGRpcnR5UmVjdC5pbnRlcnNlY3QoSW50UmVjdChJbnRQb2lu dCgwLCAwKSwgYml0bWFwU2l6ZSkpOworCiAgICAgaWYgKHBpeGVscykKICAgICAgICAgdXBkYXRl VGV4dHVyZVJlY3QocGl4ZWxzLCBiaXRtYXBTaXplLCByZXF1aXJlZFRleHR1cmVTaXplLCAgZGly dHlSZWN0LCB0ZXh0dXJlSWQpOwogfQo=