45923 2010-09-16 15:28:19 -0700 [Qt] Remove unnecessary QPainter::clipPath() call in TransparencyLayer() 2010-09-17 08:15:20 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) All All RESOLVED FIXED Performance, Qt, QtTriaged P2 Normal --- 1 kling webkit-qt-unassigned ademar oldest_to_newest 280390 0 kling 2010-09-16 15:28:19 -0700 QPainter::clipPath() can be very expensive, so use QPainter::hasClipping() instead of QPainter::clipPath().isEmpty(). 280393 1 67846 kling 2010-09-16 15:29:30 -0700 Created attachment 67846 Proposed patch 280396 2 67846 ariya.hidayat 2010-09-16 15:31:46 -0700 Comment on attachment 67846 Proposed patch LGTM. re=me. 280401 3 67846 kling 2010-09-16 15:35:37 -0700 Comment on attachment 67846 Proposed patch Clearing flags on attachment: 67846 Committed r67675: <http://trac.webkit.org/changeset/67675> 280402 4 kling 2010-09-16 15:35:47 -0700 All reviewed patches have been landed. Closing bug. 280646 5 ademar 2010-09-17 08:15:06 -0700 Revision r67675 cherry-picked into qtwebkit-2.1 with commit 52d2178 <http://gitorious.org/webkit/qtwebkit/commit/52d2178> 67846 2010-09-16 15:29:30 -0700 2010-09-16 15:35:37 -0700 Proposed patch bug-45923.diff text/plain 1413 kling ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZDIwZmJhMC4uY2I2NjdjYyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMC0wOS0xNiAgQW5kcmVhcyBLbGlu ZyAgPGFuZHJlYXMua2xpbmdAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gUmVtb3ZlIHVubmVjZXNzYXJ5IFFQYWludGVyOjpj bGlwUGF0aCgpIGNhbGwgaW4gVHJhbnNwYXJlbmN5TGF5ZXIoKQorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDU5MjMKKworICAgICAgICBRUGFpbnRlcjo6 Y2xpcFBhdGgoKSBjYW4gYmUgdmVyeSBleHBlbnNpdmUsIHNvIHVzZSBRUGFpbnRlcjo6aGFzQ2xp cHBpbmcoKQorICAgICAgICBpbnN0ZWFkIG9mIFFQYWludGVyOjpjbGlwUGF0aCgpLmlzRW1wdHko KS4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL3F0L1RyYW5zcGFyZW5jeUxheWVyLmg6 CisgICAgICAgIChXZWJDb3JlOjpUcmFuc3BhcmVuY3lMYXllcjo6VHJhbnNwYXJlbmN5TGF5ZXIp OgorCiAyMDEwLTA5LTE2ICBEYW5pZWwgQ2hlbmcgIDxkY2hlbmdAY2hyb21pdW0ub3JnPgogCiAg ICAgICAgIFJldmlld2VkIGJ5IFRvbnkgQ2hhbmcuCmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL3F0L1RyYW5zcGFyZW5jeUxheWVyLmggYi9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL3F0L1RyYW5zcGFyZW5jeUxheWVyLmgKaW5kZXggMWE2MTRhYy4uNzNhZDljNiAxMDA2 NDQKLS0tIGEvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9xdC9UcmFuc3BhcmVuY3lMYXllci5o CisrKyBiL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvcXQvVHJhbnNwYXJlbmN5TGF5ZXIuaApA QCAtNjEsOCArNjEsNyBAQCBzdHJ1Y3QgVHJhbnNwYXJlbmN5TGF5ZXIgOiBGYXN0QWxsb2NCYXNl IHsKICAgICAgICAgcGFpbnRlci5zZXRGb250KHAtPmZvbnQoKSk7CiAgICAgICAgIGlmIChwYWlu dGVyLnBhaW50RW5naW5lKCktPmhhc0ZlYXR1cmUoUVBhaW50RW5naW5lOjpQb3J0ZXJEdWZmKSkK ICAgICAgICAgICAgIHBhaW50ZXIuc2V0Q29tcG9zaXRpb25Nb2RlKHAtPmNvbXBvc2l0aW9uTW9k ZSgpKTsKLSAgICAgICAgLy8gaWYgdGhlIHBhdGggaXMgYW4gZW1wdHkgcmVnaW9uLCB0aGlzIGFz c2lnbm1lbnQgZGlzYWJsZXMgYWxsIHBhaW50aW5nCi0gICAgICAgIGlmICghcC0+Y2xpcFBhdGgo KS5pc0VtcHR5KCkpCisgICAgICAgIGlmIChwLT5oYXNDbGlwcGluZygpKQogICAgICAgICAgICAg cGFpbnRlci5zZXRDbGlwUGF0aChwLT5jbGlwUGF0aCgpKTsKICAgICB9CiAK