45921 2010-09-16 14:49:05 -0700 [chromium] Add needed entry points to WebGraphicsContext3D for compositor 2010-09-16 16:04:17 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 45912 1 kbr kbr jamesr senorblanco vangelis oldest_to_newest 280372 0 kbr 2010-09-16 14:49:05 -0700 In order to host the compositor on top of WebGraphicsContext3D, entry points are needed on WebGraphicsContext3D to select whether to render directly to the WebView, as well as for a couple of Chromium-specific extensions. 280420 1 67851 kbr 2010-09-16 15:53:27 -0700 Created attachment 67851 Patch 280428 2 kbr 2010-09-16 16:04:17 -0700 Committed r67677: <http://trac.webkit.org/changeset/67677> 67851 2010-09-16 15:53:27 -0700 2010-09-16 15:55:12 -0700 Patch wgc3d-entry-points.patch text/plain 7438 kbr SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZwkocmV2aXNpb24gNjc2NzYpCisrKyBXZWJLaXQvY2hyb21pdW0vQ2hh bmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjIgQEAKKzIwMTAtMDktMTYgIEtlbm5l dGggUnVzc2VsbCAgPGtickBnb29nbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFtjaHJvbWl1bV0gQWRkIG5lZWRlZCBlbnRyeSBwb2ludHMg dG8gV2ViR3JhcGhpY3NDb250ZXh0M0QgZm9yIGNvbXBvc2l0b3IKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ1OTIxCisKKyAgICAgICAgKiBwdWJsaWMv V2ViR3JhcGhpY3NDb250ZXh0M0QuaDoKKyAgICAgICAgKiBzcmMvV2ViR3JhcGhpY3NDb250ZXh0 M0REZWZhdWx0SW1wbC5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYkdyYXBoaWNzQ29udGV4dDNE RGVmYXVsdEltcGw6OmluaXRpYWxpemUpOgorICAgICAgICAoV2ViS2l0OjpXZWJHcmFwaGljc0Nv bnRleHQzRERlZmF1bHRJbXBsOjpzdXBwb3J0c01hcFN1YkNIUk9NSVVNKToKKyAgICAgICAgKFdl YktpdDo6V2ViR3JhcGhpY3NDb250ZXh0M0REZWZhdWx0SW1wbDo6bWFwQnVmZmVyU3ViRGF0YUNI Uk9NSVVNKToKKyAgICAgICAgKFdlYktpdDo6V2ViR3JhcGhpY3NDb250ZXh0M0REZWZhdWx0SW1w bDo6dW5tYXBCdWZmZXJTdWJEYXRhQ0hST01JVU0pOgorICAgICAgICAoV2ViS2l0OjpXZWJHcmFw aGljc0NvbnRleHQzRERlZmF1bHRJbXBsOjptYXBUZXhTdWJJbWFnZTJEQ0hST01JVU0pOgorICAg ICAgICAoV2ViS2l0OjpXZWJHcmFwaGljc0NvbnRleHQzRERlZmF1bHRJbXBsOjp1bm1hcFRleFN1 YkltYWdlMkRDSFJPTUlVTSk6CisgICAgICAgIChXZWJLaXQ6OldlYkdyYXBoaWNzQ29udGV4dDNE RGVmYXVsdEltcGw6OnN1cHBvcnRzQ29weVRleHR1cmVUb1BhcmVudFRleHR1cmVDSFJPTUlVTSk6 CisgICAgICAgIChXZWJLaXQ6OldlYkdyYXBoaWNzQ29udGV4dDNERGVmYXVsdEltcGw6OmNvcHlU ZXh0dXJlVG9QYXJlbnRUZXh0dXJlQ0hST01JVU0pOgorICAgICAgICAqIHNyYy9XZWJHcmFwaGlj c0NvbnRleHQzRERlZmF1bHRJbXBsLmg6CisKIDIwMTAtMDktMTUgIFRvbnkgQ2hhbmcgIDx0b255 QGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBLZW50IFRhbXVyYS4KSW5kZXg6 IFdlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViR3JhcGhpY3NDb250ZXh0M0QuaAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBXZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYkdyYXBoaWNzQ29udGV4dDNELmgJKHJldmlz aW9uIDY3NjcyKQorKysgV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJHcmFwaGljc0NvbnRleHQz RC5oCSh3b3JraW5nIGNvcHkpCkBAIC04Myw2ICs4MywxMSBAQCBwdWJsaWM6CiAKICAgICAvLyBJ bml0aWFsaXplcyB0aGUgZ3JhcGhpY3MgY29udGV4dDsgc2hvdWxkIGJlIHRoZSBmaXJzdCBvcGVy YXRpb24gcGVyZm9ybWVkCiAgICAgLy8gb24gbmV3bHktY29uc3RydWN0ZWQgaW5zdGFuY2VzLiBS ZXR1cm5zIHRydWUgb24gc3VjY2Vzcy4KKyAgICB2aXJ0dWFsIGJvb2wgaW5pdGlhbGl6ZShBdHRy aWJ1dGVzLCBXZWJWaWV3KiwgYm9vbCByZW5kZXJEaXJlY3RseVRvV2ViVmlldykgPSAwOworCisg ICAgLy8gSW5pdGlhbGl6ZXMgdGhlIGdyYXBoaWNzIGNvbnRleHQ7IHNob3VsZCBiZSB0aGUgZmly c3Qgb3BlcmF0aW9uIHBlcmZvcm1lZAorICAgIC8vIG9uIG5ld2x5LWNvbnN0cnVjdGVkIGluc3Rh bmNlcy4gUmV0dXJucyB0cnVlIG9uIHN1Y2Nlc3MuCisgICAgLy8gRklYTUU6IHJlbW92ZSB0aGlz IGVudHJ5IHBvaW50IG9uY2UgdGhlIGNvbXBvc2l0b3IgaXMgc3dpdGNoZWQgdG8gdXNlIEdyYXBo aWNzQ29udGV4dDNELgogICAgIHZpcnR1YWwgYm9vbCBpbml0aWFsaXplKEF0dHJpYnV0ZXMsIFdl YlZpZXcqKSA9IDA7CiAKICAgICAvLyBNYWtlcyB0aGUgT3BlbkdMIGNvbnRleHQgY3VycmVudCBv biB0aGUgY3VycmVudCB0aHJlYWQuIFJldHVybnMgdHJ1ZSBvbgpAQCAtMTM0LDggKzEzOSwyMCBA QCBwdWJsaWM6CiAgICAgLy8gZ2V0RXJyb3IgaW4gdGhlIG9yZGVyIHRoZXkgd2VyZSBhZGRlZC4K ICAgICB2aXJ0dWFsIHZvaWQgc3ludGhlc2l6ZUdMRXJyb3IodW5zaWduZWQgbG9uZyBlcnJvcikg PSAwOwogCisgICAgLy8gRVhUX3RleHR1cmVfZm9ybWF0X0JHUkE4ODg4CiAgICAgdmlydHVhbCBi b29sIHN1cHBvcnRzQkdSQSgpID0gMDsKIAorICAgIC8vIEdMX0NIUk9NSVVNX21hcF9zdWIKKyAg ICB2aXJ0dWFsIGJvb2wgc3VwcG9ydHNNYXBTdWJDSFJPTUlVTSgpID0gMDsKKyAgICB2aXJ0dWFs IHZvaWQqIG1hcEJ1ZmZlclN1YkRhdGFDSFJPTUlVTSh1bnNpZ25lZCB0YXJnZXQsIGludCBvZmZz ZXQsIGludCBzaXplLCB1bnNpZ25lZCBhY2Nlc3MpID0gMDsKKyAgICB2aXJ0dWFsIHZvaWQgdW5t YXBCdWZmZXJTdWJEYXRhQ0hST01JVU0oY29uc3Qgdm9pZCopID0gMDsKKyAgICB2aXJ0dWFsIHZv aWQqIG1hcFRleFN1YkltYWdlMkRDSFJPTUlVTSh1bnNpZ25lZCB0YXJnZXQsIGludCBsZXZlbCwg aW50IHhvZmZzZXQsIGludCB5b2Zmc2V0LCBpbnQgd2lkdGgsIGludCBoZWlnaHQsIHVuc2lnbmVk IGZvcm1hdCwgdW5zaWduZWQgdHlwZSwgdW5zaWduZWQgYWNjZXNzKSA9IDA7CisgICAgdmlydHVh bCB2b2lkIHVubWFwVGV4U3ViSW1hZ2UyRENIUk9NSVVNKGNvbnN0IHZvaWQqKSA9IDA7CisKKyAg ICAvLyBHTF9DSFJPTUlVTV9jb3B5X3RleHR1cmVfdG9fcGFyZW50X3RleHR1cmUKKyAgICB2aXJ0 dWFsIGJvb2wgc3VwcG9ydHNDb3B5VGV4dHVyZVRvUGFyZW50VGV4dHVyZUNIUk9NSVVNKCkgPSAw OworICAgIHZpcnR1YWwgdm9pZCBjb3B5VGV4dHVyZVRvUGFyZW50VGV4dHVyZUNIUk9NSVVNKHVu c2lnbmVkIHRleHR1cmUsIHVuc2lnbmVkIHBhcmVudFRleHR1cmUpID0gMDsKKwogICAgIC8vIFRo ZSBlbnRyeSBwb2ludHMgYmVsb3cgbWFwIGRpcmVjdGx5IHRvIHRoZSBPcGVuR0wgRVMgMi4wIEFQ SS4KICAgICAvLyBTZWU6IGh0dHA6Ly93d3cua2hyb25vcy5vcmcvcmVnaXN0cnkvZ2xlcy8KICAg ICAvLyBhbmQ6IGh0dHA6Ly93d3cua2hyb25vcy5vcmcvb3BlbmdsZXMvc2RrL2RvY3MvbWFuLwpJ bmRleDogV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJHcmFwaGljc0NvbnRleHQzRERlZmF1bHRJbXBs LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXQvY2hyb21pdW0vc3JjL1dlYkdyYXBoaWNzQ29udGV4 dDNERGVmYXVsdEltcGwuY3BwCShyZXZpc2lvbiA2NzY3MikKKysrIFdlYktpdC9jaHJvbWl1bS9z cmMvV2ViR3JhcGhpY3NDb250ZXh0M0REZWZhdWx0SW1wbC5jcHAJKHdvcmtpbmcgY29weSkKQEAg LTk3LDExICs5NywxNiBAQCBXZWJHcmFwaGljc0NvbnRleHQzRERlZmF1bHRJbXBsOjp+V2ViR3Jh CiAgICAgfQogfQogCi1ib29sIFdlYkdyYXBoaWNzQ29udGV4dDNERGVmYXVsdEltcGw6OmluaXRp YWxpemUoV2ViR3JhcGhpY3NDb250ZXh0M0Q6OkF0dHJpYnV0ZXMgYXR0cmlidXRlcywgV2ViVmll dyogd2ViVmlldykKK2Jvb2wgV2ViR3JhcGhpY3NDb250ZXh0M0REZWZhdWx0SW1wbDo6aW5pdGlh bGl6ZShXZWJHcmFwaGljc0NvbnRleHQzRDo6QXR0cmlidXRlcyBhdHRyaWJ1dGVzLCBXZWJWaWV3 KiB3ZWJWaWV3LCBib29sIHJlbmRlckRpcmVjdGx5VG9XZWJWaWV3KQogeworICAgIGlmIChyZW5k ZXJEaXJlY3RseVRvV2ViVmlldykgeworICAgICAgICAvLyBUaGlzIG1vZGUgaXNuJ3Qgc3VwcG9y dGVkIHdpdGggdGhlIGluLXByb2Nlc3MgaW1wbGVtZW50YXRpb24geWV0LiAoRklYTUUpCisgICAg ICAgIHJldHVybiBmYWxzZTsKKyAgICB9CisKICAgICBpZiAoIWdmeDo6R0xDb250ZXh0OjpJbml0 aWFsaXplT25lT2ZmKCkpCiAgICAgICAgIHJldHVybiBmYWxzZTsKLSAgICAgICAgCisKICAgICBt X2dsQ29udGV4dCA9IFdURjo6YWRvcHRQdHIoZ2Z4OjpHTENvbnRleHQ6OkNyZWF0ZU9mZnNjcmVl bkdMQ29udGV4dCgwKSk7CiAgICAgaWYgKCFtX2dsQ29udGV4dCkKICAgICAgICAgcmV0dXJuIGZh bHNlOwpAQCAtMTE0LDYgKzExOSwxMSBAQCBib29sIFdlYkdyYXBoaWNzQ29udGV4dDNERGVmYXVs dEltcGw6OmluCiAgICAgcmV0dXJuIHRydWU7CiB9CiAKK2Jvb2wgV2ViR3JhcGhpY3NDb250ZXh0 M0REZWZhdWx0SW1wbDo6aW5pdGlhbGl6ZShXZWJHcmFwaGljc0NvbnRleHQzRDo6QXR0cmlidXRl cyBhdHRyaWJ1dGVzLCBXZWJWaWV3KiB3ZWJWaWV3KQoreworICAgIHJldHVybiBpbml0aWFsaXpl KGF0dHJpYnV0ZXMsIHdlYlZpZXcsIGZhbHNlKTsKK30KKwogdm9pZCBXZWJHcmFwaGljc0NvbnRl eHQzRERlZmF1bHRJbXBsOjp2YWxpZGF0ZUF0dHJpYnV0ZXMoKQogewogICAgIGNvbnN0IGNoYXIq IGV4dGVuc2lvbnMgPSByZWludGVycHJldF9jYXN0PGNvbnN0IGNoYXIqPihnbEdldFN0cmluZyhH TF9FWFRFTlNJT05TKSk7CkBAIC00NjMsNiArNDczLDQwIEBAIGJvb2wgV2ViR3JhcGhpY3NDb250 ZXh0M0REZWZhdWx0SW1wbDo6c3UKICAgICByZXR1cm4gZmFsc2U7CiB9CiAKK2Jvb2wgV2ViR3Jh cGhpY3NDb250ZXh0M0REZWZhdWx0SW1wbDo6c3VwcG9ydHNNYXBTdWJDSFJPTUlVTSgpCit7Cisg ICAgLy8gV2UgZG9uJ3QgY2xhaW0gc3VwcG9ydCBmb3IgdGhpcyBleHRlbnNpb24gYXQgdGhpcyB0 aW1lCisgICAgcmV0dXJuIGZhbHNlOworfQorCit2b2lkKiBXZWJHcmFwaGljc0NvbnRleHQzRERl ZmF1bHRJbXBsOjptYXBCdWZmZXJTdWJEYXRhQ0hST01JVU0odW5zaWduZWQgdGFyZ2V0LCBpbnQg b2Zmc2V0LCBpbnQgc2l6ZSwgdW5zaWduZWQgYWNjZXNzKQoreworICAgIHJldHVybiAwOworfQor Cit2b2lkIFdlYkdyYXBoaWNzQ29udGV4dDNERGVmYXVsdEltcGw6OnVubWFwQnVmZmVyU3ViRGF0 YUNIUk9NSVVNKGNvbnN0IHZvaWQqIG1lbSkKK3sKK30KKwordm9pZCogV2ViR3JhcGhpY3NDb250 ZXh0M0REZWZhdWx0SW1wbDo6bWFwVGV4U3ViSW1hZ2UyRENIUk9NSVVNKHVuc2lnbmVkIHRhcmdl dCwgaW50IGxldmVsLCBpbnQgeG9mZnNldCwgaW50IHlvZmZzZXQsIGludCB3aWR0aCwgaW50IGhl aWdodCwgdW5zaWduZWQgZm9ybWF0LCB1bnNpZ25lZCB0eXBlLCB1bnNpZ25lZCBhY2Nlc3MpCit7 CisgICAgcmV0dXJuIDA7Cit9CisKK3ZvaWQgV2ViR3JhcGhpY3NDb250ZXh0M0REZWZhdWx0SW1w bDo6dW5tYXBUZXhTdWJJbWFnZTJEQ0hST01JVU0oY29uc3Qgdm9pZCogbWVtKQoreworfQorCiti b29sIFdlYkdyYXBoaWNzQ29udGV4dDNERGVmYXVsdEltcGw6OnN1cHBvcnRzQ29weVRleHR1cmVU b1BhcmVudFRleHR1cmVDSFJPTUlVTSgpCit7CisgICAgLy8gV2UgZG9uJ3QgY2xhaW0gc3VwcG9y dCBmb3IgdGhpcyBleHRlbnNpb24gYXQgdGhpcyB0aW1lCisgICAgcmV0dXJuIGZhbHNlOworfQor Cit2b2lkIFdlYkdyYXBoaWNzQ29udGV4dDNERGVmYXVsdEltcGw6OmNvcHlUZXh0dXJlVG9QYXJl bnRUZXh0dXJlQ0hST01JVU0odW5zaWduZWQgaWQsIHVuc2lnbmVkIGlkMikKK3sKK30KKwogLy8g SGVscGVyIG1hY3JvcyB0byByZWR1Y2UgdGhlIGFtb3VudCBvZiBjb2RlLgogCiAjZGVmaW5lIERF TEVHQVRFX1RPX0dMKG5hbWUsIGdsbmFtZSkgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgXApJbmRleDogV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJHcmFwaGljc0NvbnRl eHQzRERlZmF1bHRJbXBsLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJH cmFwaGljc0NvbnRleHQzRERlZmF1bHRJbXBsLmgJKHJldmlzaW9uIDY3NjcyKQorKysgV2ViS2l0 L2Nocm9taXVtL3NyYy9XZWJHcmFwaGljc0NvbnRleHQzRERlZmF1bHRJbXBsLmgJKHdvcmtpbmcg Y29weSkKQEAgLTU5LDYgKzU5LDggQEAgcHVibGljOgogCiAgICAgLy8tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCiAg ICAgLy8gV2ViR3JhcGhpY3NDb250ZXh0M0QgbWV0aG9kcworICAgIHZpcnR1YWwgYm9vbCBpbml0 aWFsaXplKFdlYkdyYXBoaWNzQ29udGV4dDNEOjpBdHRyaWJ1dGVzIGF0dHJpYnV0ZXMsIFdlYlZp ZXcqLCBib29sKTsKKyAgICAvLyBGSVhNRTogcmVtb3ZlIG9uY2UgY29tcG9zaXRvciBpcyBzd2l0 Y2hlZCBvdmVyIHRvIEdyYXBoaWNzQ29udGV4dDNELgogICAgIHZpcnR1YWwgYm9vbCBpbml0aWFs aXplKFdlYkdyYXBoaWNzQ29udGV4dDNEOjpBdHRyaWJ1dGVzIGF0dHJpYnV0ZXMsIFdlYlZpZXcq KTsKICAgICB2aXJ0dWFsIGJvb2wgbWFrZUNvbnRleHRDdXJyZW50KCk7CiAKQEAgLTgwLDYgKzgy LDEzIEBAIHB1YmxpYzoKIAogICAgIHZpcnR1YWwgdm9pZCBzeW50aGVzaXplR0xFcnJvcih1bnNp Z25lZCBsb25nIGVycm9yKTsKICAgICB2aXJ0dWFsIGJvb2wgc3VwcG9ydHNCR1JBKCk7CisgICAg dmlydHVhbCBib29sIHN1cHBvcnRzTWFwU3ViQ0hST01JVU0oKTsKKyAgICB2aXJ0dWFsIHZvaWQq IG1hcEJ1ZmZlclN1YkRhdGFDSFJPTUlVTSh1bnNpZ25lZCB0YXJnZXQsIGludCBvZmZzZXQsIGlu dCBzaXplLCB1bnNpZ25lZCBhY2Nlc3MpOworICAgIHZpcnR1YWwgdm9pZCB1bm1hcEJ1ZmZlclN1 YkRhdGFDSFJPTUlVTShjb25zdCB2b2lkKik7CisgICAgdmlydHVhbCB2b2lkKiBtYXBUZXhTdWJJ bWFnZTJEQ0hST01JVU0odW5zaWduZWQgdGFyZ2V0LCBpbnQgbGV2ZWwsIGludCB4b2Zmc2V0LCBp bnQgeW9mZnNldCwgaW50IHdpZHRoLCBpbnQgaGVpZ2h0LCB1bnNpZ25lZCBmb3JtYXQsIHVuc2ln bmVkIHR5cGUsIHVuc2lnbmVkIGFjY2Vzcyk7CisgICAgdmlydHVhbCB2b2lkIHVubWFwVGV4U3Vi SW1hZ2UyRENIUk9NSVVNKGNvbnN0IHZvaWQqKTsKKyAgICB2aXJ0dWFsIGJvb2wgc3VwcG9ydHND b3B5VGV4dHVyZVRvUGFyZW50VGV4dHVyZUNIUk9NSVVNKCk7CisgICAgdmlydHVhbCB2b2lkIGNv cHlUZXh0dXJlVG9QYXJlbnRUZXh0dXJlQ0hST01JVU0odW5zaWduZWQgdGV4dHVyZSwgdW5zaWdu ZWQgcGFyZW50VGV4dHVyZSk7CiAKICAgICB2aXJ0dWFsIHZvaWQgYWN0aXZlVGV4dHVyZSh1bnNp Z25lZCBsb25nIHRleHR1cmUpOwogICAgIHZpcnR1YWwgdm9pZCBhdHRhY2hTaGFkZXIoV2ViR0xJ ZCBwcm9ncmFtLCBXZWJHTElkIHNoYWRlcik7Cg==