45913 2010-09-16 12:01:47 -0700 [chromium] Add WebGraphicsContext3D accessor to WebView 2010-09-16 12:26:41 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 45912 1 kbr kbr jamesr senorblanco vangelis oldest_to_newest 280250 0 kbr 2010-09-16 12:01:47 -0700 In order to allow GraphicsContext3D instances for WebGL and other APIs to share resources with the compositor's GraphicsContext3D, a WebGraphicsContext3D accessor needs to be added to WebView (WebKit/chromium/public/WebView.h). Initially this needs to be stubbed out; it can be fully implemented once other changes land. 280254 1 67825 kbr 2010-09-16 12:05:58 -0700 Created attachment 67825 Patch 280257 2 67825 jamesr 2010-09-16 12:10:09 -0700 Comment on attachment 67825 Patch R=me. Darin OK'd at the WebKit API change verbally as wel. 280274 3 kbr 2010-09-16 12:26:41 -0700 Committed r67649: <http://trac.webkit.org/changeset/67649> 67825 2010-09-16 12:05:58 -0700 2010-09-16 12:10:09 -0700 Patch wgc3d-accessor.patch text/plain 3884 kbr SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZwkocmV2aXNpb24gNjc2NDQpCisrKyBXZWJLaXQvY2hyb21pdW0vQ2hh bmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTAtMDktMTYgIEtlbm5l dGggUnVzc2VsbCAgPGtickBnb29nbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFtjaHJvbWl1bV0gQWRkIFdlYkdyYXBoaWNzQ29udGV4dDNE IGFjY2Vzc29yIHRvIFdlYlZpZXcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTQ1OTEzCisKKyAgICAgICAgKiBwdWJsaWMvV2ViVmlldy5oOgorICAgICAg ICAqIHNyYy9XZWJWaWV3SW1wbC5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYlZpZXdJbXBsOjpX ZWJWaWV3SW1wbCk6CisgICAgICAgIChXZWJLaXQ6OldlYlZpZXdJbXBsOjpncmFwaGljc0NvbnRl eHQzRCk6CisgICAgICAgICogc3JjL1dlYlZpZXdJbXBsLmg6CisKIDIwMTAtMDktMTYgIFl1cnkg U2VtaWtoYXRza3kgIDx5dXJ5c0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkg UGF2ZWwgRmVsZG1hbi4KSW5kZXg6IFdlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViVmlldy5oCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFdlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViVmlldy5oCShyZXZpc2lvbiA2 NzU5MSkKKysrIFdlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViVmlldy5oCSh3b3JraW5nIGNvcHkp CkBAIC00NSw2ICs0NSw3IEBAIGNsYXNzIFdlYkRyYWdEYXRhOwogY2xhc3MgV2ViRnJhbWU7CiBj bGFzcyBXZWJGcmFtZUNsaWVudDsKIGNsYXNzIFdlYkdMRVMyQ29udGV4dDsKK2NsYXNzIFdlYkdy YXBoaWNzQ29udGV4dDNEOwogY2xhc3MgV2ViTm9kZTsKIGNsYXNzIFdlYlNldHRpbmdzOwogY2xh c3MgV2ViU3RyaW5nOwpAQCAtMzQyLDggKzM0MywxNyBAQCBwdWJsaWM6CiAKICAgICAvLyBSZXR1 cm5zIHRoZSBHTEVTMkNvbnRleHQgYXNzb2NpYXRlZCB3aXRoIHRoaXMgV2ViVmlldy4gT25lIHdp bGwgYmUKICAgICAvLyBjcmVhdGVkIGlmIGl0IGRvZXNuJ3QgYWxyZWFkeSBleGlzdC4KKyAgICAv LyBGSVhNRTogcmVtb3ZlIHRoaXMgbWV0aG9kIG9uY2UgdGhlIGNvbXBvc2l0b3IgaXMgZnVsbHkg c3dpdGNoZWQKKyAgICAvLyBvdmVyIHRvIEdyYXBoaWNzQ29udGV4dDNELgogICAgIHZpcnR1YWwg V2ViR0xFUzJDb250ZXh0KiBnbGVzMkNvbnRleHQoKSA9IDA7CiAKKyAgICAvLyBSZXR1cm5zIHRo ZSAob24tc2NyZWVuKSBXZWJHcmFwaGljc0NvbnRleHQzRCBhc3NvY2lhdGVkIHdpdGgKKyAgICAv LyB0aGlzIFdlYlZpZXcuIE9uZSB3aWxsIGJlIGNyZWF0ZWQgaWYgaXQgZG9lc24ndCBhbHJlYWR5 IGV4aXN0LgorICAgIC8vIFRoaXMgaXMgdXNlZCB0byBzZXQgdXAgc2hhcmluZyBiZXR3ZWVuIHRo aXMgY29udGV4dCAod2hpY2ggaXMKKyAgICAvLyB0aGF0IHVzZWQgYnkgdGhlIGNvbXBvc2l0b3Ip IGFuZCBjb250ZXh0cyBmb3IgV2ViR0wgYW5kIG90aGVyCisgICAgLy8gQVBJcy4KKyAgICB2aXJ0 dWFsIFdlYkdyYXBoaWNzQ29udGV4dDNEKiBncmFwaGljc0NvbnRleHQzRCgpID0gMDsKKwogcHJv dGVjdGVkOgogICAgIH5XZWJWaWV3KCkge30KIH07CkluZGV4OiBXZWJLaXQvY2hyb21pdW0vc3Jj L1dlYlZpZXdJbXBsLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXQvY2hyb21pdW0vc3JjL1dlYlZp ZXdJbXBsLmNwcAkocmV2aXNpb24gNjc1OTEpCisrKyBXZWJLaXQvY2hyb21pdW0vc3JjL1dlYlZp ZXdJbXBsLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjc3LDcgKzI3Nyw2IEBAIFdlYlZpZXdJbXBs OjpXZWJWaWV3SW1wbChXZWJWaWV3Q2xpZW50KiAKICNpZiBFTkFCTEUoSU5QVVRfU1BFRUNIKQog ICAgICwgbV9zcGVlY2hJbnB1dENsaWVudChjbGllbnQpCiAjZW5kaWYKLSAgICAsIG1fZ2xlczJD b250ZXh0KDApCiAgICAgLCBtX2RldmljZU9yaWVudGF0aW9uQ2xpZW50UHJveHkobmV3IERldmlj ZU9yaWVudGF0aW9uQ2xpZW50UHJveHkoY2xpZW50ID8gY2xpZW50LT5kZXZpY2VPcmllbnRhdGlv bkNsaWVudCgpIDogMCkpCiB7CiAgICAgLy8gV2ViS2l0L3dpbi9XZWJWaWV3LmNwcCBkb2VzIHRo ZSBzYW1lIHRoaW5nLCBleGNlcHQgdGhleSBjYWxsIHRoZQpAQCAtMjQ1OSw0ICsyNDU4LDEwIEBA IFdlYkdMRVMyQ29udGV4dCogV2ViVmlld0ltcGw6OmdsZXMyQ29udGUKICAgICByZXR1cm4gbV9n bGVzMkNvbnRleHQuZ2V0KCk7CiB9CiAKK1dlYkdyYXBoaWNzQ29udGV4dDNEKiBXZWJWaWV3SW1w bDo6Z3JhcGhpY3NDb250ZXh0M0QoKQoreworICAgIC8vIEZJWE1FOiBpbXBsZW1lbnQgdGhpcy4K KyAgICByZXR1cm4gMDsKK30KKwogfSAvLyBuYW1lc3BhY2UgV2ViS2l0CkluZGV4OiBXZWJLaXQv Y2hyb21pdW0vc3JjL1dlYlZpZXdJbXBsLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2Nocm9taXVt L3NyYy9XZWJWaWV3SW1wbC5oCShyZXZpc2lvbiA2NzU5MSkKKysrIFdlYktpdC9jaHJvbWl1bS9z cmMvV2ViVmlld0ltcGwuaAkod29ya2luZyBjb3B5KQpAQCAtMzM2LDEwICszMzYsMTkgQEAgcHVi bGljOgogICAgIC8vIE9uc2NyZWVuIGNvbnRleHRzIGRpc3BsYXkgdG8gdGhlIHNjcmVlbiBhc3Nv Y2lhdGVkIHdpdGggdGhpcyB2aWV3LgogICAgIC8vIE9mZnNjcmVlbiBjb250ZXh0cyByZW5kZXIg b2Zmc2NyZWVuIGJ1dCBjYW4gc2hhcmUgcmVzb3VyY2VzIHdpdGggdGhlCiAgICAgLy8gb25zY3Jl ZW4gY29udGV4dCBhbmQgdGh1cyBjYW4gYmUgY29tcG9zaXRlZC4KKyAgICAvLyBGSVhNRTogcmVt b3ZlIHRoaXMgb25jZSB0aGUgY29tcG9zaXRvciBpcyBzd2l0Y2hlZCB0byB1c2UgR3JhcGhpY3ND b250ZXh0M0QuCiAgICAgUGFzc093blB0cjxXZWJDb3JlOjpHTEVTMkNvbnRleHQ+IGdldE9uc2Ny ZWVuR0xFUzJDb250ZXh0KCk7CiAKICAgICAvLyBSZXR1cm5zIGFuIG9uc2NyZWVuIGNvbnRleHQK KyAgICAvLyBGSVhNRTogcmVtb3ZlIHRoaXMgb25jZSB0aGUgY29tcG9zaXRvciBpcyBzd2l0Y2hl ZCB0byB1c2UgR3JhcGhpY3NDb250ZXh0M0QuCiAgICAgdmlydHVhbCBXZWJHTEVTMkNvbnRleHQq IGdsZXMyQ29udGV4dCgpOworCisgICAgLy8gUmV0dXJucyB0aGUgb25zY3JlZW4gM0QgY29udGV4 dCB1c2VkIGJ5IHRoZSBjb21wb3NpdG9yLiBUaGlzIGlzCisgICAgLy8gdXNlZCBieSB0aGUgcmVu ZGVyZXIncyBjb2RlIHRvIHNldCB1cCByZXNvdXJjZSBzaGFyaW5nIGJldHdlZW4KKyAgICAvLyB0 aGUgY29tcG9zaXRvcidzIGNvbnRleHQgYW5kIHN1Ym9yZGluYXRlIGNvbnRleHRzIGZvciBBUElz IGxpa2UKKyAgICAvLyBXZWJHTC4gUmV0dXJucyAwIGlmIGNvbXBvc2l0aW5nIHN1cHBvcnQgaXMg bm90IGNvbXBpbGVkIGluLgorICAgIHZpcnR1YWwgV2ViR3JhcGhpY3NDb250ZXh0M0QqIGdyYXBo aWNzQ29udGV4dDNEKCk7CisKICAgICB2aXJ0dWFsIFdlYkNvcmU6OlNoYXJlZEdyYXBoaWNzQ29u dGV4dDNEKiBnZXRTaGFyZWRHcmFwaGljc0NvbnRleHQzRCgpOwogCiAgICAgV2ViQ29yZTo6UG9w dXBDb250YWluZXIqIHNlbGVjdFBvcHVwKCkgY29uc3QgeyByZXR1cm4gbV9zZWxlY3RQb3B1cC5n ZXQoKTsgfQo=