45908 2010-09-16 11:07:28 -0700 Must enable GL_POINT_SPRITE in GraphicsContext3D implementations 2010-10-27 14:04:46 -0700 1 1 1 Unclassified WebKit WebGL 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 kbr zmo abarth cmarrin danceoffwithyourpantsoff enne eric simon.fraser webkit.review.bot zmo oldest_to_newest 280215 0 kbr 2010-09-16 11:07:28 -0700 In order to properly support the gl_PointCoord built-in variable in fragment shaders, it is necessary for the various GraphicsContext3D implementations running on desktop GL to enable the GL_POINT_SPRITE capability. This is similar to the earlier requirement to enable the GL_VERTEX_PROGRAM_POINT_SIZE capability. Note that testing this in WebKit requires ANGLE issue http://code.google.com/p/angleproject/issues/detail?id=35 to be fixed and the version of ANGLE in WebKit to be updated. 296711 1 danceoffwithyourpantsoff 2010-10-20 02:31:09 -0700 (In reply to comment #0) > In order to properly support the gl_PointCoord built-in variable in fragment shaders, it is necessary for the various GraphicsContext3D implementations running on desktop GL to enable the GL_POINT_SPRITE capability. This is similar to the earlier requirement to enable the GL_VERTEX_PROGRAM_POINT_SIZE capability. > > Note that testing this in WebKit requires ANGLE issue http://code.google.com/p/angleproject/issues/detail?id=35 to be fixed and the version of ANGLE in WebKit to be updated. This was recently fixed in ANGLE and rolled into Chromium, and gl_PointCoord is working now. However, shaders that use gl_PointCoord still fail to compile in non-chromium WebKit / Safari. Relevant: http://code.google.com/p/chromium/issues/detail?id=59763 http://code.google.com/p/angleproject/source/detail?r=448 http://src.chromium.org/viewvc/chrome?view=rev&revision=63084 296858 2 zmo 2010-10-20 10:25:03 -0700 (In reply to comment #1) > (In reply to comment #0) > > In order to properly support the gl_PointCoord built-in variable in fragment shaders, it is necessary for the various GraphicsContext3D implementations running on desktop GL to enable the GL_POINT_SPRITE capability. This is similar to the earlier requirement to enable the GL_VERTEX_PROGRAM_POINT_SIZE capability. > > > > Note that testing this in WebKit requires ANGLE issue http://code.google.com/p/angleproject/issues/detail?id=35 to be fixed and the version of ANGLE in WebKit to be updated. > > This was recently fixed in ANGLE and rolled into Chromium, and gl_PointCoord is working now. > > However, shaders that use gl_PointCoord still fail to compile in non-chromium WebKit / Safari. > > Relevant: > > http://code.google.com/p/chromium/issues/detail?id=59763 > http://code.google.com/p/angleproject/source/detail?r=448 > http://src.chromium.org/viewvc/chrome?view=rev&revision=63084 That's because they are still using an older version of ANGLE. 298051 3 71574 zmo 2010-10-22 10:36:40 -0700 Created attachment 71574 patch Mac port still needs to roll ANGLE for gl_pointCoord to work 299235 4 71574 kbr 2010-10-25 19:08:39 -0700 Comment on attachment 71574 patch OK, but see https://bugs.webkit.org/show_bug.cgi?id=48282 ; this only adds code which will need to be fixed later under that bug. Minimally, add a comment to that bug about this new code. 300342 5 71574 zmo 2010-10-27 10:24:57 -0700 Comment on attachment 71574 patch Clearing flags on attachment: 71574 Committed r70666: <http://trac.webkit.org/changeset/70666> 300343 6 zmo 2010-10-27 10:25:02 -0700 All reviewed patches have been landed. Closing bug. 300548 7 webkit.review.bot 2010-10-27 14:04:46 -0700 http://trac.webkit.org/changeset/70666 might have broken GTK Linux 32-bit Debug 71574 2010-10-22 10:36:40 -0700 2010-10-27 10:24:57 -0700 patch sprite.patch text/plain 2345 zmo SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA3MDMxNikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTMgQEAKKzIwMTAtMTAtMjIgIFpIZW55YW8gTW8gIDx6bW9AZ29vZ2xlLmNvbT4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBNdXN0IGVu YWJsZSBHTF9QT0lOVF9TUFJJVEUgaW4gR3JhcGhpY3NDb250ZXh0M0QgaW1wbGVtZW50YXRpb25z CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NTkwOAor CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvbWFjL0dyYXBoaWNzQ29udGV4dDNETWFjLm1t OiBFbmFibGUgZm9yIE1hYyBwb3J0LgorICAgICAgICAoV2ViQ29yZTo6R3JhcGhpY3NDb250ZXh0 M0Q6OkdyYXBoaWNzQ29udGV4dDNEKToKKwogMjAxMC0xMC0yMiAgUGF0cmljayBHYW5zdGVyZXIg IDxwYXJvZ2FAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBBZGFtIFJvYmVuLgpJ bmRleDogV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9tYWMvR3JhcGhpY3NDb250ZXh0M0RNYWMu bW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9tYWMvR3JhcGhpY3ND b250ZXh0M0RNYWMubW0JKHJldmlzaW9uIDcwMjc1KQorKysgV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy9tYWMvR3JhcGhpY3NDb250ZXh0M0RNYWMubW0JKHdvcmtpbmcgY29weSkKQEAgLTIxMCw2 ICsyMTAsOCBAQCBHcmFwaGljc0NvbnRleHQzRDo6R3JhcGhpY3NDb250ZXh0M0QoR3JhCiAgICAg bV9jb21waWxlci5zZXRSZXNvdXJjZXMoQU5HTEVSZXNvdXJjZXMpOwogICAgIAogICAgIDo6Z2xF bmFibGUoR0xfVkVSVEVYX1BST0dSQU1fUE9JTlRfU0laRSk7CisgICAgOjpnbEVuYWJsZShHTF9Q T0lOVF9TUFJJVEUpOworCiAgICAgOjpnbENsZWFyQ29sb3IoMCwgMCwgMCwgMCk7CiB9CiAKSW5k ZXg6IFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2Nocm9t aXVtL0NoYW5nZUxvZwkocmV2aXNpb24gNzAzMTYpCisrKyBXZWJLaXQvY2hyb21pdW0vQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTAtMTAtMjIgIFpIZW55YW8g TW8gIDx6bW9AZ29vZ2xlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBNdXN0IGVuYWJsZSBHTF9QT0lOVF9TUFJJVEUgaW4gR3JhcGhpY3NDb250 ZXh0M0QgaW1wbGVtZW50YXRpb25zCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD00NTkwOAorCisgICAgICAgICogc3JjL1dlYkdyYXBoaWNzQ29udGV4dDNE RGVmYXVsdEltcGwuY3BwOiBFbmFibGUgZm9yIGNocm9taXVtIC0taW4tcHJvY2Vzcy13ZWJnbCBw b3J0LgorICAgICAgICAoV2ViS2l0OjpXZWJHcmFwaGljc0NvbnRleHQzRERlZmF1bHRJbXBsOjpp bml0aWFsaXplKToKKwogMjAxMC0xMC0yMiAgU2hlcmlmZiBCb3QgIDx3ZWJraXQucmV2aWV3LmJv dEBnbWFpbC5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjcwMzAxLgpJ bmRleDogV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJHcmFwaGljc0NvbnRleHQzRERlZmF1bHRJbXBs LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXQvY2hyb21pdW0vc3JjL1dlYkdyYXBoaWNzQ29udGV4 dDNERGVmYXVsdEltcGwuY3BwCShyZXZpc2lvbiA3MDI3NSkKKysrIFdlYktpdC9jaHJvbWl1bS9z cmMvV2ViR3JhcGhpY3NDb250ZXh0M0REZWZhdWx0SW1wbC5jcHAJKHdvcmtpbmcgY29weSkKQEAg LTE2NSw2ICsxNjUsNyBAQCBib29sIFdlYkdyYXBoaWNzQ29udGV4dDNERGVmYXVsdEltcGw6Omlu CiAgICAgdmFsaWRhdGVBdHRyaWJ1dGVzKCk7CiAKICAgICBnbEVuYWJsZShHTF9WRVJURVhfUFJP R1JBTV9QT0lOVF9TSVpFKTsKKyAgICBnbEVuYWJsZShHTF9QT0lOVF9TUFJJVEUpOwogCiAgICAg aWYgKCFhbmdsZUNyZWF0ZUNvbXBpbGVycygpKSB7CiAgICAgICAgIGFuZ2xlRGVzdHJveUNvbXBp bGVycygpOwo=