45893 2010-09-16 08:26:07 -0700 Add the namespace in a friend declaration to get MSVC recognize it properly. 2010-09-16 08:40:38 -0700 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 satish webkit-unassigned jianli jorlow oldest_to_newest 280110 0 satish 2010-09-16 08:26:07 -0700 This is a fix for a build break caused by r67614 in the chromium windows builders (which use VS 2008). Looks like without the proper namespace, the friend declaration was treated as a forward declaration and the build failed with the following error message: 1>JavaScriptCore\wtf/RefCounted.h(139) : error C2248: 'WebCore::FileWriter::~FileWriter' : cannot access private member declared in class 'WebCore::FileWriter' 1> webcore\fileapi\FileWriter.h(124) : compiler has generated 'WebCore::FileWriter::~FileWriter' here 1> webcore\fileapi\FileWriter.h(52) : see declaration of 'WebCore::FileWriter' 1> JavaScriptCore\wtf/RefCounted.h(137) : while compiling class template member function 'void WTF::RefCounted<T>::deref(void)' 1> with 1> [ 1> T=WebCore::FileWriter 1> ] 1> webcore\fileapi\FileWriter.h(52) : see reference to class template instantiation 'WTF::RefCounted<T>' being compiled 1> with 1> [ 1> T=WebCore::FileWriter 1> ] 280111 1 67800 satish 2010-09-16 08:28:24 -0700 Created attachment 67800 Patch 280115 2 67800 jorlow 2010-09-16 08:33:01 -0700 Comment on attachment 67800 Patch r=me 280119 3 67800 satish 2010-09-16 08:40:27 -0700 Comment on attachment 67800 Patch Clearing flags on attachment: 67800 Committed r67622: <http://trac.webkit.org/changeset/67622> 67800 2010-09-16 08:28:24 -0700 2010-09-16 08:40:27 -0700 Patch bug-45893-20100916162822.patch text/plain 1045 satish ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg Yzc2ZjMzYWE1NjQ5ZmM3NzMxY2UxOGEzMGQ0OTJlMTdlMWQ1YjdkYS4uMTIyYmM0ZTUxZWJiMDgw MDViYzUyODE2N2MyZWE2NDBjYWYxOWNhYyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMiBAQAorMjAxMC0wOS0xNiAgU2F0 aXNoIFNhbXBhdGggIDxzYXRpc2hAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZpeCBidWlsZCBicmVhaywgYWRkIHRoZSBuYW1l c3BhY2UgaW4gYSBmcmllbmQgZGVjbGFyYXRpb24gdG8gZ2V0IE1TVkMgcmVjb2duaXplIGl0IHBy b3Blcmx5LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 NDU4OTMKKworICAgICAgICAqIGZpbGVhcGkvRmlsZVdyaXRlci5oOgorCiAyMDEwLTA5LTE2ICBB bmRyZXkgS29zeWFrb3YgIDxjYXNlcUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQg YnkgUGF2ZWwgRmVsZG1hbi4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvZmlsZWFwaS9GaWxlV3JpdGVy LmggYi9XZWJDb3JlL2ZpbGVhcGkvRmlsZVdyaXRlci5oCmluZGV4IGQ5YWM3ZTZmMmE4NWM1ZmI5 M2JlZWFiYWYwMjU0NTgyNDJjZjdhM2MuLjA3MzcwODVhNmNiM2QyNGUzOWNmZThjYzgxNmQ3ZjIz ODljYzZkZmIgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvZmlsZWFwaS9GaWxlV3JpdGVyLmgKKysrIGIv V2ViQ29yZS9maWxlYXBpL0ZpbGVXcml0ZXIuaApAQCAtMTAzLDcgKzEwMyw3IEBAIHByaXZhdGU6 CiAKICAgICB2aXJ0dWFsIH5GaWxlV3JpdGVyKCk7CiAKLSAgICBmcmllbmQgY2xhc3MgUmVmQ291 bnRlZDxGaWxlV3JpdGVyPjsKKyAgICBmcmllbmQgY2xhc3MgV1RGOjpSZWZDb3VudGVkPEZpbGVX cml0ZXI+OwogCiAgICAgLy8gRXZlbnRUYXJnZXQKICAgICB2aXJ0dWFsIHZvaWQgcmVmRXZlbnRU YXJnZXQoKSB7IHJlZigpOyB9Cg==