45869 2010-09-15 19:41:00 -0700 [chromium] ImageLayerChromium must keep a reference to the Image it uses 2010-10-11 16:25:14 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED DUPLICATE 45717 P2 Normal --- 1 vangelis vangelis thakis oldest_to_newest 279913 0 vangelis 2010-09-15 19:41:00 -0700 Otherwise the image could be released before the layer is done with it. This has already been fixed for the CG backend but we need a solution for PLATFORM(SKIA). 279914 1 thakis 2010-09-15 19:42:54 -0700 *** This bug has been marked as a duplicate of bug 45717 *** 279916 2 67763 vangelis 2010-09-15 19:45:29 -0700 Created attachment 67763 proposed patch 292753 3 67763 jamesr 2010-10-11 16:25:14 -0700 Comment on attachment 67763 proposed patch Not needed now that this has landed: http://trac.webkit.org/changeset/67625 clearing flags to remove from r? queue 67763 2010-09-15 19:45:29 -0700 2010-10-11 16:25:14 -0700 proposed patch imageLayer_45869.txt text/plain 5703 vangelis SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2NzU5NikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTggQEAKKzIwMTAtMDktMTUgIFZhbmdlbGlzIEtva2tldmlzICA8dmFuZ2VsaXNA Y2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFtjaHJvbWl1bV0gSW1hZ2VMYXllckNocm9taXVtIG5lZWRzIHRvIGtlZXAgYSByZWYg dG8gdGhlIEltYWdlIGl0IHVzZXMKKyAgICAgICAgc28gdGhhdCBpdCBuZXZlciB0cmllcyB0byBh Y2Nlc3MgYW4gYWxyZWFkeSBkZXN0cm95ZWQgSW1hZ2UuCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NTg2OQorCisgICAgICAgICogcGxhdGZvcm0vZ3Jh cGhpY3MvY2hyb21pdW0vR3JhcGhpY3NMYXllckNocm9taXVtLmNwcDoKKyAgICAgICAgKFdlYkNv cmU6OkdyYXBoaWNzTGF5ZXJDaHJvbWl1bTo6c2V0Q29udGVudHNUb0ltYWdlKToKKyAgICAgICAg KiBwbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9JbWFnZUxheWVyQ2hyb21pdW0uY3BwOgorICAg ICAgICAoV2ViQ29yZTo6SW1hZ2VMYXllckNocm9taXVtOjpzZXRDb250ZW50cyk6CisgICAgICAg IChXZWJDb3JlOjpJbWFnZUxheWVyQ2hyb21pdW06OnVwZGF0ZUNvbnRlbnRzKToKKyAgICAgICAg KiBwbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9JbWFnZUxheWVyQ2hyb21pdW0uaDoKKwogMjAx MC0wOS0xNSAgU2ltb24gRnJhc2VyICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KIAogICAgICAg ICBGaXggY2hyb21pdW0gYnVpbGQuCkluZGV4OiBXZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2No cm9taXVtL0dyYXBoaWNzTGF5ZXJDaHJvbWl1bS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9HcmFwaGljc0xheWVyQ2hyb21pdW0uY3BwCShyZXZp c2lvbiA2NzU2NykKKysrIFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vR3JhcGhp Y3NMYXllckNocm9taXVtLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzI0LDcgKzMyNCw2IEBAIHZv aWQgR3JhcGhpY3NMYXllckNocm9taXVtOjpzZXRDb250ZW50c1QKIHsKICAgICBib29sIGNoaWxk cmVuQ2hhbmdlZCA9IGZhbHNlOwogICAgIGlmIChpbWFnZSkgewotICAgICAgICBOYXRpdmVJbWFn ZVB0ciBuYXRpdmVJbWFnZSA9IGltYWdlLT5uYXRpdmVJbWFnZUZvckN1cnJlbnRGcmFtZSgpOwog ICAgICAgICBpZiAoIW1fY29udGVudHNMYXllci5nZXQoKSB8fCBtX2NvbnRlbnRzTGF5ZXJQdXJw b3NlICE9IENvbnRlbnRzTGF5ZXJGb3JJbWFnZSkgewogICAgICAgICAgICAgUmVmUHRyPEltYWdl TGF5ZXJDaHJvbWl1bT4gaW1hZ2VMYXllciA9IEltYWdlTGF5ZXJDaHJvbWl1bTo6Y3JlYXRlKHRo aXMpOwogICAgICAgICAgICAgc2V0dXBDb250ZW50c0xheWVyKGltYWdlTGF5ZXIuZ2V0KCkpOwpA QCAtMzMzLDcgKzMzMiw3IEBAIHZvaWQgR3JhcGhpY3NMYXllckNocm9taXVtOjpzZXRDb250ZW50 c1QKICAgICAgICAgICAgIGNoaWxkcmVuQ2hhbmdlZCA9IHRydWU7CiAgICAgICAgIH0KICAgICAg ICAgSW1hZ2VMYXllckNocm9taXVtKiBpbWFnZUxheWVyID0gc3RhdGljX2Nhc3Q8SW1hZ2VMYXll ckNocm9taXVtKj4obV9jb250ZW50c0xheWVyLmdldCgpKTsKLSAgICAgICAgaW1hZ2VMYXllci0+ c2V0Q29udGVudHMobmF0aXZlSW1hZ2UpOworICAgICAgICBpbWFnZUxheWVyLT5zZXRDb250ZW50 cyhpbWFnZSk7CiAgICAgICAgIHVwZGF0ZUNvbnRlbnRzUmVjdCgpOwogICAgIH0gZWxzZSB7CiAg ICAgICAgIGlmIChtX2NvbnRlbnRzTGF5ZXIpIHsKSW5kZXg6IFdlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3MvY2hyb21pdW0vSW1hZ2VMYXllckNocm9taXVtLmNwcAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL0ltYWdlTGF5ZXJDaHJvbWl1bS5jcHAJKHJl dmlzaW9uIDY3NTY3KQorKysgV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9JbWFn ZUxheWVyQ2hyb21pdW0uY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zNCw2ICszNCw3IEBACiAKICNp bmNsdWRlICJJbWFnZUxheWVyQ2hyb21pdW0uaCIKIAorI2luY2x1ZGUgIkltYWdlLmgiCiAjaW5j bHVkZSAiTGF5ZXJSZW5kZXJlckNocm9taXVtLmgiCiAKICNpZiBQTEFURk9STShTS0lBKQpAQCAt NjEsNyArNjIsNyBAQCBJbWFnZUxheWVyQ2hyb21pdW06OkltYWdlTGF5ZXJDaHJvbWl1bShHCiB7 CiB9CiAKLXZvaWQgSW1hZ2VMYXllckNocm9taXVtOjpzZXRDb250ZW50cyhOYXRpdmVJbWFnZVB0 ciBjb250ZW50cykKK3ZvaWQgSW1hZ2VMYXllckNocm9taXVtOjpzZXRDb250ZW50cyhJbWFnZSog Y29udGVudHMpCiB7CiAgICAgLy8gQ2hlY2sgaWYgdGhlIGltYWdlIGhhcyBjaGFuZ2VkLgogICAg IGlmIChtX2NvbnRlbnRzID09IGNvbnRlbnRzKQpAQCAtNzksOSArODAsMTEgQEAgdm9pZCBJbWFn ZUxheWVyQ2hyb21pdW06OnVwZGF0ZUNvbnRlbnRzKAogICAgIEludFNpemUgcmVxdWlyZWRUZXh0 dXJlU2l6ZTsKICAgICBJbnRTaXplIGJpdG1hcFNpemU7CiAKKyAgICBOYXRpdmVJbWFnZVB0ciBu YXRpdmVJbWFnZSA9IG1fY29udGVudHMtPm5hdGl2ZUltYWdlRm9yQ3VycmVudEZyYW1lKCk7CisK ICNpZiBQTEFURk9STShTS0lBKQogICAgIC8vIFRoZSBsYXllciBjb250YWlucyBhbiBJbWFnZS4K LSAgICBOYXRpdmVJbWFnZVNraWEqIHNraWFJbWFnZSA9IHN0YXRpY19jYXN0PE5hdGl2ZUltYWdl U2tpYSo+KG1fY29udGVudHMpOworICAgIE5hdGl2ZUltYWdlU2tpYSogc2tpYUltYWdlID0gc3Rh dGljX2Nhc3Q8TmF0aXZlSW1hZ2VTa2lhKj4obmF0aXZlSW1hZ2UpOwogICAgIGNvbnN0IFNrQml0 bWFwKiBza2lhQml0bWFwID0gc2tpYUltYWdlOwogICAgIHJlcXVpcmVkVGV4dHVyZVNpemUgPSBJ bnRTaXplKHNraWFCaXRtYXAtPndpZHRoKCksIHNraWFCaXRtYXAtPmhlaWdodCgpKTsKICAgICBB U1NFUlQoc2tpYUJpdG1hcCk7CkBAIC05NSw5ICs5OCw4IEBAIHZvaWQgSW1hZ2VMYXllckNocm9t aXVtOjp1cGRhdGVDb250ZW50cygKICAgICB9CiAjZWxpZiBQTEFURk9STShDRykKICAgICAvLyBO YXRpdmVJbWFnZVB0ciBpcyBhIENHSW1hZ2VSZWYgb24gTWFjIE9TIFguCi0gICAgQ0dJbWFnZVJl ZiBjZ0ltYWdlID0gbV9jb250ZW50cy5nZXQoKTsKLSAgICBpbnQgd2lkdGggPSBDR0ltYWdlR2V0 V2lkdGgoY2dJbWFnZSk7Ci0gICAgaW50IGhlaWdodCA9IENHSW1hZ2VHZXRIZWlnaHQoY2dJbWFn ZSk7CisgICAgaW50IHdpZHRoID0gQ0dJbWFnZUdldFdpZHRoKG5hdGl2ZUltYWdlKTsKKyAgICBp bnQgaGVpZ2h0ID0gQ0dJbWFnZUdldEhlaWdodChuYXRpdmVJbWFnZSk7CiAgICAgcmVxdWlyZWRU ZXh0dXJlU2l6ZSA9IEludFNpemUod2lkdGgsIGhlaWdodCk7CiAgICAgYml0bWFwU2l6ZSA9IHJl cXVpcmVkVGV4dHVyZVNpemU7CiAgICAgLy8gRklYTUU6IHdlIHNob3VsZCBnZXQgcmlkIG9mIHRo aXMgdGVtcG9yYXJ5IGNvcHkgd2hlcmUgcG9zc2libGUuCkBAIC0xMDksNyArMTExLDcgQEAgdm9p ZCBJbWFnZUxheWVyQ2hyb21pdW06OnVwZGF0ZUNvbnRlbnRzKAogICAgIC8vIFRyeSB0byByZXVz ZSB0aGUgY29sb3Igc3BhY2UgZnJvbSB0aGUgaW1hZ2UgdG8gcHJlc2VydmUgaXRzIGNvbG9ycy4K ICAgICAvLyBTb21lIGltYWdlcyB1c2UgYSBjb2xvciBzcGFjZSAoc3VjaCBhcyBpbmRleGVkKSB1 bnN1cHBvcnRlZCBieSB0aGUgYml0bWFwIGNvbnRleHQuCiAgICAgUmV0YWluUHRyPENHQ29sb3JT cGFjZVJlZj4gY29sb3JTcGFjZVJlbGVhc2VyOwotICAgIENHQ29sb3JTcGFjZVJlZiBjb2xvclNw YWNlID0gQ0dJbWFnZUdldENvbG9yU3BhY2UoY2dJbWFnZSk7CisgICAgQ0dDb2xvclNwYWNlUmVm IGNvbG9yU3BhY2UgPSBDR0ltYWdlR2V0Q29sb3JTcGFjZShuYXRpdmVJbWFnZSk7CiAgICAgQ0dD b2xvclNwYWNlTW9kZWwgY29sb3JTcGFjZU1vZGVsID0gQ0dDb2xvclNwYWNlR2V0TW9kZWwoY29s b3JTcGFjZSk7CiAgICAgc3dpdGNoIChjb2xvclNwYWNlTW9kZWwpIHsKICAgICBjYXNlIGtDR0Nv bG9yU3BhY2VNb2RlbE1vbm9jaHJvbWU6CkBAIC0xMzAsNyArMTMyLDcgQEAgdm9pZCBJbWFnZUxh eWVyQ2hyb21pdW06OnVwZGF0ZUNvbnRlbnRzKAogICAgIENHQ29udGV4dFNldEJsZW5kTW9kZSh0 ZW1wQ29udGV4dC5nZXQoKSwga0NHQmxlbmRNb2RlQ29weSk7CiAgICAgQ0dDb250ZXh0RHJhd0lt YWdlKHRlbXBDb250ZXh0LmdldCgpLAogICAgICAgICAgICAgICAgICAgICAgICBDR1JlY3RNYWtl KDAsIDAsIHN0YXRpY19jYXN0PENHRmxvYXQ+KHdpZHRoKSwgc3RhdGljX2Nhc3Q8Q0dGbG9hdD4o aGVpZ2h0KSksCi0gICAgICAgICAgICAgICAgICAgICAgIGNnSW1hZ2UpOworICAgICAgICAgICAg ICAgICAgICAgICBuYXRpdmVJbWFnZSk7CiAgICAgcGl4ZWxzID0gdGVtcFZlY3Rvci5kYXRhKCk7 CiAjZWxzZQogI2Vycm9yICJOZWVkIHRvIGltcGxlbWVudCBmb3IgeW91ciBwbGF0Zm9ybS4iCklu ZGV4OiBXZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL0ltYWdlTGF5ZXJDaHJvbWl1 bS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vSW1h Z2VMYXllckNocm9taXVtLmgJKHJldmlzaW9uIDY3NTY3KQorKysgV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy9jaHJvbWl1bS9JbWFnZUxheWVyQ2hyb21pdW0uaAkod29ya2luZyBjb3B5KQpAQCAt NDIsNiArNDIsOCBAQAogCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKK2NsYXNzIEltYWdlOworCiAv LyBBIExheWVyIHRoYXQgY29udGFpbnMgb25seSBhbiBJbWFnZSBlbGVtZW50LgogY2xhc3MgSW1h Z2VMYXllckNocm9taXVtIDogcHVibGljIENvbnRlbnRMYXllckNocm9taXVtIHsKIHB1YmxpYzoK QEAgLTUwLDE3ICs1MiwxMiBAQCBwdWJsaWM6CiAgICAgdmlydHVhbCB2b2lkIHVwZGF0ZUNvbnRl bnRzKCk7CiAgICAgdmlydHVhbCBib29sIGRyYXdzQ29udGVudCgpIHsgcmV0dXJuIG1fY29udGVu dHM7IH0KIAotICAgIHZvaWQgc2V0Q29udGVudHMoTmF0aXZlSW1hZ2VQdHIpOworICAgIHZvaWQg c2V0Q29udGVudHMoSW1hZ2UqIGltYWdlKTsKIAogcHJpdmF0ZToKICAgICBJbWFnZUxheWVyQ2hy b21pdW0oR3JhcGhpY3NMYXllckNocm9taXVtKiBvd25lcik7CiAKLSNpZiBQTEFURk9STShDRykK LSAgICBSZXRhaW5QdHI8Q0dJbWFnZVJlZj4gbV9jb250ZW50czsKLSNlbHNlCi0gICAgLy8gRklY TUU6IFRoaXMgbmVlZHMgdG8gYmUgYW4gb3duaW5nIHR5cGUuCi0gICAgTmF0aXZlSW1hZ2VQdHIg bV9jb250ZW50czsKLSNlbmRpZgorICAgIFJlZlB0cjxJbWFnZT4gbV9jb250ZW50czsKIH07CiAK IH0K