45868 2010-09-15 19:31:41 -0700 update-webkit --chromium spitting out a spurious error 2010-09-18 18:21:34 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 prasadt webkit-unassigned abarth commit-queue levin oldest_to_newest 279907 0 prasadt 2010-09-15 19:31:41 -0700 update-webkit --chromium invokes invokes update-webkit-chromium which checks for gclient. And it does this by looking the value of `gclient --version`. When gclient is not in the path, it returns an error. Given that this is not a failure and the script moves on to look for it in other places, this ends up as spurious error in the output that can be misleading. One fix would be to redirect stderr of the command to "nul" on windows and "/dev/null" on other platforms. 279912 1 67762 prasadt 2010-09-15 19:35:27 -0700 Created attachment 67762 Redirect stderr from `gclient --version` to nul on windows and /dev/null on other platforms. 280848 2 67762 levin 2010-09-17 14:11:28 -0700 Comment on attachment 67762 Redirect stderr from `gclient --version` to nul on windows and /dev/null on other platforms. This needs a ChangeLog. 280850 3 levin 2010-09-17 14:16:27 -0700 btw, I see other places in perl code using "File::Spec->devnull()" instead of detecting the OS and setting a variable. 280903 4 67959 prasadt 2010-09-17 15:19:11 -0700 Created attachment 67959 Redirect stderr from `gclient --version` to nul on windows and /dev/null on other platforms. Added ChangeLog and using commandExists() instead of back tick. 281238 5 67959 abarth 2010-09-18 18:21:29 -0700 Comment on attachment 67959 Redirect stderr from `gclient --version` to nul on windows and /dev/null on other platforms. Clearing flags on attachment: 67959 Committed r67806: <http://trac.webkit.org/changeset/67806> 281239 6 abarth 2010-09-18 18:21:34 -0700 All reviewed patches have been landed. Closing bug. 67762 2010-09-15 19:35:27 -0700 2010-09-17 15:47:34 -0700 Redirect stderr from `gclient --version` to nul on windows and /dev/null on other platforms. update_webkit_chromium.txt text/plain 687 prasadt SW5kZXg6IFdlYktpdFRvb2xzL1NjcmlwdHMvdXBkYXRlLXdlYmtpdC1jaHJvbWl1bQo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBXZWJLaXRUb29scy9TY3JpcHRzL3VwZGF0ZS13ZWJraXQtY2hyb21pdW0JKHJldmlz aW9uIDY3NTk0KQorKysgV2ViS2l0VG9vbHMvU2NyaXB0cy91cGRhdGUtd2Via2l0LWNocm9taXVt CSh3b3JraW5nIGNvcHkpCkBAIC0zMyw5ICszMywxNyBAQCB1c2UgR2V0b3B0OjpMb25nOwogCiBj aGRpcigiV2ViS2l0L2Nocm9taXVtIikgb3IgZGllICQhOwogCisjIEdldCB0aGUgT1Mgc3BlY2lm aWMgL2Rldi9udWxsLgorbXkgJGRldm51bGw7CitpZiAoJF5PIGVxICdNU1dpbjMyJykgeworICAk ZGV2bnVsbCA9ICdudWwnOworfSBlbHNlIHsKKyAgJGRldm51bGwgPSAnL2Rldi9udWxsJzsKK30K KwogIyBGaW5kIGdjbGllbnQgb3IgaW5zdGFsbCBpdC4KIG15ICRnY2xpZW50UGF0aDsKLWlmIChg Z2NsaWVudCAtLXZlcnNpb25gKSB7CitpZiAoYGdjbGllbnQgLS12ZXJzaW9uIDI+ICRkZXZudWxs YCkgewogICAgICRnY2xpZW50UGF0aCA9ICdnY2xpZW50JzsKIH0gZWxzaWYgKC1lICdkZXBvdF90 b29scy9nY2xpZW50JykgewogICAgICRnY2xpZW50UGF0aCA9ICdkZXBvdF90b29scy9nY2xpZW50 JzsK 67959 2010-09-17 15:19:11 -0700 2010-09-18 18:21:29 -0700 Redirect stderr from `gclient --version` to nul on windows and /dev/null on other platforms. update_webkit_chromium.txt text/plain 1277 prasadt SW5kZXg6IFdlYktpdFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9D aGFuZ2VMb2cJKHJldmlzaW9uIDY3NzUwKQorKysgV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTAtMDktMTcgIFByYXNhZCBUYW1tYW5hICA8 cHJhc2FkdEBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgdXBkYXRlLXdlYmtpdCAtLWNocm9taXVtIHNwaXR0aW5nIG91dCBhIHNw dXJpb3VzIGVycm9yCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD00NTg2OAorCisgICAgICAgICogU2NyaXB0cy91cGRhdGUtd2Via2l0LWNocm9taXVtOiBV c2UgY29tbWFuZEV4aXN0cygpIGZ1bmN0aW9uIHRvIGNoZWNrIGZvciBleGlzdGVuY2Ugb2YgZ2Ns aWVudC4KKwogMjAxMC0wOS0xNyAgTWFydGluIFJvYmluc29uICA8bXJvYmluc29uQGlnYWxpYS5j b20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgT2xpdmVyIEh1bnQuCkluZGV4OiBXZWJLaXRUb29s cy9TY3JpcHRzL3VwZGF0ZS13ZWJraXQtY2hyb21pdW0KPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0VG9v bHMvU2NyaXB0cy91cGRhdGUtd2Via2l0LWNocm9taXVtCShyZXZpc2lvbiA2Nzc1MCkKKysrIFdl YktpdFRvb2xzL1NjcmlwdHMvdXBkYXRlLXdlYmtpdC1jaHJvbWl1bQkod29ya2luZyBjb3B5KQpA QCAtMjksMTMgKzI5LDE2IEBACiAjIFVwZGF0ZSBzY3JpcHQgZm9yIHRoZSBXZWJLaXQgQ2hyb21p dW0gUG9ydC4KIAogdXNlIEZpbGU6OlBhdGg7Cit1c2UgRmluZEJpbjsKIHVzZSBHZXRvcHQ6Okxv bmc7Cit1c2UgbGliICRGaW5kQmluOjpCaW47Cit1c2Ugd2Via2l0ZGlyczsKIAogY2hkaXIoIldl YktpdC9jaHJvbWl1bSIpIG9yIGRpZSAkITsKIAogIyBGaW5kIGdjbGllbnQgb3IgaW5zdGFsbCBp dC4KIG15ICRnY2xpZW50UGF0aDsKLWlmIChgZ2NsaWVudCAtLXZlcnNpb25gKSB7CitpZiAoY29t bWFuZEV4aXN0cygnZ2NsaWVudCcpKSB7CiAgICAgJGdjbGllbnRQYXRoID0gJ2djbGllbnQnOwog fSBlbHNpZiAoLWUgJ2RlcG90X3Rvb2xzL2djbGllbnQnKSB7CiAgICAgJGdjbGllbnRQYXRoID0g J2RlcG90X3Rvb2xzL2djbGllbnQnOwo=