45867 2010-09-15 19:20:59 -0700 Style bot complains about cairo forward declaration naming 2010-09-17 10:20:24 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC Linux RESOLVED FIXED Cairo P3 Normal --- 1 mrobinson webkit-unassigned oldest_to_newest 279905 0 mrobinson 2010-09-15 19:20:59 -0700 Typical errors take the form: WebCore/platform/DragImage.h:51: cairo_surface_t is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] We probably just need to add an exclusion for cairo typedefs. 280439 1 67858 mrobinson 2010-09-16 16:29:21 -0700 Created attachment 67858 Patch for this issue 280712 2 67858 mrobinson 2010-09-17 10:20:21 -0700 Comment on attachment 67858 Patch for this issue Clearing flags on attachment: 67858 Committed r67722: <http://trac.webkit.org/changeset/67722> 280713 3 mrobinson 2010-09-17 10:20:24 -0700 All reviewed patches have been landed. Closing bug. 67858 2010-09-16 16:29:21 -0700 2010-09-17 10:20:21 -0700 Patch for this issue bug-45867-20100916162920.patch text/plain 2879 mrobinson ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCAwMzlkYzAxMmU4YzAxYjY3MGI5MzlmMWZmY2I3ZTlhMjZmZjYwYTdmLi5jOWE4ZGFk ODlmMTdhMTg2OGI4MGQ0YTlhMzA0ZDQwNjg2ODIwYWQ0IDEwMDY0NAotLS0gYS9XZWJLaXRUb29s cy9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAK KzIwMTAtMDktMTYgIE1hcnRpbiBSb2JpbnNvbiAgPG1yb2JpbnNvbkBpZ2FsaWEuY29tPgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFN0eWxlIGJvdCBj b21wbGFpbnMgYWJvdXQgY2Fpcm8gZm9yd2FyZCBkZWNsYXJhdGlvbiBuYW1pbmcKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ1ODY3CisKKyAgICAgICAg RXhjbHVkZSBDYWlybyBmb3J3YXJkIGRlY2xhcmF0aW9ucyBmcm9tIGluZGVudGlmaWVycyB3aXRo IHVuZGVyc2NvcmVzIGNoZWNrcy4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvc3R5bGUv Y2hlY2tlcnMvY3BwLnB5OiBBZGQgZXhjbHVzaW9uIGZvciBDYWlybyBmb3J3YXJkLWRlY2xhcmF0 aW9ucy4KKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcF91bml0 dGVzdC5weTogQWRkIHNvbWUgdGVzdHMgZm9yIHRoaXMuCisKIDIwMTAtMDktMTUgIFRvbnkgQ2hh bmcgIDx0b255QGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBLZW50IFRhbXVy YS4KZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tl cnMvY3BwLnB5IGIvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9j cHAucHkKaW5kZXggNjJmNDBlYWIzN2ZiNDljZmNiYjFiYTkyZDQ0YmQyYjQxYzJhMjhiOC4uZjhl YmVmZjIwYjNlMmVmZjhjM2VjZTgwMWNlYzliZWU2OGQxZjk1ZCAxMDA2NDQKLS0tIGEvV2ViS2l0 VG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHAucHkKKysrIGIvV2ViS2l0 VG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHAucHkKQEAgLTI1MTksNiAr MjUxOSw3IEBAIGRlZiBjaGVja19pZGVudGlmaWVyX25hbWVfaW5fZGVjbGFyYXRpb24oZmlsZW5h bWUsIGxpbmVfbnVtYmVyLCBsaW5lLCBlcnJvcik6CiAgICAgICAgICAgICAgICAgYW5kIG5vdCBt b2RpZmllZF9pZGVudGlmaWVyLnN0YXJ0c3dpdGgoJ05QUF8nKQogICAgICAgICAgICAgICAgIGFu ZCBub3QgbW9kaWZpZWRfaWRlbnRpZmllci5zdGFydHN3aXRoKCdOUF8nKQogICAgICAgICAgICAg ICAgIGFuZCBub3QgbW9kaWZpZWRfaWRlbnRpZmllci5zdGFydHN3aXRoKCdxdF8nKQorICAgICAg ICAgICAgICAgIGFuZCBub3QgbW9kaWZpZWRfaWRlbnRpZmllci5zdGFydHN3aXRoKCdjYWlyb18n KQogICAgICAgICAgICAgICAgIGFuZCBub3QgbW9kaWZpZWRfaWRlbnRpZmllci5maW5kKCc6OnF0 XycpID49IDAKICAgICAgICAgICAgICAgICBhbmQgbm90IG1vZGlmaWVkX2lkZW50aWZpZXIgPT0g ImNvbnN0X2l0ZXJhdG9yIik6CiAgICAgICAgICAgICAgICAgZXJyb3IobGluZV9udW1iZXIsICdy ZWFkYWJpbGl0eS9uYW1pbmcnLCA0LCBpZGVudGlmaWVyICsgIiBpcyBpbmNvcnJlY3RseSBuYW1l ZC4gRG9uJ3QgdXNlIHVuZGVyc2NvcmVzIGluIHlvdXIgaWRlbnRpZmllciBuYW1lcy4iKQpkaWZm IC0tZ2l0IGEvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHBf dW5pdHRlc3QucHkgYi9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJz L2NwcF91bml0dGVzdC5weQppbmRleCAxNmIxYTNjMDRkZGZjY2ZhZmZjNGQ4YjE3Y2QzNTQxYzBm MDgxMmQwLi4yZjU0MzA1ZTAxMTIxYWFhOGJlZWFkZjI3NDY1NjZiMTA4NWFjZWVhIDEwMDY0NAot LS0gYS9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcF91bml0 dGVzdC5weQorKysgYi9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJz L2NwcF91bml0dGVzdC5weQpAQCAtMzcwMyw2ICszNzAzLDExIEBAIGNsYXNzIFdlYktpdFN0eWxl VGVzdChDcHBTdHlsZVRlc3RCYXNlKToKICAgICAgICAgc2VsZi5hc3NlcnRfbGludCgndm9pZCBR VEZyYW1lOjpxdF9kcnRfaXNfYXdlc29tZShpbnQgdmFyMSwgaW50IHZhcjIpJywgJycpCiAgICAg ICAgIHNlbGYuYXNzZXJ0X2xpbnQoJ3ZvaWQgcXRfZHJ0X2lzX2F3ZXNvbWUoaW50IHZhcjEsIGlu dCB2YXIyKTsnLCAnJykKIAorICAgICAgICAjIENhaXJvIGZvcndhcmQtZGVjbGFyYXRpb25zIHNo b3VsZCBub3QgYmUgYSBmYWlsdXJlLgorICAgICAgICBzZWxmLmFzc2VydF9saW50KCd0eXBlZGVm IHN0cnVjdCBfY2Fpcm8gY2Fpcm9fdDsnLCAnJykKKyAgICAgICAgc2VsZi5hc3NlcnRfbGludCgn dHlwZWRlZiBzdHJ1Y3QgX2NhaXJvX3N1cmZhY2UgY2Fpcm9fc3VyZmFjZV90OycsICcnKQorICAg ICAgICBzZWxmLmFzc2VydF9saW50KCd0eXBlZGVmIHN0cnVjdCBfY2Fpcm9fc2NhbGVkX2ZvbnQg Y2Fpcm9fc2NhbGVkX2ZvbnRfdDsnLCAnJykKKwogICAgICAgICAjIE5QQVBJIGZ1bmN0aW9ucyB0 aGF0IHN0YXJ0IHdpdGggTlBOXywgTlBQXyBvciBOUF8gYXJlIGFsbG93ZWQuCiAgICAgICAgIHNl bGYuYXNzZXJ0X2xpbnQoJ3ZvaWQgTlBOX1N0YXR1cyhOUFAsIGNvbnN0IGNoYXIqKScsICcnKQog ICAgICAgICBzZWxmLmFzc2VydF9saW50KCdOUEVycm9yIE5QUF9TZXRXaW5kb3coTlBQIGluc3Rh bmNlLCBOUFdpbmRvdyAqd2luZG93KScsICcnKQo=