45860 2010-09-15 18:08:58 -0700 [reviewtool] Allow setting review and commit-queue flags from main review screen 2010-09-15 20:03:06 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 abarth abarth abarth eric ojan webkit.review.bot oldest_to_newest 279870 0 abarth 2010-09-15 18:08:58 -0700 [reviewtool] Allow setting review and commit-queue flags from main review screen 279874 1 67753 abarth 2010-09-15 18:13:56 -0700 Created attachment 67753 Patch 279877 2 abarth 2010-09-15 18:19:39 -0700 Committed r67590: <http://trac.webkit.org/changeset/67590> 279922 3 webkit.review.bot 2010-09-15 20:03:06 -0700 http://trac.webkit.org/changeset/67590 might have broken GTK Linux 32-bit Debug The following changes are on the blame list: http://trac.webkit.org/changeset/67589 http://trac.webkit.org/changeset/67590 http://trac.webkit.org/changeset/67591 67753 2010-09-15 18:13:56 -0700 2010-09-15 18:14:58 -0700 Patch bug-45860-20100915181355.patch text/plain 5341 abarth SW5kZXg6IEJ1Z3NTaXRlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBCdWdzU2l0ZS9DaGFuZ2VM b2cJKHJldmlzaW9uIDY3NTg4KQorKysgQnVnc1NpdGUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkp CkBAIC0xLDMgKzEsMjggQEAKKzIwMTAtMDktMTUgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0 Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBb cmV2aWV3dG9vbF0gQWxsb3cgc2V0dGluZyByZXZpZXcgYW5kIGNvbW1pdC1xdWV1ZSBmbGFncyBm cm9tIG1haW4gcmV2aWV3IHNjcmVlbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9NDU4NjAKKworICAgICAgICBUaGlzIHBhdGNoIGFkZHMgZHJvcCBkb3du IG1lbnVzIGZvciBhZGp1c3RpbmcgdGhlIHJldmlldyBhbmQKKyAgICAgICAgY29tbWl0LXF1ZXVl IGZsYWdzIGZyb20gdGhlIG1haW4gcmV2aWV3IHNjcmVlbi4gIFRoZXNlIGNvbnRyb2xzIGRvbid0 CisgICAgICAgIGFwcGVhciBpbW1lZGlhdGVseSBiZWNhdXNlIHdlIG5lZWQgdG8gcmVhZCB0aGUg c3RhdGUgb2YgdGhlIGZsYWdzIG9mZgorICAgICAgICB0aGUgZGV0YWlscyBwYWdlLgorCisgICAg ICAgIEl0J3MgYSBzbGlnaHQgc2FkbmVzcyB0aGF0IGJ1Z3ppbGxhIGRvZXNuJ3QgaGF2ZSBhIGNs ZWFuIHdheSBvZgorICAgICAgICBpZGVudGlmeWluZyB3aGljaCBzZWxlY3QgY29udHJvbCBpcyBh c3NvY2lhdGVkIHdpdGggYSBnaXZlbiBmbGFnLiAgVGhlCisgICAgICAgIGZsYWdzIHNlZW0gdG8g aGF2ZSBzb21lIHNvcnQgb2YgaWQsIGJ1dCBpdCdzIHVuY2xlYXIgdG8gbWUgaG93IHRvIG1hcAor ICAgICAgICB0aGF0IGlkIGJhY2sgdG8gYSBub3Rpb24gb2YgInJldmlldyIgb3IgImNvbW1pdC1x dWV1ZSIuICBJbnN0ZWFkLCB3ZQorICAgICAgICBsb29rIGZvciBzb21lIG1hZ2ljIHN0cmluZ3Mg aW4gdGhlIHRpdGxlLiAgSSdtIHN1cmUgdGhpcyB3aWxsIGNvbWUgYmFjaworICAgICAgICB0byBi aXQgdXMgYXQgc29tZSBwb2ludCwgYnV0IEknbSBub3Qgc3VyZSB3aGF0IHRvIGRvIHRoYXQncyBi ZXR0ZXIuCisgICAgICAgIChUaGUgd2Via2l0cHkgc29sdXRpb24gdG8gdGhpcyBwcm9ibGVtIGlz IHRvIGFzc3VtZSB0aGF0IHRoZSBmbGFncyBhcmUKKyAgICAgICAgaW4gYSBnaXZlbiBvcmRlciwg YnV0IHRoaXMgc2VlbXMgYmV0dGVyLikKKworICAgICAgICAqIFByZXR0eVBhdGNoL1ByZXR0eVBh dGNoLnJiOgorICAgICAgICAgICAgLSBCdW1wIHZlcnNpb24gbnVtYmVyIHRvIGJ1c3QgdGhyb3Vo IGNhY2hlcy4KKyAgICAgICAgKiBjb2RlLXJldmlldy5qczoKKwogMjAxMC0wOS0xNSAgQWRhbSBC YXJ0aCAgPGFiYXJ0aEB3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEVyaWMgU2Vp ZGVsLgpJbmRleDogQnVnc1NpdGUvY29kZS1yZXZpZXcuanMKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gQnVnc1Np dGUvY29kZS1yZXZpZXcuanMJKHJldmlzaW9uIDY3NTc1KQorKysgQnVnc1NpdGUvY29kZS1yZXZp ZXcuanMJKHdvcmtpbmcgY29weSkKQEAgLTE5Myw2ICsxOTMsMzMgQEAKICAgICByZXR1cm4gY29t bWVudHM7CiAgIH0KIAorICBmdW5jdGlvbiBpc1Jldmlld0ZsYWcoc2VsZWN0KSB7CisgICAgcmV0 dXJuICQoc2VsZWN0KS5hdHRyKCd0aXRsZScpID09ICdSZXF1ZXN0IGZvciBwYXRjaCByZXZpZXcu JzsKKyAgfQorCisgIGZ1bmN0aW9uIGlzQ29tbWl0UXVldWVGbGFnKHNlbGVjdCkgeworICAgIHJl dHVybiAkKHNlbGVjdCkuYXR0cigndGl0bGUnKS5tYXRjaCgvY29tbWl0LXF1ZXVlLyk7CisgIH0K KworICBmdW5jdGlvbiBmaW5kQ29udHJvbEZvckZsYWcoc2VsZWN0KSB7CisgICAgaWYgKGlzUmV2 aWV3RmxhZyhzZWxlY3QpKQorICAgICAgcmV0dXJuICQoJyN0b29sYmFyIC5yZXZpZXcgc2VsZWN0 Jyk7CisgICAgZWxzZSBpZiAoaXNDb21taXRRdWV1ZUZsYWcoc2VsZWN0KSkKKyAgICAgIHJldHVy biAkKCcjdG9vbGJhciAuY29tbWl0UXVldWUgc2VsZWN0Jyk7CisgICAgcmV0dXJuICQoKTsKKyAg fQorCisgIGZ1bmN0aW9uIGFkZEZsYWdzRm9yQXR0YWNobWVudChkZXRhaWxzKSB7CisgICAgdmFy IGZsYWdfY29udHJvbCA9ICI8c2VsZWN0PjxvcHRpb24+PC9vcHRpb24+PG9wdGlvbj4/PC9vcHRp b24+PG9wdGlvbj4rPC9vcHRpb24+PG9wdGlvbj4tPC9vcHRpb24+PC9zZWxlY3Q+IjsKKyAgICAk KCcjdG9vbGJhciAuYWN0aW9ucycpLmFwcGVuZCgKKyAgICAgICQoJzxzcGFuIGNsYXNzPSJyZXZp ZXciPiByOiAnICsgZmxhZ19jb250cm9sICsgJzwvc3Bhbj4nKSkuYXBwZW5kKAorICAgICAgJCgn PHNwYW4gY2xhc3M9ImNvbW1pdFF1ZXVlIj4gY3E6ICcgKyBmbGFnX2NvbnRyb2wgKyAnPC9zcGFu PicpKTsKKworICAgIGRldGFpbHMuZmluZCgnI2ZsYWdzIHNlbGVjdCcpLmVhY2goZnVuY3Rpb24o KSB7CisgICAgICBmaW5kQ29udHJvbEZvckZsYWcodGhpcykuYXR0cignc2VsZWN0ZWRJbmRleCcs ICQodGhpcykuYXR0cignc2VsZWN0ZWRJbmRleCcpKTsKKyAgICB9KTsKKyAgfQorCiAgIGZ1bmN0 aW9uIGZldGNoSGlzdG9yeSgpIHsKICAgICAkLmdldCgnYXR0YWNobWVudC5jZ2k/aWQ9JyArIGF0 dGFjaG1lbnRfaWQgKyAnJmFjdGlvbj1lZGl0JywgZnVuY3Rpb24oZGF0YSkgewogICAgICAgdmFy IGJ1Z19pZCA9IC9BdHRhY2htZW50IFxkKyBEZXRhaWxzIGZvciBCdWcgKFxkKykvLmV4ZWMoZGF0 YSlbMV07CkBAIC0yMDcsNiArMjM0LDEwIEBACiAgICAgICAgIH0pOwogICAgICAgICBkaXNwbGF5 UHJldmlvdXNDb21tZW50cyhjb21tZW50cyk7CiAgICAgICB9KTsKKworICAgICAgdmFyIGRldGFp bHMgPSAkKGRhdGEpOworCisgICAgICBhZGRGbGFnc0ZvckF0dGFjaG1lbnQoZGV0YWlscyk7CiAg ICAgfSk7CiAgIH0KIApAQCAtMjIxLDggKzI1Miw4IEBACiAgICQoZG9jdW1lbnQpLnJlYWR5KGZ1 bmN0aW9uKCkgewogICAgIGNyYXdsRGlmZigpOwogICAgIGZldGNoSGlzdG9yeSgpOwotICAgICQo ZG9jdW1lbnQuYm9keSkucHJlcGVuZCgnPGRpdiBpZD0idG9vbGJhciI+PGRpdiBjbGFzcz0iYWN0 aW9ucyI+PGJ1dHRvbiBpZD0icG9zdF9jb21tZW50cyI+UHVibGlzaCBjb21tZW50czwvYnV0dG9u PjwvZGl2PjxkaXYgY2xhc3M9Im1lc3NhZ2UiPjxzcGFuIGNsYXNzPSJjb21tZW50U3RhdHVzIj48 L3NwYW4+IDxzcGFuIGNsYXNzPSJoZWxwIj5Eb3VibGUtY2xpY2sgYSBsaW5lIHRvIGFkZCBhIGNv bW1lbnQuPC9zcGFuPjwvZGl2PjwvZGl2PicpOwotICAgICQoZG9jdW1lbnQuYm9keSkucHJlcGVu ZCgnPGRpdiBpZD0iY29tbWVudF9mb3JtIiBjbGFzcz0iaW5hY3RpdmUiPjxkaXYgY2xhc3M9Indp bnRlciI+PC9kaXY+PGRpdiBjbGFzcz0ibGlnaHRib3giPjxpZnJhbWUgc3JjPSJhdHRhY2htZW50 LmNnaT9pZD0nICsgYXR0YWNobWVudF9pZCArICcmYWN0aW9uPXJldmlld2Zvcm0iPjwvaWZyYW1l PjwvZGl2PjwvZGl2PicpOworICAgICQoZG9jdW1lbnQuYm9keSkucHJlcGVuZCgnPGRpdiBpZD0i dG9vbGJhciI+PGRpdiBjbGFzcz0iYWN0aW9ucyI+PGJ1dHRvbiBpZD0icG9zdF9jb21tZW50cyI+ UHVibGlzaDwvYnV0dG9uPjwvZGl2PjxkaXYgY2xhc3M9Im1lc3NhZ2UiPjxzcGFuIGNsYXNzPSJj b21tZW50U3RhdHVzIj48L3NwYW4+IDxzcGFuIGNsYXNzPSJoZWxwIj5Eb3VibGUtY2xpY2sgYSBs aW5lIHRvIGFkZCBhIGNvbW1lbnQuPC9zcGFuPjwvZGl2PjwvZGl2PicpOworICAgICQoZG9jdW1l bnQuYm9keSkucHJlcGVuZCgnPGRpdiBpZD0iY29tbWVudF9mb3JtIiBjbGFzcz0iaW5hY3RpdmUi PjxkaXYgY2xhc3M9IndpbnRlciI+PC9kaXY+PGRpdiBjbGFzcz0ibGlnaHRib3giPjxpZnJhbWUg aWQ9InJldmlld2Zvcm0iIHNyYz0iYXR0YWNobWVudC5jZ2k/aWQ9JyArIGF0dGFjaG1lbnRfaWQg KyAnJmFjdGlvbj1yZXZpZXdmb3JtIj48L2lmcmFtZT48L2Rpdj48L2Rpdj4nKTsKICAgICAkKGRv Y3VtZW50LmJvZHkpLmFwcGVuZCgnPGRpdiBjbGFzcz0ib3ZlcmFsbENvbW1lbnRzIj48ZGl2IGNs YXNzPSJkZXNjcmlwdGlvbiI+T3ZlcmFsbCBjb21tZW50czo8L2Rpdj48dGV4dGFyZWE+PC90ZXh0 YXJlYT48L2Rpdj4nKTsKICAgfSk7CiAKQEAgLTQyNiw2ICs0NTcsMTMgQEAKICAgICBjb21tZW50 ICs9IGNvbW1lbnRzX2luX2NvbnRleHQuam9pbignXG5cbicpOwogICAgIGlmIChjb21tZW50ICE9 ICcnKQogICAgICAgY29tbWVudCA9ICdWaWV3IGluIGNvbnRleHQ6ICcgKyB3aW5kb3cubG9jYXRp b24gKyAnXG5cbicgKyBjb21tZW50OwotICAgICQoJyNjb21tZW50X2Zvcm0nKS5maW5kKCdpZnJh bWUnKS5jb250ZW50cygpLmZpbmQoJyNjb21tZW50JykudmFsKGNvbW1lbnQpOworICAgIHZhciBy ZXZpZXdfZm9ybSA9ICQoJyNyZXZpZXdmb3JtJykuY29udGVudHMoKTsKKyAgICByZXZpZXdfZm9y bS5maW5kKCcjY29tbWVudCcpLnZhbChjb21tZW50KTsKKyAgICByZXZpZXdfZm9ybS5maW5kKCcj ZmxhZ3Mgc2VsZWN0JykuZWFjaChmdW5jdGlvbigpIHsKKyAgICAgIHZhciBjb250cm9sID0gZmlu ZENvbnRyb2xGb3JGbGFnKHRoaXMpOworICAgICAgaWYgKCFjb250cm9sLnNpemUoKSkKKyAgICAg ICAgcmV0dXJuOworICAgICAgJCh0aGlzKS5hdHRyKCdzZWxlY3RlZEluZGV4JywgY29udHJvbC5h dHRyKCdzZWxlY3RlZEluZGV4JykpOworICAgIH0pOwogICB9KTsKIH0pKCk7CkluZGV4OiBCdWdz U2l0ZS9QcmV0dHlQYXRjaC9QcmV0dHlQYXRjaC5yYgo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBCdWdzU2l0ZS9Q cmV0dHlQYXRjaC9QcmV0dHlQYXRjaC5yYgkocmV2aXNpb24gNjc1NjkpCisrKyBCdWdzU2l0ZS9Q cmV0dHlQYXRjaC9QcmV0dHlQYXRjaC5yYgkod29ya2luZyBjb3B5KQpAQCAtMjk4LDcgKzI5OCw3 IEBAIGJvZHkgewogfQogPC9zdHlsZT4KIDxzY3JpcHQgc3JjPSJodHRwczovL2FqYXguZ29vZ2xl YXBpcy5jb20vYWpheC9saWJzL2pxdWVyeS8xLjQuMi9qcXVlcnkubWluLmpzIj48L3NjcmlwdD4g Ci08c2NyaXB0IHNyYz0iY29kZS1yZXZpZXcuanM/dmVyc2lvbj03Ij48L3NjcmlwdD4gCis8c2Ny aXB0IHNyYz0iY29kZS1yZXZpZXcuanM/dmVyc2lvbj04Ij48L3NjcmlwdD4gCiBFT0YKIAogICAg IGRlZiBzZWxmLnJldmlzaW9uT3JEZXNjcmlwdGlvbihzdHJpbmcpCg==