<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>45857</bug_id>
          
          <creation_ts>2010-09-15 17:58:26 -0700</creation_ts>
          <short_desc>PluginStrategy should satisfy the needs of Qt</short_desc>
          <delta_ts>2010-09-22 07:24:30 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Platform</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>PC</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>45881</blocked>
    
    <blocked>46078</blocked>
    
    <blocked>46181</blocked>
          <everconfirmed>0</everconfirmed>
          <reporter name="Balazs Kelemen">kbalazs</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>abarth</cc>
    
    <cc>abecsi</cc>
    
    <cc>ademar</cc>
    
    <cc>darin</cc>
    
    <cc>eric</cc>
    
    <cc>kenneth</cc>
    
    <cc>kling</cc>
    
    <cc>mjs</cc>
    
    <cc>ossy</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>279863</commentid>
    <comment_count>0</comment_count>
    <who name="Balazs Kelemen">kbalazs</who>
    <bug_when>2010-09-15 17:58:26 -0700</bug_when>
    <thetext>The WebKit2 port makes the need of using the PlatformStrategies in Qt but currently PluginStrategy does not fit our needs. Qt has API to set custom plugins for a specific page.  See http://doc.qt.nokia.com/4.6/qwebpage.html#setPluginFactory for more information.
To be able to implement this API through PluginStrategy PluginStrategy::getPluginInfo should take a Page* argument that would be unused by other ports.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>279872</commentid>
    <comment_count>1</comment_count>
      <attachid>67752</attachid>
    <who name="Balazs Kelemen">kbalazs</who>
    <bug_when>2010-09-15 18:12:36 -0700</bug_when>
    <thetext>Created attachment 67752
proposed patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>279957</commentid>
    <comment_count>2</comment_count>
      <attachid>67752</attachid>
    <who name="Kenneth Rohde Christiansen">kenneth</who>
    <bug_when>2010-09-16 00:27:16 -0700</bug_when>
    <thetext>Comment on attachment 67752
proposed patch

The patch doesn&apos;t contain the Qt part, not say why the page is needed.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>279964</commentid>
    <comment_count>3</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2010-09-16 01:06:27 -0700</bug_when>
    <thetext>Attachment 67752 did not build on win:
Build output: http://queues.webkit.org/results/4005036</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>279984</commentid>
    <comment_count>4</comment_count>
      <attachid>67752</attachid>
    <who name="Balazs Kelemen">kbalazs</who>
    <bug_when>2010-09-16 02:14:25 -0700</bug_when>
    <thetext>Comment on attachment 67752
proposed patch

Windows needs investigation.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>279985</commentid>
    <comment_count>5</comment_count>
    <who name="Balazs Kelemen">kbalazs</who>
    <bug_when>2010-09-16 02:17:26 -0700</bug_when>
    <thetext>(In reply to comment #2)
&gt; (From update of attachment 67752 [details])
&gt; The patch doesn&apos;t contain the Qt part, not say why the page is needed.

The qt part will coming soon in a separate patch but first I need to fix the windows build.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>280014</commentid>
    <comment_count>6</comment_count>
      <attachid>67780</attachid>
    <who name="Balazs Kelemen">kbalazs</who>
    <bug_when>2010-09-16 04:47:28 -0700</bug_when>
    <thetext>Created attachment 67780
proposed patch v2</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>281319</commentid>
    <comment_count>7</comment_count>
      <attachid>67780</attachid>
    <who name="Andreas Kling">kling</who>
    <bug_when>2010-09-19 15:06:59 -0700</bug_when>
    <thetext>Comment on attachment 67780
proposed patch v2

&gt; +        * plugins/PluginStrategy.h: Added a |const Page*| argument to initPlugins.
Typo: you&apos;re adding the argument to getPluginInfo, not initPlugins.

This approach looks good to me, it fixes the current crashiness and API regression.

Why does the Qt part needs to be in a separate patch?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>281444</commentid>
    <comment_count>8</comment_count>
    <who name="Balazs Kelemen">kbalazs</who>
    <bug_when>2010-09-20 01:44:22 -0700</bug_when>
    <thetext>(In reply to comment #7)
&gt; (From update of attachment 67780 [details])
&gt; &gt; +        * plugins/PluginStrategy.h: Added a |const Page*| argument to initPlugins.
&gt; Typo: you&apos;re adding the argument to getPluginInfo, not initPlugins.
&gt; 
&gt; This approach looks good to me, it fixes the current crashiness and API regression.
&gt; 
&gt; Why does the Qt part needs to be in a separate patch?

For easier review :). My imagination was that this will be reviewed by a core developer from Apple and the qt part will be reviewed by a Qt folk. Furthermore,
as I know the policy is to keep patches as small as we can.
Actually, the Qt part is out-of-date by means of http://trac.webkit.org/changeset/67787. I think we should land this first and then fix our PlatformStrategies.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>281445</commentid>
    <comment_count>9</comment_count>
      <attachid>67780</attachid>
    <who name="Balazs Kelemen">kbalazs</who>
    <bug_when>2010-09-20 01:47:51 -0700</bug_when>
    <thetext>Comment on attachment 67780
proposed patch v2

Review cq? since the Changelog should be typo fixed.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>281446</commentid>
    <comment_count>10</comment_count>
    <who name="Balazs Kelemen">kbalazs</who>
    <bug_when>2010-09-20 01:48:06 -0700</bug_when>
    <thetext>(In reply to comment #9)
&gt; (From update of attachment 67780 [details])
&gt; Review cq? since the Changelog should be typo fixed.

Remove</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>282893</commentid>
    <comment_count>11</comment_count>
      <attachid>67780</attachid>
    <who name="Kenneth Rohde Christiansen">kenneth</who>
    <bug_when>2010-09-22 06:12:55 -0700</bug_when>
    <thetext>Comment on attachment 67780
proposed patch v2

PlatformStrategies is supposed to be a global instance for global platform things. Getting additional [Qt] plugins associated with a page isn&apos;t really a platform things and might have to be done separately.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>282894</commentid>
    <comment_count>12</comment_count>
    <who name="Kenneth Rohde Christiansen">kenneth</who>
    <bug_when>2010-09-22 06:15:23 -0700</bug_when>
    <thetext>(In reply to comment #11)
&gt; (From update of attachment 67780 [details])
&gt; PlatformStrategies is supposed to be a global instance for global platform things. Getting additional [Qt] plugins associated with a page isn&apos;t really a platform things and might have to be done separately.

Maybe it is not such a bad idea anyway, as it would allow us to restrict certain plugins for certain pages.

Another solution would be to create a PluginDatabaseClient for accessing the Qt page related plugins, though that seems like a bit of overkill.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>282918</commentid>
    <comment_count>13</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2010-09-22 07:23:07 -0700</bug_when>
    <thetext>http://trac.webkit.org/changeset/68038 might have broken Qt Linux Release minimal, Qt Linux ARMv5 Release, and Qt Linux ARMv7 Release
The following changes are on the blame list:
http://trac.webkit.org/changeset/68037
http://trac.webkit.org/changeset/68038</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>282920</commentid>
    <comment_count>14</comment_count>
    <who name="Andreas Kling">kling</who>
    <bug_when>2010-09-22 07:24:30 -0700</bug_when>
    <thetext>Committed r68038: &lt;http://trac.webkit.org/changeset/68038&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>67752</attachid>
            <date>2010-09-15 18:12:36 -0700</date>
            <delta_ts>2010-09-16 02:14:24 -0700</delta_ts>
            <desc>proposed patch</desc>
            <filename>land_pluginstrategy_page.diff</filename>
            <type>text/plain</type>
            <size>7290</size>
            <attacher name="Balazs Kelemen">kbalazs</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg
ODFhNWI4Ny4uNzA2MmM2YSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi
Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMC0wOS0xNSAgQmFsYXpzIEtlbGVt
ZW4gIDxrYkBpbmYudS1zemVnZWQuaHU+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP
T1BTISkuCisKKyAgICAgICAgUGx1Z2luU3RyYXRlZ3kgc2hvdWxkIHNhdGlzZmllcyB0aGUgbmVl
ZHMgb2YgUXQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk
PTQ1ODU3CisgICAgICAgIE5vIG5ldyBmdW5jdGlvbmFsaXR5IHNvIG5vIG5ldyB0ZXN0cy4KKwor
ICAgICAgICAqIHBsdWdpbnMvUGx1Z2luRGF0YS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpQbHVn
aW5EYXRhOjppbml0UGx1Z2lucyk6CisgICAgICAgICogcGx1Z2lucy9QbHVnaW5TdHJhdGVneS5o
OiBBZGRlZCBhIHxjb25zdCBQYWdlKnwgYXJndW1lbnQgdG8gaW5pdFBsdWdpbnMuCisKIDIwMTAt
MDktMTQgIFBpZXJyZS1BbnRvaW5lIExhRmF5ZXR0ZSAgPHBsYWZheWV0QGNvZGVhdXJvcmEub3Jn
PgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEFkbGVyLgpkaWZmIC0tZ2l0IGEvV2ViQ29y
ZS9wbHVnaW5zL1BsdWdpbkRhdGEuY3BwIGIvV2ViQ29yZS9wbHVnaW5zL1BsdWdpbkRhdGEuY3Bw
CmluZGV4IGZmOTA3NDcuLmQyNGQyMzQgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGx1Z2lucy9QbHVn
aW5EYXRhLmNwcAorKysgYi9XZWJDb3JlL3BsdWdpbnMvUGx1Z2luRGF0YS5jcHAKQEAgLTc1LDcg
Kzc1LDcgQEAgdm9pZCBQbHVnaW5EYXRhOjppbml0UGx1Z2lucygpCiB7CiAgICAgQVNTRVJUKG1f
cGx1Z2lucy5pc0VtcHR5KCkpOwogICAgIAotICAgIHBsYXRmb3JtU3RyYXRlZ2llcygpLT5wbHVn
aW5TdHJhdGVneSgpLT5nZXRQbHVnaW5JbmZvKG1fcGx1Z2lucyk7CisgICAgcGxhdGZvcm1TdHJh
dGVnaWVzKCktPnBsdWdpblN0cmF0ZWd5KCktPmdldFBsdWdpbkluZm8obV9wYWdlLCBtX3BsdWdp
bnMpOwogfQogI2VuZGlmCiAKZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGx1Z2lucy9QbHVnaW5TdHJh
dGVneS5oIGIvV2ViQ29yZS9wbHVnaW5zL1BsdWdpblN0cmF0ZWd5LmgKaW5kZXggN2U5MjE5Ni4u
OWQ4YTdiNSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wbHVnaW5zL1BsdWdpblN0cmF0ZWd5LmgKKysr
IGIvV2ViQ29yZS9wbHVnaW5zL1BsdWdpblN0cmF0ZWd5LmgKQEAgLTMyLDEwICszMiwxMiBAQAog
CiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKK2NsYXNzIFBhZ2U7CisKIGNsYXNzIFBsdWdpblN0cmF0
ZWd5IHsKIHB1YmxpYzoKICAgICB2aXJ0dWFsIHZvaWQgcmVmcmVzaFBsdWdpbnMoKSA9IDA7Ci0g
ICAgdmlydHVhbCB2b2lkIGdldFBsdWdpbkluZm8oVmVjdG9yPFBsdWdpbkluZm8+JikgPSAwOwor
ICAgIHZpcnR1YWwgdm9pZCBnZXRQbHVnaW5JbmZvKGNvbnN0IFBhZ2UqLCBWZWN0b3I8UGx1Z2lu
SW5mbz4mKSA9IDA7CiAKIHByb3RlY3RlZDoKICAgICB2aXJ0dWFsIH5QbHVnaW5TdHJhdGVneSgp
IHsgfQpkaWZmIC0tZ2l0IGEvV2ViS2l0L21hYy9DaGFuZ2VMb2cgYi9XZWJLaXQvbWFjL0NoYW5n
ZUxvZwppbmRleCBhOWUwMzA0Li5mYWMyZmVkIDEwMDY0NAotLS0gYS9XZWJLaXQvbWFjL0NoYW5n
ZUxvZworKysgYi9XZWJLaXQvbWFjL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEwLTA5
LTE1ICBCYWxhenMgS2VsZW1lbiAgPGtiQGluZi51LXN6ZWdlZC5odT4KKworICAgICAgICBSZXZp
ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBQbHVnaW5TdHJhdGVneSBzaG91bGQg
c2F0aXNmaWVzIHRoZSBuZWVkcyBvZiBRdAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y
Zy9zaG93X2J1Zy5jZ2k/aWQ9NDU4NTcKKyAgICAgICAgTm8gbmV3IGZ1bmN0aW9uYWxpdHkgc28g
bm8gbmV3IHRlc3RzLgorCisgICAgICAgICogV2ViQ29yZVN1cHBvcnQvV2ViUGxhdGZvcm1TdHJh
dGVnaWVzLmg6CisgICAgICAgICogV2ViQ29yZVN1cHBvcnQvV2ViUGxhdGZvcm1TdHJhdGVnaWVz
Lm1tOgorICAgICAgICAoV2ViUGxhdGZvcm1TdHJhdGVnaWVzOjpnZXRQbHVnaW5JbmZvKToKKwog
MjAxMC0wOS0xNCAgRXJpYyBTZWlkZWwgIDxlcmljQHdlYmtpdC5vcmc+CiAKICAgICAgICAgVW5y
ZXZpZXdlZCwgcmV2ZXJ0aW5nIGNoYW5nZXMgcjY3NDUxIGFuZCByNjc0NTEuCmRpZmYgLS1naXQg
YS9XZWJLaXQvbWFjL1dlYkNvcmVTdXBwb3J0L1dlYlBsYXRmb3JtU3RyYXRlZ2llcy5oIGIvV2Vi
S2l0L21hYy9XZWJDb3JlU3VwcG9ydC9XZWJQbGF0Zm9ybVN0cmF0ZWdpZXMuaAppbmRleCA1M2Yz
OWY4Li43YjZjNDdkIDEwMDY0NAotLS0gYS9XZWJLaXQvbWFjL1dlYkNvcmVTdXBwb3J0L1dlYlBs
YXRmb3JtU3RyYXRlZ2llcy5oCisrKyBiL1dlYktpdC9tYWMvV2ViQ29yZVN1cHBvcnQvV2ViUGxh
dGZvcm1TdHJhdGVnaWVzLmgKQEAgLTQ1LDcgKzQ1LDcgQEAgcHJpdmF0ZToKIAogICAgIC8vIFdl
YkNvcmU6OlBsdWdpblN0cmF0ZWd5CiAgICAgdmlydHVhbCB2b2lkIHJlZnJlc2hQbHVnaW5zKCk7
Ci0gICAgdmlydHVhbCB2b2lkIGdldFBsdWdpbkluZm8oVmVjdG9yPFdlYkNvcmU6OlBsdWdpbklu
Zm8+Jik7CisgICAgdmlydHVhbCB2b2lkIGdldFBsdWdpbkluZm8oY29uc3QgUGFnZSosIFZlY3Rv
cjxXZWJDb3JlOjpQbHVnaW5JbmZvPiYpOwogCiAgICAgLy8gV2ViQ29yZTo6TG9jYWxpemF0aW9u
U3RyYXRlZ3kgICAgCiAgICAgdmlydHVhbCBXVEY6OlN0cmluZyBpbnB1dEVsZW1lbnRBbHRUZXh0
KCk7CmRpZmYgLS1naXQgYS9XZWJLaXQvbWFjL1dlYkNvcmVTdXBwb3J0L1dlYlBsYXRmb3JtU3Ry
YXRlZ2llcy5tbSBiL1dlYktpdC9tYWMvV2ViQ29yZVN1cHBvcnQvV2ViUGxhdGZvcm1TdHJhdGVn
aWVzLm1tCmluZGV4IDI5MDBjY2YuLjViNzQzYzYgMTAwNjQ0Ci0tLSBhL1dlYktpdC9tYWMvV2Vi
Q29yZVN1cHBvcnQvV2ViUGxhdGZvcm1TdHJhdGVnaWVzLm1tCisrKyBiL1dlYktpdC9tYWMvV2Vi
Q29yZVN1cHBvcnQvV2ViUGxhdGZvcm1TdHJhdGVnaWVzLm1tCkBAIC03Miw3ICs3Miw3IEBAIHZv
aWQgV2ViUGxhdGZvcm1TdHJhdGVnaWVzOjpyZWZyZXNoUGx1Z2lucygpCiAgICAgW1tXZWJQbHVn
aW5EYXRhYmFzZSBzaGFyZWREYXRhYmFzZV0gcmVmcmVzaF07CiB9CiAKLXZvaWQgV2ViUGxhdGZv
cm1TdHJhdGVnaWVzOjpnZXRQbHVnaW5JbmZvKFZlY3RvcjxXZWJDb3JlOjpQbHVnaW5JbmZvPiYg
cGx1Z2lucykKK3ZvaWQgV2ViUGxhdGZvcm1TdHJhdGVnaWVzOjpnZXRQbHVnaW5JbmZvKGNvbnN0
IFBhZ2UqLCBWZWN0b3I8V2ViQ29yZTo6UGx1Z2luSW5mbz4mIHBsdWdpbnMpCiB7CiAgICAgQkVH
SU5fQkxPQ0tfT0JKQ19FWENFUFRJT05TOwogCmRpZmYgLS1naXQgYS9XZWJLaXQvd2luL0NoYW5n
ZUxvZyBiL1dlYktpdC93aW4vQ2hhbmdlTG9nCmluZGV4IDhjOGU3YTMuLjcxMDU2Y2EgMTAwNjQ0
Ci0tLSBhL1dlYktpdC93aW4vQ2hhbmdlTG9nCisrKyBiL1dlYktpdC93aW4vQ2hhbmdlTG9nCkBA
IC0xLDMgKzEsMTUgQEAKKzIwMTAtMDktMTUgIEJhbGF6cyBLZWxlbWVuICA8a2JAaW5mLnUtc3pl
Z2VkLmh1PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg
IFBsdWdpblN0cmF0ZWd5IHNob3VsZCBzYXRpc2ZpZXMgdGhlIG5lZWRzIG9mIFF0CisgICAgICAg
IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NTg1NworICAgICAgICBO
byBuZXcgZnVuY3Rpb25hbGl0eSBzbyBubyBuZXcgdGVzdHMuCisKKyAgICAgICAgKiBXZWJDb3Jl
U3VwcG9ydC9XZWJQbGF0Zm9ybVN0cmF0ZWdpZXMuY3BwOgorICAgICAgICAoV2ViUGxhdGZvcm1T
dHJhdGVnaWVzOjpnZXRQbHVnaW5JbmZvKToKKyAgICAgICAgKiBXZWJDb3JlU3VwcG9ydC9XZWJQ
bGF0Zm9ybVN0cmF0ZWdpZXMuaDoKKwogMjAxMC0wOS0xMyAgRW5yaWNhIENhc3VjY2kgIDxlbnJp
Y2FAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFNhbSBXZWluaWcuCmRpZmYgLS1n
aXQgYS9XZWJLaXQvd2luL1dlYkNvcmVTdXBwb3J0L1dlYlBsYXRmb3JtU3RyYXRlZ2llcy5jcHAg
Yi9XZWJLaXQvd2luL1dlYkNvcmVTdXBwb3J0L1dlYlBsYXRmb3JtU3RyYXRlZ2llcy5jcHAKaW5k
ZXggMDBhMmVhYi4uN2YwNTc4ZSAxMDA2NDQKLS0tIGEvV2ViS2l0L3dpbi9XZWJDb3JlU3VwcG9y
dC9XZWJQbGF0Zm9ybVN0cmF0ZWdpZXMuY3BwCisrKyBiL1dlYktpdC93aW4vV2ViQ29yZVN1cHBv
cnQvV2ViUGxhdGZvcm1TdHJhdGVnaWVzLmNwcApAQCAtNjgsNyArNjgsNyBAQCB2b2lkIFdlYlBs
YXRmb3JtU3RyYXRlZ2llczo6cmVmcmVzaFBsdWdpbnMoKQogICAgIFBsdWdpbkRhdGFiYXNlOjpp
bnN0YWxsZWRQbHVnaW5zKCktPnJlZnJlc2goKTsKIH0KIAotdm9pZCBXZWJQbGF0Zm9ybVN0cmF0
ZWdpZXM6OmdldFBsdWdpbkluZm8oVmVjdG9yPFdlYkNvcmU6OlBsdWdpbkluZm8+JiBvdXRQbHVn
aW5zKQordm9pZCBXZWJQbGF0Zm9ybVN0cmF0ZWdpZXM6OmdldFBsdWdpbkluZm8oY29uc3QgUGFn
ZSosIFZlY3RvcjxXZWJDb3JlOjpQbHVnaW5JbmZvPiYgb3V0UGx1Z2lucykKIHsKICAgICBjb25z
dCBWZWN0b3I8UGx1Z2luUGFja2FnZSo+JiBwbHVnaW5zID0gUGx1Z2luRGF0YWJhc2U6Omluc3Rh
bGxlZFBsdWdpbnMoKS0+cGx1Z2lucygpOwogCmRpZmYgLS1naXQgYS9XZWJLaXQvd2luL1dlYkNv
cmVTdXBwb3J0L1dlYlBsYXRmb3JtU3RyYXRlZ2llcy5oIGIvV2ViS2l0L3dpbi9XZWJDb3JlU3Vw
cG9ydC9XZWJQbGF0Zm9ybVN0cmF0ZWdpZXMuaAppbmRleCBjM2NmYmI0Li5lYzVhZGIwIDEwMDY0
NAotLS0gYS9XZWJLaXQvd2luL1dlYkNvcmVTdXBwb3J0L1dlYlBsYXRmb3JtU3RyYXRlZ2llcy5o
CisrKyBiL1dlYktpdC93aW4vV2ViQ29yZVN1cHBvcnQvV2ViUGxhdGZvcm1TdHJhdGVnaWVzLmgK
QEAgLTQ1LDcgKzQ1LDcgQEAgcHJpdmF0ZToKIAogICAgIC8vIFdlYkNvcmU6OlBsdWdpblN0cmF0
ZWd5CiAgICAgdmlydHVhbCB2b2lkIHJlZnJlc2hQbHVnaW5zKCk7Ci0gICAgdmlydHVhbCB2b2lk
IGdldFBsdWdpbkluZm8oVmVjdG9yPFdlYkNvcmU6OlBsdWdpbkluZm8+Jik7CisgICAgdmlydHVh
bCB2b2lkIGdldFBsdWdpbkluZm8oY29uc3QgUGFnZSosIFZlY3RvcjxXZWJDb3JlOjpQbHVnaW5J
bmZvPiYpOwogCiAgICAgLy8gV2ViQ29yZTo6TG9jYWxpemF0aW9uU3RyYXRlZ3kgICAgCiAgICAg
dmlydHVhbCBXVEY6OlN0cmluZyBpbnB1dEVsZW1lbnRBbHRUZXh0KCk7CmRpZmYgLS1naXQgYS9X
ZWJLaXQyL0NoYW5nZUxvZyBiL1dlYktpdDIvQ2hhbmdlTG9nCmluZGV4IDRiNjZmNzAuLjU3YWM4
MzYgMTAwNjQ0Ci0tLSBhL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1dlYktpdDIvQ2hhbmdlTG9n
CkBAIC0xLDMgKzEsMTUgQEAKKzIwMTAtMDktMTUgIEJhbGF6cyBLZWxlbWVuICA8a2JAaW5mLnUt
c3plZ2VkLmh1PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg
ICAgIFBsdWdpblN0cmF0ZWd5IHNob3VsZCBzYXRpc2ZpZXMgdGhlIG5lZWRzIG9mIFF0CisgICAg
ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NTg1NworICAgICAg
ICBObyBuZXcgZnVuY3Rpb25hbGl0eSBzbyBubyBuZXcgdGVzdHMuCisKKyAgICAgICAgKiBXZWJQ
cm9jZXNzL1dlYkNvcmVTdXBwb3J0L1dlYlBsYXRmb3JtU3RyYXRlZ2llcy5jcHA6CisgICAgICAg
IChXZWJLaXQ6OldlYlBsYXRmb3JtU3RyYXRlZ2llczo6Z2V0UGx1Z2luSW5mbyk6CisgICAgICAg
ICogV2ViUHJvY2Vzcy9XZWJDb3JlU3VwcG9ydC9XZWJQbGF0Zm9ybVN0cmF0ZWdpZXMuaDoKKwog
MjAxMC0wOS0xNCAgRXJpYyBTZWlkZWwgIDxlcmljQHdlYmtpdC5vcmc+CiAKICAgICAgICAgVW5y
ZXZpZXdlZCwgcmV2ZXJ0aW5nIGNoYW5nZXMgcjY3NDUxIGFuZCByNjc0NTEuCmRpZmYgLS1naXQg
YS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViQ29yZVN1cHBvcnQvV2ViUGxhdGZvcm1TdHJhdGVnaWVz
LmNwcCBiL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJDb3JlU3VwcG9ydC9XZWJQbGF0Zm9ybVN0cmF0
ZWdpZXMuY3BwCmluZGV4IGExOTg2YWYuLmM5MzliM2EgMTAwNjQ0Ci0tLSBhL1dlYktpdDIvV2Vi
UHJvY2Vzcy9XZWJDb3JlU3VwcG9ydC9XZWJQbGF0Zm9ybVN0cmF0ZWdpZXMuY3BwCisrKyBiL1dl
YktpdDIvV2ViUHJvY2Vzcy9XZWJDb3JlU3VwcG9ydC9XZWJQbGF0Zm9ybVN0cmF0ZWdpZXMuY3Bw
CkBAIC0xMDIsNyArMTAyLDcgQEAgdm9pZCBXZWJQbGF0Zm9ybVN0cmF0ZWdpZXM6OnJlZnJlc2hQ
bHVnaW5zKCkKICAgICBwb3B1bGF0ZVBsdWdpbkNhY2hlKCk7CiB9CiAKLXZvaWQgV2ViUGxhdGZv
cm1TdHJhdGVnaWVzOjpnZXRQbHVnaW5JbmZvKFZlY3RvcjxXZWJDb3JlOjpQbHVnaW5JbmZvPiYg
cGx1Z2lucykKK3ZvaWQgV2ViUGxhdGZvcm1TdHJhdGVnaWVzOjpnZXRQbHVnaW5JbmZvKGNvbnN0
IFBhZ2UqLCBWZWN0b3I8V2ViQ29yZTo6UGx1Z2luSW5mbz4mIHBsdWdpbnMpCiB7CiAgICAgcG9w
dWxhdGVQbHVnaW5DYWNoZSgpOwogICAgIHBsdWdpbnMgPSBtX2NhY2hlZFBsdWdpbnM7CmRpZmYg
LS1naXQgYS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViQ29yZVN1cHBvcnQvV2ViUGxhdGZvcm1TdHJh
dGVnaWVzLmggYi9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViQ29yZVN1cHBvcnQvV2ViUGxhdGZvcm1T
dHJhdGVnaWVzLmgKaW5kZXggNjQyYjlmYy4uMzM0Njk0NSAxMDA2NDQKLS0tIGEvV2ViS2l0Mi9X
ZWJQcm9jZXNzL1dlYkNvcmVTdXBwb3J0L1dlYlBsYXRmb3JtU3RyYXRlZ2llcy5oCisrKyBiL1dl
YktpdDIvV2ViUHJvY2Vzcy9XZWJDb3JlU3VwcG9ydC9XZWJQbGF0Zm9ybVN0cmF0ZWdpZXMuaApA
QCAtNDksNyArNDksNyBAQCBwcml2YXRlOgogCiAgICAgLy8gV2ViQ29yZTo6UGx1Z2luU3RyYXRl
Z3kKICAgICB2aXJ0dWFsIHZvaWQgcmVmcmVzaFBsdWdpbnMoKTsKLSAgICB2aXJ0dWFsIHZvaWQg
Z2V0UGx1Z2luSW5mbyhWZWN0b3I8V2ViQ29yZTo6UGx1Z2luSW5mbz4mKTsKKyAgICB2aXJ0dWFs
IHZvaWQgZ2V0UGx1Z2luSW5mbyhjb25zdCBXZWJDb3JlOjpQYWdlKiwgVmVjdG9yPFdlYkNvcmU6
OlBsdWdpbkluZm8+Jik7CiAKICAgICAvLyBXZWJDb3JlOjpMb2NhbGl6YXRpb25TdHJhdGVneSAg
ICAKICAgICB2aXJ0dWFsIFdURjo6U3RyaW5nIGlucHV0RWxlbWVudEFsdFRleHQoKTsK
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>67780</attachid>
            <date>2010-09-16 04:47:28 -0700</date>
            <delta_ts>2010-09-22 06:17:38 -0700</delta_ts>
            <desc>proposed patch v2</desc>
            <filename>land_pluginstrategy_page.diff</filename>
            <type>text/plain</type>
            <size>7335</size>
            <attacher name="Balazs Kelemen">kbalazs</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg
ODFhNWI4Ny4uNzA2MmM2YSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi
Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMC0wOS0xNSAgQmFsYXpzIEtlbGVt
ZW4gIDxrYkBpbmYudS1zemVnZWQuaHU+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP
T1BTISkuCisKKyAgICAgICAgUGx1Z2luU3RyYXRlZ3kgc2hvdWxkIHNhdGlzZmllcyB0aGUgbmVl
ZHMgb2YgUXQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk
PTQ1ODU3CisgICAgICAgIE5vIG5ldyBmdW5jdGlvbmFsaXR5IHNvIG5vIG5ldyB0ZXN0cy4KKwor
ICAgICAgICAqIHBsdWdpbnMvUGx1Z2luRGF0YS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpQbHVn
aW5EYXRhOjppbml0UGx1Z2lucyk6CisgICAgICAgICogcGx1Z2lucy9QbHVnaW5TdHJhdGVneS5o
OiBBZGRlZCBhIHxjb25zdCBQYWdlKnwgYXJndW1lbnQgdG8gaW5pdFBsdWdpbnMuCisKIDIwMTAt
MDktMTQgIFBpZXJyZS1BbnRvaW5lIExhRmF5ZXR0ZSAgPHBsYWZheWV0QGNvZGVhdXJvcmEub3Jn
PgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEFkbGVyLgpkaWZmIC0tZ2l0IGEvV2ViQ29y
ZS9wbHVnaW5zL1BsdWdpbkRhdGEuY3BwIGIvV2ViQ29yZS9wbHVnaW5zL1BsdWdpbkRhdGEuY3Bw
CmluZGV4IGZmOTA3NDcuLmQyNGQyMzQgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGx1Z2lucy9QbHVn
aW5EYXRhLmNwcAorKysgYi9XZWJDb3JlL3BsdWdpbnMvUGx1Z2luRGF0YS5jcHAKQEAgLTc1LDcg
Kzc1LDcgQEAgdm9pZCBQbHVnaW5EYXRhOjppbml0UGx1Z2lucygpCiB7CiAgICAgQVNTRVJUKG1f
cGx1Z2lucy5pc0VtcHR5KCkpOwogICAgIAotICAgIHBsYXRmb3JtU3RyYXRlZ2llcygpLT5wbHVn
aW5TdHJhdGVneSgpLT5nZXRQbHVnaW5JbmZvKG1fcGx1Z2lucyk7CisgICAgcGxhdGZvcm1TdHJh
dGVnaWVzKCktPnBsdWdpblN0cmF0ZWd5KCktPmdldFBsdWdpbkluZm8obV9wYWdlLCBtX3BsdWdp
bnMpOwogfQogI2VuZGlmCiAKZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGx1Z2lucy9QbHVnaW5TdHJh
dGVneS5oIGIvV2ViQ29yZS9wbHVnaW5zL1BsdWdpblN0cmF0ZWd5LmgKaW5kZXggN2U5MjE5Ni4u
OWQ4YTdiNSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wbHVnaW5zL1BsdWdpblN0cmF0ZWd5LmgKKysr
IGIvV2ViQ29yZS9wbHVnaW5zL1BsdWdpblN0cmF0ZWd5LmgKQEAgLTMyLDEwICszMiwxMiBAQAog
CiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKK2NsYXNzIFBhZ2U7CisKIGNsYXNzIFBsdWdpblN0cmF0
ZWd5IHsKIHB1YmxpYzoKICAgICB2aXJ0dWFsIHZvaWQgcmVmcmVzaFBsdWdpbnMoKSA9IDA7Ci0g
ICAgdmlydHVhbCB2b2lkIGdldFBsdWdpbkluZm8oVmVjdG9yPFBsdWdpbkluZm8+JikgPSAwOwor
ICAgIHZpcnR1YWwgdm9pZCBnZXRQbHVnaW5JbmZvKGNvbnN0IFBhZ2UqLCBWZWN0b3I8UGx1Z2lu
SW5mbz4mKSA9IDA7CiAKIHByb3RlY3RlZDoKICAgICB2aXJ0dWFsIH5QbHVnaW5TdHJhdGVneSgp
IHsgfQpkaWZmIC0tZ2l0IGEvV2ViS2l0L21hYy9DaGFuZ2VMb2cgYi9XZWJLaXQvbWFjL0NoYW5n
ZUxvZwppbmRleCBhOWUwMzA0Li5mYWMyZmVkIDEwMDY0NAotLS0gYS9XZWJLaXQvbWFjL0NoYW5n
ZUxvZworKysgYi9XZWJLaXQvbWFjL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEwLTA5
LTE1ICBCYWxhenMgS2VsZW1lbiAgPGtiQGluZi51LXN6ZWdlZC5odT4KKworICAgICAgICBSZXZp
ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBQbHVnaW5TdHJhdGVneSBzaG91bGQg
c2F0aXNmaWVzIHRoZSBuZWVkcyBvZiBRdAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y
Zy9zaG93X2J1Zy5jZ2k/aWQ9NDU4NTcKKyAgICAgICAgTm8gbmV3IGZ1bmN0aW9uYWxpdHkgc28g
bm8gbmV3IHRlc3RzLgorCisgICAgICAgICogV2ViQ29yZVN1cHBvcnQvV2ViUGxhdGZvcm1TdHJh
dGVnaWVzLmg6CisgICAgICAgICogV2ViQ29yZVN1cHBvcnQvV2ViUGxhdGZvcm1TdHJhdGVnaWVz
Lm1tOgorICAgICAgICAoV2ViUGxhdGZvcm1TdHJhdGVnaWVzOjpnZXRQbHVnaW5JbmZvKToKKwog
MjAxMC0wOS0xNCAgRXJpYyBTZWlkZWwgIDxlcmljQHdlYmtpdC5vcmc+CiAKICAgICAgICAgVW5y
ZXZpZXdlZCwgcmV2ZXJ0aW5nIGNoYW5nZXMgcjY3NDUxIGFuZCByNjc0NTEuCmRpZmYgLS1naXQg
YS9XZWJLaXQvbWFjL1dlYkNvcmVTdXBwb3J0L1dlYlBsYXRmb3JtU3RyYXRlZ2llcy5oIGIvV2Vi
S2l0L21hYy9XZWJDb3JlU3VwcG9ydC9XZWJQbGF0Zm9ybVN0cmF0ZWdpZXMuaAppbmRleCA1M2Yz
OWY4Li43YjZjNDdkIDEwMDY0NAotLS0gYS9XZWJLaXQvbWFjL1dlYkNvcmVTdXBwb3J0L1dlYlBs
YXRmb3JtU3RyYXRlZ2llcy5oCisrKyBiL1dlYktpdC9tYWMvV2ViQ29yZVN1cHBvcnQvV2ViUGxh
dGZvcm1TdHJhdGVnaWVzLmgKQEAgLTQ1LDcgKzQ1LDcgQEAgcHJpdmF0ZToKIAogICAgIC8vIFdl
YkNvcmU6OlBsdWdpblN0cmF0ZWd5CiAgICAgdmlydHVhbCB2b2lkIHJlZnJlc2hQbHVnaW5zKCk7
Ci0gICAgdmlydHVhbCB2b2lkIGdldFBsdWdpbkluZm8oVmVjdG9yPFdlYkNvcmU6OlBsdWdpbklu
Zm8+Jik7CisgICAgdmlydHVhbCB2b2lkIGdldFBsdWdpbkluZm8oY29uc3QgV2ViQ29yZTo6UGFn
ZSosIFZlY3RvcjxXZWJDb3JlOjpQbHVnaW5JbmZvPiYpOwogCiAgICAgLy8gV2ViQ29yZTo6TG9j
YWxpemF0aW9uU3RyYXRlZ3kgICAgCiAgICAgdmlydHVhbCBXVEY6OlN0cmluZyBpbnB1dEVsZW1l
bnRBbHRUZXh0KCk7CmRpZmYgLS1naXQgYS9XZWJLaXQvbWFjL1dlYkNvcmVTdXBwb3J0L1dlYlBs
YXRmb3JtU3RyYXRlZ2llcy5tbSBiL1dlYktpdC9tYWMvV2ViQ29yZVN1cHBvcnQvV2ViUGxhdGZv
cm1TdHJhdGVnaWVzLm1tCmluZGV4IDI5MDBjY2YuLjViNzQzYzYgMTAwNjQ0Ci0tLSBhL1dlYktp
dC9tYWMvV2ViQ29yZVN1cHBvcnQvV2ViUGxhdGZvcm1TdHJhdGVnaWVzLm1tCisrKyBiL1dlYktp
dC9tYWMvV2ViQ29yZVN1cHBvcnQvV2ViUGxhdGZvcm1TdHJhdGVnaWVzLm1tCkBAIC03Miw3ICs3
Miw3IEBAIHZvaWQgV2ViUGxhdGZvcm1TdHJhdGVnaWVzOjpyZWZyZXNoUGx1Z2lucygpCiAgICAg
W1tXZWJQbHVnaW5EYXRhYmFzZSBzaGFyZWREYXRhYmFzZV0gcmVmcmVzaF07CiB9CiAKLXZvaWQg
V2ViUGxhdGZvcm1TdHJhdGVnaWVzOjpnZXRQbHVnaW5JbmZvKFZlY3RvcjxXZWJDb3JlOjpQbHVn
aW5JbmZvPiYgcGx1Z2lucykKK3ZvaWQgV2ViUGxhdGZvcm1TdHJhdGVnaWVzOjpnZXRQbHVnaW5J
bmZvKGNvbnN0IFdlYkNvcmU6OlBhZ2UqLCBWZWN0b3I8V2ViQ29yZTo6UGx1Z2luSW5mbz4mIHBs
dWdpbnMpCiB7CiAgICAgQkVHSU5fQkxPQ0tfT0JKQ19FWENFUFRJT05TOwogCmRpZmYgLS1naXQg
YS9XZWJLaXQvd2luL0NoYW5nZUxvZyBiL1dlYktpdC93aW4vQ2hhbmdlTG9nCmluZGV4IDhjOGU3
YTMuLjcxMDU2Y2EgMTAwNjQ0Ci0tLSBhL1dlYktpdC93aW4vQ2hhbmdlTG9nCisrKyBiL1dlYktp
dC93aW4vQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTAtMDktMTUgIEJhbGF6cyBLZWxl
bWVuICA8a2JAaW5mLnUtc3plZ2VkLmh1PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo
T09QUyEpLgorCisgICAgICAgIFBsdWdpblN0cmF0ZWd5IHNob3VsZCBzYXRpc2ZpZXMgdGhlIG5l
ZWRzIG9mIFF0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p
ZD00NTg1NworICAgICAgICBObyBuZXcgZnVuY3Rpb25hbGl0eSBzbyBubyBuZXcgdGVzdHMuCisK
KyAgICAgICAgKiBXZWJDb3JlU3VwcG9ydC9XZWJQbGF0Zm9ybVN0cmF0ZWdpZXMuY3BwOgorICAg
ICAgICAoV2ViUGxhdGZvcm1TdHJhdGVnaWVzOjpnZXRQbHVnaW5JbmZvKToKKyAgICAgICAgKiBX
ZWJDb3JlU3VwcG9ydC9XZWJQbGF0Zm9ybVN0cmF0ZWdpZXMuaDoKKwogMjAxMC0wOS0xMyAgRW5y
aWNhIENhc3VjY2kgIDxlbnJpY2FAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFNh
bSBXZWluaWcuCmRpZmYgLS1naXQgYS9XZWJLaXQvd2luL1dlYkNvcmVTdXBwb3J0L1dlYlBsYXRm
b3JtU3RyYXRlZ2llcy5jcHAgYi9XZWJLaXQvd2luL1dlYkNvcmVTdXBwb3J0L1dlYlBsYXRmb3Jt
U3RyYXRlZ2llcy5jcHAKaW5kZXggMDBhMmVhYi4uN2YwNTc4ZSAxMDA2NDQKLS0tIGEvV2ViS2l0
L3dpbi9XZWJDb3JlU3VwcG9ydC9XZWJQbGF0Zm9ybVN0cmF0ZWdpZXMuY3BwCisrKyBiL1dlYktp
dC93aW4vV2ViQ29yZVN1cHBvcnQvV2ViUGxhdGZvcm1TdHJhdGVnaWVzLmNwcApAQCAtNjgsNyAr
NjgsNyBAQCB2b2lkIFdlYlBsYXRmb3JtU3RyYXRlZ2llczo6cmVmcmVzaFBsdWdpbnMoKQogICAg
IFBsdWdpbkRhdGFiYXNlOjppbnN0YWxsZWRQbHVnaW5zKCktPnJlZnJlc2goKTsKIH0KIAotdm9p
ZCBXZWJQbGF0Zm9ybVN0cmF0ZWdpZXM6OmdldFBsdWdpbkluZm8oVmVjdG9yPFdlYkNvcmU6OlBs
dWdpbkluZm8+JiBvdXRQbHVnaW5zKQordm9pZCBXZWJQbGF0Zm9ybVN0cmF0ZWdpZXM6OmdldFBs
dWdpbkluZm8oY29uc3QgV2ViQ29yZTo6UGFnZSosIFZlY3RvcjxXZWJDb3JlOjpQbHVnaW5JbmZv
PiYgb3V0UGx1Z2lucykKIHsKICAgICBjb25zdCBWZWN0b3I8UGx1Z2luUGFja2FnZSo+JiBwbHVn
aW5zID0gUGx1Z2luRGF0YWJhc2U6Omluc3RhbGxlZFBsdWdpbnMoKS0+cGx1Z2lucygpOwogCmRp
ZmYgLS1naXQgYS9XZWJLaXQvd2luL1dlYkNvcmVTdXBwb3J0L1dlYlBsYXRmb3JtU3RyYXRlZ2ll
cy5oIGIvV2ViS2l0L3dpbi9XZWJDb3JlU3VwcG9ydC9XZWJQbGF0Zm9ybVN0cmF0ZWdpZXMuaApp
bmRleCBjM2NmYmI0Li5lYzVhZGIwIDEwMDY0NAotLS0gYS9XZWJLaXQvd2luL1dlYkNvcmVTdXBw
b3J0L1dlYlBsYXRmb3JtU3RyYXRlZ2llcy5oCisrKyBiL1dlYktpdC93aW4vV2ViQ29yZVN1cHBv
cnQvV2ViUGxhdGZvcm1TdHJhdGVnaWVzLmgKQEAgLTQ1LDcgKzQ1LDcgQEAgcHJpdmF0ZToKIAog
ICAgIC8vIFdlYkNvcmU6OlBsdWdpblN0cmF0ZWd5CiAgICAgdmlydHVhbCB2b2lkIHJlZnJlc2hQ
bHVnaW5zKCk7Ci0gICAgdmlydHVhbCB2b2lkIGdldFBsdWdpbkluZm8oVmVjdG9yPFdlYkNvcmU6
OlBsdWdpbkluZm8+Jik7CisgICAgdmlydHVhbCB2b2lkIGdldFBsdWdpbkluZm8oY29uc3QgV2Vi
Q29yZTo6UGFnZSosIFZlY3RvcjxXZWJDb3JlOjpQbHVnaW5JbmZvPiYpOwogCiAgICAgLy8gV2Vi
Q29yZTo6TG9jYWxpemF0aW9uU3RyYXRlZ3kgICAgCiAgICAgdmlydHVhbCBXVEY6OlN0cmluZyBp
bnB1dEVsZW1lbnRBbHRUZXh0KCk7CmRpZmYgLS1naXQgYS9XZWJLaXQyL0NoYW5nZUxvZyBiL1dl
YktpdDIvQ2hhbmdlTG9nCmluZGV4IDRiNjZmNzAuLjU3YWM4MzYgMTAwNjQ0Ci0tLSBhL1dlYktp
dDIvQ2hhbmdlTG9nCisrKyBiL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIw
MTAtMDktMTUgIEJhbGF6cyBLZWxlbWVuICA8a2JAaW5mLnUtc3plZ2VkLmh1PgorCisgICAgICAg
IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFBsdWdpblN0cmF0ZWd5IHNo
b3VsZCBzYXRpc2ZpZXMgdGhlIG5lZWRzIG9mIFF0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr
aXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NTg1NworICAgICAgICBObyBuZXcgZnVuY3Rpb25hbGl0
eSBzbyBubyBuZXcgdGVzdHMuCisKKyAgICAgICAgKiBXZWJQcm9jZXNzL1dlYkNvcmVTdXBwb3J0
L1dlYlBsYXRmb3JtU3RyYXRlZ2llcy5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYlBsYXRmb3Jt
U3RyYXRlZ2llczo6Z2V0UGx1Z2luSW5mbyk6CisgICAgICAgICogV2ViUHJvY2Vzcy9XZWJDb3Jl
U3VwcG9ydC9XZWJQbGF0Zm9ybVN0cmF0ZWdpZXMuaDoKKwogMjAxMC0wOS0xNCAgRXJpYyBTZWlk
ZWwgIDxlcmljQHdlYmtpdC5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcmV2ZXJ0aW5nIGNo
YW5nZXMgcjY3NDUxIGFuZCByNjc0NTEuCmRpZmYgLS1naXQgYS9XZWJLaXQyL1dlYlByb2Nlc3Mv
V2ViQ29yZVN1cHBvcnQvV2ViUGxhdGZvcm1TdHJhdGVnaWVzLmNwcCBiL1dlYktpdDIvV2ViUHJv
Y2Vzcy9XZWJDb3JlU3VwcG9ydC9XZWJQbGF0Zm9ybVN0cmF0ZWdpZXMuY3BwCmluZGV4IGExOTg2
YWYuLmM5MzliM2EgMTAwNjQ0Ci0tLSBhL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJDb3JlU3VwcG9y
dC9XZWJQbGF0Zm9ybVN0cmF0ZWdpZXMuY3BwCisrKyBiL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJD
b3JlU3VwcG9ydC9XZWJQbGF0Zm9ybVN0cmF0ZWdpZXMuY3BwCkBAIC0xMDIsNyArMTAyLDcgQEAg
dm9pZCBXZWJQbGF0Zm9ybVN0cmF0ZWdpZXM6OnJlZnJlc2hQbHVnaW5zKCkKICAgICBwb3B1bGF0
ZVBsdWdpbkNhY2hlKCk7CiB9CiAKLXZvaWQgV2ViUGxhdGZvcm1TdHJhdGVnaWVzOjpnZXRQbHVn
aW5JbmZvKFZlY3RvcjxXZWJDb3JlOjpQbHVnaW5JbmZvPiYgcGx1Z2lucykKK3ZvaWQgV2ViUGxh
dGZvcm1TdHJhdGVnaWVzOjpnZXRQbHVnaW5JbmZvKGNvbnN0IFdlYkNvcmU6OlBhZ2UqLCBWZWN0
b3I8V2ViQ29yZTo6UGx1Z2luSW5mbz4mIHBsdWdpbnMpCiB7CiAgICAgcG9wdWxhdGVQbHVnaW5D
YWNoZSgpOwogICAgIHBsdWdpbnMgPSBtX2NhY2hlZFBsdWdpbnM7CmRpZmYgLS1naXQgYS9XZWJL
aXQyL1dlYlByb2Nlc3MvV2ViQ29yZVN1cHBvcnQvV2ViUGxhdGZvcm1TdHJhdGVnaWVzLmggYi9X
ZWJLaXQyL1dlYlByb2Nlc3MvV2ViQ29yZVN1cHBvcnQvV2ViUGxhdGZvcm1TdHJhdGVnaWVzLmgK
aW5kZXggNjQyYjlmYy4uMzM0Njk0NSAxMDA2NDQKLS0tIGEvV2ViS2l0Mi9XZWJQcm9jZXNzL1dl
YkNvcmVTdXBwb3J0L1dlYlBsYXRmb3JtU3RyYXRlZ2llcy5oCisrKyBiL1dlYktpdDIvV2ViUHJv
Y2Vzcy9XZWJDb3JlU3VwcG9ydC9XZWJQbGF0Zm9ybVN0cmF0ZWdpZXMuaApAQCAtNDksNyArNDks
NyBAQCBwcml2YXRlOgogCiAgICAgLy8gV2ViQ29yZTo6UGx1Z2luU3RyYXRlZ3kKICAgICB2aXJ0
dWFsIHZvaWQgcmVmcmVzaFBsdWdpbnMoKTsKLSAgICB2aXJ0dWFsIHZvaWQgZ2V0UGx1Z2luSW5m
byhWZWN0b3I8V2ViQ29yZTo6UGx1Z2luSW5mbz4mKTsKKyAgICB2aXJ0dWFsIHZvaWQgZ2V0UGx1
Z2luSW5mbyhjb25zdCBXZWJDb3JlOjpQYWdlKiwgVmVjdG9yPFdlYkNvcmU6OlBsdWdpbkluZm8+
Jik7CiAKICAgICAvLyBXZWJDb3JlOjpMb2NhbGl6YXRpb25TdHJhdGVneSAgICAKICAgICB2aXJ0
dWFsIFdURjo6U3RyaW5nIGlucHV0RWxlbWVudEFsdFRleHQoKTsK
</data>
<flag name="review"
          id="57178"
          type_id="1"
          status="+"
          setter="kenneth"
    />
    <flag name="commit-queue"
          id="57179"
          type_id="3"
          status="-"
          setter="kbalazs"
    />
          </attachment>
      

    </bug>

</bugzilla>