4585 2005-08-22 04:36:35 -0700 update-webkit doesn't notice when you have SVGSupport and update properly 2005-08-25 10:23:44 -0700 1 1 1 Unclassified WebKit SVG 420+ Mac OS X 10.4 RESOLVED FIXED P4 Normal --- 1 eric eric ben.lamonica oldest_to_newest 17115 0 eric 2005-08-22 04:36:35 -0700 update-webkit doesn't notice when you have SVGSupport and update properly This is because the current checkout-svg script is sorta a hack. It checks out SVGSupport separately (as a top level module) and creates symlinks from WebCore/ into SVGSupport/ It might be better to change checkout-svg to checkout sub-modules SVGSupport/ksvg2, etc directly into the WebCore/ directory... or at least update update-webkit to test if SVGSupport is checked out and issue a cvs up command appopriately. 17302 1 3543 ben.lamonica 2005-08-23 19:02:31 -0700 Created attachment 3543 Checks for SVGSupport directory, and updates accordingly If the SVGSupport directory is present in the webkit dir, then this will also be updated when update-webkit is run. 17345 2 3543 darin 2005-08-24 11:57:23 -0700 Comment on attachment 3543 Checks for SVGSupport directory, and updates accordingly Looks fine to me. Using $" seems unnecessarily clever when join could do the job; it also seems a little ugly to pop the last item off of @sources and then re-append it. But this is a small script, and those are nits, so r=me. 3543 2005-08-23 19:02:31 -0700 2005-08-24 11:57:23 -0700 Checks for SVGSupport directory, and updates accordingly update-webkit.patch text/plain 976 ben.lamonica SW5kZXg6IHVwZGF0ZS13ZWJraXQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpSQ1MgZmlsZTogL2N2cy9yb290L1dlYktp dFRvb2xzL1NjcmlwdHMvdXBkYXRlLXdlYmtpdCx2CnJldHJpZXZpbmcgcmV2aXNpb24gMS42CmRp ZmYgLXAgLXUgLXIxLjYgdXBkYXRlLXdlYmtpdAotLS0gdXBkYXRlLXdlYmtpdAkxMyBKdW4gMjAw NSAwMDoxMDozMyAtMDAwMAkxLjYKKysrIHVwZGF0ZS13ZWJraXQJMjQgQXVnIDIwMDUgMDI6MDM6 MDIgLTAwMDAKQEAgLTQxLDExICs0MSwyMSBAQCBteSAkcm9vdCA9IDxST09UPjsKIGNob21wICRy b290OwogY2xvc2UgUk9PVDsKIAorbXkgQHNvdXJjZXMgPSAoIldlYktpdFRvb2xzIiwiSmF2YVNj cmlwdENvcmUiLCJXZWJDb3JlIiwiV2ViS2l0TGlicmFyaWVzIiwiV2ViS2l0Iik7CitwdXNoIEBz b3VyY2VzLCAiU1ZHU3VwcG9ydCIgaWYgLWQgIlNWR1N1cHBvcnQiOworCiAjIENoZWNrIG91dCBh bGwgdGhlIHNvdXJjZXMuCiBwcmludCAiQ1ZTIHJvb3QgaXMgJHJvb3RcbiI7Ci1wcmludCAiVXBk YXRpbmcgV2ViS2l0VG9vbHMsIEphdmFTY3JpcHRDb3JlLCBXZWJDb3JlLCBXZWJLaXRMaWJyYXJp ZXMsIGFuZCBXZWJLaXRcbiI7Ci1vcGVuIENWUywgImN2cyAtZCAnJHJvb3QnIGNvIC1QIFdlYktp dFRvb2xzIEphdmFTY3JpcHRDb3JlIFdlYkNvcmUgV2ViS2l0TGlicmFyaWVzIFdlYktpdCB8IiBv ciBkaWU7CisKK215ICRsYXN0RGlyZWN0b3J5ID0gcG9wIEBzb3VyY2VzOworJCIgPSAiLCAiOwor cHJpbnQgIlVwZGF0aW5nIEBzb3VyY2VzLCBhbmQgJGxhc3REaXJlY3RvcnlcbiI7CiskIiA9ICIg IjsKKworb3BlbiBDVlMsICJjdnMgLWQgJyRyb290JyBjbyAtUCBAc291cmNlcyAkbGFzdERpcmVj dG9yeSB8IiBvciBkaWU7CiB3aGlsZSAoPENWUz4pIHsKICAgICBwcmludDsKIH0KIGNsb3NlIENW UzsKKworCg==