45849 2010-09-15 16:39:42 -0700 WKURLCreateWithCFURL crashes with bad url 2010-09-15 16:51:49 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 simon.fraser webkit-unassigned oldest_to_newest 279812 0 simon.fraser 2010-09-15 16:39:42 -0700 I entered a bogus url into MiniBrowser's url bar, and hit return, and it crashed. URL was <rdar://problem/999> Crashes in WKURLCreateWithCFURL at: String urlString(CFURLGetString(cfURL)); cfURL is null. 279816 1 simon.fraser 2010-09-15 16:42:53 -0700 Minibrowser bug I guess: diff --git a/WebKitTools/MiniBrowser/mac/BrowserWindowController.m b/WebKitTools/MiniBrowser/mac/BrowserWindowController.m index 43351e5..162d99a 100644 --- a/WebKitTools/MiniBrowser/mac/BrowserWindowController.m +++ b/WebKitTools/MiniBrowser/mac/BrowserWindowController.m @@ -61,6 +61,9 @@ - (void)dealloc - (IBAction)fetch:(id)sender { CFURLRef cfURL = CFURLCreateWithString(0, (CFStringRef)[urlText stringValue], 0); + if (!cfURL) + return; + WKURLRef url = WKURLCreateWithCFURL(cfURL); CFRelease(cfURL); 279825 2 simon.fraser 2010-09-15 16:51:49 -0700 http://trac.webkit.org/changeset/67580