45847 2010-09-15 16:18:28 -0700 [reviewtool] Comments should quote previous comments on the same line 2010-09-15 16:25:48 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 abarth abarth arv eric jparent ojan oldest_to_newest 279803 0 abarth 2010-09-15 16:18:28 -0700 [reviewtool] Comments should quote previous comments on the same line 279804 1 67738 abarth 2010-09-15 16:20:39 -0700 Created attachment 67738 Patch 279806 2 67738 eric 2010-09-15 16:24:09 -0700 Comment on attachment 67738 Patch OK. You should really find some javascript ninjas to help you review this all and make it unit tested. :( 279807 3 abarth 2010-09-15 16:25:48 -0700 Committed r67575: <http://trac.webkit.org/changeset/67575> 67738 2010-09-15 16:20:39 -0700 2010-09-15 16:24:09 -0700 Patch bug-45847-20100915162037.patch text/plain 5035 abarth SW5kZXg6IEJ1Z3NTaXRlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBCdWdzU2l0ZS9DaGFuZ2VM b2cJKHJldmlzaW9uIDY3NTc0KQorKysgQnVnc1NpdGUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkp CkBAIC0xLDMgKzEsMTkgQEAKKzIwMTAtMDktMTUgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0 Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBb cmV2aWV3dG9vbF0gQ29tbWVudHMgc2hvdWxkIHF1b3RlIHByZXZpb3VzIGNvbW1lbnRzIG9uIHRo ZSBzYW1lIGxpbmUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTQ1ODQ3CisKKyAgICAgICAgTm93IHdoZW4geW91IHJlcGx5IHRvIGEgcHJldmlvdXMgY29t bWVudCwgdGhlIHRvb2wgd2lsbCBxdW90ZSB0aGUKKyAgICAgICAgcHJldmlvdXMgY29tbWVudCBp biB0aGUgYnVncy53ZWJraXQub3JnIHBvc3QuICBUaGlzIG1ha2VzIGl0IGVhaXNlciBmb3IKKyAg ICAgICAgZm9sa3MgZm9sbG93aW5nIGFsb25nIGluIGVtYWlsIHRvIHVuZGVyc3RhbmQgdGhlIGRp c2N1c3Npb24uCisKKyAgICAgICAgV2hpbGUgSSB3YXMgZWRpdGluZyB0aGlzIGNvZGUsIEkgYWxz byBjbGVhbmVkIHVwIHNvbWUgb2YgdGhlIHdoaXRlc3BhY2UKKyAgICAgICAgaGFuZGxpbmcgaW4g Y29tbWVudHMuCisKKyAgICAgICAgKiBjb2RlLXJldmlldy5qczoKKwogMjAxMC0wOS0xNSAgQWRh bSBCYXJ0aCAgPGFiYXJ0aEB3ZWJraXQub3JnPgogCiAgICAgICAgIE1pbm9yIFVJIHR3ZWFrIHRv IHRoZSByZXZpZXcgdG9vbC4gIFdlIHdhbnQgdG8gZGlzcGxheSBuZXdsaW5lcyBpbgpJbmRleDog QnVnc1NpdGUvY29kZS1yZXZpZXcuanMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gQnVnc1NpdGUvY29kZS1yZXZp ZXcuanMJKHJldmlzaW9uIDY3NTY4KQorKysgQnVnc1NpdGUvY29kZS1yZXZpZXcuanMJKHdvcmtp bmcgY29weSkKQEAgLTY3LDYgKzY3LDE2IEBACiAgICAgfSk7CiAgIH0KIAorICBmdW5jdGlvbiBw cmV2aW91c0NvbW1lbnRzRm9yKGxpbmUpIHsKKyAgICB2YXIgY29tbWVudHMgPSBbXTsKKyAgICB2 YXIgcG9zaXRpb24gPSBsaW5lOworICAgIHdoaWxlIChwb3NpdGlvbi5uZXh0KCkgJiYgcG9zaXRp b24ubmV4dCgpLmhhc0NsYXNzKCdwcmV2aW91c0NvbW1lbnQnKSkgeworICAgICAgcG9zaXRpb24g PSBwb3NpdGlvbi5uZXh0KCk7CisgICAgICBjb21tZW50cy5wdXNoKHBvc2l0aW9uLmdldCgpKTsK KyAgICB9CisgICAgcmV0dXJuICQoY29tbWVudHMpOworICB9CisKICAgZnVuY3Rpb24gZmluZENv bW1lbnRQb3NpdGlvbkZvcihsaW5lKSB7CiAgICAgdmFyIHBvc2l0aW9uID0gbGluZTsKICAgICB3 aGlsZSAocG9zaXRpb24ubmV4dCgpICYmIHBvc2l0aW9uLm5leHQoKS5oYXNDbGFzcygncHJldmlv dXNDb21tZW50JykpCkBAIC0xMTQsNyArMTI0LDggQEAKICAgZnVuY3Rpb24gYWRkUHJldmlvdXND b21tZW50KGxpbmUsIGF1dGhvciwgY29tbWVudF90ZXh0KSB7CiAgICAgdmFyIGNvbW1lbnRfYmxv Y2sgPSAkKCc8ZGl2IGRhdGEtY29tbWVudC1mb3I9IicgKyBsaW5lLmF0dHIoJ2lkJykgKyAnIiBj bGFzcz0icHJldmlvdXNDb21tZW50Ij48L2Rpdj4nKTsKICAgICB2YXIgYXV0aG9yX2Jsb2NrID0g JCgnPGRpdiBjbGFzcz0iYXV0aG9yIj48L2Rpdj4nKS50ZXh0KGF1dGhvciArICc6Jyk7Ci0gICAg Y29tbWVudF9ibG9jay50ZXh0KGNvbW1lbnRfdGV4dCkucHJlcGVuZChhdXRob3JfYmxvY2spLmVh Y2goaG92ZXJpZnkpLmNsaWNrKGFkZENvbW1lbnRGaWVsZCk7CisgICAgdmFyIHRleHRfYmxvY2sg PSAkKCc8ZGl2IGNsYXNzPSJjb250ZW50Ij48L2Rpdj4nKS50ZXh0KGNvbW1lbnRfdGV4dCk7Cisg ICAgY29tbWVudF9ibG9jay5hcHBlbmQoYXV0aG9yX2Jsb2NrKS5hcHBlbmQodGV4dF9ibG9jayku ZWFjaChob3ZlcmlmeSkuY2xpY2soYWRkQ29tbWVudEZpZWxkKTsKICAgICBpbnNlcnRDb21tZW50 Rm9yKGxpbmUsIGNvbW1lbnRfYmxvY2spOwogICB9CiAKQEAgLTE3MSw3ICsxODIsNyBAQAogICAg ICAgICArK2k7CiAgICAgICB9CiAgICAgICAtLWk7IC8vIERlY3JlbWVudCBpIGJlY2F1c2UgdGhl IGZvciBsb29wIHdpbGwgaW5jcmVtZW50IGl0IGFnYWluIGluIGEgc2Vjb25kLgotICAgICAgdmFy IGNvbW1lbnRfdGV4dCA9IGNvbW1lbnRfbGluZXMuam9pbignXG4nKTsKKyAgICAgIHZhciBjb21t ZW50X3RleHQgPSBjb21tZW50X2xpbmVzLmpvaW4oJ1xuJykudHJpbSgpOwogICAgICAgY29tbWVu dHMucHVzaCh7CiAgICAgICAgICdhdXRob3InOiBhdXRob3IsCiAgICAgICAgICdmaWxlX25hbWUn OiBmaWxlX25hbWUsCkBAIC0zNDcsNyArMzU4LDcgQEAKIAogICAkKCcuRGlmZlNlY3Rpb24nKS5s aXZlKCdtb3VzZWxlYXZlJywgc3RvcERyYWdTZWxlY3QpLmxpdmUoJ21vdXNldXAnLCBzdG9wRHJh Z1NlbGVjdCk7CiAKLSAgZnVuY3Rpb24gY29udGV4dFNuaXBwZXRGb3IobGluZSkgeworICBmdW5j dGlvbiBjb250ZXh0U25pcHBldEZvcihsaW5lLCBpbmRlbnQpIHsKICAgICB2YXIgc25pcHBldHMg PSBbXQogICAgIGNvbnRleHRMaW5lc0ZvcihsaW5lKS5lYWNoKGZ1bmN0aW9uKCkgewogICAgICAg dmFyIGFjdGlvbiA9ICcgJzsKQEAgLTM1Niw3ICszNjcsNyBAQAogICAgICAgZWxzZSBpZiAoJCh0 aGlzKS5oYXNDbGFzcygncmVtb3ZlJykpCiAgICAgICAgIGFjdGlvbiA9ICctJzsKICAgICAgIHZh ciB0ZXh0ID0gJCh0aGlzKS5jaGlsZHJlbignLnRleHQnKS50ZXh0KCk7Ci0gICAgICBzbmlwcGV0 cy5wdXNoKCc+ICcgKyBhY3Rpb24gKyB0ZXh0KTsKKyAgICAgIHNuaXBwZXRzLnB1c2goaW5kZW50 ICsgYWN0aW9uICsgdGV4dCk7CiAgICAgfSk7CiAgICAgcmV0dXJuIHNuaXBwZXRzLmpvaW4oJ1xu Jyk7CiAgIH0KQEAgLTM2NSwxMCArMzc2LDI1IEBACiAgICAgcmV0dXJuIGxpbmUucGFyZW50c1Vu dGlsKCcuRmlsZURpZmYnKS5wYXJlbnQoKS5maW5kKCdoMScpLnRleHQoKTsKICAgfQogCi0gIGZ1 bmN0aW9uIHNuaXBwZXRGb3IobGluZSkgeworICBmdW5jdGlvbiBpbmRlbnRGb3IoZGVwdGgpIHsK KyAgICByZXR1cm4gKG5ldyBBcnJheShkZXB0aCArIDEpKS5qb2luKCc+JykgKyAnICc7CisgIH0K KworICBmdW5jdGlvbiBzbmlwcGV0Rm9yKGxpbmUsIGluZGVudCkgewogICAgIHZhciBmaWxlX25h bWUgPSBmaWxlTmFtZUZvcihsaW5lKTsKICAgICB2YXIgbGluZV9udW1iZXIgPSBsaW5lLmhhc0Ns YXNzKCdyZW1vdmUnKSA/ICctJyArIGxpbmUuY2hpbGRyZW4oJy5mcm9tJykudGV4dCgpIDogbGlu ZS5jaGlsZHJlbignLnRvJykudGV4dCgpOwotICAgIHJldHVybiAnPiAnICsgZmlsZV9uYW1lICsg JzonICsgbGluZV9udW1iZXIgKyAnXG4nICsgY29udGV4dFNuaXBwZXRGb3IobGluZSk7CisgICAg cmV0dXJuIGluZGVudCArIGZpbGVfbmFtZSArICc6JyArIGxpbmVfbnVtYmVyICsgJ1xuJyArIGNv bnRleHRTbmlwcGV0Rm9yKGxpbmUsIGluZGVudCk7CisgIH0KKworICBmdW5jdGlvbiBxdW90ZVBy ZXZpb3VzQ29tbWVudHMoY29tbWVudHMpIHsKKyAgICB2YXIgcXVvdGVkX2NvbW1lbnRzID0gW107 CisgICAgdmFyIGRlcHRoID0gY29tbWVudHMuc2l6ZSgpOworICAgIGNvbW1lbnRzLmVhY2goZnVu Y3Rpb24oKSB7CisgICAgICB2YXIgaW5kZW50ID0gaW5kZW50Rm9yKGRlcHRoLS0pOworICAgICAg dmFyIHRleHQgPSAkKHRoaXMpLmNoaWxkcmVuKCcuY29udGVudCcpLnRleHQoKTsKKyAgICAgIHF1 b3RlZF9jb21tZW50cy5wdXNoKGluZGVudCArICdcbicgKyBpbmRlbnQgKyB0ZXh0LnNwbGl0KCdc bicpLmpvaW4oJ1xuJyArIGluZGVudCkpOworICAgIH0pOworICAgIHJldHVybiBxdW90ZWRfY29t bWVudHMuam9pbignXG4nKTsKICAgfQogCiAgICQoJyNjb21tZW50X2Zvcm0gLndpbnRlcicpLmxp dmUoJ2NsaWNrJywgZnVuY3Rpb24oKSB7CkBAIC0zODAsMTEgKzQwNiwxOCBAQAogICAgIGZvckVh Y2hMaW5lKGZ1bmN0aW9uKGxpbmUpIHsKICAgICAgIGlmIChsaW5lLmF0dHIoJ2RhdGEtaGFzLWNv bW1lbnQnKSAhPSAndHJ1ZScpCiAgICAgICAgIHJldHVybjsKLSAgICAgIHZhciBzbmlwcGV0ID0g c25pcHBldEZvcihsaW5lKTsKICAgICAgIHZhciBjb21tZW50ID0gZmluZENvbW1lbnRCbG9ja0Zv cihsaW5lKS5jaGlsZHJlbigndGV4dGFyZWEnKS52YWwoKS50cmltKCk7CiAgICAgICBpZiAoY29t bWVudCA9PSAnJykKICAgICAgICAgcmV0dXJuOwotICAgICAgY29tbWVudHNfaW5fY29udGV4dC5w dXNoKHNuaXBwZXQgKyAnXG4nICsgY29tbWVudCk7CisgICAgICB2YXIgcHJldmlvdXNfY29tbWVu dHMgPSBwcmV2aW91c0NvbW1lbnRzRm9yKGxpbmUpOworICAgICAgdmFyIHNuaXBwZXQgPSBzbmlw cGV0Rm9yKGxpbmUsIGluZGVudEZvcihwcmV2aW91c19jb21tZW50cy5zaXplKCkgKyAxKSk7Cisg ICAgICB2YXIgcXVvdGVkX2NvbW1lbnRzID0gcXVvdGVQcmV2aW91c0NvbW1lbnRzKHByZXZpb3Vz X2NvbW1lbnRzKTsKKyAgICAgIHZhciBjb21tZW50X3dpdGhfY29udGV4dCA9IFtdOworICAgICAg Y29tbWVudF93aXRoX2NvbnRleHQucHVzaChzbmlwcGV0KTsKKyAgICAgIGlmIChxdW90ZWRfY29t bWVudHMgIT0gJycpCisgICAgICAgIGNvbW1lbnRfd2l0aF9jb250ZXh0LnB1c2gocXVvdGVkX2Nv bW1lbnRzKTsKKyAgICAgIGNvbW1lbnRfd2l0aF9jb250ZXh0LnB1c2goJ1xuJyArIGNvbW1lbnQp OworICAgICAgY29tbWVudHNfaW5fY29udGV4dC5wdXNoKGNvbW1lbnRfd2l0aF9jb250ZXh0Lmpv aW4oJ1xuJykpOwogICAgIH0pOwogICAgICQoJyNjb21tZW50X2Zvcm0nKS5yZW1vdmVDbGFzcygn aW5hY3RpdmUnKTsKICAgICB2YXIgY29tbWVudCA9ICQoJy5vdmVyYWxsQ29tbWVudHMgdGV4dGFy ZWEnKS52YWwoKS50cmltKCk7Cg==